130363 2014-03-17 14:53:00 -0700 Add transparent window support back into MiniBrowser 2014-03-18 23:49:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca commit-queue mitz simon.fraser thorton oldest_to_newest 991404 0 simon.fraser 2014-03-17 14:53:00 -0700 Add transparent window support back into MiniBrowser 991405 1 226968 simon.fraser 2014-03-17 14:53:28 -0700 Created attachment 226968 Patch 991407 2 commit-queue 2014-03-17 14:54:39 -0700 Attachment 226968 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 991448 3 226968 thorton 2014-03-17 16:43:54 -0700 Comment on attachment 226968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84 > +@property (nonatomic, setter=_setDrawsTransparentBackground:)BOOL _drawsTransparentBackground; spaces around = 991449 4 226968 andersca 2014-03-17 16:43:58 -0700 Comment on attachment 226968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:257 > + [[self window] setOpaque:!isTransparent]; > + [[self window] setHasShadow:!isTransparent]; I think you should use dot notation here. 991451 5 226968 thorton 2014-03-17 16:44:29 -0700 Comment on attachment 226968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:84 >> +@property (nonatomic, setter=_setDrawsTransparentBackground:)BOOL _drawsTransparentBackground; > > spaces around = and after the ) 991452 6 226968 thorton 2014-03-17 16:45:08 -0700 Comment on attachment 226968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226968&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:34 > +#import <WebKit2/WKWebViewPrivate.h> > #import <WebKit2/WKNavigationDelegate.h> This doesn't look sorted right. 992036 7 thorton 2014-03-18 23:49:23 -0700 I think this landed in http://trac.webkit.org/changeset/165775 and http://trac.webkit.org/changeset/165776 226968 2014-03-17 14:53:28 -0700 2014-03-17 16:45:08 -0700 Patch bug-130363-20140317145312.patch text/plain 5120 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjUwNDAzNmEzNDkyY2Fl ZmU2NzEwYTM1MTc5ODFmNWQ5NzY3NmIxMi4uNWM1NTY4YWJjMTA2YmU1YjQ0YTJlNGExZTM1OWIw ZjQ1NjM3NWU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTE3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCB0cmFuc3Bh cmVudCB3aW5kb3cgc3VwcG9ydCBiYWNrIGludG8gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDM2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRXhwb3NlIFNQSSBmb3Ig dHJhbnNwYXJlbnQgd2luZG93IHN1cHBvcnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9kcmF3c1RyYW5zcGFyZW50 QmFja2dyb3VuZF0pOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3NldERyYXdzVHJhbnNwYXJlbnRC YWNrZ3JvdW5kOl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJp dmF0ZS5oOgorCiAyMDE0LTAzLTE3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFtNYWNdIGdldEF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2UgYXJndW1l bnRzIGFyZSBpbmNvcnJlY3RseSBuYW1lZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCAxNGY3YWIwMzkxNDRiOTk0MWM0MzdiMTk2ZWJk MGZhMDdjYjk1ZmVlLi43ZjhmNWNlMjRiNWEwNjFjNDAzMzRmZTg5NDEwODk3ZGM2YThiMzJmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpA QCAtOTc1LDYgKzk3NSwxNiBAQCBzdGF0aWMgaW5saW5lIFdlYkNvcmU6OkxheW91dE1pbGVzdG9u ZXMgbGF5b3V0TWlsZXN0b25lcyhfV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZQogICAgIHJldHVybiBu c0NvbG9yKGNvbG9yKTsKIH0KIAorLSAoQk9PTClfZHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQK K3sKKyAgICByZXR1cm4gX3BhZ2UtPmRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kKCk7Cit9CisK Ky0gKHZvaWQpX3NldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kOihCT09MKWRyYXdzVHJhbnNw YXJlbnRCYWNrZ3JvdW5kCit7CisgICAgX3BhZ2UtPnNldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3Jv dW5kKGRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kKTsKK30KKwogI2VuZGlmCiAKIEBlbmQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJp dmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2 YXRlLmgKaW5kZXggNGQ3YjNjYjVkYmRlZWU3YWNlOTA3M2Y0YTRlYzNkYjZkNWM2NDEyOS4uYmIy NjhkODZmMGQ4ZmYwZGVmNzkxNTVkOTJlZDE4YmZhNjBjOWZjYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKQEAgLTgx LDYgKzgxLDcgQEAgdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS1JlbmRlcmluZ1By b2dyZXNzRXZlbnRzKSB7CiAtICh2b2lkKV9lbmRJbnRlcmFjdGl2ZU9ic2N1cmVkSW5zZXRzQ2hh bmdlOwogI2Vsc2UKIEBwcm9wZXJ0eSAocmVhZG9ubHkpIE5TQ29sb3IgKl9wYWdlRXh0ZW5kZWRC YWNrZ3JvdW5kQ29sb3I7CitAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXREcmF3c1Ry YW5zcGFyZW50QmFja2dyb3VuZDopQk9PTCBfZHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQ7CiAj ZW5kaWYKIAogLSAodm9pZClfcnVuSmF2YVNjcmlwdEluTWFpbkZyYW1lOihOU1N0cmluZyAqKXNj cmlwdFN0cmluZzsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCBjY2YyZjBjZDc2NWIzNmZmYjVkZmE3YzUwOTY2YzMwODllNjY3NzRlLi4xMGFjMDgx MTVkMmVhNGQwMzFlM2RjZmUyYjg3YjY4YzQ2YTcxMmU1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTQtMDMtMTcg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIHRy YW5zcGFyZW50IHdpbmRvdyBzdXBwb3J0IGJhY2sgaW50byBNaW5pQnJvd3NlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMzYzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBSZS1lbmFibGUg dHJhbnNwYXJlbnQgd2luZG93IHN1cHBvcnQgZm9yIFdLMi4KKworICAgICAgICAqIE1pbmlCcm93 c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tOgorICAgICAgICAoLVtXSzJCcm93 c2VyV2luZG93Q29udHJvbGxlciB2YWxpZGF0ZU1lbnVJdGVtOl0pOgorICAgICAgICAoLVtXSzJC cm93c2VyV2luZG93Q29udHJvbGxlciB0b2dnbGVUcmFuc3BhcmVudFdpbmRvdzpdKToKKworMjAx NC0wMy0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAg ICBGaXggdGhlIDMyLWJpdCBidWlsZDsgbWFrZSB0aGUgb3BlbiBwYW5lbCBtYWtlIGEgV0sxIHdp bmRvdy4KIAogICAgICAgICAqIE1pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tOgpkaWZmIC0t Z2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvbWFjL1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0g Yi9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQppbmRl eCBkNDUwNWNiMjVlYzdmODJjODA2M2U1YWQyZWFjMDNhNDE1ODAwMTU0Li42M2M4NzA4MjgyNGUw ZDQ2MjExMGQxZjhlODRmY2E4MDIxZTkyMzUyIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQorKysgYi9Ub29scy9NaW5pQnJvd3Nl ci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQpAQCAtMzAsNiArMzAsNyBAQAogI2lt cG9ydCAiQXBwRGVsZWdhdGUuaCIKICNpbXBvcnQgPFdlYktpdDIvV0tGcmFtZUluZm8uaD4KICNp bXBvcnQgPFdlYktpdDIvV0tXZWJWaWV3Lmg+CisjaW1wb3J0IDxXZWJLaXQyL1dLV2ViVmlld1By aXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdDIvV0tOYXZpZ2F0aW9uRGVsZWdhdGUuaD4KICNpbXBv cnQgPFdlYktpdDIvV0tVSURlbGVnYXRlLmg+CiAKQEAgLTExOCwxNCArMTE5LDE1IEBAIC0gKEJP T0wpdmFsaWRhdGVNZW51SXRlbTooTlNNZW51SXRlbSAqKW1lbnVJdGVtCiAgICAgICAgIHx8IGFj dGlvbiA9PSBAc2VsZWN0b3IocmVzZXRab29tOikKICAgICAgICAgfHwgYWN0aW9uID09IEBzZWxl Y3RvcihkdW1wU291cmNlVG9Db25zb2xlOikKICAgICAgICAgfHwgYWN0aW9uID09IEBzZWxlY3Rv cihmaW5kOikKLSAgICAgICAgfHwgYWN0aW9uID09IEBzZWxlY3Rvcih0b2dnbGVQYWdpbmF0aW9u TW9kZTopCi0gICAgICAgIHx8IGFjdGlvbiA9PSBAc2VsZWN0b3IodG9nZ2xlVHJhbnNwYXJlbnRX aW5kb3c6KSkKKyAgICAgICAgfHwgYWN0aW9uID09IEBzZWxlY3Rvcih0b2dnbGVQYWdpbmF0aW9u TW9kZTopKQogICAgICAgICByZXR1cm4gTk87CiAgICAgCiAgICAgaWYgKGFjdGlvbiA9PSBAc2Vs ZWN0b3Ioc2hvd0hpZGVXZWJWaWV3OikpCiAgICAgICAgIFttZW51SXRlbSBzZXRUaXRsZTpbX3dl YlZpZXcgaXNIaWRkZW5dID8gQCJTaG93IFdlYiBWaWV3IiA6IEAiSGlkZSBXZWIgVmlldyJdOwog ICAgIGVsc2UgaWYgKGFjdGlvbiA9PSBAc2VsZWN0b3IocmVtb3ZlUmVpbnNlcnRXZWJWaWV3Oikp CiAgICAgICAgIFttZW51SXRlbSBzZXRUaXRsZTpbX3dlYlZpZXcgd2luZG93XSA/IEAiUmVtb3Zl IFdlYiBWaWV3IiA6IEAiSW5zZXJ0IFdlYiBWaWV3Il07CisgICAgZWxzZSBpZiAoW21lbnVJdGVt IGFjdGlvbl0gPT0gQHNlbGVjdG9yKHRvZ2dsZVRyYW5zcGFyZW50V2luZG93OikpCisgICAgICAg IFttZW51SXRlbSBzZXRTdGF0ZTpbW3NlbGYgd2luZG93XSBpc09wYXF1ZV0gPyBOU09mZlN0YXRl IDogTlNPblN0YXRlXTsKICAgICBlbHNlIGlmIChbbWVudUl0ZW0gYWN0aW9uXSA9PSBAc2VsZWN0 b3IodG9nZ2xlVUlTaWRlQ29tcG9zaXRpbmc6KSkKICAgICAgICAgW21lbnVJdGVtIHNldFN0YXRl OltzZWxmIGlzVUlTaWRlQ29tcG9zaXRpbmdFbmFibGVkXSA/IE5TT25TdGF0ZSA6IE5TT2ZmU3Rh dGVdOwogCkBAIC0yNDgsNiArMjUwLDE1IEBAIC0gKHZvaWQpem9vbU91dDooaWQpc2VuZGVyCiAK IC0gKElCQWN0aW9uKXRvZ2dsZVRyYW5zcGFyZW50V2luZG93OihpZClzZW5kZXIKIHsKKyAgICBC T09MIGlzVHJhbnNwYXJlbnQgPSBfd2ViVmlldy5fZHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQ7 CisgICAgaXNUcmFuc3BhcmVudCA9ICFpc1RyYW5zcGFyZW50OworCisgICAgW1tzZWxmIHdpbmRv d10gc2V0T3BhcXVlOiFpc1RyYW5zcGFyZW50XTsKKyAgICBbW3NlbGYgd2luZG93XSBzZXRIYXNT aGFkb3c6IWlzVHJhbnNwYXJlbnRdOworCisgICAgX3dlYlZpZXcuX2RyYXdzVHJhbnNwYXJlbnRC YWNrZ3JvdW5kID0gaXNUcmFuc3BhcmVudDsKKworICAgIFtbc2VsZiB3aW5kb3ddIGRpc3BsYXld OyAgICAKIH0KIAogLSAoQk9PTClpc1VJU2lkZUNvbXBvc2l0aW5nRW5hYmxlZAo=