130353 2014-03-17 12:17:46 -0700 Layout Test mathml/wbr-in-mroot-crash.html times out 2016-06-28 10:05:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 119038 132267 134031 155434 1 jer.noble fred.wang alex ap bfulgham calvaris cfleizach darin fred.wang svillar oldest_to_newest 991335 0 jer.noble 2014-03-17 12:17:46 -0700 The following layout test crashes on Apple MountainLion Release WK2, Apple Mavericks Release, and EFL Linux 64-bit Release. mathml/wbr-in-mroot-crash.html Probable cause: http://trac.webkit.org/changeset/165702 from https://bugs.webkit.org/show_bug.cgi?id=124128 991338 1 jer.noble 2014-03-17 12:29:00 -0700 Marked tests as failing in https://trac.webkit.org/r165747. 991339 2 ap 2014-03-17 12:46:26 -0700 Is there a crash log seen anywhere? On bots I checked, it looks like a timeout misreported as crash. 991340 3 fred.wang 2014-03-17 12:47:36 -0700 In http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/r165745%20%2816869%29/mathml/wbr-in-mroot-crash-sample.txt the crash seems to happen in RenderMathMLOperator, however no <mo>s are involved in the test so something is probably doing a wrong cast into a RenderMathMLOperator. I guess we can remove htmlElement.hasTagName(HTMLNames::wbrTag) from isPhrasingContent to workaround the crash, but I'd like to find what the problem is exactly. 991584 4 fred.wang 2014-03-18 03:27:28 -0700 I just tried again this morning and was not able to reproduce the crash on Linux. I'm no longer able to build a debug on my laptop and adding printf on RenderMathMLOperator does print anything so I'm not sure why they appear in the crash log. Does it happen only on Mac? @Brent: I think you worked on the security issue with HTML content badly cast to MathML. Do you know if that could happen again after bug 124128? Especially, this change allows <wbr> as child of token elements. (BTW, the change in bug 128907 might also be involved here) 991593 5 fred.wang 2014-03-18 04:06:57 -0700 (In reply to comment #2) > Is there a crash log seen anywhere? On bots I checked, it looks like a timeout misreported as crash. This seems to be random: r165702 has crash log but not http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/r165702%20%2816840%29/mathml/wbr-in-mroot-crash-sample.txt http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/r165703%20%2816841%29/mathml/ (In reply to comment #4) > Does it happen only on Mac? Apparently it was disabled on EFL too, so I'll try to build that port and see if I can reproduce the crash. 991689 6 fred.wang 2014-03-18 09:23:10 -0700 (In reply to comment #5) > (In reply to comment #4) > > Does it happen only on Mac? > > Apparently it was disabled on EFL too, so I'll try to build that port and see if I can reproduce the crash. I have not been able to reproduce any crash or hang... 1016385 7 fred.wang 2014-06-17 23:52:46 -0700 Looking at the results for revision r170050-r170094, I know only see at worse time out. So let's say bug 119038 improved the situation here, and mark the test as "Timeout". I'm also renaming the bug entry. 1016406 8 fred.wang 2014-06-18 00:46:22 -0700 Committed r170099: <http://trac.webkit.org/changeset/170099> 1016407 9 fred.wang 2014-06-18 00:47:34 -0700 Reopening, since the timeout is not actually fixed. 1205944 10 fred.wang 2016-06-28 00:49:35 -0700 *** Bug 132267 has been marked as a duplicate of this bug. *** 1205948 11 fred.wang 2016-06-28 01:23:00 -0700 Per bug 157990 comment 4 and below, the problem actually seemed to be related to the previous test mathml/very-large-stretchy-operators.html. I can not reproduce the timeout on GTK with the command proposed there and the test expectation was removed for mac. So I assumed this has been fixed by the patch for bug 155434. 1205951 12 282222 fred.wang 2016-06-28 01:27:29 -0700 Created attachment 282222 Patch 1206028 13 fred.wang 2016-06-28 08:06:13 -0700 Committed r202564: <http://trac.webkit.org/changeset/202564> 1206057 14 ap 2016-06-28 10:05:30 -0700 On Efl, the flakiness was "Crash Pass", which I don't think can be explained by this. But it's not happening any more, according to the flakiness dashboard, so it's fine to remove the expectation. 282222 2016-06-28 01:27:29 -0700 2016-06-28 08:07:47 -0700 Patch bug-130353-20160628102712.patch text/plain 3437 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTQ2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjM3YzBhOTdhNGQ0NmJhZTc1OTA1 NjY2YTM3Njk2MmEwNTYzYjk5ZS4uZDg3YzM2YjliNTNkOGFmNjA4Y2YxYmU0YjgwNTNmZGE2Yzkw NTY5MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA2LTI4ICBGcmVkZXJpYyBXYW5nICA8 ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBSZW1vdmUgZmxha2luZXNzIGV4cGVjdGF0aW9u cyBmb3IgbWF0aG1sL3dici1pbi1tcm9vdC1jcmFzaC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAzNTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZmxha2luZXNzIHNlZW1lZCB0byBiZSBk dWUgdG8gdGhlIHRpbWVvdXQgb2YgbWF0aG1sL3ZlcnktbGFyZ2Utc3RyZXRjaHktb3BlcmF0b3Jz Lmh0bWwuCisgICAgICAgIFRoZSBsYXR0ZXIgd2FzIGZpeGVkIGluIHIyMDI0ODksIHNvIHdlIHVw ZGF0ZSB0aGUgdGVzdCBleHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVz dEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoK KyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zOgor CiAyMDE2LTA2LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcmViYXNlbGluZSB0ZXN0IG9uIGlPUyBhZnRlciByMjAyNTM5LgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxNTU2NDNmODFmNjAwODYx NjExYTIxN2U2Njc4ZDA0YTAwMzkxMGU4Li5mYjViOWM3MDdlMzU2NzY0Y2NiY2I0OWJkOTBmMDk4 ZTQ0MWFhNmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpA QCAtOTQ5LDggKzk0OSw2IEBAIHdlYmtpdC5vcmcvYi8xMjU1NzMgY29tcG9zaXRpbmcvYmFja2dy b3VuZHMvZml4ZWQtYmFja2dyb3VuZHMuaHRtbCBbIENyYXNoIFBhc3MKIHdlYmtpdC5vcmcvYi8x MjkxODAgc3ZnL2NsaXAtcGF0aC9jbGlwLXBhdGgtb24tc3ZnLTAwMS5zdmcgWyBJbWFnZU9ubHlG YWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEyOTE4MCBzdmcvY2xpcC1wYXRoL2NsaXAtcGF0 aC1vbi1zdmctMDAyLnN2ZyBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCiAKLXdlYmtpdC5vcmcv Yi8xMzAzNTMgbWF0aG1sL3dici1pbi1tcm9vdC1jcmFzaC5odG1sIFsgQ3Jhc2ggUGFzcyBdCi0K IHdlYmtpdC5vcmcvYi8xMTk3ODkgZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaW5zaWRlLWlmcmFt ZS5odG1sIFsgQ3Jhc2ggUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8xMzMzMDUgZmFzdC90ZXh0L21h cmstbWF0Y2hlcy1yZW5kZXJpbmcuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDU0YmU2NmI5OTNhOGVi ODI5ZGI1YzVhN2YyYzhhODYwZDNlNWZhYWYuLmY5NDVkNTdlY2EzZWFlMGJhMWQ2MTFhZTYwMDZi MWQ3MzRiOGE4YTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z CkBAIC0xMDkzLDcgKzEwOTMsNiBAQCB3ZWJraXQub3JnL2IvMTMyMjU0IGZhc3Qvc3ViLXBpeGVs L3NpbXBsZS1jbGlwcGluZy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBDcmFzaAogd2Via2l0Lm9y Zy9iLzEzMjI1NyBmYXN0L2hpc3RvcnkvZm9ybS1zdWJtaXQtaW4tZnJhbWUtdmlhLW9uY2xpY2su aHRtbCBbIFRpbWVvdXQgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTMyMjYwIGZhc3Qvd29ya2Vycy93 b3JrZXItY2xvc2UuaHRtbCBbIFRpbWVvdXQgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTMyMjYxIGh0 bWw1bGliL2dlbmVyYXRlZC9ydW4tdGVzdHMxNi1kYXRhLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQot d2Via2l0Lm9yZy9iLzEzMjI2NyBtYXRobWwvd2JyLWluLW1yb290LWNyYXNoLmh0bWwgWyBUaW1l b3V0IFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzMjI3MiBmYXN0L2RvbS9nYy0xMC5odG1sIFsgRmFp bHVyZSBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMzIyNzkgcGVyZi9tb3VzZS1ldmVudC5odG1sIFsg RmFpbHVyZSBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMzIyODEgZmFzdC93b3JrZXJzL3dvcmtlci1j b25zdHJ1Y3Rvci5odG1sIFsgVGltZW91dCBQYXNzIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2lvcy1zaW11bGF0b3Itd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGU3MDkw ZDI2Y2QyNTViNzRlYzMyZTNjMzdhNDcyMGNkNjMyNjNjODIuLjY2NTI3NzIzMGJlYzk3MzBlNjY0 YmY1NDM5YzcyZDAwYmIzODQ3NTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lv cy1zaW11bGF0b3Itd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vaW9zLXNpbXVsYXRvci13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTg5NSw4ICsxODk1LDYg QEAgZmFzdC9zY3JvbGxpbmcvaW9zL3Njcm9sbC1ldmVudHMtYmFjay1mb3J3YXJkLWFmdGVyLXBh Z2VzaG93Lmh0bWwgWyBQYXNzIEZhaWx1cmUKIAogd2Via2l0Lm9yZy9iLzE1NzU4OSBmYXN0L3Rl eHQtYXV0b3NpemluZy9pb3MvdGV4dC1hdXRvc2l6aW5nLWFmdGVyLWJhY2suaHRtbCBbIFBhc3Mg VGltZW91dCBdCiAKLXdlYmtpdC5vcmcvYi8xNTc5OTAgWyBSZWxlYXNlIF0gbWF0aG1sL3dici1p bi1tcm9vdC1jcmFzaC5odG1sIFsgUGFzcyBUaW1lb3V0IF0KLQogIyBzdGFydGVkIHRvIGZhaWwg YWZ0ZXIgbmV3IHNuYXBzaG90dGluZyBpbiByMjAyNTMyCiBjb21wb3NpdGluZy9jb250ZW50cy1z Y2FsZS9yYXN0ZXJpemF0aW9uLXNjYWxlLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIGNvbXBv c2l0aW5nL292ZXJsYXAtYmxlbmRpbmcvcmVmbGVjdGlvbi1vcGFjaXR5LWh1Z2UuaHRtbCBbIElt YWdlT25seUZhaWx1cmUgXQo=