130349 2014-03-17 10:21:37 -0700 [Mac] getAttributedSubstringFromRange arguments are incorrectly named 2014-03-17 13:21:33 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap darin enrica oldest_to_newest 991284 0 ap 2014-03-17 10:21:37 -0700 We pass range start and end, and implementation treats arguments as such, but they are named location/length. 991286 1 226937 ap 2014-03-17 10:24:05 -0700 Created attachment 226937 proposed fix 991358 2 ap 2014-03-17 13:21:33 -0700 Committed <http://trac.webkit.org/r165750>. 226937 2014-03-17 10:24:05 -0700 2014-03-17 13:08:14 -0700 proposed fix RangeEnd.txt text/plain 6262 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTczOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAzLTE3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGdldEF0dHJpYnV0 ZWRTdWJzdHJpbmdGcm9tUmFuZ2UgYXJndW1lbnRzIGFyZSBpbmNvcnJlY3RseSBuYW1lZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMzQ5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgYSBt ZXNzIG9mIHN0YXJ0L2VuZCBhbmQgc3RhcnQvbGVuZ3RoIHBhaXJzIGluIElQQy4gT25lIGRheSB3 ZSdsbCBmaXggdGhlbQorICAgICAgICBhbGwsIGJ1dCBub3csIGxldCdzIGF0IGxlYXN0IG5hbWUg dGhlbSBjb3JyZWN0bHkuCisKKyAgICAgICAgTm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2Vi UGFnZVByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmdldEF0dHJp YnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2UpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMu aW46CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpnZXRBdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJhbmdlKToK KwogMjAxNC0wMy0xNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS11bQ01ha2VdIEVuc3VyZSB0aGF0IEhBVkVfR1RLX1VOSVhfUFJJTlRJTkcg aXMgZGVmaW5lZCB3aGVuIGFwcHJvcHJpYXRlCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiAxNjU1MzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTUzMiw3ICs1MzIsNyBAQCBw dWJsaWM6CiAgICAgYm9vbCBpbnNlcnREaWN0YXRlZFRleHQoY29uc3QgU3RyaW5nJiB0ZXh0LCB1 aW50NjRfdCByZXBsYWNlbWVudFJhbmdlU3RhcnQsIHVpbnQ2NF90IHJlcGxhY2VtZW50UmFuZ2VF bmQsIGNvbnN0IFZlY3RvcjxXZWJDb3JlOjpUZXh0QWx0ZXJuYXRpdmVXaXRoUmFuZ2U+JiBkaWN0 YXRpb25BbHRlcm5hdGl2ZXMpOwogICAgIHZvaWQgZ2V0TWFya2VkUmFuZ2UodWludDY0X3QmIGxv Y2F0aW9uLCB1aW50NjRfdCYgbGVuZ3RoKTsKICAgICB2b2lkIGdldFNlbGVjdGVkUmFuZ2UodWlu dDY0X3QmIGxvY2F0aW9uLCB1aW50NjRfdCYgbGVuZ3RoKTsKLSAgICB2b2lkIGdldEF0dHJpYnV0 ZWRTdWJzdHJpbmdGcm9tUmFuZ2UodWludDY0X3QgbG9jYXRpb24sIHVpbnQ2NF90IGxlbmd0aCwg QXR0cmlidXRlZFN0cmluZyYpOworICAgIHZvaWQgZ2V0QXR0cmlidXRlZFN1YnN0cmluZ0Zyb21S YW5nZSh1aW50NjRfdCByYW5nZVN0YXJ0LCB1aW50NjRfdCByYW5nZUVuZCwgQXR0cmlidXRlZFN0 cmluZyYpOwogICAgIHVpbnQ2NF90IGNoYXJhY3RlckluZGV4Rm9yUG9pbnQoY29uc3QgV2ViQ29y ZTo6SW50UG9pbnQpOwogICAgIFdlYkNvcmU6OkludFJlY3QgZmlyc3RSZWN0Rm9yQ2hhcmFjdGVy UmFuZ2UodWludDY0X3QsIHVpbnQ2NF90KTsKICAgICBib29sIGV4ZWN1dGVLZXlwcmVzc0NvbW1h bmRzKGNvbnN0IFZlY3RvcjxXZWJDb3JlOjpLZXlwcmVzc0NvbW1hbmQ+Jik7CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBhZ2VQcm94eU1hYy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBhZ2VQcm94eU1hYy5tbQkocmV2aXNp b24gMTY1NTM0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQYWdlUHJveHlN YWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTI0MSwxMSArMjQxLDExIEBAIHZvaWQgV2ViUGFnZVBy b3h5OjpnZXRTZWxlY3RlZFJhbmdlKHVpbnQKICAgICBwcm9jZXNzKCkuc2VuZFN5bmMoTWVzc2Fn ZXM6OldlYlBhZ2U6OkdldFNlbGVjdGVkUmFuZ2UoKSwgTWVzc2FnZXM6OldlYlBhZ2U6OkdldFNl bGVjdGVkUmFuZ2U6OlJlcGx5KGxvY2F0aW9uLCBsZW5ndGgpLCBtX3BhZ2VJRCk7CiB9CiAKLXZv aWQgV2ViUGFnZVByb3h5OjpnZXRBdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJhbmdlKHVpbnQ2NF90 IGxvY2F0aW9uLCB1aW50NjRfdCBsZW5ndGgsIEF0dHJpYnV0ZWRTdHJpbmcmIHJlc3VsdCkKK3Zv aWQgV2ViUGFnZVByb3h5OjpnZXRBdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJhbmdlKHVpbnQ2NF90 IHJhbmdlU3RhcnQsIHVpbnQ2NF90IHJhbmdlRW5kLCBBdHRyaWJ1dGVkU3RyaW5nJiByZXN1bHQp CiB7CiAgICAgaWYgKCFpc1ZhbGlkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICBwcm9jZXNzKCku c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBhZ2U6OkdldEF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFu Z2UobG9jYXRpb24sIGxlbmd0aCksIE1lc3NhZ2VzOjpXZWJQYWdlOjpHZXRBdHRyaWJ1dGVkU3Vi c3RyaW5nRnJvbVJhbmdlOjpSZXBseShyZXN1bHQpLCBtX3BhZ2VJRCk7CisgICAgcHJvY2Vzcygp LnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlOjpHZXRBdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJh bmdlKHJhbmdlU3RhcnQsIHJhbmdlRW5kKSwgTWVzc2FnZXM6OldlYlBhZ2U6OkdldEF0dHJpYnV0 ZWRTdWJzdHJpbmdGcm9tUmFuZ2U6OlJlcGx5KHJlc3VsdCksIG1fcGFnZUlEKTsKIH0KIAogdWlu dDY0X3QgV2ViUGFnZVByb3h5OjpjaGFyYWN0ZXJJbmRleEZvclBvaW50KGNvbnN0IEludFBvaW50 IHBvaW50KQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oCShyZXZpc2lvbiAxNjU1MzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NDMsNyArNTQzLDcgQEAgcHVibGljOgog I2VuZGlmCiAgICAgdm9pZCBnZXRNYXJrZWRSYW5nZSh1aW50NjRfdCYgbG9jYXRpb24sIHVpbnQ2 NF90JiBsZW5ndGgpOwogICAgIHZvaWQgZ2V0U2VsZWN0ZWRSYW5nZSh1aW50NjRfdCYgbG9jYXRp b24sIHVpbnQ2NF90JiBsZW5ndGgpOwotICAgIHZvaWQgZ2V0QXR0cmlidXRlZFN1YnN0cmluZ0Zy b21SYW5nZSh1aW50NjRfdCBsb2NhdGlvbiwgdWludDY0X3QgbGVuZ3RoLCBBdHRyaWJ1dGVkU3Ry aW5nJik7CisgICAgdm9pZCBnZXRBdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJhbmdlKHVpbnQ2NF90 IHJhbmdlU3RhcnQsIHVpbnQ2NF90IHJhbmdlRW5kLCBBdHRyaWJ1dGVkU3RyaW5nJik7CiAgICAg dm9pZCBjaGFyYWN0ZXJJbmRleEZvclBvaW50KGNvbnN0IFdlYkNvcmU6OkludFBvaW50IHBvaW50 LCB1aW50NjRfdCYgcmVzdWx0KTsKICAgICB2b2lkIGZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdl KHVpbnQ2NF90IGxvY2F0aW9uLCB1aW50NjRfdCBsZW5ndGgsIFdlYkNvcmU6OkludFJlY3QmIHJl c3VsdFJlY3QpOwogICAgIHZvaWQgZXhlY3V0ZUtleXByZXNzQ29tbWFuZHMoY29uc3QgVmVjdG9y PFdlYkNvcmU6OktleXByZXNzQ29tbWFuZD4mLCBib29sJiBoYW5kbGVkLCBFZGl0b3JTdGF0ZSYg bmV3U3RhdGUpOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UubWVzc2FnZXMuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4JKHJldmlzaW9uIDE2NTUzNCkKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCSh3b3JraW5nIGNv cHkpCkBAIC0yOTQsNyArMjk0LDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZSBMZWdhY3lSZWNlaXZl ciB7CiAgICAgQ2FuY2VsQ29tcG9zaXRpb24oKSAtPiAoV2ViS2l0OjpFZGl0b3JTdGF0ZSBuZXdT dGF0ZSkKICAgICBHZXRNYXJrZWRSYW5nZSgpIC0+ICh1aW50NjRfdCBsb2NhdGlvbiwgdWludDY0 X3QgbGVuZ3RoKQogICAgIEdldFNlbGVjdGVkUmFuZ2UoKSAtPiAodWludDY0X3QgbG9jYXRpb24s IHVpbnQ2NF90IGxlbmd0aCkKLSAgICBHZXRBdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJhbmdlKHVp bnQ2NF90IGxvY2F0aW9uLCB1aW50NjRfdCBsZW5ndGgpIC0+IChXZWJLaXQ6OkF0dHJpYnV0ZWRT dHJpbmcgcmVzdWx0KQorICAgIEdldEF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2UodWludDY0 X3QgcmFuZ2VTdGFydCwgdWludDY0X3QgcmFuZ2VFbmQpIC0+IChXZWJLaXQ6OkF0dHJpYnV0ZWRT dHJpbmcgcmVzdWx0KQogICAgIENoYXJhY3RlckluZGV4Rm9yUG9pbnQoV2ViQ29yZTo6SW50UG9p bnQgcG9pbnQpIC0+ICh1aW50NjRfdCByZXN1bHQpCiAgICAgRmlyc3RSZWN0Rm9yQ2hhcmFjdGVy UmFuZ2UodWludDY0X3QgbG9jYXRpb24sIHVpbnQ2NF90IGxlbmd0aCkgLT4gKFdlYkNvcmU6Oklu dFJlY3QgcmVzdWx0UmVjdCkKICAgICBFeGVjdXRlS2V5cHJlc3NDb21tYW5kcyhWZWN0b3I8V2Vi Q29yZTo6S2V5cHJlc3NDb21tYW5kPiBzYXZlZENvbW1hbmRzKSAtPiAoYm9vbCBoYW5kbGVkLCBX ZWJLaXQ6OkVkaXRvclN0YXRlIG5ld1N0YXRlKQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkocmV2aXNpb24gMTY1NTM0 KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0zNDcsNyArMzQ3LDcgQEAgdm9pZCBXZWJQYWdlOjpnZXRTZWxl Y3RlZFJhbmdlKHVpbnQ2NF90JgogICAgIH0KIH0KIAotdm9pZCBXZWJQYWdlOjpnZXRBdHRyaWJ1 dGVkU3Vic3RyaW5nRnJvbVJhbmdlKHVpbnQ2NF90IGxvY2F0aW9uLCB1aW50NjRfdCBsZW5ndGgs IEF0dHJpYnV0ZWRTdHJpbmcmIHJlc3VsdCkKK3ZvaWQgV2ViUGFnZTo6Z2V0QXR0cmlidXRlZFN1 YnN0cmluZ0Zyb21SYW5nZSh1aW50NjRfdCByYW5nZVN0YXJ0LCB1aW50NjRfdCByYW5nZUVuZCwg QXR0cmlidXRlZFN0cmluZyYgcmVzdWx0KQogewogICAgIEZyYW1lJiBmcmFtZSA9IG1fcGFnZS0+ Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCk7CiAKQEAgLTM1NSw3ICszNTUs NyBAQCB2b2lkIFdlYlBhZ2U6OmdldEF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tCiAgICAgaWYgKHNl bGVjdGlvbi5pc05vbmUoKSB8fCAhc2VsZWN0aW9uLmlzQ29udGVudEVkaXRhYmxlKCkgfHwgc2Vs ZWN0aW9uLmlzSW5QYXNzd29yZEZpZWxkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIE5TUmFu Z2UgbnNSYW5nZSA9IE5TTWFrZVJhbmdlKGxvY2F0aW9uLCBsZW5ndGggLSBsb2NhdGlvbik7Cisg ICAgTlNSYW5nZSBuc1JhbmdlID0gTlNNYWtlUmFuZ2UocmFuZ2VTdGFydCwgcmFuZ2VFbmQgLSBy YW5nZVN0YXJ0KTsKICAgICBSZWZQdHI8UmFuZ2U+IHJhbmdlID0gY29udmVydFRvUmFuZ2UoJmZy YW1lLCBuc1JhbmdlKTsKICAgICBpZiAoIXJhbmdlKQogICAgICAgICByZXR1cm47Cg==