130336 2014-03-17 07:41:53 -0700 [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break 2014-03-18 05:51:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 r.plociennik webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi ossy oldest_to_newest 991208 0 r.plociennik 2014-03-17 07:41:53 -0700 fontconfig-2.8.0 is not compliant with C++11 which leads to a build break on gcc 4.8.x. 991209 1 226915 r.plociennik 2014-03-17 07:43:40 -0700 Created attachment 226915 Proposed patch 991230 2 ossy 2014-03-17 08:56:20 -0700 How come it didn't cause build failure previously? We have used fontconfig 2.8 long time ago and there are many developers use GCC 4.8. 991233 3 r.plociennik 2014-03-17 09:04:54 -0700 (In reply to comment #2) > How come it didn't cause build failure previously? Perhaps this only started to occur when compiling with language standard explicitly set to C++11? The corresponding patch for GTK was just merged on Jan 21 2014 although this very issue has been detected/patched in Fontconfig at least 2 years ago. 991575 4 226915 gyuyoung.kim 2014-03-18 02:44:02 -0700 Comment on attachment 226915 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=226915&action=review As ossy said, could you show the build error log when compiling WebKit EFL with C++11 ? > Tools/ChangeLog:8 > + fontconfig-2.8.0 is not compliant with C++11 which leads to a build break This description looks redundant because bug title is almost same with description. 991602 5 r.plociennik 2014-03-18 04:18:45 -0700 (In reply to comment #4) > As ossy said, could you show the build error log when compiling WebKit EFL with C++11 ? Oh, right. I'm encountering the same issues as presented here: http://lists.freedesktop.org/archives/fontconfig/2012-April/003927.html Not to mention that the person that replies to that message is the same that provided the patch included in this patch and the original GTK one (9aa823564), referenced here. > This description looks redundant because bug title is almost same with description. True, updating the ChangeLog accordingly as we speak... 991605 6 227033 r.plociennik 2014-03-18 04:34:57 -0700 Created attachment 227033 Proposed patch 991621 7 227033 gyuyoung.kim 2014-03-18 05:21:41 -0700 Comment on attachment 227033 Proposed patch As mentioned in bug 127283, I believe EFL port doesn't want to slip C++11 into WebKit code as well. LGTM. 991624 8 227033 commit-queue 2014-03-18 05:51:47 -0700 Comment on attachment 227033 Proposed patch Clearing flags on attachment: 227033 Committed r165808: <http://trac.webkit.org/changeset/165808> 991625 9 commit-queue 2014-03-18 05:51:52 -0700 All reviewed patches have been landed. Closing bug. 226915 2014-03-17 07:43:40 -0700 2014-03-18 04:34:57 -0700 Proposed patch patch text/plain 2844 r.plociennik ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNzQ3 ODcwLi43YzIwNDU2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDMtMTcgIFJvYmVydCBQbG9jaWVubmlrICA8 ci5wbG9jaWVubmlrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIGZvbnRjb25maWctMi44 LjAgaXMgbm90IGNvbXBsaWFudCB3aXRoIEMrKzExIGxlYWRpbmcgdG8gYSBidWlsZCBicmVhawor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMzM2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZm9udGNvbmZp Zy0yLjguMCBpcyBub3QgY29tcGxpYW50IHdpdGggQysrMTEgd2hpY2ggbGVhZHMgdG8gYSBidWls ZCBicmVhaworICAgICAgICBvbiBnY2MgNC44LnguCisKKyAgICAgICAgVGhpcyBwYXRjaCBhcHBs aWVzIGEgc29sdXRpb24gZnJvbSByMTYyNDQ4IHRvIHRoZSBFRkwgcG9ydC4KKworICAgICAgICAq IGVmbC9wYXRjaGVzL2ZvbnRjb25maWctQy0xMS1yZXF1aXJlcy1hLXNwYWNlLWJldHdlZW4tbGl0 ZXJhbC1hbmQtaWRlbnRpZmllci5wYXRjaDogQWRkZWQuCisgICAgICAgICogZWZsL2poYnVpbGQu bW9kdWxlczogQWRkZWQgYXBwcm9wcmlhdGUgcGF0Y2ggc2VjdGlvbi4KKwogMjAxNC0wMy0xNiAg S2ltIEJ5dW5nIEp1biAgPGJqMTk4Ny5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0g RW5hYmxlIFRPVUNIX1NMSURFUiBtYWNybwpkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL2poYnVpbGQu bW9kdWxlcyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggN2FmOTEyYS4uYzk0MjU4 ZCAxMDA2NDQKLS0tIGEvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9lZmwv amhidWlsZC5tb2R1bGVzCkBAIC0xMzQsNiArMTM0LDcgQEAKICAgICAgICAgICAgIHJlcG89ImZy ZWVkZXNrdG9wLm9yZyIKICAgICAgICAgICAgIGhhc2g9InNoYTI1NjpmYTJhMWM2ZWVhNjU0ZDlm Y2U3YTRiMTIyMGYxMGM5OWNkZWM4NDhkY2NhZjE2MjVjMDFmMDc2YjMxMzgyMzM1IgogICAgICAg ICAgICAgbWQ1c3VtPSI3N2UxNWE5MjAwNmRkYzJhZGJiMDZmODQwZDU5MWMwZSI+CisgICAgICA8 cGF0Y2ggZmlsZT0iZm9udGNvbmZpZy1DLTExLXJlcXVpcmVzLWEtc3BhY2UtYmV0d2Vlbi1saXRl cmFsLWFuZC1pZGVudGlmaWVyLnBhdGNoIiBzdHJpcD0iMSIvPgogICAgIDwvYnJhbmNoPgogICA8 L2F1dG90b29scz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvZWZsL3BhdGNoZXMvZm9udGNvbmZpZy1D LTExLXJlcXVpcmVzLWEtc3BhY2UtYmV0d2Vlbi1saXRlcmFsLWFuZC1pZGVudGlmaWVyLnBhdGNo IGIvVG9vbHMvZWZsL3BhdGNoZXMvZm9udGNvbmZpZy1DLTExLXJlcXVpcmVzLWEtc3BhY2UtYmV0 d2Vlbi1saXRlcmFsLWFuZC1pZGVudGlmaWVyLnBhdGNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLmI0ZTBhNTQKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9lZmwvcGF0Y2hl cy9mb250Y29uZmlnLUMtMTEtcmVxdWlyZXMtYS1zcGFjZS1iZXR3ZWVuLWxpdGVyYWwtYW5kLWlk ZW50aWZpZXIucGF0Y2gKQEAgLTAsMCArMSwzMCBAQAorRnJvbSA3MDY5ZDcxN2U5ODJhZGNmOGUx ZDMwMGNiZDEwZWVjNjMyMmE2NWM5IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQorRnJvbTogQWtp cmEgVEFHT0ggPGFraXJhQHRhZ29oLm9yZz4KK0RhdGU6IFN1biwgMjIgQXByIDIwMTIgMjE6NDA6 NDQgKzA5MDAKK1N1YmplY3Q6IFtQQVRDSF0gQysrMTEgcmVxdWlyZXMgYSBzcGFjZSBiZXR3ZWVu IGxpdGVyYWwgYW5kIGlkZW50aWZpZXIKKworUmVwb3J0ZWQgYnkgQnVnYW5pbmkKKy0tLQorIGZv bnRjb25maWcvZm9udGNvbmZpZy5oIHwgNiArKystLS0KKyAxIGZpbGUgY2hhbmdlZCwgMyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQorCitkaWZmIC0tZ2l0IGEvZm9udGNvbmZpZy9mb250 Y29uZmlnLmggYi9mb250Y29uZmlnL2ZvbnRjb25maWcuaAoraW5kZXggMGUyY2E1MC4uYjI3Y2Ni NSAxMDA2NDQKKy0tLSBhL2ZvbnRjb25maWcvZm9udGNvbmZpZy5oCisrKysgYi9mb250Y29uZmln L2ZvbnRjb25maWcuaAorQEAgLTExMiw5ICsxMTIsOSBAQCB0eXBlZGVmIGludAkJRmNCb29sOwor ICNkZWZpbmUgRkNfREVDT1JBVElWRQkgICAgImRlY29yYXRpdmUiCS8qIEJvb2wgLSB0cnVlIGlm IHN0eWxlIGlzIGEgZGVjb3JhdGl2ZSB2YXJpYW50ICovCisgI2RlZmluZSBGQ19MQ0RfRklMVEVS CSAgICAibGNkZmlsdGVyIgkJLyogSW50ICovCisgCistI2RlZmluZSBGQ19DQUNIRV9TVUZGSVgJ CSAgICAiLmNhY2hlLSJGQ19DQUNIRV9WRVJTSU9OCistI2RlZmluZSBGQ19ESVJfQ0FDSEVfRklM RQkgICAgImZvbnRzLmNhY2hlLSJGQ19DQUNIRV9WRVJTSU9OCistI2RlZmluZSBGQ19VU0VSX0NB Q0hFX0ZJTEUJICAgICIuZm9udHMuY2FjaGUtIkZDX0NBQ0hFX1ZFUlNJT04KKysjZGVmaW5lIEZD X0NBQ0hFX1NVRkZJWAkJICAgICIuY2FjaGUtIiBGQ19DQUNIRV9WRVJTSU9OCisrI2RlZmluZSBG Q19ESVJfQ0FDSEVfRklMRQkgICAgImZvbnRzLmNhY2hlLSIgRkNfQ0FDSEVfVkVSU0lPTgorKyNk ZWZpbmUgRkNfVVNFUl9DQUNIRV9GSUxFCSAgICAiLmZvbnRzLmNhY2hlLSIgRkNfQ0FDSEVfVkVS U0lPTgorIAorIC8qIEFkanVzdCBvdXRsaW5lIHJhc3Rlcml6ZXIgKi8KKyAjZGVmaW5lIEZDX0NI QVJfV0lEVEgJICAgICJjaGFyd2lkdGgiCS8qIEludCAqLworLS0gCisxLjguMy4yCisK 227033 2014-03-18 04:34:57 -0700 2014-03-18 05:51:47 -0700 Proposed patch patch text/plain 2933 r.plociennik ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNzQ3 ODcwLi5jNDJlNzk2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDMtMTcgIFJvYmVydCBQbG9jaWVubmlrICA8 ci5wbG9jaWVubmlrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIGZvbnRjb25maWctMi44 LjAgaXMgbm90IGNvbXBsaWFudCB3aXRoIEMrKzExIGxlYWRpbmcgdG8gYSBidWlsZCBicmVhawor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMzM2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsYXRp b24gd2l0aCBnY2MgNC44LnggcmVzdWx0cyBpbiAnaW52YWxpZCBzdWZmaXggb24gbGl0ZXJhbDsg QysrMTEKKyAgICAgICAgcmVxdWlyZXMgYSBzcGFjZSBiZXR3ZWVuIGxpdGVyYWwgYW5kIHN0cmlu ZyBtYWNybyBbLVdsaXRlcmFsLXN1ZmZpeF0nCisgICAgICAgIHdhcm5pbmcgdHJlYXRlZCBhcyBl cnJvci4KKworICAgICAgICBUaGlzIHBhdGNoIGFwcGxpZXMgYSBzb2x1dGlvbiBmcm9tIHIxNjI0 NDggdG8gdGhlIEVGTCBwb3J0LgorCisgICAgICAgICogZWZsL3BhdGNoZXMvZm9udGNvbmZpZy1D LTExLXJlcXVpcmVzLWEtc3BhY2UtYmV0d2Vlbi1saXRlcmFsLWFuZC1pZGVudGlmaWVyLnBhdGNo OiBBZGRlZC4KKyAgICAgICAgKiBlZmwvamhidWlsZC5tb2R1bGVzOiBBZGRlZCBhcHByb3ByaWF0 ZSBwYXRjaCBzZWN0aW9uLgorCiAyMDE0LTAzLTE2ICBLaW0gQnl1bmcgSnVuICA8YmoxOTg3Lmtp bUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBFbmFibGUgVE9VQ0hfU0xJREVSIG1hY3Jv CmRpZmYgLS1naXQgYS9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZWZsL2poYnVp bGQubW9kdWxlcwppbmRleCA3YWY5MTJhLi5jOTQyNThkIDEwMDY0NAotLS0gYS9Ub29scy9lZmwv amhidWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKQEAgLTEzNCw2 ICsxMzQsNyBAQAogICAgICAgICAgICAgcmVwbz0iZnJlZWRlc2t0b3Aub3JnIgogICAgICAgICAg ICAgaGFzaD0ic2hhMjU2OmZhMmExYzZlZWE2NTRkOWZjZTdhNGIxMjIwZjEwYzk5Y2RlYzg0OGRj Y2FmMTYyNWMwMWYwNzZiMzEzODIzMzUiCiAgICAgICAgICAgICBtZDVzdW09Ijc3ZTE1YTkyMDA2 ZGRjMmFkYmIwNmY4NDBkNTkxYzBlIj4KKyAgICAgIDxwYXRjaCBmaWxlPSJmb250Y29uZmlnLUMt MTEtcmVxdWlyZXMtYS1zcGFjZS1iZXR3ZWVuLWxpdGVyYWwtYW5kLWlkZW50aWZpZXIucGF0Y2gi IHN0cmlwPSIxIi8+CiAgICAgPC9icmFuY2g+CiAgIDwvYXV0b3Rvb2xzPgogCmRpZmYgLS1naXQg YS9Ub29scy9lZmwvcGF0Y2hlcy9mb250Y29uZmlnLUMtMTEtcmVxdWlyZXMtYS1zcGFjZS1iZXR3 ZWVuLWxpdGVyYWwtYW5kLWlkZW50aWZpZXIucGF0Y2ggYi9Ub29scy9lZmwvcGF0Y2hlcy9mb250 Y29uZmlnLUMtMTEtcmVxdWlyZXMtYS1zcGFjZS1iZXR3ZWVuLWxpdGVyYWwtYW5kLWlkZW50aWZp ZXIucGF0Y2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYjRlMGE1NAotLS0g L2Rldi9udWxsCisrKyBiL1Rvb2xzL2VmbC9wYXRjaGVzL2ZvbnRjb25maWctQy0xMS1yZXF1aXJl cy1hLXNwYWNlLWJldHdlZW4tbGl0ZXJhbC1hbmQtaWRlbnRpZmllci5wYXRjaApAQCAtMCwwICsx LDMwIEBACitGcm9tIDcwNjlkNzE3ZTk4MmFkY2Y4ZTFkMzAwY2JkMTBlZWM2MzIyYTY1YzkgTW9u IFNlcCAxNyAwMDowMDowMCAyMDAxCitGcm9tOiBBa2lyYSBUQUdPSCA8YWtpcmFAdGFnb2gub3Jn PgorRGF0ZTogU3VuLCAyMiBBcHIgMjAxMiAyMTo0MDo0NCArMDkwMAorU3ViamVjdDogW1BBVENI XSBDKysxMSByZXF1aXJlcyBhIHNwYWNlIGJldHdlZW4gbGl0ZXJhbCBhbmQgaWRlbnRpZmllcgor CitSZXBvcnRlZCBieSBCdWdhbmluaQorLS0tCisgZm9udGNvbmZpZy9mb250Y29uZmlnLmggfCA2 ICsrKy0tLQorIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p CisKK2RpZmYgLS1naXQgYS9mb250Y29uZmlnL2ZvbnRjb25maWcuaCBiL2ZvbnRjb25maWcvZm9u dGNvbmZpZy5oCitpbmRleCAwZTJjYTUwLi5iMjdjY2I1IDEwMDY0NAorLS0tIGEvZm9udGNvbmZp Zy9mb250Y29uZmlnLmgKKysrKyBiL2ZvbnRjb25maWcvZm9udGNvbmZpZy5oCitAQCAtMTEyLDkg KzExMiw5IEBAIHR5cGVkZWYgaW50CQlGY0Jvb2w7CisgI2RlZmluZSBGQ19ERUNPUkFUSVZFCSAg ICAiZGVjb3JhdGl2ZSIJLyogQm9vbCAtIHRydWUgaWYgc3R5bGUgaXMgYSBkZWNvcmF0aXZlIHZh cmlhbnQgKi8KKyAjZGVmaW5lIEZDX0xDRF9GSUxURVIJICAgICJsY2RmaWx0ZXIiCQkvKiBJbnQg Ki8KKyAKKy0jZGVmaW5lIEZDX0NBQ0hFX1NVRkZJWAkJICAgICIuY2FjaGUtIkZDX0NBQ0hFX1ZF UlNJT04KKy0jZGVmaW5lIEZDX0RJUl9DQUNIRV9GSUxFCSAgICAiZm9udHMuY2FjaGUtIkZDX0NB Q0hFX1ZFUlNJT04KKy0jZGVmaW5lIEZDX1VTRVJfQ0FDSEVfRklMRQkgICAgIi5mb250cy5jYWNo ZS0iRkNfQ0FDSEVfVkVSU0lPTgorKyNkZWZpbmUgRkNfQ0FDSEVfU1VGRklYCQkgICAgIi5jYWNo ZS0iIEZDX0NBQ0hFX1ZFUlNJT04KKysjZGVmaW5lIEZDX0RJUl9DQUNIRV9GSUxFCSAgICAiZm9u dHMuY2FjaGUtIiBGQ19DQUNIRV9WRVJTSU9OCisrI2RlZmluZSBGQ19VU0VSX0NBQ0hFX0ZJTEUJ ICAgICIuZm9udHMuY2FjaGUtIiBGQ19DQUNIRV9WRVJTSU9OCisgCisgLyogQWRqdXN0IG91dGxp bmUgcmFzdGVyaXplciAqLworICNkZWZpbmUgRkNfQ0hBUl9XSURUSAkgICAgImNoYXJ3aWR0aCIJ LyogSW50ICovCistLSAKKzEuOC4zLjIKKwo=