130333 2014-03-17 06:59:10 -0700 [EFL] vibration/cancelVibration-during-pattern-vibrating.html is failing after r165598 2014-03-19 02:21:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 k.wolanski webkit-unassigned commit-queue darin gyuyoung.kim jw00.jeong lucas.de.marchi ossy ryuan.choi oldest_to_newest 991196 0 k.wolanski 2014-03-17 06:59:10 -0700 Added setting m_state when calling Vibration::vibrate. It was missing after refactoring Vibration (r165598). 991197 1 226908 k.wolanski 2014-03-17 06:59:58 -0700 Created attachment 226908 proposed patch 991589 2 jw00.jeong 2014-03-18 03:42:46 -0700 If there is a timing issue and this patch makes a layout test to pass, m_state should be set as State::Waiting instead of State::Vibrating. If m_state is set as State::Vibrating, the first element of m_pattern will be used for waiting time. 991606 3 227034 k.wolanski 2014-03-18 04:38:02 -0700 Created attachment 227034 apply suggestion 992056 4 227034 commit-queue 2014-03-19 02:18:07 -0700 Comment on attachment 227034 apply suggestion Clearing flags on attachment: 227034 Committed r165882: <http://trac.webkit.org/changeset/165882> 992058 5 commit-queue 2014-03-19 02:21:19 -0700 All reviewed patches have been landed. Closing bug. 226908 2014-03-17 06:59:58 -0700 2014-03-18 04:38:02 -0700 proposed patch gardening_17_03.patch text/plain 1184 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NjI2ODUwLi45MzU4MGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDMtMTcgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgW0VGTF0gdmlicmF0aW9uL2NhbmNlbFZpYnJhdGlvbi1kdXJpbmctcGF0 dGVybi12aWJyYXRpbmcuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHIxNjU1OTgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDMzMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHNldHRpbmcgbV9zdGF0 ZSB3aGVuIGNhbGxpbmcgVmlicmF0aW9uOjp2aWJyYXRlLiBJdCB3YXMgbWlzc2luZyBhZnRlcgor ICAgICAgICByZWZhY3RvcmluZyBWaWJyYXRpb24gKHIxNjU1OTgpLgorCisgICAgICAgICogTW9k dWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlZpYnJhdGlv bjo6dmlicmF0ZSk6CisKIDIwMTQtMDMtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFN0b3AgdXNpbmcgZGVwcmVjYXRlZENoYXJhY3RlcnMgaW4gSFRNTFRyZWVC dWlsZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9WaWJy YXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNw cAppbmRleCA2NTBiMDRiLi40MzYwMzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3ZpYnJhdGlvbi9WaWJyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv dmlicmF0aW9uL1ZpYnJhdGlvbi5jcHAKQEAgLTgyLDYgKzgyLDcgQEAgYm9vbCBWaWJyYXRpb246 OnZpYnJhdGUoY29uc3QgVmlicmF0aW9uUGF0dGVybiYgcGF0dGVybikKICAgICBtX3BhdHRlcm4g PSBzYW5pdGl6ZWQ7CiAKICAgICBtX3RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKKyAgICBtX3N0YXRl ID0gU3RhdGU6OlZpYnJhdGluZzsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo= 227034 2014-03-18 04:38:02 -0700 2014-03-19 02:17:14 -0700 apply suggestion gardening_17_03.patch text/plain 1182 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NjI2ODUwLi45MzU4MGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDMtMTcgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgW0VGTF0gdmlicmF0aW9uL2NhbmNlbFZpYnJhdGlvbi1kdXJpbmctcGF0 dGVybi12aWJyYXRpbmcuaHRtbCBpcyBmYWlsaW5nIGFmdGVyIHIxNjU1OTgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDMzMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHNldHRpbmcgbV9zdGF0 ZSB3aGVuIGNhbGxpbmcgVmlicmF0aW9uOjp2aWJyYXRlLiBJdCB3YXMgbWlzc2luZyBhZnRlcgor ICAgICAgICByZWZhY3RvcmluZyBWaWJyYXRpb24gKHIxNjU1OTgpLgorCisgICAgICAgICogTW9k dWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlZpYnJhdGlv bjo6dmlicmF0ZSk6CisKIDIwMTQtMDMtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFN0b3AgdXNpbmcgZGVwcmVjYXRlZENoYXJhY3RlcnMgaW4gSFRNTFRyZWVC dWlsZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9WaWJy YXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNw cAppbmRleCA2NTBiMDRiLi40MzYwMzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3ZpYnJhdGlvbi9WaWJyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv dmlicmF0aW9uL1ZpYnJhdGlvbi5jcHAKQEAgLTgyLDYgKzgyLDcgQEAgYm9vbCBWaWJyYXRpb246 OnZpYnJhdGUoY29uc3QgVmlicmF0aW9uUGF0dGVybiYgcGF0dGVybikKICAgICBtX3BhdHRlcm4g PSBzYW5pdGl6ZWQ7CiAKICAgICBtX3RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKKyAgICBtX3N0YXRl ID0gU3RhdGU6OldhaXRpbmc7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK