130323 2014-03-17 00:10:30 -0700 Stop using deprecatedCharacters in HTMLTreeBuilder 2014-03-17 01:01:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 126854 1 darin darin andersca barraclough esprehn+autocc gyuyoung.kim kling koivisto rniwa webkit-ews oldest_to_newest 991121 0 darin 2014-03-17 00:10:30 -0700 Stop using deprecatedCharacters in HTMLTreeBuilder 991125 1 226892 darin 2014-03-17 00:11:56 -0700 Created attachment 226892 Patch 991138 2 226892 kling 2014-03-17 00:52:41 -0700 Comment on attachment 226892 Patch Cool! Very curious to see how this fares on the perf bots. 991146 3 darin 2014-03-17 01:01:53 -0700 Committed r165724: <http://trac.webkit.org/changeset/165724> 226892 2014-03-17 00:11:56 -0700 2014-03-17 00:52:41 -0700 Patch bug-130323-20140317001134.patch text/plain 7301 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjcyNDk2YjBkNjVlZjg0 YzcwNzg3ZGJiMDg4MjBhNmNiZTIwZGNmZC4uZDk5MGQwYzAwOGFlYjRmMWUwMjI2NjRkYjNmNjA3 MmM5ZWQ4ZWNhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTAzLTE3ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHVzaW5nIGRlcHJlY2F0 ZWRDaGFyYWN0ZXJzIGluIEhUTUxUcmVlQnVpbGRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgS2VlcGluZyB0aGlzIHNlcGFyYXRlIGZyb20gb3RoZXIg cGF0Y2hlcyBiZWNhdXNlIG9mIGNvbmNlcm4gdGhhdCB0aGlzIGNvdWxkIGFmZmVjdAorICAgICAg ICBwYWdlIGxvYWQgcGVyZm9ybWFuY2UuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJl ZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpFeHRlcm5h bENoYXJhY3RlclRva2VuQnVmZmVyOjpFeHRlcm5hbENoYXJhY3RlclRva2VuQnVmZmVyKToKKyAg ICAgICAgVXNlIGEgU3RyaW5nVmlldyBpbnN0ZWFkIG9mIGEgY2hhcmFjdGVyIHBvaW50ZXIuCisg ICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OkV4dGVybmFsQ2hhcmFjdGVyVG9rZW5C dWZmZXI6OmlzRW1wdHkpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRl cjo6RXh0ZXJuYWxDaGFyYWN0ZXJUb2tlbkJ1ZmZlcjo6c2tpcEF0TW9zdE9uZUxlYWRpbmdOZXds aW5lKToKKyAgICAgICAgRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6 OkV4dGVybmFsQ2hhcmFjdGVyVG9rZW5CdWZmZXI6OnRha2VSZW1haW5pbmcpOiBEaXR0by4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6RXh0ZXJuYWxDaGFyYWN0ZXJUb2tlbkJ1 ZmZlcjo6Z2l2ZVJlbWFpbmluZ1RvKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJl ZUJ1aWxkZXI6OkV4dGVybmFsQ2hhcmFjdGVyVG9rZW5CdWZmZXI6OnRha2VSZW1haW5pbmdXaGl0 ZXNwYWNlKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OkV4dGVy bmFsQ2hhcmFjdGVyVG9rZW5CdWZmZXI6OnNraXBMZWFkaW5nKTogRGl0dG8uCisgICAgICAgIChX ZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OkV4dGVybmFsQ2hhcmFjdGVyVG9rZW5CdWZmZXI6OnRh a2VMZWFkaW5nKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6Omxp bmtpZnlQaG9uZU51bWJlcnMpOiBVc2UgU3RyaW5nVmlldzo6dXBjb252ZXJ0ZWRDaGFyYWN0ZXJz LgorCiAyMDE0LTAzLTE2ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAg ICAgICAgIFtDU1NSZWdpb25zXURvIG5vdCBjb21wdXRlIHJlZ2lvbiByYW5nZSBmb3IgYSBib3gg dW5sZXNzIHRoZSBwYXJlbnQgaGFzIG9uZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2Vy L0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggMjEzODU4ZWFlYjQ4MWNhZDc0NzY3NWFmMDc3ZTBm NTk3NjA3YTMxNS4uYjcwNmZlNjliNTYwNzUwNTNmZDgxYzRkMzU0NWE3OTJmNzgzNGY3NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0x MzgsMTcgKzEzOCwxNSBAQCBjbGFzcyBIVE1MVHJlZUJ1aWxkZXI6OkV4dGVybmFsQ2hhcmFjdGVy VG9rZW5CdWZmZXIgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEV4dGVybmFsQ2hhcmFjdGVy VG9rZW5CdWZmZXIpOwogcHVibGljOgogICAgIGV4cGxpY2l0IEV4dGVybmFsQ2hhcmFjdGVyVG9r ZW5CdWZmZXIoQXRvbWljSFRNTFRva2VuKiB0b2tlbikKLSAgICAgICAgOiBtX2N1cnJlbnQodG9r ZW4tPmNoYXJhY3RlcnMoKSkKLSAgICAgICAgLCBtX2VuZChtX2N1cnJlbnQgKyB0b2tlbi0+Y2hh cmFjdGVyc0xlbmd0aCgpKQorICAgICAgICA6IG1fdGV4dCh0b2tlbi0+Y2hhcmFjdGVycygpLCB0 b2tlbi0+Y2hhcmFjdGVyc0xlbmd0aCgpKQogICAgICAgICAsIG1faXNBbGw4Qml0RGF0YSh0b2tl bi0+aXNBbGw4Qml0RGF0YSgpKQogICAgIHsKICAgICAgICAgQVNTRVJUKCFpc0VtcHR5KCkpOwog ICAgIH0KIAogICAgIGV4cGxpY2l0IEV4dGVybmFsQ2hhcmFjdGVyVG9rZW5CdWZmZXIoY29uc3Qg U3RyaW5nJiBzdHJpbmcpCi0gICAgICAgIDogbV9jdXJyZW50KHN0cmluZy5kZXByZWNhdGVkQ2hh cmFjdGVycygpKQotICAgICAgICAsIG1fZW5kKG1fY3VycmVudCArIHN0cmluZy5sZW5ndGgoKSkK LSAgICAgICAgLCBtX2lzQWxsOEJpdERhdGEoc3RyaW5nLmxlbmd0aCgpICYmIHN0cmluZy5pczhC aXQoKSkKKyAgICAgICAgOiBtX3RleHQoc3RyaW5nKQorICAgICAgICAsIG1faXNBbGw4Qml0RGF0 YShtX3RleHQubGVuZ3RoKCkgJiYgbV90ZXh0LmlzOEJpdCgpKQogICAgIHsKICAgICAgICAgQVNT RVJUKCFpc0VtcHR5KCkpOwogICAgIH0KQEAgLTE1OCwxNSArMTU2LDE1IEBAIHB1YmxpYzoKICAg ICAgICAgQVNTRVJUKGlzRW1wdHkoKSk7CiAgICAgfQogCi0gICAgYm9vbCBpc0VtcHR5KCkgY29u c3QgeyByZXR1cm4gbV9jdXJyZW50ID09IG1fZW5kOyB9CisgICAgYm9vbCBpc0VtcHR5KCkgY29u c3QgeyByZXR1cm4gbV90ZXh0LmlzRW1wdHkoKTsgfQogCiAgICAgYm9vbCBpc0FsbDhCaXREYXRh KCkgY29uc3QgeyByZXR1cm4gbV9pc0FsbDhCaXREYXRhOyB9CiAKICAgICB2b2lkIHNraXBBdE1v c3RPbmVMZWFkaW5nTmV3bGluZSgpCiAgICAgewogICAgICAgICBBU1NFUlQoIWlzRW1wdHkoKSk7 Ci0gICAgICAgIGlmICgqbV9jdXJyZW50ID09ICdcbicpCi0gICAgICAgICAgICArK21fY3VycmVu dDsKKyAgICAgICAgaWYgKG1fdGV4dFswXSA9PSAnXG4nKQorICAgICAgICAgICAgbV90ZXh0ID0g bV90ZXh0LnN1YnN0cmluZygxKTsKICAgICB9CiAKICAgICB2b2lkIHNraXBMZWFkaW5nV2hpdGVz cGFjZSgpCkBAIC0xODYsMzcgKzE4NCwzOCBAQCBwdWJsaWM6CiAKICAgICBTdHJpbmcgdGFrZVJl bWFpbmluZygpCiAgICAgewotICAgICAgICBBU1NFUlQoIWlzRW1wdHkoKSk7Ci0gICAgICAgIGNv bnN0IFVDaGFyKiBzdGFydCA9IG1fY3VycmVudDsKLSAgICAgICAgbV9jdXJyZW50ID0gbV9lbmQ7 Ci0gICAgICAgIHNpemVfdCBsZW5ndGggPSBtX2N1cnJlbnQgLSBzdGFydDsKLQotICAgICAgICBp ZiAoaXNBbGw4Qml0RGF0YSgpKQotICAgICAgICAgICAgcmV0dXJuIFN0cmluZzo6bWFrZThCaXRG cm9tMTZCaXRTb3VyY2Uoc3RhcnQsIGxlbmd0aCk7Ci0KLSAgICAgICAgcmV0dXJuIFN0cmluZyhz dGFydCwgbGVuZ3RoKTsKKyAgICAgICAgU3RyaW5nIHJlc3VsdDsKKyAgICAgICAgaWYgKG1fdGV4 dC5pczhCaXQoKSB8fCAhaXNBbGw4Qml0RGF0YSgpKQorICAgICAgICAgICAgcmVzdWx0ID0gbV90 ZXh0LnRvU3RyaW5nKCk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJlc3VsdCA9IFN0cmlu Zzo6bWFrZThCaXRGcm9tMTZCaXRTb3VyY2UobV90ZXh0LmNoYXJhY3RlcnMxNigpLCBtX3RleHQu bGVuZ3RoKCkpOworICAgICAgICBtX3RleHQgPSBTdHJpbmdWaWV3KCk7CisgICAgICAgIHJldHVy biByZXN1bHQ7CiAgICAgfQogCiAgICAgdm9pZCBnaXZlUmVtYWluaW5nVG8oU3RyaW5nQnVpbGRl ciYgcmVjaXBpZW50KQogICAgIHsKLSAgICAgICAgcmVjaXBpZW50LmFwcGVuZChtX2N1cnJlbnQs IG1fZW5kIC0gbV9jdXJyZW50KTsKLSAgICAgICAgbV9jdXJyZW50ID0gbV9lbmQ7CisgICAgICAg IHJlY2lwaWVudC5hcHBlbmQobV90ZXh0KTsKKyAgICAgICAgbV90ZXh0ID0gU3RyaW5nVmlldygp OwogICAgIH0KIAogICAgIFN0cmluZyB0YWtlUmVtYWluaW5nV2hpdGVzcGFjZSgpCiAgICAgewog ICAgICAgICBBU1NFUlQoIWlzRW1wdHkoKSk7Ci0gICAgICAgIFZlY3RvcjxVQ2hhcj4gd2hpdGVz cGFjZTsKKyAgICAgICAgVmVjdG9yPExDaGFyLCA4PiB3aGl0ZXNwYWNlOwogICAgICAgICBkbyB7 Ci0gICAgICAgICAgICBVQ2hhciBjYyA9ICptX2N1cnJlbnQrKzsKLSAgICAgICAgICAgIGlmIChp c0hUTUxTcGFjZShjYykpCi0gICAgICAgICAgICAgICAgd2hpdGVzcGFjZS5hcHBlbmQoY2MpOwot ICAgICAgICB9IHdoaWxlIChtX2N1cnJlbnQgPCBtX2VuZCk7CisgICAgICAgICAgICBVQ2hhciBj aGFyYWN0ZXIgPSBtX3RleHRbMF07CisgICAgICAgICAgICBpZiAoaXNIVE1MU3BhY2UoY2hhcmFj dGVyKSkKKyAgICAgICAgICAgICAgICB3aGl0ZXNwYWNlLmFwcGVuZChjaGFyYWN0ZXIpOworICAg ICAgICAgICAgbV90ZXh0ID0gbV90ZXh0LnN1YnN0cmluZygxKTsKKyAgICAgICAgfSB3aGlsZSAo IW1fdGV4dC5pc0VtcHR5KCkpOworCiAgICAgICAgIC8vIFJldHVybmluZyB0aGUgbnVsbCBzdHJp bmcgd2hlbiB0aGVyZSBhcmVuJ3QgYW55IHdoaXRlc3BhY2UKICAgICAgICAgLy8gY2hhcmFjdGVy cyBpcyBzbGlnaHRseSBjbGVhbmVyIHNlbWFudGljYWxseSBiZWNhdXNlIHdlIGRvbid0IHdhbnQK ICAgICAgICAgLy8gdG8gaW5zZXJ0IGEgdGV4dCBub2RlIChhcyBvcHBvc2VkIHRvIGluc2VydGlu ZyBhbiBlbXB0eSB0ZXh0IG5vZGUpLgogICAgICAgICBpZiAod2hpdGVzcGFjZS5pc0VtcHR5KCkp CiAgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisKICAgICAgICAgcmV0dXJuIFN0cmluZzo6 YWRvcHQod2hpdGVzcGFjZSk7CiAgICAgfQogCkBAIC0yMjUsOCArMjI0LDkgQEAgcHJpdmF0ZToK ICAgICB2b2lkIHNraXBMZWFkaW5nKCkKICAgICB7CiAgICAgICAgIEFTU0VSVCghaXNFbXB0eSgp KTsKLSAgICAgICAgd2hpbGUgKGNoYXJhY3RlclByZWRpY2F0ZSgqbV9jdXJyZW50KSkgewotICAg ICAgICAgICAgaWYgKCsrbV9jdXJyZW50ID09IG1fZW5kKQorICAgICAgICB3aGlsZSAoY2hhcmFj dGVyUHJlZGljYXRlKG1fdGV4dFswXSkpIHsKKyAgICAgICAgICAgIG1fdGV4dCA9IG1fdGV4dC5z dWJzdHJpbmcoMSk7CisgICAgICAgICAgICBpZiAobV90ZXh0LmlzRW1wdHkoKSkKICAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9CkBAIC0yMzUsMTcgKzIzNSwxNyBAQCBw cml2YXRlOgogICAgIFN0cmluZyB0YWtlTGVhZGluZygpCiAgICAgewogICAgICAgICBBU1NFUlQo IWlzRW1wdHkoKSk7Ci0gICAgICAgIGNvbnN0IFVDaGFyKiBzdGFydCA9IG1fY3VycmVudDsKKyAg ICAgICAgU3RyaW5nVmlldyBzdGFydCA9IG1fdGV4dDsKICAgICAgICAgc2tpcExlYWRpbmc8Y2hh cmFjdGVyUHJlZGljYXRlPigpOwotICAgICAgICBpZiAoc3RhcnQgPT0gbV9jdXJyZW50KQorICAg ICAgICBpZiAoc3RhcnQubGVuZ3RoKCkgPT0gbV90ZXh0Lmxlbmd0aCgpKQogICAgICAgICAgICAg cmV0dXJuIFN0cmluZygpOwotICAgICAgICBpZiAoaXNBbGw4Qml0RGF0YSgpKQotICAgICAgICAg ICAgcmV0dXJuIFN0cmluZzo6bWFrZThCaXRGcm9tMTZCaXRTb3VyY2Uoc3RhcnQsIG1fY3VycmVu dCAtIHN0YXJ0KTsKLSAgICAgICAgcmV0dXJuIFN0cmluZyhzdGFydCwgbV9jdXJyZW50IC0gc3Rh cnQpOworICAgICAgICBTdHJpbmdWaWV3IGxlYWRpbmcgPSBzdGFydC5zdWJzdHJpbmcoMCwgc3Rh cnQubGVuZ3RoKCkgLSBtX3RleHQubGVuZ3RoKCkpOworICAgICAgICBpZiAobGVhZGluZy5pczhC aXQoKSB8fCAhaXNBbGw4Qml0RGF0YSgpKQorICAgICAgICAgICAgcmV0dXJuIGxlYWRpbmcudG9T dHJpbmcoKTsKKyAgICAgICAgcmV0dXJuIFN0cmluZzo6bWFrZThCaXRGcm9tMTZCaXRTb3VyY2Uo bGVhZGluZy5jaGFyYWN0ZXJzMTYoKSwgbGVhZGluZy5sZW5ndGgoKSk7CiAgICAgfQogCi0gICAg Y29uc3QgVUNoYXIqIG1fY3VycmVudDsKLSAgICBjb25zdCBVQ2hhciogbV9lbmQ7CisgICAgU3Ry aW5nVmlldyBtX3RleHQ7CiAgICAgYm9vbCBtX2lzQWxsOEJpdERhdGE7CiB9OwogCkBAIC0yMzM4 LDggKzIzMzgsMTAgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OmxpbmtpZnlQaG9uZU51bWJlcnMo Y29uc3QgU3RyaW5nJiBzdHJpbmcpCiAgICAgaW50IHJlbGF0aXZlU3RhcnRQb3NpdGlvbiA9IDA7 CiAgICAgaW50IHJlbGF0aXZlRW5kUG9zaXRpb24gPSAwOwogCisgICAgYXV0byBjaGFyYWN0ZXJz ID0gc3RyaW5nLnVwY29udmVydGVkQ2hhcmFjdGVycygpOworCiAgICAgLy8gV2hpbGUgdGhlcmUn cyBhIHBob25lIG51bWJlciBpbiB0aGUgcmVzdCBvZiB0aGUgc3RyaW5nLi4uCi0gICAgd2hpbGUg KChzY2FubmVyUG9zaXRpb24gPCBsZW5ndGgpICYmIFRlbGVwaG9uZU51bWJlckRldGVjdG9yOjpm aW5kKCZzdHJpbmcuZGVwcmVjYXRlZENoYXJhY3RlcnMoKVtzY2FubmVyUG9zaXRpb25dLCBsZW5n dGggLSBzY2FubmVyUG9zaXRpb24sICZyZWxhdGl2ZVN0YXJ0UG9zaXRpb24sICZyZWxhdGl2ZUVu ZFBvc2l0aW9uKSkgeworICAgIHdoaWxlIChzY2FubmVyUG9zaXRpb24gPCBsZW5ndGggJiYgVGVs ZXBob25lTnVtYmVyRGV0ZWN0b3I6OmZpbmQoJmNoYXJhY3RlcnNbc2Nhbm5lclBvc2l0aW9uXSwg bGVuZ3RoIC0gc2Nhbm5lclBvc2l0aW9uLCAmcmVsYXRpdmVTdGFydFBvc2l0aW9uLCAmcmVsYXRp dmVFbmRQb3NpdGlvbikpIHsKICAgICAgICAgLy8gVGhlIGNvbnZlbnRpb24gaW4gdGhlIERhdGEg RGV0ZWN0b3JzIGZyYW1ld29yayBpcyB0aGF0IHRoZSBlbmQgcG9zaXRpb24gaXMgdGhlIGZpcnN0 IGNoYXJhY3RlciBOT1QgaW4gdGhlIHBob25lIG51bWJlcgogICAgICAgICAvLyAodGhhdCBpcywg dGhlIGxlbmd0aCBvZiB0aGUgcmFuZ2UgaXMgcmVsYXRpdmVFbmRQb3NpdGlvbiAtIHJlbGF0aXZl U3RhcnRQb3NpdGlvbikuIFNvIHN1YnN0cmFjdCAxIHRvIGdldCB0aGUgc2FtZQogICAgICAgICAv LyBjb252ZW50aW9uIGFzIHRoZSBvbGQgV2ViQ29yZSBwaG9uZSBudW1iZXIgcGFyc2VyIChzbyB0 aGF0IHRoZSByZXN0IG9mIHRoZSBjb2RlIGlzIHN0aWxsIHZhbGlkIGlmIHdlIHdhbnQgdG8gZ28g YmFjawo=