130315 2014-03-16 15:56:21 -0700 CSSValueList should assert that no null values are added to it. 2014-03-16 21:32:22 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn gyuyoung.kim kling koivisto macpherson menard oldest_to_newest 991047 0 kling 2014-03-16 15:56:21 -0700 CSSValueList should assert that no null values are added to it. 991048 1 226865 kling 2014-03-16 15:56:53 -0700 Created attachment 226865 Patch 991050 2 commit-queue 2014-03-16 15:59:35 -0700 Attachment 226865 did not pass style-queue: ERROR: Source/WebCore/css/CSSValueList.h:57: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/css/CSSValueList.h:58: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 991068 3 226865 darin 2014-03-16 19:25:55 -0700 Comment on attachment 226865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226865&action=review Bot says: Regressions: Unexpected crashes (1) mathml/wbr-in-mroot-crash.html [ Crash ] r=me if you look into that > Source/WebCore/css/CSSValueList.h:58 > + void append(PassRefPtr<CSSValue> value); > + void prepend(PassRefPtr<CSSValue> value); Like the style bot says, you should remove the argument names here. 991083 4 kling 2014-03-16 21:32:22 -0700 Committed r165717: <http://trac.webkit.org/changeset/165717> 226865 2014-03-16 15:56:53 -0700 2014-03-16 19:25:54 -0700 Patch bug-130315.diff text/plain 3645 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDlhY2I0Li4yYzFiYjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMDMtMTYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIENTU1ZhbHVlTGlzdCBzaG91bGQgYXNzZXJ0IHRoYXQgbm8gbnVsbCB2YWx1ZXMgYXJlIGFk ZGVkIHRvIGl0LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMwMzE1PgorCisgICAg ICAgIEFkZCBhc3NlcnRpb25zIGluIENTU1ZhbHVlTGlzdCdzIGFwcGVuZCgpIGFuZCBwcmVwZW5k KCkgdGhhdCB3ZSBhcmUKKyAgICAgICAgbm90IGFkZGluZyBhIG51bGwgdmFsdWUuIFRoaXMgY2F1 Z2h0IGEgc2luZ2xlIHBsYWNlIGluIENTU1BhcnNlcgorICAgICAgICB0aGF0IHdhcyBhcHBlbmRp bmcgYW4gYWxyZWFkLXJlbGVhc2VkIFJlZlB0ciB0byBhIENTU1ZhbHVlTGlzdC4KKyAgICAgICAg VGhhdCBsaXN0IHdhcyBldmVudHVhbGx5IGRpc2NhcmRlZCBhbnl3YXkgKGR1ZSB0byAiZm91bmRD bGlwIiBub3cKKyAgICAgICAgYmVpbmcgdHJ1ZSksIHNvIHRoZSBmaXggaXMgc2ltcGx5IHRvIHJl bW92ZSB0aGUgYWRkaW5nLgorCisgICAgICAgIEV2ZW50dWFsbHkgd2Ugc2hvdWxkIHVzZSBSZWYg YW5kIFBhc3NSZWYgYWxsIG92ZXIgZm9yIENTU1ZhbHVlTGlzdCwKKyAgICAgICAgdGhpcyBpcyBq dXN0IGEgZmlyc3Qgc3RlcCBvbiB0aGUgd2F5LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDU1NQYXJzZXI6OnBhcnNlRmlsbFNob3J0aGFuZCk6CisgICAgICAgICogY3NzL0NTU1Zh bHVlTGlzdC5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTVmFsdWVMaXN0OjphcHBlbmQpOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTVmFsdWVMaXN0OjpwcmVwZW5kKToKKwogMjAxNC0wMy0wMyAgQW5k cmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgU2NyaXB0RXhlY3V0aW9u Q29udGV4dDo6dm0oKSBzaG91bGQgcmV0dXJuIGEgcmVmZXJlbmNlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmNwcAppbmRleCBhYzFlNDU1Li5lNjZjN2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cApAQCAtMzE5NSwxMSArMzE5NSw4IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUZpbGxTaG9ydGhh bmQoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGNvbnN0IENTU1Byb3BlcnR5SUQqIHByCiAgICAgICAg ICAgICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWRkRmls bFZhbHVlKGNsaXBWYWx1ZSwgY3NzVmFsdWVQb29sKCkuY3JlYXRlSW1wbGljaXRJbml0aWFsVmFs dWUoKSk7IC8vIFNvbWUgdmFsdWUgd2FzIHVzZWQgZm9yIG9yaWdpbiB0aGF0IGlzIG5vdCBzdXBw b3J0ZWQgYnkgY2xpcC4gSnVzdCByZXNldCBjbGlwIGluc3RlYWQuCiAgICAgICAgICAgICAgICAg ICAgIH0KLSAgICAgICAgICAgICAgICAgICAgaWYgKHByb3BlcnRpZXNbaV0gPT0gQ1NTUHJvcGVy dHlCYWNrZ3JvdW5kQ2xpcCB8fCBwcm9wZXJ0aWVzW2ldID09IENTU1Byb3BlcnR5V2Via2l0TWFz a0NsaXApIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIFVwZGF0ZSBjbGlwVmFsdWUKLSAg ICAgICAgICAgICAgICAgICAgICAgIGFkZEZpbGxWYWx1ZShjbGlwVmFsdWUsIHZhbDEucmVsZWFz ZSgpKTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKHByb3BlcnRpZXNbaV0gPT0gQ1NTUHJvcGVy dHlCYWNrZ3JvdW5kQ2xpcCB8fCBwcm9wZXJ0aWVzW2ldID09IENTU1Byb3BlcnR5V2Via2l0TWFz a0NsaXApCiAgICAgICAgICAgICAgICAgICAgICAgICBmb3VuZENsaXAgPSB0cnVlOwotICAgICAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIGlmIChwcm9wZXJ0aWVzW2ldID09 IENTU1Byb3BlcnR5QmFja2dyb3VuZFBvc2l0aW9uIHx8IHByb3BlcnRpZXNbaV0gPT0gQ1NTUHJv cGVydHlXZWJraXRNYXNrUG9zaXRpb24pCiAgICAgICAgICAgICAgICAgICAgICAgICBmb3VuZFBv c2l0aW9uQ1NTUHJvcGVydHkgPSB0cnVlOwogICAgICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUxpc3QuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NWYWx1ZUxpc3QuaAppbmRleCBmYTgyYTlhLi5jODVjNGY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTVmFsdWVMaXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Zh bHVlTGlzdC5oCkBAIC01NCw4ICs1NCw4IEBAIHB1YmxpYzoKICAgICBDU1NWYWx1ZSogaXRlbVdp dGhvdXRCb3VuZHNDaGVjayhzaXplX3QgaW5kZXgpIHsgcmV0dXJuIG1fdmFsdWVzW2luZGV4XS5n ZXQoKTsgfQogICAgIGNvbnN0IENTU1ZhbHVlKiBpdGVtV2l0aG91dEJvdW5kc0NoZWNrKHNpemVf dCBpbmRleCkgY29uc3QgeyBBU1NFUlQoaW5kZXggPCBtX3ZhbHVlcy5zaXplKCkpOyByZXR1cm4g bV92YWx1ZXNbaW5kZXhdLmdldCgpOyB9CiAKLSAgICB2b2lkIGFwcGVuZChQYXNzUmVmUHRyPENT U1ZhbHVlPiB2YWx1ZSkgeyBtX3ZhbHVlcy5hcHBlbmQodmFsdWUpOyB9Ci0gICAgdm9pZCBwcmVw ZW5kKFBhc3NSZWZQdHI8Q1NTVmFsdWU+IHZhbHVlKSB7IG1fdmFsdWVzLmluc2VydCgwLCB2YWx1 ZSk7IH0KKyAgICB2b2lkIGFwcGVuZChQYXNzUmVmUHRyPENTU1ZhbHVlPiB2YWx1ZSk7CisgICAg dm9pZCBwcmVwZW5kKFBhc3NSZWZQdHI8Q1NTVmFsdWU+IHZhbHVlKTsKICAgICBib29sIHJlbW92 ZUFsbChDU1NWYWx1ZSopOwogICAgIGJvb2wgaGFzVmFsdWUoQ1NTVmFsdWUqKSBjb25zdDsKICAg ICBQYXNzUmVmUHRyPENTU1ZhbHVlTGlzdD4gY29weSgpOwpAQCAtODMsNiArODMsMTggQEAgcHJp dmF0ZToKIAogQ1NTX1ZBTFVFX1RZUEVfQ0FTVFMoQ1NTVmFsdWVMaXN0LCBpc1ZhbHVlTGlzdCgp KQogCitpbmxpbmUgdm9pZCBDU1NWYWx1ZUxpc3Q6OmFwcGVuZChQYXNzUmVmUHRyPENTU1ZhbHVl PiB2YWx1ZSkKK3sKKyAgICBBU1NFUlQodmFsdWUpOworICAgIG1fdmFsdWVzLmFwcGVuZCh2YWx1 ZSk7Cit9CisKK2lubGluZSB2b2lkIENTU1ZhbHVlTGlzdDo6cHJlcGVuZChQYXNzUmVmUHRyPENT U1ZhbHVlPiB2YWx1ZSkKK3sKKyAgICBBU1NFUlQodmFsdWUpOworICAgIG1fdmFsdWVzLmluc2Vy dCgwLCB2YWx1ZSk7Cit9CisKIC8vIE9iamVjdHMgb2YgdGhpcyBjbGFzcyBhcmUgaW50ZW5kZWQg dG8gYmUgc3RhY2stYWxsb2NhdGVkIGFuZCBzY29wZWQgdG8gYSBzaW5nbGUgZnVuY3Rpb24uCiAv LyBQbGVhc2UgdGFrZSBjYXJlIG5vdCB0byBwYXNzIHRoZXNlIGFyb3VuZCBhcyB0aGV5IGRvIGhv bGQgb250byBhIHJhdyBwb2ludGVyLgogY2xhc3MgQ1NTVmFsdWVMaXN0SW5zcGVjdG9yIHsK