130303 2014-03-16 03:24:43 -0700 HTMLInputElement::defaultEventHandler() shouldn't force style updates. 2014-03-17 16:14:00 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling koivisto oldest_to_newest 990952 0 kling 2014-03-16 03:24:43 -0700 HTMLInputElement::defaultEventHandler() shouldn't force style updates. 990953 1 226839 kling 2014-03-16 03:25:59 -0700 Created attachment 226839 Patch 990968 2 226839 darin 2014-03-16 08:42:28 -0700 Comment on attachment 226839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226839&action=review > Source/WebCore/ChangeLog:10 > + There might be a better way to do this; we only want to know if the > + element has/gets a renderer at all, but this is an easy hack to avoid > + a lot of unnecessary work. This comment made me see a little bit of opportunity for additional optimization. We don’t in fact just want to know if the element has a renderer in all cases. We use the renderer for blur and focus. And in the other cases we want to know if there’s a renderer. But in still-other cases we don’t need to check the renderer for null at all! > Source/WebCore/html/TextFieldInputType.cpp:180 > + element().document().updateStyleIfNeededForNode(element()); > if (element().renderer() && (event->isMouseEvent() || event->isDragEvent() || event->eventInterface() == WheelEventInterfaceType || event->type() == eventNames().blurEvent || event->type() == eventNames().focusEvent)) { Should rearrange this to only do the updateStyleIfNeededForNode after the second half of the if statement returns true. No reason to do this style update for other types of events. 991443 3 kling 2014-03-17 16:14:00 -0700 Committed r165773: <http://trac.webkit.org/changeset/165773> 226839 2014-03-16 03:25:59 -0700 2014-03-16 08:42:28 -0700 Patch bug-130303.diff text/plain 2271 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZWI0MzJlZi4uMGVlMTFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE0LTAzLTE2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAg ICAgICBIVE1MSW5wdXRFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKCkgc2hvdWxkbid0IGZv cmNlIHN0eWxlIHVwZGF0ZXMuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzAzMDM+ CisKKyAgICAgICAgTW92ZSB0aGUgdXBkYXRlU3R5bGVJZk5lZWRlZCgpIGNhbGwgZG93biB0byBU ZXh0RmllbGRJbnB1dFR5cGUgaW5zdGVhZAorICAgICAgICBvZiBkb2luZyBpdCBmb3IgZXZlcnkg SFRNTElucHV0RXZlbnQuCisgICAgICAgIFRoZXJlIG1pZ2h0IGJlIGEgYmV0dGVyIHdheSB0byBk byB0aGlzOyB3ZSBvbmx5IHdhbnQgdG8ga25vdyBpZiB0aGUKKyAgICAgICAgZWxlbWVudCBoYXMv Z2V0cyBhIHJlbmRlcmVyIGF0IGFsbCwgYnV0IHRoaXMgaXMgYW4gZWFzeSBoYWNrIHRvIGF2b2lk CisgICAgICAgIGEgbG90IG9mIHVubmVjZXNzYXJ5IHdvcmsuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6CisgICAgICAgICogaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjpmb3J3YXJkRXZlbnQpOgorCiAyMDE0LTAzLTE1ICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHB1bGxpbmcg aW4gSlNET01CaW5kaW5nLmggdmlhIEpTRXZlbnRMaXN0ZW5lci5oCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCBmOGM5Nzc3Li41OGE5NDBjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTExNzYsNyArMTE3Niw2IEBAIHZv aWQgSFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZ0KQogICAg ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGRvY3VtZW50KCkudXBkYXRlU3R5bGVJZk5l ZWRlZEZvck5vZGUoKnRoaXMpOwogICAgIG1faW5wdXRUeXBlLT5mb3J3YXJkRXZlbnQoZXZ0KTsK IAogICAgIGlmICghY2FsbEJhc2VDbGFzc0Vhcmx5ICYmICFldnQtPmRlZmF1bHRIYW5kbGVkKCkp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKaW5kZXggNDM5OGJj Mi4uYWE2Mzc4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1 dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNw cApAQCAtMTc2LDYgKzE3Niw3IEBAIHZvaWQgVGV4dEZpZWxkSW5wdXRUeXBlOjpmb3J3YXJkRXZl bnQoRXZlbnQqIGV2ZW50KQogICAgICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGVsZW1l bnQoKS5kb2N1bWVudCgpLnVwZGF0ZVN0eWxlSWZOZWVkZWRGb3JOb2RlKGVsZW1lbnQoKSk7CiAg ICAgaWYgKGVsZW1lbnQoKS5yZW5kZXJlcigpICYmIChldmVudC0+aXNNb3VzZUV2ZW50KCkgfHwg ZXZlbnQtPmlzRHJhZ0V2ZW50KCkgfHwgZXZlbnQtPmV2ZW50SW50ZXJmYWNlKCkgPT0gV2hlZWxF dmVudEludGVyZmFjZVR5cGUgfHwgZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkuYmx1ckV2 ZW50IHx8IGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmZvY3VzRXZlbnQpKSB7CiAgICAg ICAgIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZSogcmVuZGVyVGV4dENvbnRyb2wgPSB0b1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZShlbGVtZW50KCkucmVuZGVyZXIoKSk7CiAgICAgICAg IGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5ibHVyRXZlbnQpIHsK