130298 2014-03-15 21:54:21 -0700 PlatformTimeRanges::nearest() truncates closestDelta values from double to float 2014-03-16 10:05:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin eric.carlson jer.noble mjs simon.fraser oldest_to_newest 990923 0 ddkilzer 2014-03-15 21:54:21 -0700 WebCore/platform/graphics/PlatformTimeRanges.cpp:210:28: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value] closestDelta = fabsf(startTime - time); ^ WebCore/platform/graphics/PlatformTimeRanges.cpp:210:28: note: use function 'fabs' instead closestDelta = fabsf(startTime - time); ^~~~~ fabs WebCore/platform/graphics/PlatformTimeRanges.cpp:214:28: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value] closestDelta = fabsf(endTime - time); ^ WebCore/platform/graphics/PlatformTimeRanges.cpp:214:28: note: use function 'fabs' instead closestDelta = fabsf(endTime - time); ^~~~~ fabs 2 errors generated. 990926 1 226831 ddkilzer 2014-03-15 22:05:51 -0700 Created attachment 226831 Patch v1 990973 2 226831 commit-queue 2014-03-16 10:05:44 -0700 Comment on attachment 226831 Patch v1 Clearing flags on attachment: 226831 Committed r165701: <http://trac.webkit.org/changeset/165701> 990974 3 commit-queue 2014-03-16 10:05:49 -0700 All reviewed patches have been landed. Closing bug. 226831 2014-03-15 22:05:51 -0700 2014-03-16 10:05:44 -0700 Patch v1 bug-130298-20140315220528.patch text/plain 3354 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2Y2E1NmJlNzhhMTVj MjUyZTIyODIxNWIzZjY3YTgzM2QwN2M4MS4uMWIxODk1NTRmMjk2YWVhODRiN2Q4ZTlkZjhkMmRj NjEzMWUwOGVjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM0IEBACiAyMDE0LTAzLTE1ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAgICAgICAgUGxhdGZvcm1UaW1lUmFu Z2VzOjpuZWFyZXN0KCkgdHJ1bmNhdGVzIGNsb3Nlc3REZWx0YSB2YWx1ZXMgZnJvbSBkb3VibGUg dG8gZmxvYXQKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTMwMjk4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIHRoZSBmb2xsb3dp bmcgYnVpbGQgZmFpbHVyZXMgdXNpbmcgdHJ1bmsgY2xhbmc6CisKKyAgICAgICAgICAgIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1UaW1lUmFuZ2VzLmNwcDoyMTA6Mjg6IGVycm9y OiBhYnNvbHV0ZSB2YWx1ZSBmdW5jdGlvbiAnZmFic2YnIGdpdmVuIGFuIGFyZ3VtZW50IG9mIHR5 cGUgJ2RvdWJsZScgYnV0IGhhcyBwYXJhbWV0ZXIgb2YgdHlwZSAnZmxvYXQnIHdoaWNoIG1heSBj YXVzZSB0cnVuY2F0aW9uIG9mIHZhbHVlIFstV2Vycm9yLC1XYWJzb2x1dGUtdmFsdWVdCisgICAg ICAgICAgICAgICAgICAgICAgICBjbG9zZXN0RGVsdGEgPSBmYWJzZihzdGFydFRpbWUgLSB0aW1l KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4KKyAgICAgICAgICAg IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1UaW1lUmFuZ2VzLmNwcDoyMTA6Mjg6 IG5vdGU6IHVzZSBmdW5jdGlvbiAnZmFicycgaW5zdGVhZAorICAgICAgICAgICAgICAgICAgICAg ICAgY2xvc2VzdERlbHRhID0gZmFic2Yoc3RhcnRUaW1lIC0gdGltZSk7CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZmFicworICAgICAgICAgICAgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9QbGF0Zm9ybVRpbWVSYW5nZXMuY3BwOjIxNDoyODogZXJyb3I6IGFic29sdXRlIHZhbHVlIGZ1 bmN0aW9uICdmYWJzZicgZ2l2ZW4gYW4gYXJndW1lbnQgb2YgdHlwZSAnZG91YmxlJyBidXQgaGFz IHBhcmFtZXRlciBvZiB0eXBlICdmbG9hdCcgd2hpY2ggbWF5IGNhdXNlIHRydW5jYXRpb24gb2Yg dmFsdWUgWy1XZXJyb3IsLVdhYnNvbHV0ZS12YWx1ZV0KKyAgICAgICAgICAgICAgICAgICAgICAg IGNsb3Nlc3REZWx0YSA9IGZhYnNmKGVuZFRpbWUgLSB0aW1lKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIF4KKyAgICAgICAgICAgIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvUGxhdGZvcm1UaW1lUmFuZ2VzLmNwcDoyMTQ6Mjg6IG5vdGU6IHVzZSBmdW5jdGlvbiAn ZmFicycgaW5zdGVhZAorICAgICAgICAgICAgICAgICAgICAgICAgY2xvc2VzdERlbHRhID0gZmFi c2YoZW5kVGltZSAtIHRpbWUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXn5+fn4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhYnMKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtVGltZVJhbmdlcy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQbGF0Zm9ybVRpbWVSYW5nZXM6Om5lYXJlc3QpOiBFeHRyYWN0IHN0YXJ0 IGFuZCBlbmQKKyAgICAgICAgdGltZSBkZWx0YXMgaW50byBsb2NhbCB2YXJpYWJsZXMgc28gdGhl eSBkb24ndCBoYXZlIHRvIGJlCisgICAgICAgIGNvbXB1dGVkIHR3aWNlLCB1c2luZyBmYWJzKCkg aW5zdGVhZCBvZiBmYWJzZigpLgorCisyMDE0LTAzLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CisKICAgICAgICAgRG91YmxlIHZhbHVlcyBwYXNzZWQgdG8gZmFic2YoKSBp biBtYXhTY2FsZUZyb21UcmFuc2Zvcm0oKQogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8x MzAyOTc+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1Bs YXRmb3JtVGltZVJhbmdlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Q bGF0Zm9ybVRpbWVSYW5nZXMuY3BwCmluZGV4IDk4ZDJmOGRlODE0NGE0NDcyZTcwNmM4MThhNDRm MDIxYTU0YjZkYTUuLmNmMmEyZWFiY2U2ZWQyNWFmOWMyNGJjYTdhNWQ2YTlkMjg0ZDA5ODQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtVGltZVJh bmdlcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1U aW1lUmFuZ2VzLmNwcApAQCAtMjA1LDEzICsyMDUsMTcgQEAgZG91YmxlIFBsYXRmb3JtVGltZVJh bmdlczo6bmVhcmVzdChkb3VibGUgdGltZSkgY29uc3QKICAgICAgICAgZG91YmxlIGVuZFRpbWUg PSBlbmQobmR4LCBpZ25vcmVJbnZhbGlkKTsKICAgICAgICAgaWYgKHRpbWUgPj0gc3RhcnRUaW1l ICYmIHRpbWUgPD0gZW5kVGltZSkKICAgICAgICAgICAgIHJldHVybiB0aW1lOwotICAgICAgICBp ZiAoZmFicyhzdGFydFRpbWUgLSB0aW1lKSA8IGNsb3Nlc3REZWx0YSkgeworCisgICAgICAgIGRv dWJsZSBzdGFydFRpbWVEZWx0YSA9IGZhYnMoc3RhcnRUaW1lIC0gdGltZSk7CisgICAgICAgIGlm IChzdGFydFRpbWVEZWx0YSA8IGNsb3Nlc3REZWx0YSkgewogICAgICAgICAgICAgY2xvc2VzdFRp bWUgPSBzdGFydFRpbWU7Ci0gICAgICAgICAgICBjbG9zZXN0RGVsdGEgPSBmYWJzZihzdGFydFRp bWUgLSB0aW1lKTsKKyAgICAgICAgICAgIGNsb3Nlc3REZWx0YSA9IHN0YXJ0VGltZURlbHRhOwog ICAgICAgICB9Ci0gICAgICAgIGlmIChmYWJzKGVuZFRpbWUgLSB0aW1lKSA8IGNsb3Nlc3REZWx0 YSkgeworCisgICAgICAgIGRvdWJsZSBlbmRUaW1lRGVsdGEgPSBmYWJzKGVuZFRpbWUgLSB0aW1l KTsKKyAgICAgICAgaWYgKGVuZFRpbWVEZWx0YSA8IGNsb3Nlc3REZWx0YSkgewogICAgICAgICAg ICAgY2xvc2VzdFRpbWUgPSBlbmRUaW1lOwotICAgICAgICAgICAgY2xvc2VzdERlbHRhID0gZmFi c2YoZW5kVGltZSAtIHRpbWUpOworICAgICAgICAgICAgY2xvc2VzdERlbHRhID0gZW5kVGltZURl bHRhOwogICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiBjbG9zZXN0VGltZTsK