130297 2014-03-15 21:46:32 -0700 Double values passed to fabsf() in maxScaleFromTransform() 2014-03-16 14:42:19 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin dino mjs simon.fraser oldest_to_newest 990922 0 ddkilzer 2014-03-15 21:46:32 -0700 WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:21: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value] return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY)); ^ WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:21: note: use function 'fabs' instead return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY)); ^~~~~ fabs WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:50: error: absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value] return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY)); ^ WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287:50: note: use function 'fabs' instead return std::max(fabsf(decomposeData.scaleX), fabsf(decomposeData.scaleY)); ^~~~~ fabs 2 errors generated. 990927 1 226832 ddkilzer 2014-03-15 22:08:57 -0700 Created attachment 226832 Patch v1 990940 2 226832 darin 2014-03-16 00:58:19 -0700 Comment on attachment 226832 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=226832&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287 > + return std::max(fabsf(static_cast<float>(decomposeData.scaleX)), fabsf(static_cast<float>(decomposeData.scaleY))); I’d really prefer we use syntax cast for casting double to float that would not also work to convert, say, int to float. 990941 3 226832 darin 2014-03-16 00:58:42 -0700 Comment on attachment 226832 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=226832&action=review >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:287 >> + return std::max(fabsf(static_cast<float>(decomposeData.scaleX)), fabsf(static_cast<float>(decomposeData.scaleY))); > > I’d really prefer we use syntax cast for casting double to float that would not also work to convert, say, int to float. Seems like we have it! It’s called narrowPrecisionToFloat. 990943 4 226832 commit-queue 2014-03-16 01:28:04 -0700 Comment on attachment 226832 Patch v1 Clearing flags on attachment: 226832 Committed r165693: <http://trac.webkit.org/changeset/165693> 990944 5 commit-queue 2014-03-16 01:28:08 -0700 All reviewed patches have been landed. Closing bug. 991002 6 ddkilzer 2014-03-16 11:52:26 -0700 Reopening for follow-up patch to switch to using narrowPrecisionToFloat() instead. 991003 7 226850 ddkilzer 2014-03-16 12:00:44 -0700 Created attachment 226850 Patch for follow-up issue 991040 8 226850 commit-queue 2014-03-16 14:42:16 -0700 Comment on attachment 226850 Patch for follow-up issue Clearing flags on attachment: 226850 Committed r165711: <http://trac.webkit.org/changeset/165711> 991041 9 commit-queue 2014-03-16 14:42:19 -0700 All reviewed patches have been landed. Closing bug. 226832 2014-03-15 22:08:57 -0700 2014-03-16 12:00:37 -0700 Patch v1 bug-130297-20140315220835.patch text/plain 2931 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ4M2FhMWIyNTc3OGIz ZDUwZjY1ODUxZmQyYmUwNjU5YmM2MzY0ZS4uZDM2Y2E1NmJlNzhhMTVjMjUyZTIyODIxNWIzZjY3 YTgzM2QwN2M4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTAzLTE1ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRG91YmxlIHZhbHVlcyBw YXNzZWQgdG8gZmFic2YoKSBpbiBtYXhTY2FsZUZyb21UcmFuc2Zvcm0oKQorICAgICAgICA8aHR0 cDovL3dlYmtpdC5vcmcvYi8xMzAyOTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZXMgdGhlIGZvbGxvd2luZyBidWlsZCBmYWlsdXJlcyB1c2lu ZyB0cnVuayBjbGFuZzoKKworICAgICAgICAgICAgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YS9HcmFwaGljc0xheWVyQ0EuY3BwOjI4NzoyMTogZXJyb3I6IGFic29sdXRlIHZhbHVlIGZ1bmN0 aW9uICdmYWJzZicgZ2l2ZW4gYW4gYXJndW1lbnQgb2YgdHlwZSAnZG91YmxlJyBidXQgaGFzIHBh cmFtZXRlciBvZiB0eXBlICdmbG9hdCcgd2hpY2ggbWF5IGNhdXNlIHRydW5jYXRpb24gb2YgdmFs dWUgWy1XZXJyb3IsLVdhYnNvbHV0ZS12YWx1ZV0KKyAgICAgICAgICAgICAgICByZXR1cm4gc3Rk OjptYXgoZmFic2YoZGVjb21wb3NlRGF0YS5zY2FsZVgpLCBmYWJzZihkZWNvbXBvc2VEYXRhLnNj YWxlWSkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCisgICAgICAgICAgICBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6Mjg3OjIxOiBu b3RlOiB1c2UgZnVuY3Rpb24gJ2ZhYnMnIGluc3RlYWQKKyAgICAgICAgICAgICAgICByZXR1cm4g c3RkOjptYXgoZmFic2YoZGVjb21wb3NlRGF0YS5zY2FsZVgpLCBmYWJzZihkZWNvbXBvc2VEYXRh LnNjYWxlWSkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBmYWJzCisgICAgICAgICAgICBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6Mjg3OjUwOiBlcnJvcjogYWJzb2x1 dGUgdmFsdWUgZnVuY3Rpb24gJ2ZhYnNmJyBnaXZlbiBhbiBhcmd1bWVudCBvZiB0eXBlICdkb3Vi bGUnIGJ1dCBoYXMgcGFyYW1ldGVyIG9mIHR5cGUgJ2Zsb2F0JyB3aGljaCBtYXkgY2F1c2UgdHJ1 bmNhdGlvbiBvZiB2YWx1ZSBbLVdlcnJvciwtV2Fic29sdXRlLXZhbHVlXQorICAgICAgICAgICAg ICAgIHJldHVybiBzdGQ6Om1heChmYWJzZihkZWNvbXBvc2VEYXRhLnNjYWxlWCksIGZhYnNmKGRl Y29tcG9zZURhdGEuc2NhbGVZKSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXgorICAgICAgICAgICAgV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwOjI4Nzo1MDogbm90ZTogdXNlIGZ1bmN0 aW9uICdmYWJzJyBpbnN0ZWFkCisgICAgICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bWF4KGZhYnNm KGRlY29tcG9zZURhdGEuc2NhbGVYKSwgZmFic2YoZGVjb21wb3NlRGF0YS5zY2FsZVkpKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBefn5+fgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGZhYnMKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBo aWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjptYXhTY2FsZUZyb21UcmFuc2Zvcm0p OiBVc2Ugc3RhdGljX2Nhc3Q8ZmxvYXQ+KCkgdG8KKyAgICAgICAgY29udmVydCBmbG9hdCB2YWx1 ZXMgdG8gZG91YmxlIHZhbHVlcy4KKwogMjAxNC0wMy0xNCAgTWFyayBSb3dlICA8bXJvd2VAYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgcHJvZHVjdGlvbiBidWlsZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3Bw CmluZGV4IDFkZjIxOGU3MTI4YzBiYjM4YmEyZjY4ZmIzNzFmMDYxNWVlM2EwMGQuLmNhM2JlNDk4 NjA3NjJiZjAxOGRjMzMwMzE4NTgwNzJlNTRmNzJjNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcApAQCAtMjg0 LDcgKzI4NCw3IEBAIHN0YXRpYyBmbG9hdCBtYXhTY2FsZUZyb21UcmFuc2Zvcm0oY29uc3QgVHJh bnNmb3JtYXRpb25NYXRyaXgmIHQpCiAKICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6RGVjb21w b3NlZDRUeXBlIGRlY29tcG9zZURhdGE7CiAgICAgdC5kZWNvbXBvc2U0KGRlY29tcG9zZURhdGEp OwotICAgIHJldHVybiBzdGQ6Om1heChmYWJzZihkZWNvbXBvc2VEYXRhLnNjYWxlWCksIGZhYnNm KGRlY29tcG9zZURhdGEuc2NhbGVZKSk7CisgICAgcmV0dXJuIHN0ZDo6bWF4KGZhYnNmKHN0YXRp Y19jYXN0PGZsb2F0PihkZWNvbXBvc2VEYXRhLnNjYWxlWCkpLCBmYWJzZihzdGF0aWNfY2FzdDxm bG9hdD4oZGVjb21wb3NlRGF0YS5zY2FsZVkpKSk7CiB9CiAKICNpZiBFTkFCTEUoQ1NTX0ZJTFRF UlMpIHx8ICFBU1NFUlRfRElTQUJMRUQK 226850 2014-03-16 12:00:44 -0700 2014-03-16 14:42:16 -0700 Patch for follow-up issue bug-130297-20140316120021.patch text/plain 1584 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZiYzY3NzBhMzc1YmY5 NjI0ZjU3NDhhMzYzOGNhMDg1NDY5ZmNlZC4uNjdhZmVhYjhlOTRlNjgxZWI3NmJkMzFkMGZkNzhk MjkxNWVmOTlkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTE2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRm9sbG93LXVwOiBEb3Vi bGUgdmFsdWVzIHBhc3NlZCB0byBmYWJzZigpIGluIG1heFNjYWxlRnJvbVRyYW5zZm9ybSgpCisg ICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEzMDI5Nz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBo aWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjptYXhTY2FsZUZyb21UcmFuc2Zvcm0p OiBVc2UgbmFycm93UHJlY2lzaW9uVG9GbG9hdCgpCisgICAgICAgIGluc3RlYWQgb2Ygc3RhdGlj X2Nhc3Q8ZmxvYXQ+KCkuCisKIDIwMTQtMDMtMTYgIEZyw6lkw6lyaWMgV2FuZyAgPGZyZWQud2Fu Z0BmcmVlLmZyPgogCiAgICAgICAgIFtyZWdyZXNzaW9uXSBmb3JlaWduIGNvbnRlbnQgbm90IGRp c3BsYXllZCBpbiBNYXRoTUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCmluZGV4IGNhM2JlNDk4NjA3NjJiZjAxOGRj MzMwMzE4NTgwNzJlNTRmNzJjNmIuLjUxMDBmNTVjN2FkOTJkN2Y1MTk1Y2U1MzBlMTE5ZTJjNWYx MmNjMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dy YXBoaWNzTGF5ZXJDQS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvR3JhcGhpY3NMYXllckNBLmNwcApAQCAtMjg0LDcgKzI4NCw3IEBAIHN0YXRpYyBmbG9hdCBt YXhTY2FsZUZyb21UcmFuc2Zvcm0oY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIHQpCiAKICAg ICBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6RGVjb21wb3NlZDRUeXBlIGRlY29tcG9zZURhdGE7CiAg ICAgdC5kZWNvbXBvc2U0KGRlY29tcG9zZURhdGEpOwotICAgIHJldHVybiBzdGQ6Om1heChmYWJz ZihzdGF0aWNfY2FzdDxmbG9hdD4oZGVjb21wb3NlRGF0YS5zY2FsZVgpKSwgZmFic2Yoc3RhdGlj X2Nhc3Q8ZmxvYXQ+KGRlY29tcG9zZURhdGEuc2NhbGVZKSkpOworICAgIHJldHVybiBzdGQ6Om1h eChmYWJzZihuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGRlY29tcG9zZURhdGEuc2NhbGVYKSksIGZh YnNmKG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoZGVjb21wb3NlRGF0YS5zY2FsZVkpKSk7CiB9CiAK ICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpIHx8ICFBU1NFUlRfRElTQUJMRUQK