130293 2014-03-15 07:31:06 -0700 [iOS] Define SYSTEM_VERSION_PREFIX consistently 2014-03-15 16:17:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue mitz mrowe oldest_to_newest 990859 0 ddkilzer 2014-03-15 07:31:06 -0700 SYSTEM_VERSION_PREFIX is defined inconsistently (if at all) across Version.xcconfig files during iOS builds. 990860 1 ddkilzer 2014-03-15 07:31:52 -0700 <rdar://problem/15926359> 990861 2 226818 ddkilzer 2014-03-15 07:41:19 -0700 Created attachment 226818 Patch v1 990897 3 226818 commit-queue 2014-03-15 16:17:33 -0700 Comment on attachment 226818 Patch v1 Clearing flags on attachment: 226818 Committed r165685: <http://trac.webkit.org/changeset/165685> 990898 4 commit-queue 2014-03-15 16:17:36 -0700 All reviewed patches have been landed. Closing bug. 226818 2014-03-15 07:41:19 -0700 2014-03-15 16:17:33 -0700 Patch v1 bug-130293-20140315074056.patch text/plain 7201 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MjQ1MmUzNDYzYmUyMDM1Y2Q2NzEyODAxYjI3YzQwYzc4NmU3YTM1Li41MmI1MWQyZGEzODA0NWY5 NGNhOGQ2YzkwYmRiZmZjYWZmMTY2NjFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMy0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtpT1NdIERlZmluZSBTWVNURU1fVkVSU0lPTl9QUkVGSVggY29uc2lzdGVu dGx5CisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEzMDI5Mz4KKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE1OTI2MzU5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZzoKKyAgICAgICAg KFNZU1RFTV9WRVJTSU9OX1BSRUZJWF9pcGhvbmVvcyk6IFN5bmMgd2l0aAorICAgICAgICBTb3Vy Y2UvV2ViS2l0L21hYy9WZXJzaW9uLnhjY29uZmlnLgorCiAyMDE0LTAzLTEwICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAganNjIGNvbW1hbmRsaW5lIHNob3VsZG4n dCBoYXZlIGEgImNvbnNvbGUiIGJlY2F1c2UgdGhhdCBjb25mdXNlcyBzb21lIHRlc3RzIGludG8g dGhpbmtpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNGExYTA0ZDllZDBjZmZiZDg2ZDdlZDhiMDY1MjUxY2Q0 YTg5MDI4Li4xYzliMTY2YWM4NTQ3NTBmM2VjZThkMTM1YTk0YWZiYTlmMDg1YTY4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDMtMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBEZWZpbmUgU1lTVEVNX1ZFUlNJT05fUFJFRklY IGNvbnNpc3RlbnRseQorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzAyOTM+CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xNTkyNjM1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1ZlcnNpb24ueGNjb25maWc6 CisgICAgICAgIChTWVNURU1fVkVSU0lPTl9QUkVGSVhfaXBob25lb3MpOiBTeW5jIHdpdGgKKyAg ICAgICAgU291cmNlL1dlYktpdC9tYWMvVmVyc2lvbi54Y2NvbmZpZy4KKwogMjAxNC0wMy0xMCAg QmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3RhcnQg c3BsaXR0aW5nIENTUyBTZWxlY3RvcnMncyBwc2V1ZG8gdHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdl TG9nCmluZGV4IDYzMmQxYzIyNjRkOWI5Mzg4ODUxODUzNWQ5NDg0ODRhZmYxODczMjEuLmJiZTJi YWU1MjNhODRjZmE0OWFkMGYxMjk1YmM0MmQyNzA2OTUyODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRGVmaW5lIFNZU1RFTV9WRVJTSU9OX1BSRUZJ WCBjb25zaXN0ZW50bHkKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTMwMjkzPgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTU5MjYzNTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmln OgorICAgICAgICAoU1lTVEVNX1ZFUlNJT05fUFJFRklYKTogU3luYyB3aXRoCisgICAgICAgIFNv dXJjZS9XZWJLaXQvbWFjL1ZlcnNpb24ueGNjb25maWcuCisKIDIwMTQtMDMtMTAgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc2hvdyBhIGRl YnVnZ2luZy1vcmllbnRlZCBkYXNoYm9hcmQgd2hlbiBzY3JpcHRzIHBhdXNlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggYzE0NDk2MjljNGQyYjcwODEzODI3ZDk2YTY2ZGZkZjg1ODM2ZjQ5OS4uMTc2OThkMmQzOWEw OWMwZGI5YWZhMjQyOTIwNGZjZGNjZGE3NWJhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAzLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAg ICAgW2lPU10gRGVmaW5lIFNZU1RFTV9WRVJTSU9OX1BSRUZJWCBjb25zaXN0ZW50bHkKKyAgICAg ICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTMwMjkzPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTU5MjYzNTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDb25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnOgorICAgICAgICAoU1lTVEVNX1ZF UlNJT05fUFJFRklYKTogU3luYyB3aXRoCisgICAgICAgIFNvdXJjZS9XZWJLaXQvbWFjL1ZlcnNp b24ueGNjb25maWcuCisKIDIwMTQtMDMtMTAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYyNzg3MTY+IFtDb2NvYV0gQWxsb3cgc2V0 dGluZyBhIGN1c3RvbSBncm91cCBpZGVudGlmaWVyIG9uIGEgV0tXZWJWaWV3CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnCmlu ZGV4IDIxY2UwNmJiZmQ1ZjQyMjQ4YzVlYjM3YTBkZDhmYmQ1NmExMGNkY2MuLjFjMWVhOWIxNTQz Y2I0OWU0ZjFiMDc2ZjJiYTExY2Q3NjgyOThjNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnCkBAIC0zMiw3ICszMiw3 IEBAIFNIT1JUX1ZFUlNJT05fU1RSSU5HID0gJChTSE9SVF9WRVJTSU9OX1NUUklOR18kKENPTkZJ R1VSQVRJT04pKQogCiAvLyBUaGUgc3lzdGVtIHZlcnNpb24gcHJlZml4IGlzIGJhc2VkIG9uIHRo ZSBjdXJyZW50IHN5c3RlbSB2ZXJzaW9uLgogU1lTVEVNX1ZFUlNJT05fUFJFRklYID0gJChTWVNU RU1fVkVSU0lPTl9QUkVGSVhfJChQTEFURk9STV9OQU1FKSk7Ci1TWVNURU1fVkVSU0lPTl9QUkVG SVhfaXBob25lb3MgPSA2OworU1lTVEVNX1ZFUlNJT05fUFJFRklYX2lwaG9uZW9zID0gODsKIFNZ U1RFTV9WRVJTSU9OX1BSRUZJWF9pcGhvbmVzaW11bGF0b3IgPSAkKFNZU1RFTV9WRVJTSU9OX1BS RUZJWF9pcGhvbmVvcyk7CiBTWVNURU1fVkVSU0lPTl9QUkVGSVhfbWFjb3N4ID0gJChTWVNURU1f VkVSU0lPTl9QUkVGSVhfbWFjb3N4XyQoVEFSR0VUX01BQ19PU19YX1ZFUlNJT05fTUFKT1IpKTsK IFNZU1RFTV9WRVJTSU9OX1BSRUZJWF9tYWNvc3hfMTA4MCA9IDg7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnIGIvU291cmNlL1dlYkNv cmUvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZwppbmRleCA1YTFjZTJkY2JiZTdlOTE5 MzA2NzQwNDVmODg4ZjI3Mzc2ZWMzMjc4Li5iNGFjMGMzY2ZiNTA1MDlkNWNiYzNjZDM2ZTQwY2Qw MzdmYWZmNmQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9WZXJz aW9uLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1ZlcnNpb24u eGNjb25maWcKQEAgLTMyLDcgKzMyLDcgQEAgU0hPUlRfVkVSU0lPTl9TVFJJTkcgPSAkKFNIT1JU X1ZFUlNJT05fU1RSSU5HXyQoQ09ORklHVVJBVElPTikpCiAKIC8vIFRoZSBzeXN0ZW0gdmVyc2lv biBwcmVmaXggaXMgYmFzZWQgb24gdGhlIGN1cnJlbnQgc3lzdGVtIHZlcnNpb24uCiBTWVNURU1f VkVSU0lPTl9QUkVGSVggPSAkKFNZU1RFTV9WRVJTSU9OX1BSRUZJWF8kKFBMQVRGT1JNX05BTUUp KTsKLVNZU1RFTV9WRVJTSU9OX1BSRUZJWF9pcGhvbmVvcyA9IDY7IC8vIGlPUyBpcyBtb3N0IGxp a2UgU25vd0xlb3BhcmQgY3VycmVudGx5LgorU1lTVEVNX1ZFUlNJT05fUFJFRklYX2lwaG9uZW9z ID0gODsKIFNZU1RFTV9WRVJTSU9OX1BSRUZJWF9pcGhvbmVzaW11bGF0b3IgPSAkKFNZU1RFTV9W RVJTSU9OX1BSRUZJWF9pcGhvbmVvcyk7CiBTWVNURU1fVkVSU0lPTl9QUkVGSVhfbWFjb3N4ID0g JChTWVNURU1fVkVSU0lPTl9QUkVGSVhfbWFjb3N4XyQoVEFSR0VUX01BQ19PU19YX1ZFUlNJT05f TUFKT1IpKTsKIFNZU1RFTV9WRVJTSU9OX1BSRUZJWF9tYWNvc3hfMTA4MCA9IDg7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZp ZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmln CmluZGV4IDEwMDQ2YjkxMTQ4NGU0MmFkZDUyOWYzMzJjYzViOTU5ODQ3MmRkYzYuLjk3NDE4NjQ5 Y2NiMzlhYTc4NDYzNzNlYjg2NzY5ZTljMjBjYzkwYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnCkBAIC00LDEwICs0 LDEzIEBAIFRJTllfVkVSU0lPTiA9IDA7CiBGVUxMX1ZFUlNJT04gPSAkKE1BSk9SX1ZFUlNJT04p LiQoTUlOT1JfVkVSU0lPTik7CiAKIC8vIFRoZSBzeXN0ZW0gdmVyc2lvbiBwcmVmaXggaXMgYmFz ZWQgb24gdGhlIGN1cnJlbnQgc3lzdGVtIHZlcnNpb24uCi1TWVNURU1fVkVSU0lPTl9QUkVGSVgg PSAkKFNZU1RFTV9WRVJTSU9OX1BSRUZJWF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9S KSk7Ci1TWVNURU1fVkVSU0lPTl9QUkVGSVhfMTA4MCA9IDg7Ci1TWVNURU1fVkVSU0lPTl9QUkVG SVhfMTA5MCA9IDk7Ci1TWVNURU1fVkVSU0lPTl9QUkVGSVhfMTAxMDAwID0gMTA7CitTWVNURU1f VkVSU0lPTl9QUkVGSVggPSAkKFNZU1RFTV9WRVJTSU9OX1BSRUZJWF8kKFBMQVRGT1JNX05BTUUp KTsKK1NZU1RFTV9WRVJTSU9OX1BSRUZJWF9pcGhvbmVvcyA9IDg7CitTWVNURU1fVkVSU0lPTl9Q UkVGSVhfaXBob25lc2ltdWxhdG9yID0gJChTWVNURU1fVkVSU0lPTl9QUkVGSVhfaXBob25lb3Mp OworU1lTVEVNX1ZFUlNJT05fUFJFRklYX21hY29zeCA9ICQoU1lTVEVNX1ZFUlNJT05fUFJFRklY X21hY29zeF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7CitTWVNURU1fVkVSU0lP Tl9QUkVGSVhfbWFjb3N4XzEwODAgPSA4OworU1lTVEVNX1ZFUlNJT05fUFJFRklYX21hY29zeF8x MDkwID0gOTsKK1NZU1RFTV9WRVJTSU9OX1BSRUZJWF9tYWNvc3hfMTAxMDAwID0gMTA7CiAKIEJV TkRMRV9WRVJTSU9OID0gJChTWVNURU1fVkVSU0lPTl9QUkVGSVgpJChGVUxMX1ZFUlNJT04pOwog U0hPUlRfVkVSU0lPTl9TVFJJTkcgPSAkKFNZU1RFTV9WRVJTSU9OX1BSRUZJWCkkKE1BSk9SX1ZF UlNJT04pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvVmVyc2lv bi54Y2NvbmZpZyBiL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1ZlcnNpb24ueGNjb25m aWcKaW5kZXggOTc3YjRjOTRiZmQ2YjNmOGNhMjUyYWFhOWIzM2I3OTNhZjBkZWMzYS4uNjA0YmNk YWNiODJhNmQwNjIyN2UzZTQ3M2Q3NDFiNmRiZmUyYTk1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvQ29uZmlndXJhdGlvbnMvVmVyc2lvbi54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViS2l0 Mi9Db25maWd1cmF0aW9ucy9WZXJzaW9uLnhjY29uZmlnCkBAIC0zMSwxMCArMzEsMTMgQEAgQlVO RExFX1ZFUlNJT04gPSAkKEJVTkRMRV9WRVJTSU9OXyQoQ09ORklHVVJBVElPTikpOwogU0hPUlRf VkVSU0lPTl9TVFJJTkcgPSAkKFNIT1JUX1ZFUlNJT05fU1RSSU5HXyQoQ09ORklHVVJBVElPTikp CiAKIC8vIFRoZSBzeXN0ZW0gdmVyc2lvbiBwcmVmaXggaXMgYmFzZWQgb24gdGhlIGN1cnJlbnQg c3lzdGVtIHZlcnNpb24uCi1TWVNURU1fVkVSU0lPTl9QUkVGSVggPSAkKFNZU1RFTV9WRVJTSU9O X1BSRUZJWF8kKFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7Ci1TWVNURU1fVkVSU0lP Tl9QUkVGSVhfMTA4MCA9IDg7Ci1TWVNURU1fVkVSU0lPTl9QUkVGSVhfMTA5MCA9IDk7Ci1TWVNU RU1fVkVSU0lPTl9QUkVGSVhfMTAxMDAwID0gMTA7CitTWVNURU1fVkVSU0lPTl9QUkVGSVggPSAk KFNZU1RFTV9WRVJTSU9OX1BSRUZJWF8kKFBMQVRGT1JNX05BTUUpKTsKK1NZU1RFTV9WRVJTSU9O X1BSRUZJWF9pcGhvbmVvcyA9IDg7CitTWVNURU1fVkVSU0lPTl9QUkVGSVhfaXBob25lc2ltdWxh dG9yID0gJChTWVNURU1fVkVSU0lPTl9QUkVGSVhfaXBob25lb3MpOworU1lTVEVNX1ZFUlNJT05f UFJFRklYX21hY29zeCA9ICQoU1lTVEVNX1ZFUlNJT05fUFJFRklYX21hY29zeF8kKFRBUkdFVF9N QUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7CitTWVNURU1fVkVSU0lPTl9QUkVGSVhfbWFjb3N4XzEw ODAgPSA4OworU1lTVEVNX1ZFUlNJT05fUFJFRklYX21hY29zeF8xMDkwID0gOTsKK1NZU1RFTV9W RVJTSU9OX1BSRUZJWF9tYWNvc3hfMTAxMDAwID0gMTA7CiAKIC8vIFRoZSBwcm9kdWN0aW9uIGJ1 aWxkIGFsd2F5cyB1c2VzIHRoZSBmdWxsIHZlcnNpb24gd2l0aCBhIHN5c3RlbSB2ZXJzaW9uIHBy ZWZpeC4KIEJVTkRMRV9WRVJTSU9OX1Byb2R1Y3Rpb24gPSAkKFNZU1RFTV9WRVJTSU9OX1BSRUZJ WCkkKEZVTExfVkVSU0lPTik7Cg==