130292 2014-03-15 07:28:51 -0700 [WebGL] Broken WEBGL_compressed_texture_pvrtc extension support 2014-03-19 20:13:26 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sun.shin webkit-unassigned commit-queue dino dongseong.hwang esprehn+autocc gyuyoung.kim joone kondapallykalyan mrobinson noam roger_fong simon.fraser webkit-ews oldest_to_newest 990856 0 sun.shin 2014-03-15 07:28:51 -0700 WebGLRenderingContext::getExtension of WEBGL_compressed_texture_pvrtc extension returns always null. 990862 1 226819 xingri 2014-03-15 07:41:38 -0700 Created attachment 226819 Patch 992026 2 dongseong.hwang 2014-03-18 23:19:56 -0700 non-reviewer lgtm smfr@, could you have a chance to review? 992328 3 226819 dino 2014-03-19 17:13:59 -0700 Comment on attachment 226819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226819&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=130292 > + > + Reviewed by NOBODY (OOPS!). Please add something like "We were not returning the extension from the function." as an explanation. 992335 4 227238 xingri 2014-03-19 17:24:38 -0700 Created attachment 227238 Patch 992372 5 227238 commit-queue 2014-03-19 20:13:19 -0700 Comment on attachment 227238 Patch Clearing flags on attachment: 227238 Committed r165943: <http://trac.webkit.org/changeset/165943> 992373 6 commit-queue 2014-03-19 20:13:26 -0700 All reviewed patches have been landed. Closing bug. 226819 2014-03-15 07:41:38 -0700 2014-03-19 17:24:28 -0700 Patch bug-130292-20140315235139.patch text/plain 1491 xingri U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ4M2FhMWIyNTc3OGIz ZDUwZjY1ODUxZmQyYmUwNjU5YmM2MzY0ZS4uNDdiZDBiODUxMmNkNWUxM2YzMjQ0NDRmZDcxZTcz NTZjYjc4MGFiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAzLTE1ICBCeXVu Z3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+CisKKyAgICAgICAgRml4ICJXRUJLSVRfV0VC R0xfY29tcHJlc3NlZF90ZXh0dXJlX3B2cnRjIiBleHRlbnNpb24gc3VwcG9ydAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjkyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdD b250ZXh0OjpnZXRFeHRlbnNpb24pOgorCiAyMDE0LTAzLTE0ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgRml4IHRoZSBwcm9kdWN0aW9uIGJ1aWxkLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5k ZXggNjNjNjc4NzE3YmQ2YmZlZjJlOWUyZjc4NGU0NWQ0YzYxZmQ4NTAyYy4uMTg2ODhlZTU2YmFj MTNkYWUwMDg3Njc4MTRlMzRlNzllYWJmYmI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0yNDc1LDYgKzI0NzUs NyBAQCBXZWJHTEV4dGVuc2lvbiogV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRFeHRlbnNpb24o Y29uc3QgU3RyaW5nJiBuYW1lKQogICAgICAgICAmJiBXZWJHTENvbXByZXNzZWRUZXh0dXJlUFZS VEM6OnN1cHBvcnRlZCh0aGlzKSkgewogICAgICAgICBpZiAoIW1fd2ViZ2xDb21wcmVzc2VkVGV4 dHVyZVBWUlRDKQogICAgICAgICAgICAgbV93ZWJnbENvbXByZXNzZWRUZXh0dXJlUFZSVEMgPSBz dGQ6Om1ha2VfdW5pcXVlPFdlYkdMQ29tcHJlc3NlZFRleHR1cmVQVlJUQz4odGhpcyk7CisgICAg ICAgIHJldHVybiBtX3dlYmdsQ29tcHJlc3NlZFRleHR1cmVQVlJUQy5nZXQoKTsKICAgICB9CiAg ICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKG5hbWUsICJXRUJHTF9jb21wcmVzc2VkX3RleHR1cmVf czN0YyIpCiAgICAgICAgICYmIFdlYkdMQ29tcHJlc3NlZFRleHR1cmVTM1RDOjpzdXBwb3J0ZWQo dGhpcykpIHsK 227238 2014-03-19 17:24:38 -0700 2014-03-19 20:13:19 -0700 Patch bug-130292-20140320092413.patch text/plain 1616 xingri U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1OTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTczYzM2MjA0NzI2YzNh NGRjOTcwODM1N2FiMmU0MzdlNDNjZTczMi4uODY4Yzk2NWUxYmUwZGRjYzgzYmMzOTZmODkxZmRj YmNjYzUyZGU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTE5ICBCeXVu Z3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+CisKKyAgICAgICAgRml4ICJXRUJLSVRfV0VC R0xfY29tcHJlc3NlZF90ZXh0dXJlX3B2cnRjIiBleHRlbnNpb24gc3VwcG9ydAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjkyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViR0xSZW5kZXJpbmdDb250 ZXh0OjpnZXRFeHRlbnNpb24gd2FzIG5vdCByZXR1cm5pbmcgV0VCR0xfY29tcHJlc3NlZF90ZXh0 dXJlX3B2cnRjIGV4dGVuc2lvbi4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVy aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6 OmdldEV4dGVuc2lvbik6CisKIDIwMTQtMDMtMTkgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1 ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNjU5MjYu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0LmNwcAppbmRleCA2M2M2Nzg3MTdiZDZiZmVmMmU5ZTJmNzg0ZTQ1ZDRjNjFmZDg1MDJjLi4x ODY4OGVlNTZiYWMxM2RhZTAwODc2NzgxNGUzNGU3OWVhYmZiYjc0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTI0 NzUsNiArMjQ3NSw3IEBAIFdlYkdMRXh0ZW5zaW9uKiBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6Omdl dEV4dGVuc2lvbihjb25zdCBTdHJpbmcmIG5hbWUpCiAgICAgICAgICYmIFdlYkdMQ29tcHJlc3Nl ZFRleHR1cmVQVlJUQzo6c3VwcG9ydGVkKHRoaXMpKSB7CiAgICAgICAgIGlmICghbV93ZWJnbENv bXByZXNzZWRUZXh0dXJlUFZSVEMpCiAgICAgICAgICAgICBtX3dlYmdsQ29tcHJlc3NlZFRleHR1 cmVQVlJUQyA9IHN0ZDo6bWFrZV91bmlxdWU8V2ViR0xDb21wcmVzc2VkVGV4dHVyZVBWUlRDPih0 aGlzKTsKKyAgICAgICAgcmV0dXJuIG1fd2ViZ2xDb21wcmVzc2VkVGV4dHVyZVBWUlRDLmdldCgp OwogICAgIH0KICAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UobmFtZSwgIldFQkdMX2NvbXByZXNz ZWRfdGV4dHVyZV9zM3RjIikKICAgICAgICAgJiYgV2ViR0xDb21wcmVzc2VkVGV4dHVyZVMzVEM6 OnN1cHBvcnRlZCh0aGlzKSkgewo=