130291 2014-03-14 23:29:20 -0700 Rewrite WebHTMLConverter::_elementHasOwnBackgroundColor in C++ 2014-03-17 18:44:43 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 130227 1 rniwa rniwa andersca darin enrica kling koivisto sam oldest_to_newest 990833 0 rniwa 2014-03-14 23:29:20 -0700 For performance. 990834 1 226812 rniwa 2014-03-14 23:30:43 -0700 Created attachment 226812 Patch 991502 2 226812 rniwa 2014-03-17 18:44:40 -0700 Comment on attachment 226812 Patch Clearing flags on attachment: 226812 Committed r165788: <http://trac.webkit.org/changeset/165788> 991503 3 rniwa 2014-03-17 18:44:43 -0700 All reviewed patches have been landed. Closing bug. 226812 2014-03-14 23:30:43 -0700 2014-03-17 18:44:40 -0700 Patch bug-130291-20140314233026.patch text/plain 3128 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVmMzBlNDVhNjg1ZmYz Yjg1OGVjM2U2OTQ5NjkxOTM5MzY4YzIwOS4uZWE3YjgwY2U0MWQ4MTE4NWY2Njg1ZmZmZjM4MjVi MzQwZmY0YzA0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAzLTE0ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCisgICAgICAgIFJld3JpdGUgV2ViSFRNTENv bnZlcnRlcjo6X2VsZW1lbnRIYXNPd25CYWNrZ3JvdW5kQ29sb3IgaW4gQysrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAyOTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHRyYWN0ZWQgSFRNTENvbnZl cnRlckNhY2hlczo6ZWxlbWVudEhhc093bkJhY2tncm91bmRDb2xvci4KKworICAgICAgICAqIHBs YXRmb3JtL21hYy9IVE1MQ29udmVydGVyLm1tOgorICAgICAgICAoSFRNTENvbnZlcnRlckNhY2hl czo6ZWxlbWVudEhhc093bkJhY2tncm91bmRDb2xvcik6CisgICAgICAgICgtW1dlYkhUTUxDb252 ZXJ0ZXIgX2VsZW1lbnRIYXNPd25CYWNrZ3JvdW5kQ29sb3I6XSk6CisKKzIwMTQtMDMtMTQgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV3cml0ZSBXZWJIVE1M Q29udmVydGVyOjpfZWxlbWVudElzQmxvY2tMZXZlbCBpbiBDKysKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDI4NwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSFRNTENvbnZlcnRlci5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21hYy9IVE1MQ29udmVydGVyLm1tCmluZGV4IDlkOWU4NzM4MGFlMmRlMDJhYzlk YjNmMDU0M2UzNDdkMWNjM2M5YTMuLjQzNmU3NTk3MDA0ZGRhNTE2MjY1ODc1NjA5MmQ5OTA5ZDUw NDE4MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9IVE1MQ29udmVy dGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9IVE1MQ29udmVydGVyLm1t CkBAIC00MDMsNiArNDAzLDcgQEAgcHVibGljOgogICAgIFN0cmluZyBwcm9wZXJ0eVZhbHVlRm9y Tm9kZShOb2RlJiwgY29uc3QgU3RyaW5nJiBwcm9wZXJ0eU5hbWUpOwogICAgIGJvb2wgZmxvYXRQ cm9wZXJ0eVZhbHVlRm9yTm9kZShOb2RlJiwgY29uc3QgU3RyaW5nJiBwcm9wZXJ0eU5hbWUsIGZs b2F0Jik7CiAgICAgYm9vbCBpc0Jsb2NrRWxlbWVudChFbGVtZW50Jik7CisgICAgYm9vbCBlbGVt ZW50SGFzT3duQmFja2dyb3VuZENvbG9yKEVsZW1lbnQmKTsKIAogICAgIFBhc3NSZWZQdHI8Q1NT VmFsdWU+IGNvbXB1dGVkU3R5bGVQcm9wZXJ0eUZvckVsZW1lbnQoRWxlbWVudCYsIGNvbnN0IFN0 cmluZyYpOwogICAgIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IGlubGluZVN0eWxlUHJvcGVydHlGb3JF bGVtZW50KEVsZW1lbnQmLCBjb25zdCBTdHJpbmcmKTsKQEAgLTk0MSw2ICs5NDIsMTUgQEAgYm9v bCBIVE1MQ29udmVydGVyQ2FjaGVzOjppc0Jsb2NrRWxlbWVudChFbGVtZW50JiBlbGVtZW50KQog ICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCBIVE1MQ29udmVydGVyQ2FjaGVzOjplbGVtZW50 SGFzT3duQmFja2dyb3VuZENvbG9yKEVsZW1lbnQmIGVsZW1lbnQpCit7CisgICAgaWYgKCFpc0Js b2NrRWxlbWVudChlbGVtZW50KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIC8vIEluIHRo ZSB0ZXh0IHN5c3RlbSwgdGV4dCBibG9ja3MgKHRhYmxlIGVsZW1lbnRzKSBhbmQgZG9jdW1lbnRz IChib2R5IGVsZW1lbnRzKQorICAgIC8vIGhhdmUgdGhlaXIgb3duIGJhY2tncm91bmQgY29sb3Jz LCB3aGljaCBzaG91bGQgbm90IGJlIGluaGVyaXRlZC4KKyAgICByZXR1cm4gZWxlbWVudC5oYXNU YWdOYW1lKGh0bWxUYWcpIHx8IGVsZW1lbnQuaGFzVGFnTmFtZShib2R5VGFnKSB8fCBwcm9wZXJ0 eVZhbHVlRm9yTm9kZShlbGVtZW50LCAiZGlzcGxheSIpLnN0YXJ0c1dpdGgoInRhYmxlIik7Cit9 CisKIC0gKEJPT0wpX2VsZW1lbnRJc0Jsb2NrTGV2ZWw6KERPTUVsZW1lbnQgKillbGVtZW50CiB7 CiAgICAgcmV0dXJuIGVsZW1lbnQgJiYgX2NhY2hlcy0+aXNCbG9ja0VsZW1lbnQoKmNvcmUoZWxl bWVudCkpOwpAQCAtOTQ4LDE3ICs5NTgsOSBAQCAtIChCT09MKV9lbGVtZW50SXNCbG9ja0xldmVs OihET01FbGVtZW50ICopZWxlbWVudAogCiAtIChCT09MKV9lbGVtZW50SGFzT3duQmFja2dyb3Vu ZENvbG9yOihET01FbGVtZW50ICopZWxlbWVudAogewotICAgIC8vIEluIHRoZSB0ZXh0IHN5c3Rl bSwgdGV4dCBibG9ja3MgKHRhYmxlIGVsZW1lbnRzKSBhbmQgZG9jdW1lbnRzIChib2R5IGVsZW1l bnRzKQotICAgIC8vIGhhdmUgdGhlaXIgb3duIGJhY2tncm91bmQgY29sb3JzLCB3aGljaCBzaG91 bGQgbm90IGJlIGluaGVyaXRlZC4KLSAgICBpZiAoW3NlbGYgX2VsZW1lbnRJc0Jsb2NrTGV2ZWw6 ZWxlbWVudF0pIHsKLSAgICAgICAgRWxlbWVudCogY29yZUVsZW1lbnQgPSBjb3JlKGVsZW1lbnQp OwotICAgICAgICBOU1N0cmluZyAqZGlzcGxheVZhbCA9IFtzZWxmIF9zdHJpbmdGb3JOb2RlOmVs ZW1lbnQgcHJvcGVydHk6QCJkaXNwbGF5Il07Ci0gICAgICAgIGlmIChjb3JlRWxlbWVudC0+aGFz VGFnTmFtZShodG1sVGFnKSB8fCBjb3JlRWxlbWVudC0+aGFzVGFnTmFtZShib2R5VGFnKSB8fCBb ZGlzcGxheVZhbCBoYXNQcmVmaXg6QCJ0YWJsZSJdKQotICAgICAgICAgICAgcmV0dXJuIFlFUzsK LSAgICB9Ci0gICAgcmV0dXJuIE5POworICAgIHJldHVybiBlbGVtZW50ICYmIF9jYWNoZXMtPmVs ZW1lbnRIYXNPd25CYWNrZ3JvdW5kQ29sb3IoKmNvcmUoZWxlbWVudCkpOwogfQotICAgIAorCiAt IChET01FbGVtZW50ICopX2Jsb2NrTGV2ZWxFbGVtZW50Rm9yTm9kZTooRE9NTm9kZSAqKW5vZGUK IHsKICAgICBET01FbGVtZW50ICplbGVtZW50ID0gKERPTUVsZW1lbnQgKilub2RlOwo=