130290 2014-03-14 23:07:12 -0700 Web Inspector: AXI: crash when inspecting "bar" text node in getAccessibilityPropertiesForNode layout test 2014-03-26 08:19:00 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jcraig jcraig commit-queue dpino graouts jcraig joepeck timothy webkit-bug-importer oldest_to_newest 990829 0 jcraig 2014-03-14 23:07:12 -0700 Web Inspector: AXI: crash when inspecting " bar " text node in getAccessibilityPropertiesForNode layout test. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 ??? 000000000000000000 0 + 0 1 com.apple.WebCore 0x000000011310e86b WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties(WebCore::Node*) + 731 2 com.apple.WebCore 0x000000011310f60c non-virtual thunk to WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode(WTF::String*, int, WTF::RefPtr<Inspector::TypeBuilder::DOM::AccessibilityProperties>&) + 44 3 com.apple.WebCore 0x00000001131580a5 Inspector::InspectorDOMBackendDispatcher::getAccessibilityPropertiesForNode(long, Inspector::InspectorObject const&) + 357 4 com.apple.WebCore 0x0000000113155d8f Inspector::InspectorDOMBackendDispatcher::dispatch(long, WTF::String const&, WTF::PassRefPtr<Inspector::InspectorObject>) + 367 990830 1 webkit-bug-importer 2014-03-14 23:07:31 -0700 <rdar://problem/16334441> 994521 2 jcraig 2014-03-26 01:38:45 -0700 Looks like this was a regression from bug 129779. toElement was being called on non-element nodes including text nodes and document nodes. A simple conditional using node->isElementNode() seems to resolve the issue. Patch coming shortly. 994532 3 227840 jcraig 2014-03-26 02:38:31 -0700 Created attachment 227840 patch The WebCore fix is straightforward. The layout test result diff is obvious, but the layout test source diff is a little large. Among other things I had to rearrange things to reuse the logger on the non-element #document node which was previously specified in a element-only loop. 994578 4 227840 commit-queue 2014-03-26 08:18:57 -0700 Comment on attachment 227840 patch Clearing flags on attachment: 227840 Committed r166295: <http://trac.webkit.org/changeset/166295> 994579 5 commit-queue 2014-03-26 08:19:00 -0700 All reviewed patches have been landed. Closing bug. 227840 2014-03-26 02:38:31 -0700 2014-03-26 08:18:56 -0700 patch webkit130290.diff text/plain 7279 jcraig SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjI4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTI2ICBKYW1lcyBD cmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQVhJOiBj cmFzaCB3aGVuIGluc3BlY3RpbmcgImJhciIgdGV4dCBub2RlIGluIGdldEFjY2Vzc2liaWxpdHlQ cm9wZXJ0aWVzRm9yTm9kZSBsYXlvdXQgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaW5zcGVjdG9yLXByb3RvY29sL2RvbS9nZXRBY2Nl c3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUuaHRtbAorCisgICAgICAgIEZpeGluZyByZWdyZXNz aW9uIGZyb20gcjE2NTU5MC4gaHR0cDovL3dlYmtpdC5vcmcvYi8xMjk3NzkKKyAgICAgICAgVmVy aWZ5IGlzRWxlbWVudE5vZGUgdG8gYXZvaWQgY2FsbGluZyB0b0VsZW1lbnQgb24gZG9jdW1lbnQg b3IgdGV4dCBub2Rlcy4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmplY3RGb3JB Y2Nlc3NpYmlsaXR5UHJvcGVydGllcyk6CisKIDIwMTQtMDMtMjYgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92aW5nIHRoZSBy ZW1haW5pbmcgQXV0b21ha2UgY3J1ZnQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRE9NQWdlbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAJKHJldmlzaW9uIDE2NjI4MykKKysrIFNvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE1MDQsOSArMTUwNCwxMSBAQCBQYXNzUmVmUHRyPFR5cGVCdWlsZGVyOjpET006OkFjY2Vzc2li aWxpCiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICAgICAgCi0gICAg ICAgICAgICBzdXBwb3J0c0ZvY3VzZWQgPSB0b0VsZW1lbnQobm9kZSktPmlzRm9jdXNhYmxlKCk7 Ci0gICAgICAgICAgICBpZiAoc3VwcG9ydHNGb2N1c2VkKQotICAgICAgICAgICAgICAgIGZvY3Vz ZWQgPSBheE9iamVjdC0+aXNGb2N1c2VkKCk7CisgICAgICAgICAgICBpZiAobm9kZS0+aXNFbGVt ZW50Tm9kZSgpKSB7CisgICAgICAgICAgICAgICAgc3VwcG9ydHNGb2N1c2VkID0gdG9FbGVtZW50 KG5vZGUpLT5pc0ZvY3VzYWJsZSgpOworICAgICAgICAgICAgICAgIGlmIChzdXBwb3J0c0ZvY3Vz ZWQpCisgICAgICAgICAgICAgICAgICAgIGZvY3VzZWQgPSBheE9iamVjdC0+aXNGb2N1c2VkKCk7 CisgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGlnbm9yZWQgPSBheE9iamVjdC0+YWNjZXNz aWJpbGl0eUlzSWdub3JlZCgpOwogICAgICAgICAgICAgaWdub3JlZEJ5RGVmYXVsdCA9IGF4T2Jq ZWN0LT5hY2Nlc3NpYmlsaXR5SXNJZ25vcmVkQnlEZWZhdWx0KCk7CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biAxNjYyODcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMy0yNiAgSmFtZXMgQ3JhaWcgIDxqY3JhaWdAYXBwbGUuY29tPgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFYSTogY3Jhc2ggd2hlbiBpbnNwZWN0aW5nICJiYXIi IHRleHQgbm9kZSBpbiBnZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUgbGF5b3V0IHRl c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDI5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0 aW5nIHRlc3QgdG8gaW5jbHVkZSBwcm9wZXJ0aWVzIGZvciBkb2N1bWVudCBub2RlLgorCisgICAg ICAgICogaW5zcGVjdG9yLXByb3RvY29sL2RvbS9nZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zv ck5vZGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9kb20vZ2V0 QWNjZXNzaWJpbGl0eVByb3BlcnRpZXNGb3JOb2RlLmh0bWw6CisKIDIwMTQtMDMtMjUgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01TRV0gRHVwbGljYXRlICdz ZWVrZWQnIGV2ZW50cy4KSW5kZXg6IExheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20v Z2V0QWNjZXNzaWJpbGl0eVByb3BlcnRpZXNGb3JOb2RlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZG9tL2dldEFjY2Vzc2liaWxpdHlQ cm9wZXJ0aWVzRm9yTm9kZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE2NjI4MykKKysrIExheW91 dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20vZ2V0QWNjZXNzaWJpbGl0eVByb3BlcnRpZXNG b3JOb2RlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDEyIEBACiBDaGVj a2luZyBXZWIgSW5zcGVjdG9yIHByb3RvY29sIGZvciB0aGUgQWNjZXNzaWJpbGl0eSBOb2RlIElu c3BlY3Rvci4KIAorI2RvY3VtZW50CisgICAgZXhpc3RzOiB0cnVlCisgICAgbGFiZWw6IAorICAg IHJvbGU6IAorICAgIGNoaWxkTm9kZUlkcy5sZW5ndGg6IDE5CisKKwogVG90YWwgZWxlbWVudHMg dG8gYmUgdGVzdGVkOiA1Ny4KIAogPGxpIHJvbGU9InRyZWVpdGVtIiBhcmlhLWV4cGFuZGVkPSJ1 bmRlZmluZWQiPmV4cGFuZGVkPC9saT4KQEAgLTQ0Niw1ICs0NTMsMyBAQCBUb3RhbCBlbGVtZW50 cyB0byBiZSB0ZXN0ZWQ6IDU3LgogICAgIGxhYmVsOiAKICAgICByb2xlOiAKIAotCi0KSW5kZXg6 IExheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20vZ2V0QWNjZXNzaWJpbGl0eVByb3Bl cnRpZXNGb3JOb2RlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXBy b3RvY29sL2RvbS9nZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUuaHRtbAkocmV2aXNp b24gMTY2MjgzKQorKysgTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RvbS9nZXRBY2Nl c3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTEzLDQz ICsxMTMsNTYgQEAgZnVuY3Rpb24gY2xlYW51cCgpIHsKIGZ1bmN0aW9uIHRlc3QoKSB7CiAKICAg ICB2YXIgZXhhbXBsZXMgPSBbXTsKLQotICAgIGZ1bmN0aW9uIGxvb3AoKSB7Ci0gICAgICAgIGlm IChleGFtcGxlcy5sZW5ndGgpIHsKLSAgICAgICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1h bmQoIkRPTS5nZXRPdXRlckhUTUwiLCB7Im5vZGVJZCI6IGV4YW1wbGVzW2V4YW1wbGVzLmxlbmd0 aC0xXX0sIG9uR290T3V0ZXJIVE1MKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIElu c3BlY3RvclRlc3QubG9nKCJcbiIpOwotICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29t bWFuZCgiUnVudGltZS5ldmFsdWF0ZSIsIHsiZXhwcmVzc2lvbiI6ICJjbGVhbnVwKCkifSwgZnVu Y3Rpb24oKXsKLSAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOwot ICAgICAgICAgICAgfSk7Ci0gICAgICAgIH0KLSAgICB9OworICAgIHZhciBkb2N1bWVudE5vZGVJ ZCA9IG51bGw7CiAKICAgICBmdW5jdGlvbiBvbkdvdERvY3VtZW50KHJlc3BvbnNlKSB7CiAgICAg ICAgIEluc3BlY3RvclRlc3QuY2hlY2tGb3JFcnJvcihyZXNwb25zZSk7Ci0gICAgICAgIEluc3Bl Y3RvclRlc3Quc2VuZENvbW1hbmQoIkRPTS5xdWVyeVNlbGVjdG9yQWxsIiwgeyJub2RlSWQiOiBy ZXNwb25zZS5yZXN1bHQucm9vdC5ub2RlSWQsICJzZWxlY3RvciI6ICIuZXgifSwgb25RdWVyeVNl bGVjdG9yQWxsKTsKKyAgICAgICAgZG9jdW1lbnROb2RlSWQgPSByZXNwb25zZS5yZXN1bHQucm9v dC5ub2RlSWQ7CisgICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1hbmQoIkRPTS5nZXRBY2Nl c3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUiLCB7Im5vZGVJZCI6IGRvY3VtZW50Tm9kZUlkfSwg b25Hb3RBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0ZvckRvY3VtZW50Tm9kZSk7CiAgICAgfQogCi0g ICAgZnVuY3Rpb24gb25RdWVyeVNlbGVjdG9yQWxsKHJlc3BvbnNlKSB7CisgICAgZnVuY3Rpb24g b25Hb3RBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0ZvckRvY3VtZW50Tm9kZShyZXNwb25zZSkgewor ICAgICAgICBJbnNwZWN0b3JUZXN0LmNoZWNrRm9yRXJyb3IocmVzcG9uc2UpOworICAgICAgICBJ bnNwZWN0b3JUZXN0LmxvZygiI2RvY3VtZW50Iik7CisgICAgICAgIGxvZ0FjY2Vzc2liaWxpdHlQ cm9wZXJ0aWVzKHJlc3BvbnNlLnJlc3VsdC5wcm9wZXJ0aWVzKTsKKyAgICAgICAgSW5zcGVjdG9y VGVzdC5sb2coIlxuIik7CisgICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1hbmQoIkRPTS5x dWVyeVNlbGVjdG9yQWxsIiwgeyJub2RlSWQiOiBkb2N1bWVudE5vZGVJZCwgInNlbGVjdG9yIjog Ii5leCJ9LCBvbkdvdFF1ZXJ5U2VsZWN0b3JBbGwpOworICAgIH0KKworICAgIGZ1bmN0aW9uIG9u R290UXVlcnlTZWxlY3RvckFsbChyZXNwb25zZSkgewogICAgICAgICBJbnNwZWN0b3JUZXN0LmNo ZWNrRm9yRXJyb3IocmVzcG9uc2UpOwogICAgICAgICBleGFtcGxlcyA9IHJlc3BvbnNlLnJlc3Vs dC5ub2RlSWRzOwogICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiVG90YWwgZWxlbWVudHMgdG8g YmUgdGVzdGVkOiAiICsgZXhhbXBsZXMubGVuZ3RoICsgIi4iKTsKICAgICAgICAgbG9vcCgpOwog ICAgIH0KIAorICAgIGZ1bmN0aW9uIGxvb3AoKSB7CisgICAgICAgIGlmIChleGFtcGxlcy5sZW5n dGgpIHsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1hbmQoIkRPTS5nZXRPdXRl ckhUTUwiLCB7Im5vZGVJZCI6IGV4YW1wbGVzW2V4YW1wbGVzLmxlbmd0aC0xXX0sIG9uR290T3V0 ZXJIVE1MKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGZpbmlzaFRlc3QoKTsKKyAg ICAgICAgfQorICAgIH0KKwogICAgIGZ1bmN0aW9uIG9uR290T3V0ZXJIVE1MKHJlc3BvbnNlKSB7 CiAgICAgICAgIEluc3BlY3RvclRlc3QuY2hlY2tGb3JFcnJvcihyZXNwb25zZSk7CiAgICAgICAg IHZhciBvdXRlckhUTUwgPSByZXNwb25zZS5yZXN1bHQub3V0ZXJIVE1MOwogICAgICAgICBvdXRl ckhUTUwgPSBvdXRlckhUTUwucmVwbGFjZSgvIGNsYXNzPSJleCIvZywgIiIpOyAvLyByZW1vdmUg YW55IGR1cGxpY2F0ZWQsIHVubmVjZXNzYXJ5IGNsYXNzIGF0dHJpYnV0ZXMKICAgICAgICAgb3V0 ZXJIVE1MID0gb3V0ZXJIVE1MLnJlcGxhY2UoLztiYXNlNjQsLio/Ii8sICIuLi5cIiIpOyAvLyBz dXBwcmVzcyBmdWxsIGRhdGEgVVJJcyBpbiBvdXRwdXQKICAgICAgICAgSW5zcGVjdG9yVGVzdC5s b2coIlxuIiArIG91dGVySFRNTCk7Ci0gICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1hbmQo IkRPTS5nZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUiLCB7Im5vZGVJZCI6IGV4YW1w bGVzW2V4YW1wbGVzLmxlbmd0aC0xXX0sIG9uR290QVhQcm9wcyk7CisgICAgICAgIEluc3BlY3Rv clRlc3Quc2VuZENvbW1hbmQoIkRPTS5nZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUi LCB7Im5vZGVJZCI6IGV4YW1wbGVzW2V4YW1wbGVzLmxlbmd0aC0xXX0sIG9uR290QWNjZXNzaWJp bGl0eVByb3BlcnRpZXMpOwogICAgIH0KIAotICAgIGZ1bmN0aW9uIG9uR290QVhQcm9wcyhyZXNw b25zZSkgeworICAgIGZ1bmN0aW9uIG9uR290QWNjZXNzaWJpbGl0eVByb3BlcnRpZXMocmVzcG9u c2UpIHsKICAgICAgICAgSW5zcGVjdG9yVGVzdC5jaGVja0ZvckVycm9yKHJlc3BvbnNlKTsKLSAg ICAgICAgZm9yICh2YXIga2V5IGluIHJlc3BvbnNlLnJlc3VsdC5wcm9wZXJ0aWVzKSB7Ci0gICAg ICAgICAgICB2YXIgdmFsdWUgPSByZXNwb25zZS5yZXN1bHQucHJvcGVydGllc1trZXldOworICAg ICAgICBsb2dBY2Nlc3NpYmlsaXR5UHJvcGVydGllcyhyZXNwb25zZS5yZXN1bHQucHJvcGVydGll cyk7CisgICAgICAgIGV4YW1wbGVzLnBvcCgpOworICAgICAgICBsb29wKCk7CisgICAgfQorCisg ICAgZnVuY3Rpb24gbG9nQWNjZXNzaWJpbGl0eVByb3BlcnRpZXMocHJvcGVydGllcykgeworICAg ICAgICBmb3IgKHZhciBrZXkgaW4gcHJvcGVydGllcykgeworICAgICAgICAgICAgdmFyIHZhbHVl ID0gcHJvcGVydGllc1trZXldOwogICAgICAgICAgICAgc3dpdGNoIChrZXkpewogICAgICAgICAg ICAgY2FzZSAibm9kZUlkIjoKICAgICAgICAgICAgICAgICBjb250aW51ZTsKQEAgLTE2OSwxMCAr MTgyLDE2IEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5sb2coIiAgICAiICsga2V5ICsgIjogIiArIHZhbHVlKTsKICAgICAgICAgICAgIH0KICAgICAg ICAgfQotICAgICAgICBleGFtcGxlcy5wb3AoKTsKLSAgICAgICAgbG9vcCgpOwogICAgIH0KIAor ICAgIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKSB7CisgICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENv bW1hbmQoIlJ1bnRpbWUuZXZhbHVhdGUiLCB7ImV4cHJlc3Npb24iOiAiY2xlYW51cCgpIn0sIGZ1 bmN0aW9uKCl7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAg ICAgICB9KTsKKyAgICB9CisKKworCiAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgiRE9N LmdldERvY3VtZW50Iiwge30sIG9uR290RG9jdW1lbnQpOwogCiB9Cg==