130280 2014-03-14 19:45:46 -0700 Subpixel rendering: Push integral snapping from RenderBox::paintBoxDecorations() to RenderTheme 2014-06-26 09:13:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 990788 0 zalan 2014-03-14 19:45:46 -0700 ssia. 990789 1 226795 zalan 2014-03-14 19:47:29 -0700 Created attachment 226795 Patch 226795 2014-03-14 19:47:29 -0700 2014-06-26 09:13:10 -0700 Patch bug-130280-20140314194706.patch text/plain 6485 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIxN2U3MjkyYzczMTVk ZTlkNWQwNDEwYjRjOGExNDBjM2JmNGJiOS4uZjVmNjIxYjQxOTlkNjNiZTM4NzU2ZjQyYTMzYmQz ODM2NTNiZWM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTE0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBQdXNoIGludGVncmFsIHNuYXBwaW5nIGZyb20gUmVuZGVyQm94OjpwYWludEJveERlY29yYXRp b25zKCkgdG8gUmVuZGVyVGhlbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMDI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnBhaW50 Qm94RGVjb3JhdGlvbnMpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZTo6cGFpbnQpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVGhlbWU6OnBhaW50Qm9yZGVyT25seSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU aGVtZTo6cGFpbnREZWNvcmF0aW9ucyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1l Lmg6CisKIDIwMTQtMDMtMTQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAK ICAgICAgICAgW0NTU1JlZ2lvbnNdIElubGluZS1ibG9jayBjaGlsZCBvZiBjb250ZW50IG5vZGUg aW5jb3JyZWN0bHkgY2xpcHBlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApp bmRleCAyMjU0NTg1MGU0ZjkzM2U5NmI0OTA5NjAwMmUyY2FhOGFmOWFiN2NlLi4zYTQ4OTQ2MjJm ODNlNGE0NDUzZjkwMTAzM2QwMTUxNWUyMWEzOGI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcApAQCAtMTIyMCw4ICsxMjIwLDcgQEAgdm9pZCBSZW5kZXJCb3g6OnBhaW50 Qm94RGVjb3JhdGlvbnMoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBvaW50JiBw YWkKIAogICAgIC8vIElmIHdlIGhhdmUgYSBuYXRpdmUgdGhlbWUgYXBwZWFyYW5jZSwgcGFpbnQg dGhhdCBiZWZvcmUgcGFpbnRpbmcgb3VyIGJhY2tncm91bmQuCiAgICAgLy8gVGhlIHRoZW1lIHdp bGwgdGVsbCB1cyB3aGV0aGVyIG9yIG5vdCB3ZSBzaG91bGQgYWxzbyBwYWludCB0aGUgQ1NTIGJh Y2tncm91bmQuCi0gICAgSW50UmVjdCBzbmFwcGVkUGFpbnRSZWN0KHBpeGVsU25hcHBlZEludFJl Y3QocGFpbnRSZWN0KSk7Ci0gICAgYm9vbCB0aGVtZVBhaW50ZWQgPSBzdHlsZSgpLmhhc0FwcGVh cmFuY2UoKSAmJiAhdGhlbWUoKS5wYWludCh0aGlzLCBwYWludEluZm8sIHNuYXBwZWRQYWludFJl Y3QpOworICAgIGJvb2wgdGhlbWVQYWludGVkID0gc3R5bGUoKS5oYXNBcHBlYXJhbmNlKCkgJiYg IXRoZW1lKCkucGFpbnQodGhpcywgcGFpbnRJbmZvLCBwYWludFJlY3QpOwogICAgIGlmICghdGhl bWVQYWludGVkKSB7CiAgICAgICAgIGlmIChibGVlZEF2b2lkYW5jZSA9PSBCYWNrZ3JvdW5kQmxl ZWRCYWNrZ3JvdW5kT3ZlckJvcmRlcikKICAgICAgICAgICAgIHBhaW50Qm9yZGVyKHBhaW50SW5m bywgcGFpbnRSZWN0LCBzdHlsZSgpLCBibGVlZEF2b2lkYW5jZSk7CkBAIC0xMjI5LDEyICsxMjI4 LDEyIEBAIHZvaWQgUmVuZGVyQm94OjpwYWludEJveERlY29yYXRpb25zKFBhaW50SW5mbyYgcGFp bnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpCiAgICAgICAgIHBhaW50QmFja2dyb3VuZChw YWludEluZm8sIHBhaW50UmVjdCwgYmxlZWRBdm9pZGFuY2UpOwogCiAgICAgICAgIGlmIChzdHls ZSgpLmhhc0FwcGVhcmFuY2UoKSkKLSAgICAgICAgICAgIHRoZW1lKCkucGFpbnREZWNvcmF0aW9u cyh0aGlzLCBwYWludEluZm8sIHNuYXBwZWRQYWludFJlY3QpOworICAgICAgICAgICAgdGhlbWUo KS5wYWludERlY29yYXRpb25zKHRoaXMsIHBhaW50SW5mbywgcGFpbnRSZWN0KTsKICAgICB9CiAg ICAgcGFpbnRCb3hTaGFkb3cocGFpbnRJbmZvLCBwYWludFJlY3QsIHN0eWxlKCksIEluc2V0KTsK IAogICAgIC8vIFRoZSB0aGVtZSB3aWxsIHRlbGwgdXMgd2hldGhlciBvciBub3Qgd2Ugc2hvdWxk IGFsc28gcGFpbnQgdGhlIENTUyBib3JkZXIuCi0gICAgaWYgKGJsZWVkQXZvaWRhbmNlICE9IEJh Y2tncm91bmRCbGVlZEJhY2tncm91bmRPdmVyQm9yZGVyICYmICghc3R5bGUoKS5oYXNBcHBlYXJh bmNlKCkgfHwgKCF0aGVtZVBhaW50ZWQgJiYgdGhlbWUoKS5wYWludEJvcmRlck9ubHkodGhpcywg cGFpbnRJbmZvLCBzbmFwcGVkUGFpbnRSZWN0KSkpICYmIHN0eWxlKCkuaGFzQm9yZGVyKCkpCisg ICAgaWYgKGJsZWVkQXZvaWRhbmNlICE9IEJhY2tncm91bmRCbGVlZEJhY2tncm91bmRPdmVyQm9y ZGVyICYmICghc3R5bGUoKS5oYXNBcHBlYXJhbmNlKCkgfHwgKCF0aGVtZVBhaW50ZWQgJiYgdGhl bWUoKS5wYWludEJvcmRlck9ubHkodGhpcywgcGFpbnRJbmZvLCBwYWludFJlY3QpKSkgJiYgc3R5 bGUoKS5oYXNCb3JkZXIoKSkKICAgICAgICAgcGFpbnRCb3JkZXIocGFpbnRJbmZvLCBwYWludFJl Y3QsIHN0eWxlKCksIGJsZWVkQXZvaWRhbmNlKTsKIAogICAgIGlmIChibGVlZEF2b2lkYW5jZSA9 PSBCYWNrZ3JvdW5kQmxlZWRVc2VUcmFuc3BhcmVuY3lMYXllcikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWUuY3BwCmluZGV4IDc2ODkxOGNiOThkNGY5N2FjMTUyYTlhNjUzZjZl OTM5ZGRhYTE3Y2IuLjgxNjM4NGRiMGNlY2U4NWM2NjBlNWZmN2RkZGZjNTEwMzJmMGJiOWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcApAQCAtMjYyLDcgKzI2Miw3 IEBAIHZvaWQgUmVuZGVyVGhlbWU6OmFkanVzdFN0eWxlKFN0eWxlUmVzb2x2ZXImIHN0eWxlUmVz b2x2ZXIsIFJlbmRlclN0eWxlJiBzdHlsZSwKICAgICB9CiB9CiAKLWJvb2wgUmVuZGVyVGhlbWU6 OnBhaW50KFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0 IEludFJlY3QmIHIpCitib29sIFJlbmRlclRoZW1lOjpwYWludChSZW5kZXJPYmplY3QqIG8sIGNv bnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRSZWN0JiBwYWludFJlY3QpCiB7 CiAgICAgLy8gSWYgcGFpbnRpbmcgaXMgZGlzYWJsZWQsIGJ1dCB3ZSBhcmVuJ3QgdXBkYXRpbmcg Y29udHJvbCB0aW50cywgdGhlbiBqdXN0IGJhaWwuCiAgICAgLy8gSWYgd2UgYXJlIHVwZGF0aW5n IGNvbnRyb2wgdGludHMsIGp1c3Qgc2NoZWR1bGUgYSByZXBhaW50IGlmIHRoZSB0aGVtZSBzdXBw b3J0cyB0aW50aW5nCkBAIC0yNzYsNiArMjc2LDcgQEAgYm9vbCBSZW5kZXJUaGVtZTo6cGFpbnQo UmVuZGVyT2JqZWN0KiBvLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmUK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgQ29udHJvbFBhcnQgcGFydCA9IG8tPnN0eWxl KCkuYXBwZWFyYW5jZSgpOworICAgIEludFJlY3QgciA9IHBpeGVsU25hcHBlZEludFJlY3QocGFp bnRSZWN0KTsKIAogI2lmIFVTRShORVdfVEhFTUUpCiAgICAgc3dpdGNoIChwYXJ0KSB7CkBAIC00 MDEsMTEgKzQwMiwxMiBAQCBib29sIFJlbmRlclRoZW1lOjpwYWludChSZW5kZXJPYmplY3QqIG8s IGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBJbnRSZQogICAgIHJldHVybiB0cnVl OyAvLyBXZSBkb24ndCBzdXBwb3J0IHRoZSBhcHBlYXJhbmNlLCBzbyBsZXQgdGhlIG5vcm1hbCBi YWNrZ3JvdW5kL2JvcmRlciBwYWludC4KIH0KIAotYm9vbCBSZW5kZXJUaGVtZTo6cGFpbnRCb3Jk ZXJPbmx5KFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0 IEludFJlY3QmIHIpCitib29sIFJlbmRlclRoZW1lOjpwYWludEJvcmRlck9ubHkoUmVuZGVyT2Jq ZWN0KiBvLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UmVjdCYgcGFp bnRSZWN0KQogewogICAgIGlmIChwYWludEluZm8uY29udGV4dC0+cGFpbnRpbmdEaXNhYmxlZCgp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBJbnRSZWN0IHIgPSBwaXhlbFNuYXBwZWRJ bnRSZWN0KHBhaW50UmVjdCk7CiAjaWYgUExBVEZPUk0oSU9TKQogICAgIFVOVVNFRF9QQVJBTShy KTsKICAgICByZXR1cm4gby0+c3R5bGUoKS5hcHBlYXJhbmNlKCkgIT0gTm9Db250cm9sUGFydDsK QEAgLTQ1OSwxMSArNDYxLDEyIEBAIGJvb2wgUmVuZGVyVGhlbWU6OnBhaW50Qm9yZGVyT25seShS ZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjCiAjZW5kaWYKIH0K IAotYm9vbCBSZW5kZXJUaGVtZTo6cGFpbnREZWNvcmF0aW9ucyhSZW5kZXJPYmplY3QqIHJlbmRl cmVyLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYgcmVjdCkKK2Jv b2wgUmVuZGVyVGhlbWU6OnBhaW50RGVjb3JhdGlvbnMoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwg Y29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFJlY3QmIHBhaW50UmVjdCkK IHsKICAgICBpZiAocGFpbnRJbmZvLmNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCisgICAgSW50UmVjdCByZWN0ID0gcGl4ZWxTbmFwcGVkSW50UmVj dChwYWludFJlY3QpOwogICAgIC8vIENhbGwgdGhlIGFwcHJvcHJpYXRlIHBhaW50IG1ldGhvZCBi YXNlZCBvZmYgdGhlIGFwcGVhcmFuY2UgdmFsdWUuCiAgICAgc3dpdGNoIChyZW5kZXJlci0+c3R5 bGUoKS5hcHBlYXJhbmNlKCkpIHsKICAgICBjYXNlIE1lbnVsaXN0QnV0dG9uUGFydDoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgKaW5kZXggMGFkODZiYzVlYjI4YjI4ZWZjMDUy NTM3ZTdmMjk1NmNiM2ZmZjM0Yi4uZTYxYTE5NzBhNmJiNzkyMTUwYTcyNTQ4ZjgyNTg4NmFhNWVl Y2RkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgKQEAgLTc4LDkgKzc4 LDkgQEAgcHVibGljOgogICAgIC8vIFRoaXMgbWV0aG9kIGlzIGNhbGxlZCB0byBwYWludCB0aGUg d2lkZ2V0IGFzIGEgYmFja2dyb3VuZCBvZiB0aGUgUmVuZGVyT2JqZWN0LiAgQSB3aWRnZXQncyBm b3JlZ3JvdW5kLCBlLmcuLCB0aGUKICAgICAvLyB0ZXh0IG9mIGEgYnV0dG9uLCBpcyBhbHdheXMg cmVuZGVyZWQgYnkgdGhlIGVuZ2luZSBpdHNlbGYuICBUaGUgYm9vbGVhbiByZXR1cm4gdmFsdWUg aW5kaWNhdGVzCiAgICAgLy8gd2hldGhlciB0aGUgQ1NTIGJvcmRlci9iYWNrZ3JvdW5kIHNob3Vs ZCBhbHNvIGJlIHBhaW50ZWQuCi0gICAgYm9vbCBwYWludChSZW5kZXJPYmplY3QqLCBjb25zdCBQ YWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7Ci0gICAgYm9vbCBwYWludEJvcmRlck9ubHkoUmVu ZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwotICAgIGJvb2wg cGFpbnREZWNvcmF0aW9ucyhSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJ bnRSZWN0Jik7CisgICAgYm9vbCBwYWludChSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8m LCBjb25zdCBMYXlvdXRSZWN0Jik7CisgICAgYm9vbCBwYWludEJvcmRlck9ubHkoUmVuZGVyT2Jq ZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgTGF5b3V0UmVjdCYpOworICAgIGJvb2wgcGFp bnREZWNvcmF0aW9ucyhSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBMYXlv dXRSZWN0Jik7CiAKICAgICAvLyBUaGUgcmVtYWluaW5nIG1ldGhvZHMgc2hvdWxkIGJlIGltcGxl bWVudGVkIGJ5IHRoZSBwbGF0Zm9ybS1zcGVjaWZpYyBwb3J0aW9uIG9mIHRoZSB0aGVtZSwgZS5n LiwKICAgICAvLyBSZW5kZXJUaGVtZU1hYy5jcHAgZm9yIE1hYyBPUyBYLgo=