13028 2007-03-09 14:25:01 -0800 REGRESSION: textField:doCommandBySelector:inFrame: not being called properly 2007-07-28 07:32:17 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 rachael webkit-unassigned oldest_to_newest 19719 0 rachael 2007-03-09 14:25:01 -0800 -[WebFormDelegate textField:doCommandBySelector:inFrame:] doesn't appear to be called when the arrow keys or the tab key is pressed while focus is inside a text-field. this appears to be a regression from the behavior as of revision 19306 (at least), where the delegate method would be called. 19567 1 13581 adele 2007-03-10 15:39:46 -0800 Created attachment 13581 patch This is a regression from r19579, when we added TextInput events. 19568 2 13581 mjs 2007-03-10 15:46:40 -0800 Comment on attachment 13581 patch r=me 19552 3 adele 2007-03-10 16:15:28 -0800 Committed revision 20100. 13581 2007-03-10 15:39:46 -0800 2007-03-10 15:46:40 -0800 patch patch_docommand.txt text/plain 2094 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDk5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDMt MTAgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjgKKyAgICAgICAgUkVHUkVTU0lPTjogdGV4dEZpZWxk OmRvQ29tbWFuZEJ5U2VsZWN0b3I6aW5GcmFtZTogbm90IGJlaW5nIGNhbGxlZCBwcm9wZXJseQor CisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDogKFdlYkNvcmU6OkhUTUxJbnB1 dEVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorICAgICAgICAgIEJlZm9yZSBjYWxsaW5n IHRoZSBiYXNlIGNsYXNzIGRlZmF1bHRFdmVudEhhbmRsZXIsIHdoaWNoIHdpbGwgY2FsbCBoYW5k bGVLZXlwcmVzcywgY2FsbCBkb1RleHRGaWVsZENvbW1hbmRGcm9tRXZlbnQuICAgICAgICAKKwog MjAwNy0wMy0xMCAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHJldmlzaW9uIDIwMDk2KQorKysgaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEzMSw2ICsxMTMxLDE0 IEBACiAgICAgICAgIH0KICAgICB9CiAKKyAgICAvLyBCZWZvcmUgY2FsbGluZyB0aGUgYmFzZSBj bGFzcyBkZWZhdWx0RXZlbnRIYW5kbGVyLCB3aGljaCB3aWxsIGNhbGwgaGFuZGxlS2V5cHJlc3Ms IGNhbGwgZG9UZXh0RmllbGRDb21tYW5kRnJvbUV2ZW50LgorICAgIGlmIChpc1RleHRGaWVsZCgp ICYmIGV2dC0+dHlwZSgpID09IGtleXByZXNzRXZlbnQgJiYgZXZ0LT5pc0tleWJvYXJkRXZlbnQo KSAmJiBmb2N1c2VkKCkgJiYgZG9jdW1lbnQoKS0+ZnJhbWUoKQorICAgICAgICAgICAgICAgICYm IGRvY3VtZW50KCktPmZyYW1lKCktPmRvVGV4dEZpZWxkQ29tbWFuZEZyb21FdmVudCh0aGlzLCBz dGF0aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZ0KSkpIHsKKyAgICAgICAgZXZ0LT5zZXREZWZh dWx0SGFuZGxlZCgpOworICAgICAgICByZXR1cm47CisgICAgfQorICAgIAorICAgIC8vIExldCB0 aGUga2V5IGhhbmRsaW5nIGRvbmUgaW4gRXZlbnRUYXJnZXROb2RlIHRha2UgcHJlY2VkZW5jZSBv dmVyIHRoZSBldmVudCBoYW5kbGluZyBoZXJlIGZvciBlZGl0YWJsZSB0ZXh0IGZpZWxkcwogICAg IGlmICghY2xpY2tEZWZhdWx0Rm9ybUJ1dHRvbikgewogICAgICAgICBIVE1MR2VuZXJpY0Zvcm1F bGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKGV2dCk7CiAgICAgICAgIGlmIChldnQtPmRlZmF1 bHRIYW5kbGVkKCkpCkBAIC0xMTY4LDEyICsxMTc2LDYgQEAKICAgICBpZiAoZXZ0LT50eXBlKCkg PT0ga2V5cHJlc3NFdmVudCAmJiBldnQtPmlzS2V5Ym9hcmRFdmVudCgpKSB7CiAgICAgICAgIGJv b2wgY2xpY2tFbGVtZW50ID0gZmFsc2U7CiAKLSAgICAgICAgaWYgKGlzVGV4dEZpZWxkKCkgJiYg Zm9jdXNlZCgpICYmIGRvY3VtZW50KCktPmZyYW1lKCkKLSAgICAgICAgICAgICAgICAmJiBkb2N1 bWVudCgpLT5mcmFtZSgpLT5kb1RleHRGaWVsZENvbW1hbmRGcm9tRXZlbnQodGhpcywgc3RhdGlj X2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2dCkpKSB7Ci0gICAgICAgICAgICBldnQtPnNldERlZmF1 bHRIYW5kbGVkKCk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQogICAgICAgICBT dHJpbmcga2V5ID0gc3RhdGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2dCktPmtleUlkZW50aWZp ZXIoKTsKIAogICAgICAgICBpZiAoa2V5ID09ICJVKzAwMDAyMCIpIHsK