130266 2014-03-14 15:42:09 -0700 [EME] Add NULL protections in SourceBuffer and MediaSource. 2014-03-17 13:24:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson glenn philipj sergio oldest_to_newest 990708 0 jer.noble 2014-03-14 15:42:09 -0700 [EME] Add NULL protections in SourceBuffer and MediaSource. 990710 1 226770 jer.noble 2014-03-14 15:48:32 -0700 Created attachment 226770 Patch 991341 2 jer.noble 2014-03-17 12:50:53 -0700 efl-wk2 failed with "c++: internal compiler error: Killed (program cc1plus)" against InspectorController. Unrelated. 991360 3 226770 commit-queue 2014-03-17 13:24:04 -0700 Comment on attachment 226770 Patch Clearing flags on attachment: 226770 Committed r165751: <http://trac.webkit.org/changeset/165751> 991361 4 commit-queue 2014-03-17 13:24:09 -0700 All reviewed patches have been landed. Closing bug. 226770 2014-03-14 15:48:32 -0700 2014-03-17 13:24:04 -0700 Patch bug-130266-20140314154824.patch text/plain 5642 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZkMDI4NjJiN2QzMGQ4 ZDFjMWUyMTU2ZjMwMjgxNmM0MWI3MTVhNC4uNmJiMzY3YzJjNmYxODMxZjFmODM4MGU1NWY1ZTQx OGYxODE5ZGIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTAzLTE0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtFTUVdIEFkZCBOVUxMIHBy b3RlY3Rpb25zIGluIFNvdXJjZUJ1ZmZlciBhbmQgTWVkaWFTb3VyY2UuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAyNjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgTlVMTCBjaGVja3MgaW4gcGxh Y2VzIHdoaWNoIG1heSBiZSBjYWxsZWQgYWZ0ZXIgYSBTb3VyY2VCdWZmZXIgaGFzIGJlZW4gcmVt b3ZlZDoKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFTb3VyY2U6Om1vbml0b3JTb3VyY2VCdWZmZXJzKTogUHJv dGVjdCBhZ2FpbnN0IGEgU291cmNlQnVmZmVyIGJlaW5nIHJlbW92ZWQKKyAgICAgICAgICAgIChh bmQgdGh1cyBhY3RpdmVTb3VyY2VCdWZmZXJzIGJlaW5nIGVtcHR5KSB3aGVuIG1vbml0b3Jpbmcg c291cmNlIGJ1ZmZlciBzdGF0ZS4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJj ZUJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OmFwcGVuZEJ1ZmZl clRpbWVyRmlyZWQpOiBQcm90ZWN0IGFnYWluc3QgU291cmNlQnVmZmVyIGJlaW5nIHJlbW92ZWQu CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnZpZGVvVHJhY2tzKTogRGl0dG8uCisg ICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OmF1ZGlvVHJhY2tzKTogRGl0dG8uCisgICAg ICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXI6OnRleHRUcmFja3MpOiBEaXR0by4KKyAgICAgICAg KFdlYkNvcmU6OlNvdXJjZUJ1ZmZlcjo6c2V0QWN0aXZlKTogRGl0dG8uCisgICAgICAgIChXZWJD b3JlOjpTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRFbmRTdHJlYW0pOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlcjo6aGFzQ3VycmVudFRpbWUpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlcjo6Y2FuUGxheVRocm91Z2gpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlcjo6aGFzRnV0dXJlVGltZSk6IERpdHRv LCBhbmQgY2hlY2sgZm9yIGFuIGVtcHR5IGJ1ZmZlcmVkIHJhbmdlcy4KKwogMjAxNC0wMy0wNCAg SmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXVtNZWRpYUNv bnRyb2xzXSBSZXZlcnNlLXBpbmNoaW5nIHVzaW5nIHRoZSBidWlsdC1pbiBjb250cm9scyBzaG91 bGQgZW50ZXIgZnVsbCBzY3JlZW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNvdXJjZS9NZWRpYVNvdXJjZS5jcHAKaW5kZXggNjk3Mzg0OGVmM2RhYzhjNDg2YjJhNDc1MmRk NjRlZDc4NTIxMjQ5My4uMTIxMTY2MGZiN2FhMzc5YzQwZjZhOTQ0YWNjM2EyMTg1M2YyNmIwMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJj ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJj ZS5jcHAKQEAgLTE4NCw2ICsxODQsMTMgQEAgdm9pZCBNZWRpYVNvdXJjZTo6bW9uaXRvclNvdXJj ZUJ1ZmZlcnMoKQogewogICAgIC8vIDIuNC40IFNvdXJjZUJ1ZmZlciBNb25pdG9yaW5nCiAgICAg Ly8gaHR0cHM6Ly9kdmNzLnczLm9yZy9oZy9odG1sLW1lZGlhL3Jhdy1maWxlL2RlZmF1bHQvbWVk aWEtc291cmNlL21lZGlhLXNvdXJjZS5odG1sI2J1ZmZlci1tb25pdG9yaW5nCisKKyAgICAvLyBO b3RlLCB0aGUgYmVoYXZpb3IgaWYgYWN0aXZlU291cmNlQnVmZmVycyBpcyBlbXB0eSBpcyB1bmRl ZmluZWQuCisgICAgaWYgKCFtX2FjdGl2ZVNvdXJjZUJ1ZmZlcnMpIHsKKyAgICAgICAgbV9wcml2 YXRlLT5zZXRSZWFkeVN0YXRlKE1lZGlhUGxheWVyOjpIYXZlTm90aGluZyk7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICAvLyDihrMgSWYgYnVmZmVyZWQgZm9yIGFsbCBvYmplY3RzIGlu IGFjdGl2ZVNvdXJjZUJ1ZmZlcnMgZG8gbm90IGNvbnRhaW4gVGltZVJhbmdlcyBmb3IgdGhlIGN1 cnJlbnQKICAgICAvLyBwbGF5YmFjayBwb3NpdGlvbjoKICAgICBhdXRvIGJlZ2luID0gbV9hY3Rp dmVTb3VyY2VCdWZmZXJzLT5iZWdpbigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCmluZGV4IGI4ZmQxM2M0MGNhNTM3NWY0NTQ2 Yzc0NmNiNzYyZmZlODMzODEyOTcuLjEzYWZjMjVkMzFiYTM3MjBiZmQxMDUwNmNmMWI0M2FhMmQy YzA1OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291 cmNlQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1Nv dXJjZUJ1ZmZlci5jcHAKQEAgLTQwOCw2ICs0MDgsOSBAQCB2b2lkIFNvdXJjZUJ1ZmZlcjo6YXBw ZW5kQnVmZmVySW50ZXJuYWwodW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWduZWQgc2l6ZSwgRXhj ZQogCiB2b2lkIFNvdXJjZUJ1ZmZlcjo6YXBwZW5kQnVmZmVyVGltZXJGaXJlZChUaW1lcjxTb3Vy Y2VCdWZmZXI+JikKIHsKKyAgICBpZiAoaXNSZW1vdmVkKCkpCisgICAgICAgIHJldHVybjsKKwog ICAgIEFTU0VSVChtX3VwZGF0aW5nKTsKIAogICAgIC8vIFNlY3Rpb24gMy41LjUgQnVmZmVyIEFw cGVuZCBBbGdvcml0aG0KQEAgLTQ4MSw3ICs0ODQsNyBAQCBjb25zdCBBdG9taWNTdHJpbmcmIFNv dXJjZUJ1ZmZlcjo6bmV0d29ya0Vycm9yKCkKIAogVmlkZW9UcmFja0xpc3QqIFNvdXJjZUJ1ZmZl cjo6dmlkZW9UcmFja3MoKQogewotICAgIGlmICghbV9zb3VyY2UtPm1lZGlhRWxlbWVudCgpKQor ICAgIGlmICghbV9zb3VyY2UgfHwgIW1fc291cmNlLT5tZWRpYUVsZW1lbnQoKSkKICAgICAgICAg cmV0dXJuIG51bGxwdHI7CiAKICAgICBpZiAoIW1fdmlkZW9UcmFja3MpCkBAIC00OTIsNyArNDk1 LDcgQEAgVmlkZW9UcmFja0xpc3QqIFNvdXJjZUJ1ZmZlcjo6dmlkZW9UcmFja3MoKQogCiBBdWRp b1RyYWNrTGlzdCogU291cmNlQnVmZmVyOjphdWRpb1RyYWNrcygpCiB7Ci0gICAgaWYgKCFtX3Nv dXJjZS0+bWVkaWFFbGVtZW50KCkpCisgICAgaWYgKCFtX3NvdXJjZSB8fCAhbV9zb3VyY2UtPm1l ZGlhRWxlbWVudCgpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIGlmICghbV9hdWRp b1RyYWNrcykKQEAgLTUwMyw3ICs1MDYsNyBAQCBBdWRpb1RyYWNrTGlzdCogU291cmNlQnVmZmVy OjphdWRpb1RyYWNrcygpCiAKIFRleHRUcmFja0xpc3QqIFNvdXJjZUJ1ZmZlcjo6dGV4dFRyYWNr cygpCiB7Ci0gICAgaWYgKCFtX3NvdXJjZS0+bWVkaWFFbGVtZW50KCkpCisgICAgaWYgKCFtX3Nv dXJjZSB8fCAhbV9zb3VyY2UtPm1lZGlhRWxlbWVudCgpKQogICAgICAgICByZXR1cm4gbnVsbHB0 cjsKIAogICAgIGlmICghbV90ZXh0VHJhY2tzKQpAQCAtNTE5LDEyICs1MjIsMTQgQEAgdm9pZCBT b3VyY2VCdWZmZXI6OnNldEFjdGl2ZShib29sIGFjdGl2ZSkKIAogICAgIG1fYWN0aXZlID0gYWN0 aXZlOwogICAgIG1fcHJpdmF0ZS0+c2V0QWN0aXZlKGFjdGl2ZSk7Ci0gICAgbV9zb3VyY2UtPnNv dXJjZUJ1ZmZlckRpZENoYW5nZUFjaXR2ZVN0YXRlKHRoaXMsIGFjdGl2ZSk7CisgICAgaWYgKCFp c1JlbW92ZWQoKSkKKyAgICAgICAgbV9zb3VyY2UtPnNvdXJjZUJ1ZmZlckRpZENoYW5nZUFjaXR2 ZVN0YXRlKHRoaXMsIGFjdGl2ZSk7CiB9CiAKIHZvaWQgU291cmNlQnVmZmVyOjpzb3VyY2VCdWZm ZXJQcml2YXRlRGlkRW5kU3RyZWFtKFNvdXJjZUJ1ZmZlclByaXZhdGUqLCBjb25zdCBXVEY6OkF0 b21pY1N0cmluZyYgZXJyb3IpCiB7Ci0gICAgbV9zb3VyY2UtPmVuZE9mU3RyZWFtKGVycm9yLCBJ Z25vcmFibGVFeGNlcHRpb25Db2RlKCkpOworICAgIGlmICghaXNSZW1vdmVkKCkpCisgICAgICAg IG1fc291cmNlLT5lbmRPZlN0cmVhbShlcnJvciwgSWdub3JhYmxlRXhjZXB0aW9uQ29kZSgpKTsK IH0KIAogdm9pZCBTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRSZWNlaXZlSW5p dGlhbGl6YXRpb25TZWdtZW50KFNvdXJjZUJ1ZmZlclByaXZhdGUqLCBjb25zdCBJbml0aWFsaXph dGlvblNlZ21lbnQmIHNlZ21lbnQpCkBAIC0xMjAxLDcgKzEyMDYsNyBAQCB2b2lkIFNvdXJjZUJ1 ZmZlcjo6bW9uaXRvckJ1ZmZlcmluZ1JhdGUoKQogCiBib29sIFNvdXJjZUJ1ZmZlcjo6aGFzQ3Vy cmVudFRpbWUoKSBjb25zdAogewotICAgIGlmICghbV9idWZmZXJlZC0+bGVuZ3RoKCkpCisgICAg aWYgKGlzUmVtb3ZlZCgpIHx8ICFtX2J1ZmZlcmVkLT5sZW5ndGgoKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgZG91YmxlIGN1cnJlbnRUaW1lID0gbV9zb3VyY2UtPmN1cnJlbnRUaW1l KCk7CkBAIC0xMjEwLDggKzEyMTUsMTQgQEAgYm9vbCBTb3VyY2VCdWZmZXI6Omhhc0N1cnJlbnRU aW1lKCkgY29uc3QKIAogYm9vbCBTb3VyY2VCdWZmZXI6Omhhc0Z1dHVyZVRpbWUoKSBjb25zdAog eworICAgIGlmIChpc1JlbW92ZWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgZG91 YmxlIGN1cnJlbnRUaW1lID0gbV9zb3VyY2UtPmN1cnJlbnRUaW1lKCk7CiAgICAgY29uc3QgUGxh dGZvcm1UaW1lUmFuZ2VzJiByYW5nZXMgPSBtX2J1ZmZlcmVkLT5yYW5nZXMoKTsKKyAgICBpZiAo IXJhbmdlcy5sZW5ndGgoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgZG91YmxlIG5l YXJlc3QgPSBtX2J1ZmZlcmVkLT5uZWFyZXN0KG1fc291cmNlLT5jdXJyZW50VGltZSgpKTsKICAg ICBpZiAoZmFicyhtX2J1ZmZlcmVkLT5uZWFyZXN0KG1fc291cmNlLT5jdXJyZW50VGltZSgpKSAt IGN1cnJlbnRUaW1lKSA+IEN1cnJlbnRUaW1lRnVkZ2VGYWN0b3IpCiAgICAgICAgIHJldHVybiBm YWxzZTsKQEAgLTEyMjUsNiArMTIzNiw5IEBAIGJvb2wgU291cmNlQnVmZmVyOjpoYXNGdXR1cmVU aW1lKCkgY29uc3QKIAogYm9vbCBTb3VyY2VCdWZmZXI6OmNhblBsYXlUaHJvdWdoKCkKIHsKKyAg ICBpZiAoaXNSZW1vdmVkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIG1vbml0b3JC dWZmZXJpbmdSYXRlKCk7CiAKICAgICAvLyBBc3N1bWluZyBubyBmbHVjdHVhdGlvbnMgaW4gdGhl IGJ1ZmZlcmluZyByYXRlLCBsb2FkaW5nIDEgc2Vjb25kIHBlciBzZWNvbmQgb3IgZ3JlYXRlcgo=