130262 2014-03-14 14:09:02 -0700 Web Inspector: Gracefully handle nil name -[JSContext setName:] 2014-03-14 14:29:52 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue ggaren graouts joepeck mhahnenberg timothy webkit-bug-importer oldest_to_newest 990659 0 joepeck 2014-03-14 14:09:02 -0700 This was causing a crash. It should behave like the underlying JSGlobalContextSetName and not crash, but just clear out the name in JSGlobalObject. 990662 1 joepeck 2014-03-14 14:10:41 -0700 * TEST: JSContext *ctx = [[JSContext alloc] init]; ctx.name = nil; * CRASH: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.CoreFoundation 0x00007fff8e6deb1f CFStringGetLength + 15 1 com.apple.JavaScriptCore 0x00007fff87e87b54 JSStringCreateWithCFString + 36 2 com.apple.JavaScriptCore 0x00007fff88205ac2 -[JSContext setName:] + 34 3 a.out 0x000000010024df36 main + 102 4 libdyld.dylib 0x00007fff90dcd5c9 start + 1 990663 2 226765 joepeck 2014-03-14 14:11:42 -0700 Created attachment 226765 [PATCH] Proposed Fix 990670 3 226765 mhahnenberg 2014-03-14 14:19:25 -0700 Comment on attachment 226765 [PATCH] Proposed Fix r=me 990679 4 226765 commit-queue 2014-03-14 14:29:49 -0700 Comment on attachment 226765 [PATCH] Proposed Fix Clearing flags on attachment: 226765 Committed r165650: <http://trac.webkit.org/changeset/165650> 990680 5 commit-queue 2014-03-14 14:29:52 -0700 All reviewed patches have been landed. Closing bug. 226765 2014-03-14 14:11:42 -0700 2014-03-14 14:29:48 -0700 [PATCH] Proposed Fix nil.patch text/plain 3292 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0Lm1tIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0KaW5kZXggMjc0ZWViOS4uNjllNzM2 MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0KKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0KQEAgLTE5NSw5ICsxOTUs MTAgQEAgLSAoTlNTdHJpbmcgKiluYW1lCiAKIC0gKHZvaWQpc2V0TmFtZTooTlNTdHJpbmcgKilu YW1lCiB7Ci0gICAgSlNTdHJpbmdSZWYgbmFtZUpTID0gSlNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJp bmcoKENGU3RyaW5nUmVmKVtuYW1lIGNvcHldKTsKKyAgICBKU1N0cmluZ1JlZiBuYW1lSlMgPSBu YW1lID8gSlNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoKENGU3RyaW5nUmVmKVtuYW1lIGNvcHld KSA6IG51bGxwdHI7CiAgICAgSlNHbG9iYWxDb250ZXh0U2V0TmFtZShtX2NvbnRleHQsIG5hbWVK Uyk7Ci0gICAgSlNTdHJpbmdSZWxlYXNlKG5hbWVKUyk7CisgICAgaWYgKG5hbWVKUykKKyAgICAg ICAgSlNTdHJpbmdSZWxlYXNlKG5hbWVKUyk7CiB9CiAKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKaW5kZXggZWRmYjJjZC4uYjExZGM1NiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMKQEAgLTEwODMsMTAgKzEwODMsMTMg QEAgc3RhdGljIGJvb2wgZ2xvYmFsQ29udGV4dE5hbWVUZXN0KCkKICAgICBKU1N0cmluZ1JlZiBm ZXRjaE5hbWUxID0gSlNHbG9iYWxDb250ZXh0Q29weU5hbWUoY29udGV4dCk7CiAgICAgSlNHbG9i YWxDb250ZXh0U2V0TmFtZShjb250ZXh0LCBuYW1lMik7CiAgICAgSlNTdHJpbmdSZWYgZmV0Y2hO YW1lMiA9IEpTR2xvYmFsQ29udGV4dENvcHlOYW1lKGNvbnRleHQpOworICAgIEpTR2xvYmFsQ29u dGV4dFNldE5hbWUoY29udGV4dCwgTlVMTCk7CisgICAgSlNTdHJpbmdSZWYgZmV0Y2hOYW1lMyA9 IEpTR2xvYmFsQ29udGV4dENvcHlOYW1lKGNvbnRleHQpOwogCiAgICAgcmVzdWx0ICY9IGFzc2Vy dFRydWUoSlNTdHJpbmdJc0VxdWFsKG5hbWUxLCBmZXRjaE5hbWUxKSwgIlVuZXhwZWN0ZWQgQ29u dGV4dCBuYW1lIik7CiAgICAgcmVzdWx0ICY9IGFzc2VydFRydWUoSlNTdHJpbmdJc0VxdWFsKG5h bWUyLCBmZXRjaE5hbWUyKSwgIlVuZXhwZWN0ZWQgQ29udGV4dCBuYW1lIik7CiAgICAgcmVzdWx0 ICY9IGFzc2VydFRydWUoIUpTU3RyaW5nSXNFcXVhbChmZXRjaE5hbWUxLCBmZXRjaE5hbWUyKSwg IlVuZXhwZWN0ZWQgQ29udGV4dCBuYW1lIik7CisgICAgcmVzdWx0ICY9IGFzc2VydFRydWUoIWZl dGNoTmFtZTMsICJVbmV4cGVjdGVkIENvbnRleHQgbmFtZSIpOwogCiAgICAgSlNTdHJpbmdSZWxl YXNlKG5hbWUxKTsKICAgICBKU1N0cmluZ1JlbGVhc2UobmFtZTIpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCmluZGV4IDVhZGE5ZmIuLjczNmEzM2YgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0KQEAgLTEyODksOSArMTI4 OSwxMiBAQCB2b2lkIHRlc3RPYmplY3RpdmVDQVBJKCkKICAgICAgICAgTlNTdHJpbmcgKmZldGNo ZWROYW1lMSA9IGNvbnRleHQubmFtZTsKICAgICAgICAgY29udGV4dC5uYW1lID0gbmFtZTI7CiAg ICAgICAgIE5TU3RyaW5nICpmZXRjaGVkTmFtZTIgPSBjb250ZXh0Lm5hbWU7CisgICAgICAgIGNv bnRleHQubmFtZSA9IG5pbDsKKyAgICAgICAgTlNTdHJpbmcgKmZldGNoZWROYW1lMyA9IGNvbnRl eHQubmFtZTsKICAgICAgICAgY2hlY2tSZXN1bHQoQCJmZXRjaGVkIGNvbnRleHQubmFtZSB3YXMg ZXhwZWN0ZWQiLCBbZmV0Y2hlZE5hbWUxIGlzRXF1YWxUb1N0cmluZzpuYW1lMV0pOwogICAgICAg ICBjaGVja1Jlc3VsdChAImZldGNoZWQgY29udGV4dC5uYW1lIHdhcyBleHBlY3RlZCIsIFtmZXRj aGVkTmFtZTIgaXNFcXVhbFRvU3RyaW5nOm5hbWUyXSk7CiAgICAgICAgIGNoZWNrUmVzdWx0KEAi ZmV0Y2hlZCBjb250ZXh0Lm5hbWUgd2FzIGV4cGVjdGVkIiwgIVtmZXRjaGVkTmFtZTEgaXNFcXVh bFRvU3RyaW5nOmZldGNoZWROYW1lMl0pOworICAgICAgICBjaGVja1Jlc3VsdChAImZldGNoZWQg Y29udGV4dC5uYW1lIHdhcyBleHBlY3RlZCIsIGZldGNoZWROYW1lMyA9PSBuaWwpOwogICAgIH0K IAogICAgIEBhdXRvcmVsZWFzZXBvb2wgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOGM5 OThhYy4uNWI3N2ZjOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTQtMDMtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBHcmFjZWZ1bGx5IGhhbmRsZSBuaWwgbmFtZSAtW0pTQ29udGV4 dCBzZXROYW1lOl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMDI2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQVBJL0pTQ29udGV4dC5tbToKKyAgICAgICAgKC1bSlNDb250ZXh0IHNldE5hbWU6XSk6 CisgICAgICAgIEdyYWNlZnVsbHkgaGFuZGxlIG5pbCBpbnB1dC4KKworICAgICAgICAqIEFQSS90 ZXN0cy90ZXN0YXBpLmM6CisgICAgICAgIChnbG9iYWxDb250ZXh0TmFtZVRlc3QpOgorICAgICAg ICAqIEFQSS90ZXN0cy90ZXN0YXBpLm1tOgorICAgICAgICBUZXN0IGZvciBuaWwgLyBOVUxMIG5h bWVzIGluIHRoZSBPYmpDIGFuZCBDIEFQSXMuCisKIDIwMTQtMDMtMTIgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEaXNhYmxl IFJFTU9URV9JTlNQRUNUT1IgaW4gZWFybGllciBPUyBYIHJlbGVhc2VzCg==