130261 2014-03-14 13:52:50 -0700 [GTK][CMake] Build with -fno-rtti 2014-08-14 07:31:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan bunhere commit-queue gyuyoung.kim Martin.Jansa rakuco sergio oldest_to_newest 990650 0 zan 2014-03-14 13:52:50 -0700 [GTK][CMake] Build with -fno-rtti 990654 1 226763 zan 2014-03-14 14:02:05 -0700 Created attachment 226763 Patch 990666 2 226763 mrobinson 2014-03-14 14:17:07 -0700 Comment on attachment 226763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226763&action=review > Source/cmake/gtest/CMakeLists.txt:25 > +add_definitions(-DGTEST_CREATE_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0) New line please. > Tools/TestWebKitAPI/CMakeLists.txt:89 > +add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0 New line please. 991022 3 226763 zan 2014-03-16 13:13:52 -0700 Comment on attachment 226763 Patch Clearing flags on attachment: 226763 Committed r165709: <http://trac.webkit.org/changeset/165709> 991023 4 zan 2014-03-16 13:14:03 -0700 All reviewed patches have been landed. Closing bug. 1028941 5 Martin.Jansa 2014-08-13 15:53:47 -0700 + set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing") Is this added line correct? Causes build failures in udis86 which explicitly asks for gcc but then gets g++ flags from CMAKE_CXX_FLAGS. cc1: error: command line option '-fvisibility-inlines-hidden' is valid for C++/ObjC++ but not for C [-Werror] cc1: error: command line option '-fpermissive' is valid for C++/ObjC++ but not for C [-Werror] cc1: all warnings being treated as errors Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/build.make:11182: recipe for target 'Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/disassembler/udis86/udis86.c.o' failed make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/disassembler/udis86/udis86.c.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/OE/build/oe-core/tmp-eglibc/work/core2-64-oe-linux/webkit-efl/1_1.10.0+1.11.0-beta1-r0/build' 1029079 6 zan 2014-08-14 07:31:25 -0700 (In reply to comment #5) > + set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing") > > Is this added line correct? > > Causes build failures in udis86 which explicitly asks for gcc but then gets g++ flags from CMAKE_CXX_FLAGS. Yes, that's not correct. My bad. Fixed in r172579. http://trac.webkit.org/changeset/172579 226763 2014-03-14 14:02:05 -0700 2014-03-16 13:13:52 -0700 Patch bug-130261-20140314140141.patch text/plain 4590 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDU4MjQ5MmM5YjU2MTM4NTZhMTAzODE5NmQxMzhkNGQ5YTM4ODU3N2MuLmQyNWU5MGNkYWI1ZTAz ZDI2MzQ3M2RjNDU4MmE2ZGIxMmZlOWU3MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0yOSw3ICsyOSw5IEBAIGVuZGlmICgpCiBzZXRfcHJvcGVydHkoR0xPQkFMIFBST1BFUlRZIFVT RV9GT0xERVJTIE9OKQogCiBpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ1hYIE9SICIke0NNQUtF X0NYWF9DT01QSUxFUl9JRH0iIFNUUkVRVUFMICJDbGFuZyIpCi0gICAgc2V0KENNQUtFX0NYWF9G TEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1zdGQ9Z251KysweCIpCisgICAgc2V0KENNQUtFX0Nf RkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxp YXNpbmciKQorICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtc3Rk PWMrKzExIC1mbm8tZXhjZXB0aW9ucyAtZm5vLXN0cmljdC1hbGlhc2luZyAtZm5vLXJ0dGkiKQor CiBlbmRpZiAoKQogCiBzdHJpbmcoVE9MT1dFUiAke0NNQUtFX0hPU1RfU1lTVEVNX1BST0NFU1NP Un0gTE9XRVJDQVNFX0NNQUtFX0hPU1RfU1lTVEVNX1BST0NFU1NPUikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBl cnMuY21ha2UKaW5kZXggNWQwOGFkYzdlYzM1OTg2OTM3M2QzNDFiZWQwODZkY2I3NmI4NTU4Mi4u ZTAzNDkzYzVjNmQwNGYyNGYzZDIxZTBiNzhmNDQ2Njg4ZDU2YWFmYiAxMDA2NDQKLS0tIGEvU291 cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhl bHBlcnMuY21ha2UKQEAgLTM1LDggKzM1LDYgQEAgbWFjcm8oV0VCS0lUX1NFVF9FWFRSQV9DT01Q SUxFUl9GTEFHUyBfdGFyZ2V0KQogICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICIt ZlBJQyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAgICAgICAgIGVuZGlmICgpCiAKLSAgICAgICAg c2V0KE9MRF9DT01QSUxFX0ZMQUdTICItZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNp bmcgJHtPTERfQ09NUElMRV9GTEFHU30iKQotCiAgICAgICAgICMgRW5hYmxlIHdhcm5pbmdzIGJ5 IGRlZmF1bHQKICAgICAgICAgaWYgKE5PVCAke09QVElPTl9JR05PUkVDWFhfV0FSTklOR1N9KQog ICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICItV2FsbCAtV2V4dHJhIC1XY2FzdC1h bGlnbiAtV2Zvcm1hdC1zZWN1cml0eSAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV3BvaW50 ZXItYXJpdGggLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3MgJHtPTERfQ09NUElMRV9GTEFHU30iKQpk aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL2d0ZXN0L0NNYWtlTGlzdHMudHh0IGIvU291cmNlL2Nt YWtlL2d0ZXN0L0NNYWtlTGlzdHMudHh0CmluZGV4IDdmNTIxYTg5OGI4OWQ4ZGViMzA5YzZlMGZi YTA4YTMzZjY1ZWI1ZDUuLjgwNGVmM2NlOWMwMjE2YzU5NmMwMDAwNzAwMjRjYzJkN2NhOWVjZDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9ndGVzdC9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3Vy Y2UvY21ha2UvZ3Rlc3QvQ01ha2VMaXN0cy50eHQKQEAgLTIyLDcgKzIyLDcgQEAgYWRkX2xpYnJh cnkoZ3Rlc3QgU0hBUkVECiAgICAgJHtHVEVTVF9ESVJ9L3NyYy9ndGVzdC10eXBlZC10ZXN0LmNj CiApCiAKLWFkZF9kZWZpbml0aW9ucygtREdURVNUX0NSRUFURV9TSEFSRURfTElCUkFSWT0xKQor YWRkX2RlZmluaXRpb25zKC1ER1RFU1RfQ1JFQVRFX1NIQVJFRF9MSUJSQVJZPTEgLURHVEVTVF9I QVNfUlRUST0wKQogCiB0YXJnZXRfbGlua19saWJyYXJpZXMoZ3Rlc3QKICAgICBXVEYKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MDY4YmU3MjBh YzdhNDgyMjAwODQ1Y2MwYzI0YjA1YjhiYTdlZWI1Li4wMzIwNjI3YzExM2QwZGJjYTliYjVkZDQ3 MjdlMjZiOWQ4MDQ2ZDcyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDMtMTQgIFphbiBEb2JlcnNlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW0NNYWtlXSBCdWlsZCB3aXRoIC1m bm8tcnR0aQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMwMjYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL0NNYWtlTGlzdHMudHh0OiBCdWlsZCBUZXN0V2ViS2l0QVBJIHdpdGgg R1RFU1RfSEFTX1JUVEkgbWFjcm8KKyAgICAgICAgZGVmaW5lZCB0byAwIHRvIHByZXZlbnQgdHlw ZWlkIHVzZSBpbiBpbmNsdWRlZCBHVGVzdCBoZWFkZXJzLgorCiAyMDE0LTAzLTE0ICBKaW53b28g U29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtNaW5pQnJv d3Nlcl0gUmV2aXNlIGhlbHAgbWVzc2FnZXMgb2YgY29tbWFuZCBsaW5lIHBhcmFtZXRlcnMKZGlm ZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL0NNYWtlTGlzdHMudHh0CmluZGV4IDllZDQ4ODQ1Y2UzNzg5OGVjMTZlMzRmZmJk MzNiZmM2ZDUwMGM3OGMuLjU1ZDQ3MTZhOWMwOWZiMmRjNGU3NTg4ZDYxOGY0ZDM0ZTQ1ODc3OWUg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dApAQCAtODYsNyArODYsNyBAQCBhZGRfZGVw ZW5kZW5jaWVzKFRlc3RXZWJLaXRBUElJbmplY3RlZEJ1bmRsZSAke0ZvcndhcmRpbmdIZWFkZXJz Rm9yVGVzdFdlYktpdEFQSQogCiBnZXRfcHJvcGVydHkoVGVzdFdlYktpdEFQSUluamVjdGVkQnVu ZGxlX1BBVEggVEFSR0VUIFRlc3RXZWJLaXRBUElJbmplY3RlZEJ1bmRsZSBQUk9QRVJUWSBMT0NB VElPTikKIAotYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfTElOS0VEX0FTX1NIQVJFRF9MSUJSQVJZ PTEKK2FkZF9kZWZpbml0aW9ucygtREdURVNUX0xJTktFRF9BU19TSEFSRURfTElCUkFSWT0xIC1E R1RFU1RfSEFTX1JUVEk9MAogICAgIC1EVEVTVF9XRUJLSVQyX1JFU09VUkNFU19ESVI9XCIke1RF U1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyXCIKICAgICAtRFRFU1RfSU5KRUNURURfQlVO RExFX1BBVEg9XCIke1Rlc3RXZWJLaXRBUElJbmplY3RlZEJ1bmRsZV9QQVRIfVwiCiApCmRpZmYg LS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggN2RlMmM2N2U5ZWQyYmU0YmExNDc0 ZjMzYTQ1MjcxNGZmY2Y0MTAyNS4uMmRhZjc0NDBhMmY3MTY1ZjI5ZTliNGM1YTMyM2JhODYxOWU4 NGE5YSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAzLTE0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXVtDTWFrZV0gQnVpbGQgd2l0aCAtZm5vLXJ0dGkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDI2MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnND b21tb24uY21ha2U6IExpc3QgdGhlIC1mbm8tZXhjZXB0aW9ucywgLWZuby1zdHJpY3QtYWxpYXNp bmcKKyAgICAgICAgYW5kIC1mbm8tcnR0aSBvcHRpb25zIGluIHRoZSBnbG9iYWwgQ01BS0VfQ19G TEFHUyBhbmQgQ01BS0VfQ1hYX0ZMQUdTICgtZm5vLXJ0dGkKKyAgICAgICAgaXMgb25seSBsaXN0 ZWQgaW4gdGhlIGxhdHRlcikuIFJlcGxhY2UgLXN0ZD1nbnUrKzB4IHdpdGggdGhlIG9mZmljaWFs IC1zdGQ9YysrMTEgb3B0aW9uLgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJz LmNtYWtlOiBTdG9wIC1mbm8tZXhjZXB0aW9ucyBhbmQgLWZuby1zdHJpY3QtYWxpYXNpbmcKKyAg ICAgICAgZnJvbSBiZWluZyBzZXQgdGhyb3VnaCB0aGUgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxF Ul9GTEFHUyBtYWNybywgdGhleSBhcmUgbm93IGxpc3RlZAorICAgICAgICBpbiBDTUFLRV9DX0ZM QUdTIGFuZCBDTUFLRV9DWFhfRkxBR1MuCisgICAgICAgICogU291cmNlL2NtYWtlL2d0ZXN0L0NN YWtlTGlzdHMudHh0OiBCdWlsZCBHVGVzdCBjb2RlIHdpdGggR1RFU1RfSEFTX1JUVEkgbWFjcm8g ZGVmaW5lZCB0byAwLgorCiAyMDE0LTAzLTEzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8u cHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0NNYWtlXSBGYWlsdXJlIHRvIGxpbmsgd2l0 aCBvbGRlciBpbnN0YWxsYXRpb25zIG9mIFdlYlAK