130249 2014-03-14 11:00:02 -0700 [CSSRegions]Do not compute region range for a box unless the parent has one 2014-03-16 23:35:59 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 129478 1 mihnea webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 990565 0 mihnea 2014-03-14 11:00:02 -0700 Do not compute region range for a box unless the parent has one because otherwise we may end up with a wrong range leading to undesired effects, like incorrect clipping. 990567 1 226734 mihnea 2014-03-14 11:07:42 -0700 Created attachment 226734 Patch 991000 2 226734 abucur 2014-03-16 11:47:04 -0700 Comment on attachment 226734 Patch r=me 991108 3 226734 commit-queue 2014-03-16 23:35:56 -0700 Comment on attachment 226734 Patch Clearing flags on attachment: 226734 Committed r165720: <http://trac.webkit.org/changeset/165720> 991109 4 commit-queue 2014-03-16 23:35:59 -0700 All reviewed patches have been landed. Closing bug. 226734 2014-03-14 11:07:42 -0700 2014-03-16 23:35:56 -0700 Patch 130249.patch text/plain 7539 mihnea ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NDhiOTFmLi5iY2Q1NWQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTQtMDMt MTQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKKyAgICAgICAgW0NTU1Jl Z2lvbnNdRG8gbm90IGNvbXB1dGUgcmVnaW9uIHJhbmdlIGZvciBhIGJveCB1bmxlc3MgdGhlIHBh cmVudCBoYXMgb25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzAyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3QvcmVnaW9ucy9pbmxpbmUtYmxvY2stZmxvd2VkLWluLXJlZ2lvbnMtZXhwZWN0 ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL2lubGluZS1ibG9jay1mbG93 ZWQtaW4tcmVnaW9ucy5odG1sOiBBZGRlZC4KKworMjAxNC0wMy0xNCAgTWlobmVhIE92aWRlbmll ICA8bWlobmVhQGFkb2JlLmNvbT4KKwogICAgICAgICBbQ1NTUmVnaW9uc10gSW5saW5lLWJsb2Nr IGNoaWxkIG9mIGNvbnRlbnQgbm9kZSBpbmNvcnJlY3RseSBjbGlwcGVkCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAyMjkKIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2lubGluZS1ibG9jay1mbG93ZWQtaW4tcmVnaW9ucy1l eHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2lubGluZS1ibG9jay1mbG93 ZWQtaW4tcmVnaW9ucy1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjFiYzEwZGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lv bnMvaW5saW5lLWJsb2NrLWZsb3dlZC1pbi1yZWdpb25zLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCAr MSwyNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHN0 eWxlPgorICAgICAgICAgICAgI3JlZ2lvbjEgeyBwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTUw cHg7IGxlZnQ6IDEwMHB4OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IH0KKyAgICAgICAg ICAgICNjb250ZW50MSB7IGRpc3BsYXk6IGlubGluZS1ibG9jazsgYmFja2dyb3VuZC1jb2xvcjog cmVkOyB9CisKKyAgICAgICAgICAgICNkaXYxLCAjZGl2MiB7IHdpZHRoOiAxMDBweDsgaGVpZ2h0 OiAxMDBweDsgfQorICAgICAgICAgICAgI2RpdjEgeyBiYWNrZ3JvdW5kLWNvbG9yOiBvcmFuZ2U7 IH0KKyAgICAgICAgICAgICNkaXYyIHsgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47IH0KKyAgICAg ICAgPC9zdHlsZT4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxwPlRlc3QgdGhh dCBhbiBpbmxpbmUgYmxvY2sgY29sbGVjdGVkIGluIGEgbmFtZWQgZmxvdyB3aXRoIDIgcmVnaW9u cyBpcyBwcm9wZXJseSBkaXNwbGF5ZWQuPC9wPgorICAgICAgICA8cD5UaGUgaW5saW5lIGJsb2Nr IHNob3VsZCBiZSBkaXNwbGF5ZWQgb25seSBpbiB0aGUgZmlyc3QgcmVnaW9uLjwvcD4KKyAgICAg ICAgPHA+T24gc3VjY2VzcywgeW91IHNob3VsZCBzZWUgMiByZWN0YW5nbGVzLCB0aGUgZmlyc3Qg b25lIG9yYW5nZSBhbmQgdGhlIHNlY29uZCBvbmUgZ3JlZW4gYW5kIG5vIHJlZC48L3A+CisgICAg ICAgIDxkaXYgaWQ9InJlZ2lvbjEiPgorICAgICAgICAgICAgPGRpdiBpZD0iY29udGVudDEiPgor ICAgICAgICAgICAgICAgIDxkaXYgaWQ9ImRpdjEiPjwvZGl2PgorICAgICAgICAgICAgICAgIDxk aXYgaWQ9ImRpdjIiPjwvZGl2PgorICAgICAgICAgICAgPC9kaXY+CisgICAgICAgIDwvZGl2Pgor ICAgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9u cy9pbmxpbmUtYmxvY2stZmxvd2VkLWluLXJlZ2lvbnMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv cmVnaW9ucy9pbmxpbmUtYmxvY2stZmxvd2VkLWluLXJlZ2lvbnMuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi45NzcwMTZiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9yZWdpb25zL2lubGluZS1ibG9jay1mbG93ZWQtaW4tcmVnaW9ucy5odG1sCkBA IC0wLDAgKzEsMjYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAg ICAgIDxzdHlsZT4KKyAgICAgICAgICAgICNyZWdpb24xIHsgLXdlYmtpdC1mbG93LWZyb206IGZs b3c7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAxNTBweDsgbGVmdDogMTAwcHg7IHdpZHRoOiAx MDBweDsgaGVpZ2h0OiAxMDBweDsgfQorICAgICAgICAgICAgI3JlZ2lvbjIgeyAtd2Via2l0LWZs b3ctZnJvbTogZmxvdzsgcG9zaXRpb246IGFic29sdXRlOyB0b3A6IDE1MHB4OyBsZWZ0OiAzMDBw eDsgd2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyB9CisKKyAgICAgICAgICAgICNjb250ZW50 MSB7IC13ZWJraXQtZmxvdy1pbnRvOiBmbG93OyBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7IGJhY2tn cm91bmQtY29sb3I6IHJlZDsgfQorCisgICAgICAgICAgICAjZGl2MSwgI2RpdjIgeyB3aWR0aDog MTAwcHg7IGhlaWdodDogMTAwcHg7IH0KKyAgICAgICAgICAgICNkaXYxIHsgYmFja2dyb3VuZC1j b2xvcjogb3JhbmdlOyB9CisgICAgICAgICAgICAjZGl2MiB7IGJhY2tncm91bmQtY29sb3I6IGdy ZWVuOyB9CisgICAgICAgIDwvc3R5bGU+CisgICAgPC9oZWFkPgorICAgIDxib2R5PgorICAgICAg ICA8cD5UZXN0IHRoYXQgYW4gaW5saW5lIGJsb2NrIGNvbGxlY3RlZCBpbiBhIG5hbWVkIGZsb3cg d2l0aCAyIHJlZ2lvbnMgaXMgcHJvcGVybHkgZGlzcGxheWVkLjwvcD4KKyAgICAgICAgPHA+VGhl IGlubGluZSBibG9jayBzaG91bGQgYmUgZGlzcGxheWVkIG9ubHkgaW4gdGhlIGZpcnN0IHJlZ2lv bi48L3A+CisgICAgICAgIDxwPk9uIHN1Y2Nlc3MsIHlvdSBzaG91bGQgc2VlIDIgcmVjdGFuZ2xl cywgdGhlIGZpcnN0IG9uZSBvcmFuZ2UgYW5kIHRoZSBzZWNvbmQgb25lIGdyZWVuIGFuZCBubyBy ZWQuPC9wPgorICAgICAgICA8ZGl2IGlkPSJyZWdpb24xIj48L2Rpdj4KKyAgICAgICAgPGRpdiBp ZD0icmVnaW9uMiI+PC9kaXY+CisgICAgICAgIDxkaXYgaWQ9ImNvbnRlbnQxIj4KKyAgICAgICAg ICAgIDxkaXYgaWQ9ImRpdjEiPjwvZGl2PgorICAgICAgICAgICAgPGRpdiBpZD0iZGl2MiI+PC9k aXY+CisgICAgICAgIDwvZGl2PgorICAgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBl YjE3ZTcyLi5mZWEyM2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTQtMDMtMTQg IE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKKyAgICAgICAgW0NTU1JlZ2lv bnNdRG8gbm90IGNvbXB1dGUgcmVnaW9uIHJhbmdlIGZvciBhIGJveCB1bmxlc3MgdGhlIHBhcmVu dCBoYXMgb25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzAyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZiB0aGUgY29udGFpbmluZyBibG9jayBkb2VzIG5vdCBoYXZlIGEgcmVnaW9uIHJhbmdlIGNv bXB1dGVkLCBkbyBub3QgYXR0ZW1wdCB0byBjb21wdXRlCisgICAgICAgIGEgcmVnaW9uIHJhbmdl IGZvciBhIGNoaWxkLiBJbiBzdWNoIGNhc2VzLCB0aGUgcmFuZ2UgY29tcHV0YXRpb24gZm9yIGEg Y2hpbGQgY2FuIGxlYWQgdG8KKyAgICAgICAgYSByZXN1bHQgdGhhdCBpcyB3cm9uZywgcG9zc2li bHkgbGVhZGluZyB0byBhbiBpbmNvcnJlY3QgY2xpcHBpbmcuCisKKyAgICAgICAgVGVzdDogZmFz dC9yZWdpb25zL2lubGluZS1ibG9jay1mbG93ZWQtaW4tcmVnaW9ucy5odG1sCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FuQ29tcHV0 ZVJlZ2lvblJhbmdlRm9yQm94KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpjb21w dXRlUmVnaW9uUmFuZ2VGb3JCb3hDaGlsZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9j azo6ZXN0aW1hdGVSZWdpb25SYW5nZUZvckJveENoaWxkKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrOjp1cGRhdGVSZWdpb25SYW5nZUZvckJveENoaWxkKToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oOgorCisyMDE0LTAzLTE0ICBNaWhuZWEgT3ZpZGVuaWUg IDxtaWhuZWFAYWRvYmUuY29tPgorCiAgICAgICAgIFtDU1NSZWdpb25zXSBJbmxpbmUtYmxvY2sg Y2hpbGQgb2YgY29udGVudCBub2RlIGluY29ycmVjdGx5IGNsaXBwZWQKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDIyOQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCAyNzk3NzI3Li4zYmNkYTcyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTUwMzcsMTEgKzUwMzcsMjcg QEAgUmVuZGVyUmVnaW9uKiBSZW5kZXJCbG9jazo6cmVnaW9uQXRCbG9ja09mZnNldChMYXlvdXRV bml0IGJsb2NrT2Zmc2V0KSBjb25zdAogICAgIHJldHVybiBmbG93VGhyZWFkLT5yZWdpb25BdEJs b2NrT2Zmc2V0KHRoaXMsIG9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFBhZ2UoKSArIGJsb2Nr T2Zmc2V0LCB0cnVlKTsKIH0KIAorc3RhdGljIGJvb2wgY2FuQ29tcHV0ZVJlZ2lvblJhbmdlRm9y Qm94KGNvbnN0IFJlbmRlckJsb2NrKiBwYXJlbnRCbG9jaywgY29uc3QgUmVuZGVyQm94JiBjaGls ZEJveCwgY29uc3QgUmVuZGVyRmxvd1RocmVhZCogZmxvd1RocmVhZENvbnRhaW5pbmdCbG9jaykK K3sKKyAgICBBU1NFUlQocGFyZW50QmxvY2spOworICAgIEFTU0VSVCghY2hpbGRCb3guaXNSZW5k ZXJGbG93VGhyZWFkKCkpOworCisgICAgaWYgKCFmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIWZsb3dUaHJlYWRDb250YWluaW5nQmxv Y2stPmhhc1JlZ2lvbnMoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFjaGls ZEJveC5jYW5IYXZlT3V0c2lkZVJlZ2lvblJhbmdlKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIHJldHVybiBmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrLT5oYXNSZWdpb25SYW5nZUZv ckJveChwYXJlbnRCbG9jayk7Cit9CisKIHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVSZWdpb25S YW5nZUZvckJveENoaWxkKGNvbnN0IFJlbmRlckJveCYgYm94KSBjb25zdAogewogICAgIFJlbmRl ckZsb3dUaHJlYWQqIGZsb3dUaHJlYWQgPSBmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrKCk7Ci0g ICAgaWYgKCFmbG93VGhyZWFkIHx8ICFmbG93VGhyZWFkLT5oYXNSZWdpb25zKCkpCi0gICAgICAg IHJldHVybjsKKyAgICBBU1NFUlQoY2FuQ29tcHV0ZVJlZ2lvblJhbmdlRm9yQm94KHRoaXMsIGJv eCwgZmxvd1RocmVhZCkpOwogCiAgICAgUmVuZGVyUmVnaW9uKiBzdGFydFJlZ2lvbjsKICAgICBS ZW5kZXJSZWdpb24qIGVuZFJlZ2lvbjsKQEAgLTUwNTksNyArNTA3NSw3IEBAIHZvaWQgUmVuZGVy QmxvY2s6OmNvbXB1dGVSZWdpb25SYW5nZUZvckJveENoaWxkKGNvbnN0IFJlbmRlckJveCYgYm94 KSBjb25zdAogdm9pZCBSZW5kZXJCbG9jazo6ZXN0aW1hdGVSZWdpb25SYW5nZUZvckJveENoaWxk KGNvbnN0IFJlbmRlckJveCYgYm94KSBjb25zdAogewogICAgIFJlbmRlckZsb3dUaHJlYWQqIGZs b3dUaHJlYWQgPSBmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrKCk7Ci0gICAgaWYgKCFmbG93VGhy ZWFkIHx8ICFmbG93VGhyZWFkLT5oYXNSZWdpb25zKCkgfHwgIWJveC5jYW5IYXZlT3V0c2lkZVJl Z2lvblJhbmdlKCkpCisgICAgaWYgKCFjYW5Db21wdXRlUmVnaW9uUmFuZ2VGb3JCb3godGhpcywg Ym94LCBmbG93VGhyZWFkKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKGJveC5pc1Vuc3Bs aXR0YWJsZUZvclBhZ2luYXRpb24oKSkgewpAQCAtNTA4MCw3ICs1MDk2LDcgQEAgdm9pZCBSZW5k ZXJCbG9jazo6ZXN0aW1hdGVSZWdpb25SYW5nZUZvckJveENoaWxkKGNvbnN0IFJlbmRlckJveCYg Ym94KSBjb25zdAogYm9vbCBSZW5kZXJCbG9jazo6dXBkYXRlUmVnaW9uUmFuZ2VGb3JCb3hDaGls ZChjb25zdCBSZW5kZXJCb3gmIGJveCkgY29uc3QKIHsKICAgICBSZW5kZXJGbG93VGhyZWFkKiBm bG93VGhyZWFkID0gZmxvd1RocmVhZENvbnRhaW5pbmdCbG9jaygpOwotICAgIGlmICghZmxvd1Ro cmVhZCB8fCAhZmxvd1RocmVhZC0+aGFzUmVnaW9ucygpIHx8ICFib3guY2FuSGF2ZU91dHNpZGVS ZWdpb25SYW5nZSgpKQorICAgIGlmICghY2FuQ29tcHV0ZVJlZ2lvblJhbmdlRm9yQm94KHRoaXMs IGJveCwgZmxvd1RocmVhZCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIFJlbmRlclJl Z2lvbiogc3RhcnRSZWdpb24gPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckZsb3dUaHJlYWQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bG93VGhyZWFkLmgKaW5kZXggODIzYWM5Zi4uMmUzMWEyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5oCkBAIC0xMjQsNiArMTI0LDcgQEAgcHVibGljOgog CiAgICAgdm9pZCBzZXRSZWdpb25SYW5nZUZvckJveChjb25zdCBSZW5kZXJCb3gqLCBSZW5kZXJS ZWdpb24qLCBSZW5kZXJSZWdpb24qKTsKICAgICB2b2lkIGdldFJlZ2lvblJhbmdlRm9yQm94KGNv bnN0IFJlbmRlckJveCosIFJlbmRlclJlZ2lvbiomIHN0YXJ0UmVnaW9uLCBSZW5kZXJSZWdpb24q JiBlbmRSZWdpb24pIGNvbnN0OworICAgIGJvb2wgaGFzUmVnaW9uUmFuZ2VGb3JCb3goY29uc3Qg UmVuZGVyQm94KiBib3gpIGNvbnN0IHsgQVNTRVJUKGJveCk7IHJldHVybiBtX3JlZ2lvblJhbmdl TWFwLmNvbnRhaW5zKGJveCk7IH0KIAogICAgIC8vIENoZWNrIGlmIHRoZSBvYmplY3QgaXMgaW4g cmVnaW9uIGFuZCB0aGUgcmVnaW9uIGlzIHBhcnQgb2YgdGhpcyBmbG93IHRocmVhZC4KICAgICBi b29sIG9iamVjdEluRmxvd1JlZ2lvbihjb25zdCBSZW5kZXJPYmplY3QqLCBjb25zdCBSZW5kZXJS ZWdpb24qKSBjb25zdDsK