130241 2014-03-14 09:01:12 -0700 Refactor checking log channel state in MediaPlayerPrivateGStreamerBase. 2014-03-20 03:07:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pmolnar.u-szeged pmolnar.u-szeged agomez calvaris cgarcia commit-queue eric.carlson glenn gustavo jer.noble menard mrobinson philipj pnormand sergio vjaquez oldest_to_newest 990503 0 pmolnar.u-szeged 2014-03-14 09:01:12 -0700 The channel is passed around only to check its state. Clean this up by adding a method to check whether a log channel is enabled. 990506 1 226723 pmolnar.u-szeged 2014-03-14 09:02:29 -0700 Created attachment 226723 patch 990511 2 226723 pnormand 2014-03-14 09:08:08 -0700 Comment on attachment 226723 patch View in context: https://bugs.webkit.org/attachment.cgi?id=226723&action=review > Source/WebCore/platform/Logging.cpp:50 > + WTFLogChannel* channel = WTFLogChannelByName(logChannels, logChannelCount, name.utf8().data()); Would be good to check the channel is not null. 991171 3 226901 pmolnar.u-szeged 2014-03-17 03:31:17 -0700 Created attachment 226901 patch (In reply to comment #2) > (From update of attachment 226723 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226723&action=review > > > Source/WebCore/platform/Logging.cpp:50 > > + WTFLogChannel* channel = WTFLogChannelByName(logChannels, logChannelCount, name.utf8().data()); > > Would be good to check the channel is not null. Added null check. 991172 4 commit-queue 2014-03-17 03:33:09 -0700 Attachment 226901 did not pass style-queue: ERROR: Source/WebCore/platform/Logging.h:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/Logging.cpp:53: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 991176 5 226902 pmolnar.u-szeged 2014-03-17 04:10:51 -0700 Created attachment 226902 patch - fixed style (In reply to comment #4) > Attachment 226901 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/Logging.h:83: Code inside a namespace should not be indented. [whitespace/indent] [4] I'm not quite sure about this style error. The exactly same change in this file passed a few days ago. Someone upgraded the stlye checker? :) Should I fix the indentation in the whole file, even the lines not touched by this patch? > ERROR: Source/WebCore/platform/Logging.cpp:53: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Fixed. 991177 6 commit-queue 2014-03-17 04:12:17 -0700 Attachment 226902 did not pass style-queue: ERROR: Source/WebCore/platform/Logging.h:83: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 991793 7 226902 pnormand 2014-03-18 12:35:01 -0700 Comment on attachment 226902 patch - fixed style View in context: https://bugs.webkit.org/attachment.cgi?id=226902&action=review This is basically good but the logChannelEnabled local variable can easily be avoided, we like early returns in WebKit :) > Source/WebCore/platform/Logging.cpp:53 > + if (channel) This can be transformed to an early return: if (!channel) return false; and then below return channel->state != WTFLogChannelOff; So no need for a local variable 992053 8 227168 pmolnar.u-szeged 2014-03-19 02:01:13 -0700 Created attachment 227168 patch (In reply to comment #7) > (From update of attachment 226902 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226902&action=review > > This is basically good but the logChannelEnabled local variable can easily be avoided, we like early returns in WebKit :) Thank you for the correction, it looks nicer indeed :) > > > Source/WebCore/platform/Logging.cpp:53 > > + if (channel) > > This can be transformed to an early return: if (!channel) return false; > > and then below return channel->state != WTFLogChannelOff; > So no need for a local variable 992054 9 commit-queue 2014-03-19 02:04:10 -0700 Attachment 227168 did not pass style-queue: ERROR: Source/WebCore/platform/Logging.h:83: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 992459 10 227168 commit-queue 2014-03-20 03:07:29 -0700 Comment on attachment 227168 patch Clearing flags on attachment: 227168 Committed r165955: <http://trac.webkit.org/changeset/165955> 992460 11 commit-queue 2014-03-20 03:07:36 -0700 All reviewed patches have been landed. Closing bug. 226723 2014-03-14 09:02:29 -0700 2014-03-17 03:31:17 -0700 patch log-channel-enabled.patch text/plain 2949 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OTU1NzM5Li44Y2RjOTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDMtMTQgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBSZWZhY3RvciBjaGVja2luZyBsb2cgY2hhbm5lbCBzdGF0 ZSBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5uZWwgd2FzIHBhc3NlZCBhcm91 bmQgb25seSB0byBjaGVjayBpdHMgc3RhdGUuIENsZWFuZWQgdGhpcyB1cAorICAgICAgICBieSBh ZGRpbmcgYSBtZXRob2QgdG8gY2hlY2sgd2hldGhlciBhIGxvZyBjaGFubmVsIGlzIGVuYWJsZWQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omlz TG9nQ2hhbm5lbEVuYWJsZWQpOgorICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmspOgorCiAyMDE0LTAzLTE0ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4 IGFmdGVyIHIxNjU2MDcuIFRoZXJlIHdlcmUgdHdvIG1pc3NpbmcgcmVwbGFjZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0xvZ2dpbmcuY3BwCmluZGV4IGMyODQzMjIuLmNiYzg3YzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0xvZ2dpbmcuY3BwCkBAIC00NSw5ICs0NSwxMCBAQCBXVEZMb2dDaGFubmVsKiBs b2dDaGFubmVsc1tdID0gewogCiBzaXplX3QgbG9nQ2hhbm5lbENvdW50ID0gV1RGX0FSUkFZX0xF TkdUSChsb2dDaGFubmVscyk7CiAKLVdURkxvZ0NoYW5uZWwqIGxvZ0NoYW5uZWxCeU5hbWUoY29u c3QgU3RyaW5nJiBuYW1lKQorYm9vbCBpc0xvZ0NoYW5uZWxFbmFibGVkKGNvbnN0IFN0cmluZyYg bmFtZSkKIHsKLSAgICByZXR1cm4gV1RGTG9nQ2hhbm5lbEJ5TmFtZShsb2dDaGFubmVscywgbG9n Q2hhbm5lbENvdW50LCBuYW1lLnV0ZjgoKS5kYXRhKCkpOworICAgIFdURkxvZ0NoYW5uZWwqIGNo YW5uZWwgPSBXVEZMb2dDaGFubmVsQnlOYW1lKGxvZ0NoYW5uZWxzLCBsb2dDaGFubmVsQ291bnQs IG5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgcmV0dXJuIGNoYW5uZWwtPnN0YXRlICE9IFdURkxv Z0NoYW5uZWxPZmY7CiB9CiAKIHZvaWQgaW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVsc0lmTmVjZXNz YXJ5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaAppbmRleCA5MDYyNDgyLi4xOGEwYzIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCkBAIC04Myw3ICs4Myw3IEBAIFdFQkNPUkVfTE9H X0NIQU5ORUxTKERFQ0xBUkVfTE9HX0NIQU5ORUwpCiAgICAgZXh0ZXJuIHNpemVfdCBsb2dDaGFu bmVsQ291bnQ7CiAKICAgICBTdHJpbmcgbG9nTGV2ZWxTdHJpbmcoKTsKLSAgICBXVEZMb2dDaGFu bmVsKiBsb2dDaGFubmVsQnlOYW1lKGNvbnN0IFN0cmluZyYpOworICAgIGJvb2wgaXNMb2dDaGFu bmVsRW5hYmxlZChjb25zdCBTdHJpbmcmIG5hbWUpOwogICAgIHZvaWQgaW5pdGlhbGl6ZUxvZ2dp bmdDaGFubmVsc0lmTmVjZXNzYXJ5KCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCA4NWNjMzE1Li5iNmVhMjAyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2Uu Y3BwCkBAIC00NjYsOCArNDY2LDcgQEAgR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5rKCkKICNpZiBMT0dfRElTQUJMRUQKICAgICAgICAg Z19vYmplY3Rfc2V0KG1fZnBzU2luay5nZXQoKSwgInRleHQtb3ZlcmxheSIsIEZBTFNFICwgbnVs bHB0cik7CiAjZWxzZQotICAgICAgICBXVEZMb2dDaGFubmVsKiBjaGFubmVsID0gbG9nQ2hhbm5l bEJ5TmFtZSgiTWVkaWEiKTsKLSAgICAgICAgaWYgKGNoYW5uZWwtPnN0YXRlICE9IFdURkxvZ0No YW5uZWxPbikKKyAgICAgICAgaWYgKCFpc0xvZ0NoYW5uZWxFbmFibGVkKCJNZWRpYSIpKQogICAg ICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luay5nZXQoKSwgInRleHQtb3ZlcmxheSIsIEZB TFNFICwgbnVsbHB0cik7CiAjZW5kaWYgLy8gTE9HX0RJU0FCTEVECiAK 226901 2014-03-17 03:31:17 -0700 2014-03-17 04:10:51 -0700 patch log-channel-enabled-v2.patch text/plain 2995 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OTU1NzM5Li44Y2RjOTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDMtMTQgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBSZWZhY3RvciBjaGVja2luZyBsb2cgY2hhbm5lbCBzdGF0 ZSBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5uZWwgd2FzIHBhc3NlZCBhcm91 bmQgb25seSB0byBjaGVjayBpdHMgc3RhdGUuIENsZWFuZWQgdGhpcyB1cAorICAgICAgICBieSBh ZGRpbmcgYSBtZXRob2QgdG8gY2hlY2sgd2hldGhlciBhIGxvZyBjaGFubmVsIGlzIGVuYWJsZWQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omlz TG9nQ2hhbm5lbEVuYWJsZWQpOgorICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmspOgorCiAyMDE0LTAzLTE0ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4 IGFmdGVyIHIxNjU2MDcuIFRoZXJlIHdlcmUgdHdvIG1pc3NpbmcgcmVwbGFjZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0xvZ2dpbmcuY3BwCmluZGV4IGMyODQzMjIuLmQwZGNiZTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0xvZ2dpbmcuY3BwCkBAIC00NSw5ICs0NSwxMiBAQCBXVEZMb2dDaGFubmVsKiBs b2dDaGFubmVsc1tdID0gewogCiBzaXplX3QgbG9nQ2hhbm5lbENvdW50ID0gV1RGX0FSUkFZX0xF TkdUSChsb2dDaGFubmVscyk7CiAKLVdURkxvZ0NoYW5uZWwqIGxvZ0NoYW5uZWxCeU5hbWUoY29u c3QgU3RyaW5nJiBuYW1lKQorYm9vbCBpc0xvZ0NoYW5uZWxFbmFibGVkKGNvbnN0IFN0cmluZyYg bmFtZSkKIHsKLSAgICByZXR1cm4gV1RGTG9nQ2hhbm5lbEJ5TmFtZShsb2dDaGFubmVscywgbG9n Q2hhbm5lbENvdW50LCBuYW1lLnV0ZjgoKS5kYXRhKCkpOworICAgIFdURkxvZ0NoYW5uZWwqIGNo YW5uZWwgPSBXVEZMb2dDaGFubmVsQnlOYW1lKGxvZ0NoYW5uZWxzLCBsb2dDaGFubmVsQ291bnQs IG5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgaWYgKGNoYW5uZWwpCisgICAgICAgIHJldHVybiBj aGFubmVsLT5zdGF0ZSAhPSBXVEZMb2dDaGFubmVsT2ZmOworICAgIGVsc2UgcmV0dXJuIGZhbHNl OwogfQogCiB2b2lkIGluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2FyeSgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggOTA2MjQ4Mi4uMThhMGMyMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0xvZ2dpbmcuaApAQCAtODMsNyArODMsNyBAQCBXRUJDT1JFX0xPR19DSEFOTkVMUyhE RUNMQVJFX0xPR19DSEFOTkVMKQogICAgIGV4dGVybiBzaXplX3QgbG9nQ2hhbm5lbENvdW50Owog CiAgICAgU3RyaW5nIGxvZ0xldmVsU3RyaW5nKCk7Ci0gICAgV1RGTG9nQ2hhbm5lbCogbG9nQ2hh bm5lbEJ5TmFtZShjb25zdCBTdHJpbmcmKTsKKyAgICBib29sIGlzTG9nQ2hhbm5lbEVuYWJsZWQo Y29uc3QgU3RyaW5nJiBuYW1lKTsKICAgICB2b2lkIGluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHNJ Zk5lY2Vzc2FyeSgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggODVjYzMxNS4uYjZlYTIwMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcApAQCAtNDY2 LDggKzQ2Niw3IEBAIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6 OmNyZWF0ZVZpZGVvU2luaygpCiAjaWYgTE9HX0RJU0FCTEVECiAgICAgICAgIGdfb2JqZWN0X3Nl dChtX2Zwc1NpbmsuZ2V0KCksICJ0ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIG51bGxwdHIpOwogI2Vs c2UKLSAgICAgICAgV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGxvZ0NoYW5uZWxCeU5hbWUoIk1l ZGlhIik7Ci0gICAgICAgIGlmIChjaGFubmVsLT5zdGF0ZSAhPSBXVEZMb2dDaGFubmVsT24pCisg ICAgICAgIGlmICghaXNMb2dDaGFubmVsRW5hYmxlZCgiTWVkaWEiKSkKICAgICAgICAgICAgIGdf b2JqZWN0X3NldChtX2Zwc1NpbmsuZ2V0KCksICJ0ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIG51bGxw dHIpOwogI2VuZGlmIC8vIExPR19ESVNBQkxFRAogCg== 226902 2014-03-17 04:10:51 -0700 2014-03-19 02:01:13 -0700 patch - fixed style log-channel-enabled-v2-fixed.patch text/plain 3055 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NjI2ODUwLi4xOTYzYmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDMtMTcgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBSZWZhY3RvciBjaGVja2luZyBsb2cgY2hhbm5lbCBzdGF0 ZSBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5uZWwgd2FzIHBhc3NlZCBhcm91 bmQgb25seSB0byBjaGVjayBpdHMgc3RhdGUuIENsZWFuZWQgdGhpcyB1cAorICAgICAgICBieSBh ZGRpbmcgYSBtZXRob2QgdG8gY2hlY2sgd2hldGhlciBhIGxvZyBjaGFubmVsIGlzIGVuYWJsZWQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omlz TG9nQ2hhbm5lbEVuYWJsZWQpOgorICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmspOgorCiAyMDE0LTAzLTE3ICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIGRlcHJlY2F0ZWRDaGFyYWN0ZXJz IGluIEhUTUxUcmVlQnVpbGRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v TG9nZ2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNwcAppbmRleCAz Y2U0NmVlLi5jNjBiYzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dn aW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNwcApAQCAtNDUs OSArNDUsMTYgQEAgV1RGTG9nQ2hhbm5lbCogbG9nQ2hhbm5lbHNbXSA9IHsKIAogc2l6ZV90IGxv Z0NoYW5uZWxDb3VudCA9IFdURl9BUlJBWV9MRU5HVEgobG9nQ2hhbm5lbHMpOwogCi1XVEZMb2dD aGFubmVsKiBsb2dDaGFubmVsQnlOYW1lKGNvbnN0IFN0cmluZyYgbmFtZSkKK2Jvb2wgaXNMb2dD aGFubmVsRW5hYmxlZChjb25zdCBTdHJpbmcmIG5hbWUpCiB7Ci0gICAgcmV0dXJuIFdURkxvZ0No YW5uZWxCeU5hbWUobG9nQ2hhbm5lbHMsIGxvZ0NoYW5uZWxDb3VudCwgbmFtZS51dGY4KCkuZGF0 YSgpKTsKKyAgICBib29sIGxvZ0NoYW5uZWxFbmFibGVkOworCisgICAgV1RGTG9nQ2hhbm5lbCog Y2hhbm5lbCA9IFdURkxvZ0NoYW5uZWxCeU5hbWUobG9nQ2hhbm5lbHMsIGxvZ0NoYW5uZWxDb3Vu dCwgbmFtZS51dGY4KCkuZGF0YSgpKTsKKyAgICBpZiAoY2hhbm5lbCkKKyAgICAgICAgbG9nQ2hh bm5lbEVuYWJsZWQgPSBjaGFubmVsLT5zdGF0ZSAhPSBXVEZMb2dDaGFubmVsT2ZmOworICAgIGVs c2UKKyAgICAgICAgbG9nQ2hhbm5lbEVuYWJsZWQgPSBmYWxzZTsKKyAgICByZXR1cm4gbG9nQ2hh bm5lbEVuYWJsZWQ7CiB9CiAKIHZvaWQgaW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVsc0lmTmVjZXNz YXJ5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaAppbmRleCAzYzg2ZjRlLi4yYWVhMTU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCkBAIC04MCw3ICs4MCw3IEBAIFdFQkNPUkVfTE9H X0NIQU5ORUxTKERFQ0xBUkVfTE9HX0NIQU5ORUwpCiAjdW5kZWYgREVDTEFSRV9MT0dfQ0hBTk5F TAogCiAgICAgU3RyaW5nIGxvZ0xldmVsU3RyaW5nKCk7Ci0gICAgV1RGTG9nQ2hhbm5lbCogbG9n Q2hhbm5lbEJ5TmFtZShjb25zdCBTdHJpbmcmKTsKKyAgICBib29sIGlzTG9nQ2hhbm5lbEVuYWJs ZWQoY29uc3QgU3RyaW5nJiBuYW1lKTsKICAgICB2b2lkIGluaXRpYWxpemVMb2dnaW5nQ2hhbm5l bHNJZk5lY2Vzc2FyeSgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggODVjYzMxNS4uYjZlYTIwMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcApAQCAt NDY2LDggKzQ2Niw3IEBAIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2U6OmNyZWF0ZVZpZGVvU2luaygpCiAjaWYgTE9HX0RJU0FCTEVECiAgICAgICAgIGdfb2JqZWN0 X3NldChtX2Zwc1NpbmsuZ2V0KCksICJ0ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIG51bGxwdHIpOwog I2Vsc2UKLSAgICAgICAgV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGxvZ0NoYW5uZWxCeU5hbWUo Ik1lZGlhIik7Ci0gICAgICAgIGlmIChjaGFubmVsLT5zdGF0ZSAhPSBXVEZMb2dDaGFubmVsT24p CisgICAgICAgIGlmICghaXNMb2dDaGFubmVsRW5hYmxlZCgiTWVkaWEiKSkKICAgICAgICAgICAg IGdfb2JqZWN0X3NldChtX2Zwc1NpbmsuZ2V0KCksICJ0ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIG51 bGxwdHIpOwogI2VuZGlmIC8vIExPR19ESVNBQkxFRAogCg== 227168 2014-03-19 02:01:13 -0700 2014-03-20 03:07:29 -0700 patch log-channel-enabled-v3.patch text/plain 2948 pmolnar.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNzE4Njk0Li5mY2U0Zjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDMtMTkgIFBldGVyIE1vbG5hciAgPHBtb2xuYXIudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBSZWZhY3RvciBjaGVja2luZyBsb2cgY2hhbm5lbCBzdGF0 ZSBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5uZWwgd2FzIHBhc3NlZCBhcm91 bmQgb25seSB0byBjaGVjayBpdHMgc3RhdGUuIENsZWFuZWQgdGhpcyB1cAorICAgICAgICBieSBh ZGRpbmcgYSBtZXRob2QgdG8gY2hlY2sgd2hldGhlciBhIGxvZyBjaGFubmVsIGlzIGVuYWJsZWQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omlz TG9nQ2hhbm5lbEVuYWJsZWQpOgorICAgICAgICAqIHBsYXRmb3JtL0xvZ2dpbmcuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmspOgorCiAyMDE0LTAzLTE5ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV3cml0ZSBXZWJIVE1MQ29udmVydGVyOjpfY29sb3JG b3JOb2RlIGluIEMrKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2lu Zy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNwcAppbmRleCAzY2U0NmVl Li44NDllNWM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmNwcApAQCAtNDUsOSArNDUs MTIgQEAgV1RGTG9nQ2hhbm5lbCogbG9nQ2hhbm5lbHNbXSA9IHsKIAogc2l6ZV90IGxvZ0NoYW5u ZWxDb3VudCA9IFdURl9BUlJBWV9MRU5HVEgobG9nQ2hhbm5lbHMpOwogCi1XVEZMb2dDaGFubmVs KiBsb2dDaGFubmVsQnlOYW1lKGNvbnN0IFN0cmluZyYgbmFtZSkKK2Jvb2wgaXNMb2dDaGFubmVs RW5hYmxlZChjb25zdCBTdHJpbmcmIG5hbWUpCiB7Ci0gICAgcmV0dXJuIFdURkxvZ0NoYW5uZWxC eU5hbWUobG9nQ2hhbm5lbHMsIGxvZ0NoYW5uZWxDb3VudCwgbmFtZS51dGY4KCkuZGF0YSgpKTsK KyAgICBXVEZMb2dDaGFubmVsKiBjaGFubmVsID0gV1RGTG9nQ2hhbm5lbEJ5TmFtZShsb2dDaGFu bmVscywgbG9nQ2hhbm5lbENvdW50LCBuYW1lLnV0ZjgoKS5kYXRhKCkpOworICAgIGlmICghY2hh bm5lbCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBjaGFubmVsLT5zdGF0ZSAh PSBXVEZMb2dDaGFubmVsT2ZmOwogfQogCiB2b2lkIGluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHNJ Zk5lY2Vzc2FyeSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5n LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggM2M4NmY0ZS4uMmFl YTE1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApAQCAtODAsNyArODAsNyBAQCBXRUJD T1JFX0xPR19DSEFOTkVMUyhERUNMQVJFX0xPR19DSEFOTkVMKQogI3VuZGVmIERFQ0xBUkVfTE9H X0NIQU5ORUwKIAogICAgIFN0cmluZyBsb2dMZXZlbFN0cmluZygpOwotICAgIFdURkxvZ0NoYW5u ZWwqIGxvZ0NoYW5uZWxCeU5hbWUoY29uc3QgU3RyaW5nJik7CisgICAgYm9vbCBpc0xvZ0NoYW5u ZWxFbmFibGVkKGNvbnN0IFN0cmluZyYgbmFtZSk7CiAgICAgdm9pZCBpbml0aWFsaXplTG9nZ2lu Z0NoYW5uZWxzSWZOZWNlc3NhcnkoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IDg1Y2MzMTUuLmI2ZWEyMDIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5j cHAKQEAgLTQ2Niw4ICs0NjYsNyBAQCBHc3RFbGVtZW50KiBNZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoKQogI2lmIExPR19ESVNBQkxFRAogICAgICAgICBn X29iamVjdF9zZXQobV9mcHNTaW5rLmdldCgpLCAidGV4dC1vdmVybGF5IiwgRkFMU0UgLCBudWxs cHRyKTsKICNlbHNlCi0gICAgICAgIFdURkxvZ0NoYW5uZWwqIGNoYW5uZWwgPSBsb2dDaGFubmVs QnlOYW1lKCJNZWRpYSIpOwotICAgICAgICBpZiAoY2hhbm5lbC0+c3RhdGUgIT0gV1RGTG9nQ2hh bm5lbE9uKQorICAgICAgICBpZiAoIWlzTG9nQ2hhbm5lbEVuYWJsZWQoIk1lZGlhIikpCiAgICAg ICAgICAgICBnX29iamVjdF9zZXQobV9mcHNTaW5rLmdldCgpLCAidGV4dC1vdmVybGF5IiwgRkFM U0UgLCBudWxscHRyKTsKICNlbmRpZiAvLyBMT0dfRElTQUJMRUQKIAo=