130239 2014-03-14 08:27:35 -0700 min-width on a display:table-cell element takes precedence over a width on an outer display:table;table-layout:fixed; element if the outer width is set after initial render 2023-02-10 20:06:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pguerrant gur.trio bdakin commit-queue darin esprehn+autocc fred.moseley glenn gur.trio hyatt jarred k.gurpreet kling koivisto kondapallykalyan simon.fraser webkit-bug-importer zalan oldest_to_newest 990489 0 pguerrant 2014-03-14 08:27:35 -0700 In the following test case, the outer and inner elements should end up both being 100px wide, because of the width that is set on the outer element, however, because the width on the outer element is set after initial render, the min-width on the inner element wins and both inner and outer elements end up being 200px wide. <style> #outer { display: table; table-layout: fixed; } #inner { display: table-cell; height: 50px; background-color: green; min-width: 200px; } </style> <div id="outer"> <div id="inner"></div> </div> <script> window.onload = function() { outer = document.getElementById('outer'); outer.style.width = '100px'; }; </script> The following actions can be taken to work around the bug: 1. set the outer element's width in the stylesheet, or inline style, instead of setting the width after initial render 2. after setting the width on the outer element, hiding and showing it by setting display to "none" and then back to "table" will cause it to refresh and layout properly. This bug is reproducible in the latest webkit nightly (March 7, 2014) and in the latest versions of Safari and Chrome. 1007252 1 230978 k.gurpreet 2014-05-07 01:47:30 -0700 Created attachment 230978 Patch 1007254 2 230979 k.gurpreet 2014-05-07 02:22:59 -0700 Created attachment 230979 Patch 1007289 3 k.gurpreet 2014-05-07 04:21:19 -0700 Please review. Thanks. 1009258 4 pguerrant 2014-05-14 08:21:24 -0700 Here's an additional twist on what appears to be the same issue. This time there is no min-width involved, just a table/table-cell combo with table-layout:fixed and long non-wrapping text inside, but the symptom is the same - setting the width dynamically does not update the width of the outer element. It always expands to include the width of the text, unless a refresh is triggered by toggling some style (display works) on a timer. <style> #table { display: table; table-layout: fixed; } #cell { display: table-cell; white-space: nowrap; overflow: hidden; } </style> <div id="table"> <div id="cell">Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</div> </div> <script> window.onload = function() { table = document.getElementById('table'); table.style.width = '50px'; // workaround: // table.style.display = 'none'; // setTimeout(function() { // table.style.display = ''; // }); }; </script> 1009446 5 gur.trio 2014-05-14 21:54:24 -0700 Hi Phil. The latest content which you mentioned is also working with this patch right? 1010415 6 k.gurpreet 2014-05-20 00:13:43 -0700 Hi Simon/Darin please review. 1011466 7 230979 jarred 2014-05-23 20:00:22 -0700 Comment on attachment 230979 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230979&action=review > Source/WebCore/rendering/RenderTable.cpp:105 > + bool fixedTableLayout = oldStyle ? oldStyle->isFixedTableLayout() : false; May as well move this variable down to be above the if() that uses it. 1011645 8 k.gurpreet 2014-05-25 22:59:06 -0700 (In reply to comment #7) > (From update of attachment 230979 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230979&action=review > > > Source/WebCore/rendering/RenderTable.cpp:105 > > + bool fixedTableLayout = oldStyle ? oldStyle->isFixedTableLayout() : false; > > May as well move this variable down to be above the if() that uses it. Is this required? Earlier also the variable was defined at the same place. 1014390 9 k.gurpreet 2014-06-10 05:37:53 -0700 Hi. Its been more than and no one reviewed this. Please review. Its already landed on blink https://codereview.chromium.org/264283002. 1031954 10 k.gurpreet 2014-08-28 04:04:36 -0700 Hello. Please review. 1032015 11 darin 2014-08-28 09:41:02 -0700 Hyatt, could you take a look? Do you agree this is correct and the correct approach? 1230826 12 230979 mcatanzaro 2016-09-17 07:16:12 -0700 Comment on attachment 230979 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 1473047 13 fred.moseley 2018-10-29 13:59:56 -0700 This issue still exists. What must we do to get it addressed? 1476741 14 darin 2018-11-08 17:16:45 -0800 Alan, Simon, can one of you look over this patch? 1932871 15 ews-feeder 2023-02-10 20:05:54 -0800 Committed 260143@main (b6c71868cecc): <https://commits.webkit.org/260143@main> Reviewed commits have been landed. Closing PR #9924 and removing active labels. 1932872 16 webkit-bug-importer 2023-02-10 20:06:18 -0800 <rdar://problem/105310280> 230978 2014-05-07 01:47:30 -0700 2014-05-07 02:22:53 -0700 Patch bug-130239-20140507141709.patch text/plain 7173 k.gurpreet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODQxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA1LTA3ICBHdXJwcmVl dCBLYXVyICA8ay5ndXJwcmVldEB3ZWJraXQub3JnPgorCisgICAgICAgIG1pbi13aWR0aCBvbiBh IGRpc3BsYXk6dGFibGUtY2VsbCBlbGVtZW50IHRha2VzIHByZWNlZGVuY2Ugb3ZlciBhIHdpZHRo CisgICAgICAgIG9uIGFuIG91dGVyIGRpc3BsYXk6dGFibGU7dGFibGUtbGF5b3V0OmZpeGVkOyBl bGVtZW50IGlmIHRoZSBvdXRlciB3aWR0aAorICAgICAgICBpcyBzZXQgYWZ0ZXIgaW5pdGlhbCBy ZW5kZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzAyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIFRoZSBuZXcgd2lkdGggb2YgdGFibGUgd2FzIG5vdCBiZWluZyBhcHBsaWVkIHdoZW4g Y2hhbmdlZCBkeW5hbWljYWxseSAKKyAgICAgICAgZXZlbiB0aG91Z2ggdGhlIHRhYmxlLWxheW91 dCBpcyBmaXhlZC4gT24gY2FsY3VsYXRpbmcgd2hldGhlciB3ZSBuZWVkCisgICAgICAgIHRvIHNl dCB0aGUgbV90YWJsZUxheW91dCBhcyBmaXhlZCBvciBhdXRvIHRoZSBjaGFuZ2UgaW4gbGF5b3V0 CisgICAgICAgIHBhcmFtZXRlcnMgc3VjaCBhcyB3aWR0aCwgaGVpZ2h0IGV0YyB3YXMgbm90IGNv bnNpZGVyZWQgaGVuY2UgdGhlIHJpZ2h0CisgICAgICAgIGxheW91dCB0eXBlIHdhcyBub3QgYmVp bmcgc2V0LiAKKworICAgICAgICBUZXN0OiBmYXN0L3RhYmxlL2ZpeGVkLXRhYmxlLWxheW91dC13 aWR0aC1jaGFuZ2UuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoK KyAgICAgICAgSW5jYXNlIHRoZXJlIGFyZSBpcyBsYXlvdXQgY2hhbmdlcyB3ZSBuZWVkIHRvIHNl ZSB3aGV0aGVyIG1fdGFibGVMYXlvdXQKKyAgICAgICAgbmVlZHMgdG8gYmUgY2hhbmdlZCBvciBu b3QKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlOjpzdHlsZURpZENoYW5nZSk6CisgICAg ICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgIEFkZGVkIEFQSSB0 byBjaGVjayB3aGV0aGVyIHRhYmxlLWxheW91dCBpcyBmaXhlZCBhbmQgaWYgdGhlcmUgaXMgYW55 IAorICAgICAgICBjaGFuZ2VzIGluIHdpZHRoLgorCiAyMDE0LTA1LTA3ICBQcmF2ZWVuIFIgSmFk aGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEZpeCBidWlsZCBlcnJvcnMg Zm9yIEJsb2JEYXRhSXRlbSBhZnRlciByMTY4MzkxLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGFibGUuY3BwCShyZXZpc2lvbiAxNjgzNTMpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsMTcgKzEw MiwxNyBAQCB2b2lkIFJlbmRlclRhYmxlOjpzdHlsZURpZENoYW5nZShTdHlsZURpCiAgICAgUmVu ZGVyQmxvY2s6OnN0eWxlRGlkQ2hhbmdlKGRpZmYsIG9sZFN0eWxlKTsKICAgICBwcm9wYWdhdGVT dHlsZVRvQW5vbnltb3VzQ2hpbGRyZW4oUHJvcGFnYXRlVG9BbGxDaGlsZHJlbik7CiAKLSAgICBF VGFibGVMYXlvdXQgb2xkVGFibGVMYXlvdXQgPSBvbGRTdHlsZSA/IG9sZFN0eWxlLT50YWJsZUxh eW91dCgpIDogVEFVVE87CisgICAgYm9vbCBmaXhlZFRhYmxlTGF5b3V0ID0gb2xkU3R5bGUgPyBv bGRTdHlsZS0+aXNGaXhlZFRhYmxlTGF5b3V0KCkgOiBmYWxzZTsKIAogICAgIC8vIEluIHRoZSBj b2xsYXBzZWQgYm9yZGVyIG1vZGVsLCB0aGVyZSBpcyBubyBjZWxsIHNwYWNpbmcuCiAgICAgbV9o U3BhY2luZyA9IGNvbGxhcHNlQm9yZGVycygpID8gMCA6IHN0eWxlKCkuaG9yaXpvbnRhbEJvcmRl clNwYWNpbmcoKTsKICAgICBtX3ZTcGFjaW5nID0gY29sbGFwc2VCb3JkZXJzKCkgPyAwIDogc3R5 bGUoKS52ZXJ0aWNhbEJvcmRlclNwYWNpbmcoKTsKICAgICBtX2NvbHVtblBvc1swXSA9IG1faFNw YWNpbmc7CiAKLSAgICBpZiAoIW1fdGFibGVMYXlvdXQgfHwgc3R5bGUoKS50YWJsZUxheW91dCgp ICE9IG9sZFRhYmxlTGF5b3V0KSB7CisgICAgaWYgKCFtX3RhYmxlTGF5b3V0IHx8IHN0eWxlKCku aXNGaXhlZFRhYmxlTGF5b3V0KCkgIT0gZml4ZWRUYWJsZUxheW91dCkgewogICAgICAgICAvLyBB Y2NvcmRpbmcgdG8gdGhlIENTUzIgc3BlYywgeW91IG9ubHkgdXNlIGZpeGVkIHRhYmxlIGxheW91 dCBpZiBhbgogICAgICAgICAvLyBleHBsaWNpdCB3aWR0aCBpcyBzcGVjaWZpZWQgb24gdGhlIHRh YmxlLiAgQXV0byB3aWR0aCBpbXBsaWVzIGF1dG8gdGFibGUgbGF5b3V0LgotICAgICAgICBpZiAo c3R5bGUoKS50YWJsZUxheW91dCgpID09IFRGSVhFRCAmJiAhc3R5bGUoKS5sb2dpY2FsV2lkdGgo KS5pc0F1dG8oKSkKKyAgICAgICAgaWYgKHN0eWxlKCkuaXNGaXhlZFRhYmxlTGF5b3V0KQogICAg ICAgICAgICAgbV90YWJsZUxheW91dCA9IHN0ZDo6bWFrZV91bmlxdWU8Rml4ZWRUYWJsZUxheW91 dD4odGhpcyk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIG1fdGFibGVMYXlvdXQgPSBzdGQ6 Om1ha2VfdW5pcXVlPEF1dG9UYWJsZUxheW91dD4odGhpcyk7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAkocmV2aXNpb24gMTY4MzUzKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTY4MCw2ICs2ODAsNyBAQCBwdWJsaWM6CiAKICAgICBFQ2xlYXIgY2xlYXIoKSBjb25z dCB7IHJldHVybiBub25pbmhlcml0ZWRfZmxhZ3MuY2xlYXIoKTsgfQogICAgIEVUYWJsZUxheW91 dCB0YWJsZUxheW91dCgpIGNvbnN0IHsgcmV0dXJuIG5vbmluaGVyaXRlZF9mbGFncy50YWJsZUxh eW91dCgpOyB9CisgICAgYm9vbCBpc0ZpeGVkVGFibGVMYXlvdXQoKSBjb25zdCB7IHJldHVybiB0 YWJsZUxheW91dCgpID09IFRGSVhFRCAmJiAhbG9naWNhbFdpZHRoKCkuaXNBdXRvKCk7IH0KIAog ICAgIGNvbnN0IEZvbnQmIGZvbnQoKSBjb25zdDsKICAgICBjb25zdCBGb250TWV0cmljcyYgZm9u dE1ldHJpY3MoKSBjb25zdDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODQxNCkKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTA3 ICBHdXJwcmVldCBLYXVyICA8ay5ndXJwcmVldEB3ZWJraXQub3JnPgorCisgICAgICAgIG1pbi13 aWR0aCBvbiBhIGRpc3BsYXk6dGFibGUtY2VsbCBlbGVtZW50IHRha2VzIHByZWNlZGVuY2Ugb3Zl ciBhIHdpZHRoCisgICAgICAgIG9uIGFuIG91dGVyIGRpc3BsYXk6dGFibGU7dGFibGUtbGF5b3V0 OmZpeGVkOyBlbGVtZW50IGlmIHRoZSBvdXRlciB3aWR0aAorICAgICAgICBpcyBzZXQgYWZ0ZXIg aW5pdGlhbCByZW5kZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzAyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvdGFibGUvZml4ZWQtdGFibGUtbGF5b3V0LXdpZHRoLWNoYW5nZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGFibGUvZml4ZWQtdGFibGUtbGF5b3V0 LXdpZHRoLWNoYW5nZS5odG1sOiBBZGRlZC4KKyAgICAgICAgQWRkZWQgbmV3IHRlc3QgY2FzZSB0 byBjaGVjayB0aGUgYmVoYXZpb3VyIG9mIHRhYmxlIHdpZHRoIGhhdmluZyB0YWJsZQorICAgICAg ICBsYXlvdXQgZml4ZWQgd2hlbiBpdHMgd2lkdGggaXMgY2hhbmdlZCBkeW5hbWljYWxseS4KKwog MjAxNC0wNS0wNiAgUmlrIENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUuY29tPgogCiAgICAgICAg IENhbGxpbmcgY3JlYXRlUGF0dGVybiB3aXRoIGEgYnJva2VuIGltYWdlIG11c3QgdGhyb3cgYW4g aW52YWxpZHN0YXRlIGVycm9yCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2ZpeGVkLXRh YmxlLWxheW91dC13aWR0aC1jaGFuZ2UtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvdGFibGUvZml4ZWQtdGFibGUtbGF5b3V0LXdpZHRoLWNoYW5nZS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2ZpeGVkLXRhYmxl LWxheW91dC13aWR0aC1jaGFuZ2UtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsMTAgQEAKK1Rlc3RzIHRoYXQgdGFibGUgd2lkdGggaGF2aW5nIHRhYmxlLWxheW91dCBmaXhl ZCBjaGFuZ2VzIHdoZW4gd2lkdGggaXMgY2hhbmdlZCBkeW5hbWljYWxseS5OZXcgd2lkdGggc2hv dWxkIGJlIDEwMAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnb3V0ZXInKS5vZmZzZXRXaWR0aCBpcyAxMDAKK1BBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCgpQcm9wZXJ0eSBjaGFuZ2Vz IG9uOiBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2ZpeGVkLXRhYmxlLWxheW91dC13aWR0aC1jaGFu Z2UtZXhwZWN0ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKIyMgLTAsMCAr MSAjIworbmF0aXZlClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgcHJvcGVydHkKQWRkZWQ6IHN2bjpl eGVjdXRhYmxlCiMjIC0wLDAgKzEgIyMKKyoKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9wZXJ0 eQpBZGRlZDogc3ZuOmtleXdvcmRzCiMjIC0wLDAgKzEgIyMKK0F1dGhvciBEYXRlIElkIFJldiBV UkwKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC90YWJsZS9maXhlZC10YWJsZS1sYXlvdXQtd2lkdGgtY2hhbmdlLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9maXhlZC10YWJsZS1sYXlvdXQtd2lkdGgtY2hhbmdl Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2ZpeGVkLXRhYmxl LWxheW91dC13aWR0aC1jaGFuZ2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMzIEBA Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c2NyaXB0IHNy Yz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICAgICAgPHNj cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICAgICAgZnVuY3Rpb24gcnVuVGVz dCgpIHsKKyAgICAgICAgICAgICAgICBkZXNjcmlwdGlvbignVGVzdHMgdGhhdCB0YWJsZSB3aWR0 aCBoYXZpbmcgdGFibGUtbGF5b3V0IGZpeGVkIGNoYW5nZXMgd2hlbiB3aWR0aCBpcyBjaGFuZ2Vk IGR5bmFtaWNhbGx5Lk5ldyB3aWR0aCBzaG91bGQgYmUgMTAwJyk7CisKKyAgICAgICAgICAgICAg ICB2YXIgb3V0ZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnb3V0ZXInKTsKKyAgICAgICAg ICAgICAgICBvdXRlci5zdHlsZS53aWR0aCA9ICcxMDBweCc7CisgICAgICAgICAgICAgICAgc2hv dWxkQmUoImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdvdXRlcicpLm9mZnNldFdpZHRoIiwiMTAw Iik7CisgICAgICAgICAgICAgICAgaXNTdWNjZXNzZnVsbHlQYXJzZWQoKTsKKyAgICAgICAgICAg IH07CisgICAgICAgIDwvc2NyaXB0PgorICAgICAgICA8c3R5bGU+CisgICAgICAgICAgICAjb3V0 ZXIgeworICAgICAgICAgICAgICAgIGRpc3BsYXk6IHRhYmxlOworICAgICAgICAgICAgICAgIHRh YmxlLWxheW91dDogZml4ZWQ7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAjaW5uZXIgewor ICAgICAgICAgICAgICAgIGRpc3BsYXk6IHRhYmxlLWNlbGw7CisgICAgICAgICAgICAgICAgaGVp Z2h0OiA1MHB4OworICAgICAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworICAg ICAgICAgICAgICAgIG1pbi13aWR0aDogMjAwcHg7CisgICAgICAgICAgICB9CisgICAgICAgIDwv c3R5bGU+CisgICAgPC9oZWFkPgorICAgIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKyAgICAg ICAgPGRpdiBpZD0ib3V0ZXIiPgorICAgICAgICAgICAgPGRpdiBpZD0iaW5uZXIiPjwvZGl2Pgor ICAgICAgICA8L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9u OiBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2ZpeGVkLXRhYmxlLWxheW91dC13aWR0aC1jaGFuZ2Uu aHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiMjIC0wLDAgKzEgIyMKK25hdGl2 ZQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIHByb3BlcnR5CkFkZGVkOiBzdm46ZXhlY3V0YWJsZQoj IyAtMCwwICsxICMjCisqClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgcHJvcGVydHkK 230979 2014-05-07 02:22:59 -0700 2016-09-17 07:16:12 -0700 Patch bug-130239-20140507145239.patch text/plain 7175 k.gurpreet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODQxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA1LTA3ICBHdXJwcmVl dCBLYXVyICA8ay5ndXJwcmVldEB3ZWJraXQub3JnPgorCisgICAgICAgIG1pbi13aWR0aCBvbiBh IGRpc3BsYXk6dGFibGUtY2VsbCBlbGVtZW50IHRha2VzIHByZWNlZGVuY2Ugb3ZlciBhIHdpZHRo CisgICAgICAgIG9uIGFuIG91dGVyIGRpc3BsYXk6dGFibGU7dGFibGUtbGF5b3V0OmZpeGVkOyBl bGVtZW50IGlmIHRoZSBvdXRlciB3aWR0aAorICAgICAgICBpcyBzZXQgYWZ0ZXIgaW5pdGlhbCBy ZW5kZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzAyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIFRoZSBuZXcgd2lkdGggb2YgdGFibGUgd2FzIG5vdCBiZWluZyBhcHBsaWVkIHdoZW4g Y2hhbmdlZCBkeW5hbWljYWxseSAKKyAgICAgICAgZXZlbiB0aG91Z2ggdGhlIHRhYmxlLWxheW91 dCBpcyBmaXhlZC4gT24gY2FsY3VsYXRpbmcgd2hldGhlciB3ZSBuZWVkCisgICAgICAgIHRvIHNl dCB0aGUgbV90YWJsZUxheW91dCBhcyBmaXhlZCBvciBhdXRvIHRoZSBjaGFuZ2UgaW4gbGF5b3V0 CisgICAgICAgIHBhcmFtZXRlcnMgc3VjaCBhcyB3aWR0aCwgaGVpZ2h0IGV0YyB3YXMgbm90IGNv bnNpZGVyZWQgaGVuY2UgdGhlIHJpZ2h0CisgICAgICAgIGxheW91dCB0eXBlIHdhcyBub3QgYmVp bmcgc2V0LiAKKworICAgICAgICBUZXN0OiBmYXN0L3RhYmxlL2ZpeGVkLXRhYmxlLWxheW91dC13 aWR0aC1jaGFuZ2UuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoK KyAgICAgICAgSW5jYXNlIHRoZXJlIGFyZSBpcyBsYXlvdXQgY2hhbmdlcyB3ZSBuZWVkIHRvIHNl ZSB3aGV0aGVyIG1fdGFibGVMYXlvdXQKKyAgICAgICAgbmVlZHMgdG8gYmUgY2hhbmdlZCBvciBu b3QKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlOjpzdHlsZURpZENoYW5nZSk6CisgICAg ICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgIEFkZGVkIEFQSSB0 byBjaGVjayB3aGV0aGVyIHRhYmxlLWxheW91dCBpcyBmaXhlZCBhbmQgaWYgdGhlcmUgaXMgYW55 IAorICAgICAgICBjaGFuZ2VzIGluIHdpZHRoLgorCiAyMDE0LTA1LTA3ICBQcmF2ZWVuIFIgSmFk aGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEZpeCBidWlsZCBlcnJvcnMg Zm9yIEJsb2JEYXRhSXRlbSBhZnRlciByMTY4MzkxLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGFibGUuY3BwCShyZXZpc2lvbiAxNjgzNTMpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsMTcgKzEw MiwxNyBAQCB2b2lkIFJlbmRlclRhYmxlOjpzdHlsZURpZENoYW5nZShTdHlsZURpCiAgICAgUmVu ZGVyQmxvY2s6OnN0eWxlRGlkQ2hhbmdlKGRpZmYsIG9sZFN0eWxlKTsKICAgICBwcm9wYWdhdGVT dHlsZVRvQW5vbnltb3VzQ2hpbGRyZW4oUHJvcGFnYXRlVG9BbGxDaGlsZHJlbik7CiAKLSAgICBF VGFibGVMYXlvdXQgb2xkVGFibGVMYXlvdXQgPSBvbGRTdHlsZSA/IG9sZFN0eWxlLT50YWJsZUxh eW91dCgpIDogVEFVVE87CisgICAgYm9vbCBmaXhlZFRhYmxlTGF5b3V0ID0gb2xkU3R5bGUgPyBv bGRTdHlsZS0+aXNGaXhlZFRhYmxlTGF5b3V0KCkgOiBmYWxzZTsKIAogICAgIC8vIEluIHRoZSBj b2xsYXBzZWQgYm9yZGVyIG1vZGVsLCB0aGVyZSBpcyBubyBjZWxsIHNwYWNpbmcuCiAgICAgbV9o U3BhY2luZyA9IGNvbGxhcHNlQm9yZGVycygpID8gMCA6IHN0eWxlKCkuaG9yaXpvbnRhbEJvcmRl clNwYWNpbmcoKTsKICAgICBtX3ZTcGFjaW5nID0gY29sbGFwc2VCb3JkZXJzKCkgPyAwIDogc3R5 bGUoKS52ZXJ0aWNhbEJvcmRlclNwYWNpbmcoKTsKICAgICBtX2NvbHVtblBvc1swXSA9IG1faFNw YWNpbmc7CiAKLSAgICBpZiAoIW1fdGFibGVMYXlvdXQgfHwgc3R5bGUoKS50YWJsZUxheW91dCgp ICE9IG9sZFRhYmxlTGF5b3V0KSB7CisgICAgaWYgKCFtX3RhYmxlTGF5b3V0IHx8IHN0eWxlKCku aXNGaXhlZFRhYmxlTGF5b3V0KCkgIT0gZml4ZWRUYWJsZUxheW91dCkgewogICAgICAgICAvLyBB Y2NvcmRpbmcgdG8gdGhlIENTUzIgc3BlYywgeW91IG9ubHkgdXNlIGZpeGVkIHRhYmxlIGxheW91 dCBpZiBhbgogICAgICAgICAvLyBleHBsaWNpdCB3aWR0aCBpcyBzcGVjaWZpZWQgb24gdGhlIHRh YmxlLiAgQXV0byB3aWR0aCBpbXBsaWVzIGF1dG8gdGFibGUgbGF5b3V0LgotICAgICAgICBpZiAo c3R5bGUoKS50YWJsZUxheW91dCgpID09IFRGSVhFRCAmJiAhc3R5bGUoKS5sb2dpY2FsV2lkdGgo KS5pc0F1dG8oKSkKKyAgICAgICAgaWYgKHN0eWxlKCkuaXNGaXhlZFRhYmxlTGF5b3V0KCkpCiAg ICAgICAgICAgICBtX3RhYmxlTGF5b3V0ID0gc3RkOjptYWtlX3VuaXF1ZTxGaXhlZFRhYmxlTGF5 b3V0Pih0aGlzKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgbV90YWJsZUxheW91dCA9IHN0 ZDo6bWFrZV91bmlxdWU8QXV0b1RhYmxlTGF5b3V0Pih0aGlzKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCShyZXZpc2lvbiAxNjgzNTMpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAkod29ya2luZyBj b3B5KQpAQCAtNjgwLDYgKzY4MCw3IEBAIHB1YmxpYzoKIAogICAgIEVDbGVhciBjbGVhcigpIGNv bnN0IHsgcmV0dXJuIG5vbmluaGVyaXRlZF9mbGFncy5jbGVhcigpOyB9CiAgICAgRVRhYmxlTGF5 b3V0IHRhYmxlTGF5b3V0KCkgY29uc3QgeyByZXR1cm4gbm9uaW5oZXJpdGVkX2ZsYWdzLnRhYmxl TGF5b3V0KCk7IH0KKyAgICBib29sIGlzRml4ZWRUYWJsZUxheW91dCgpIGNvbnN0IHsgcmV0dXJu IHRhYmxlTGF5b3V0KCkgPT0gVEZJWEVEICYmICFsb2dpY2FsV2lkdGgoKS5pc0F1dG8oKTsgfQog CiAgICAgY29uc3QgRm9udCYgZm9udCgpIGNvbnN0OwogICAgIGNvbnN0IEZvbnRNZXRyaWNzJiBm b250TWV0cmljcygpIGNvbnN0OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4NDE0KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDUt MDcgIEd1cnByZWV0IEthdXIgIDxrLmd1cnByZWV0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgbWlu LXdpZHRoIG9uIGEgZGlzcGxheTp0YWJsZS1jZWxsIGVsZW1lbnQgdGFrZXMgcHJlY2VkZW5jZSBv dmVyIGEgd2lkdGgKKyAgICAgICAgb24gYW4gb3V0ZXIgZGlzcGxheTp0YWJsZTt0YWJsZS1sYXlv dXQ6Zml4ZWQ7IGVsZW1lbnQgaWYgdGhlIG91dGVyIHdpZHRoCisgICAgICAgIGlzIHNldCBhZnRl ciBpbml0aWFsIHJlbmRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMDIzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZmFzdC90YWJsZS9maXhlZC10YWJsZS1sYXlvdXQtd2lkdGgtY2hhbmdlLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC90YWJsZS9maXhlZC10YWJsZS1sYXlv dXQtd2lkdGgtY2hhbmdlLmh0bWw6IEFkZGVkLgorICAgICAgICBBZGRlZCBuZXcgdGVzdCBjYXNl IHRvIGNoZWNrIHRoZSBiZWhhdmlvdXIgb2YgdGFibGUgd2lkdGggaGF2aW5nIHRhYmxlCisgICAg ICAgIGxheW91dCBmaXhlZCB3aGVuIGl0cyB3aWR0aCBpcyBjaGFuZ2VkIGR5bmFtaWNhbGx5Lgor CiAyMDE0LTA1LTA2ICBSaWsgQ2FiYW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CiAKICAgICAg ICAgQ2FsbGluZyBjcmVhdGVQYXR0ZXJuIHdpdGggYSBicm9rZW4gaW1hZ2UgbXVzdCB0aHJvdyBh biBpbnZhbGlkc3RhdGUgZXJyb3IKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGFibGUvZml4ZWQt dGFibGUtbGF5b3V0LXdpZHRoLWNoYW5nZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC90YWJsZS9maXhlZC10YWJsZS1sYXlvdXQtd2lkdGgtY2hhbmdlLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvdGFibGUvZml4ZWQtdGFi bGUtbGF5b3V0LXdpZHRoLWNoYW5nZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAs MCArMSwxMCBAQAorVGVzdHMgdGhhdCB0YWJsZSB3aWR0aCBoYXZpbmcgdGFibGUtbGF5b3V0IGZp eGVkIGNoYW5nZXMgd2hlbiB3aWR0aCBpcyBjaGFuZ2VkIGR5bmFtaWNhbGx5Lk5ldyB3aWR0aCBz aG91bGQgYmUgMTAwCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdvdXRlcicpLm9mZnNldFdpZHRoIGlzIDEwMAorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNoYW5n ZXMgb246IExheW91dFRlc3RzL2Zhc3QvdGFibGUvZml4ZWQtdGFibGUtbGF5b3V0LXdpZHRoLWNo YW5nZS1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmtleXdvcmRzCiMjIC0wLDAg KzEgIyMKK0F1dGhvciBEYXRlIElkIFJldiBVUkwKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9w ZXJ0eQpBZGRlZDogc3ZuOmVvbC1zdHlsZQojIyAtMCwwICsxICMjCituYXRpdmUKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQpBZGRlZDogc3ZuOmV4ZWN1dGFibGUKIyMgLTAsMCArMSAj IworKgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIHByb3BlcnR5CkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L3RhYmxlL2ZpeGVkLXRhYmxlLWxheW91dC13aWR0aC1jaGFuZ2UuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2ZpeGVkLXRhYmxlLWxheW91dC13aWR0aC1jaGFu Z2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvdGFibGUvZml4ZWQtdGFi bGUtbGF5b3V0LXdpZHRoLWNoYW5nZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMzMg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzY3JpcHQg c3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgICAgICA8 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgICAgICAgICBmdW5jdGlvbiBydW5U ZXN0KCkgeworICAgICAgICAgICAgICAgIGRlc2NyaXB0aW9uKCdUZXN0cyB0aGF0IHRhYmxlIHdp ZHRoIGhhdmluZyB0YWJsZS1sYXlvdXQgZml4ZWQgY2hhbmdlcyB3aGVuIHdpZHRoIGlzIGNoYW5n ZWQgZHluYW1pY2FsbHkuTmV3IHdpZHRoIHNob3VsZCBiZSAxMDAnKTsKKworICAgICAgICAgICAg ICAgIHZhciBvdXRlciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdvdXRlcicpOworICAgICAg ICAgICAgICAgIG91dGVyLnN0eWxlLndpZHRoID0gJzEwMHB4JzsKKyAgICAgICAgICAgICAgICBz aG91bGRCZSgiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ291dGVyJykub2Zmc2V0V2lkdGgiLCIx MDAiKTsKKyAgICAgICAgICAgICAgICBpc1N1Y2Nlc3NmdWxseVBhcnNlZCgpOworICAgICAgICAg ICAgfTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgICAgIDxzdHlsZT4KKyAgICAgICAgICAgICNv dXRlciB7CisgICAgICAgICAgICAgICAgZGlzcGxheTogdGFibGU7CisgICAgICAgICAgICAgICAg dGFibGUtbGF5b3V0OiBmaXhlZDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgICNpbm5lciB7 CisgICAgICAgICAgICAgICAgZGlzcGxheTogdGFibGUtY2VsbDsKKyAgICAgICAgICAgICAgICBo ZWlnaHQ6IDUwcHg7CisgICAgICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47Cisg ICAgICAgICAgICAgICAgbWluLXdpZHRoOiAyMDBweDsKKyAgICAgICAgICAgIH0KKyAgICAgICAg PC9zdHlsZT4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorICAg ICAgICA8ZGl2IGlkPSJvdXRlciI+CisgICAgICAgICAgICA8ZGl2IGlkPSJpbm5lciI+PC9kaXY+ CisgICAgICAgIDwvZGl2PgorICAgIDwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMg b246IExheW91dFRlc3RzL2Zhc3QvdGFibGUvZml4ZWQtdGFibGUtbGF5b3V0LXdpZHRoLWNoYW5n ZS5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKIyMgLTAsMCArMSAjIworbmF0 aXZlClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgcHJvcGVydHkKQWRkZWQ6IHN2bjpleGVjdXRhYmxl CiMjIC0wLDAgKzEgIyMKKyoKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQo=