130228 2014-03-13 23:54:39 -0700 [Cocoa] WKHistoryDelegate is being called for subframes 2014-03-14 00:28:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz mrowe oldest_to_newest 990326 0 mitz 2014-03-13 23:54:39 -0700 [Cocoa] WKHistoryDelegate is being called for subframes 990327 1 mitz 2014-03-13 23:55:31 -0700 <rdar://problem/16319722> 990328 2 226660 mitz 2014-03-13 23:58:18 -0700 Created attachment 226660 Don't call the delegate for non-main frame HistoryClient callbacks 990335 3 mitz 2014-03-14 00:28:10 -0700 Fixed in <http://trac.webkit.org/r165604>. 226660 2014-03-13 23:58:18 -0700 2014-03-14 00:10:41 -0700 Don't call the delegate for non-main frame HistoryClient callbacks bug-130228-20140313235800.patch text/plain 2947 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTYwMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTEzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MzE5 NzIyPiBbQ29jb2FdIFdLSGlzdG9yeURlbGVnYXRlIGlzIGJlaW5nIGNhbGxlZCBmb3Igc3ViZnJh bWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAy MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9Db2NvYS9IaXN0b3J5Q2xpZW50Lm1tOgorICAgICAgICAoV2ViS2l0OjpIaXN0b3J5 Q2xpZW50OjpkaWROYXZpZ2F0ZVdpdGhOYXZpZ2F0aW9uRGF0YSk6IEJhaWwgb3V0IGlmIHRoZSBm cmFtZSBpcyBub3QgdGhlCisgICAgICAgIG1haW4gZnJhbWUuCisgICAgICAgIChXZWJLaXQ6Okhp c3RvcnlDbGllbnQ6OmRpZFBlcmZvcm1DbGllbnRSZWRpcmVjdCk6IERpdHRvLgorICAgICAgICAo V2ViS2l0OjpIaXN0b3J5Q2xpZW50OjpkaWRQZXJmb3JtU2VydmVyUmVkaXJlY3QpOiBEaXR0by4K KyAgICAgICAgKFdlYktpdDo6SGlzdG9yeUNsaWVudDo6ZGlkVXBkYXRlSGlzdG9yeVRpdGxlKTog RGl0dG8uCisKIDIwMTQtMDMtMTMgIEppbndvbyBKZW9uZyAgPGp3MDAuamVvbmdAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgUmVmYWN0b3IgVmlicmF0aW9uIGFsZ29yaXRobSB0byB1c2Ugb25seSBv bmUgdGltZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvSGlzdG9yeUNs aWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvSGlz dG9yeUNsaWVudC5tbQkocmV2aXNpb24gMTY1NTk5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0NvY29hL0hpc3RvcnlDbGllbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ0LDYgKzQ0LDkg QEAgSGlzdG9yeUNsaWVudDo6fkhpc3RvcnlDbGllbnQoKQogCiB2b2lkIEhpc3RvcnlDbGllbnQ6 OmRpZE5hdmlnYXRlV2l0aE5hdmlnYXRpb25EYXRhKFdlYkNvbnRleHQqLCBXZWJQYWdlUHJveHkq IHdlYlBhZ2VQcm94eSwgY29uc3QgV2ViTmF2aWdhdGlvbkRhdGFTdG9yZSYgbmF2aWdhdGlvbkRh dGFTdG9yZSwgV2ViRnJhbWVQcm94eSogd2ViRnJhbWVQcm94eSkKIHsKKyAgICBpZiAoIXdlYkZy YW1lUHJveHktPmlzTWFpbkZyYW1lKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGF1dG8mIG5h dmlnYXRpb25TdGF0ZSA9IE5hdmlnYXRpb25TdGF0ZTo6ZnJvbVdlYlBhZ2UoKndlYlBhZ2VQcm94 eSk7CiAKICAgICBuYXZpZ2F0aW9uU3RhdGUuZGlkTmF2aWdhdGVXaXRoTmF2aWdhdGlvbkRhdGEo bmF2aWdhdGlvbkRhdGFTdG9yZSk7CkBAIC01MSw2ICs1NCw5IEBAIHZvaWQgSGlzdG9yeUNsaWVu dDo6ZGlkTmF2aWdhdGVXaXRoTmF2aWcKIAogdm9pZCBIaXN0b3J5Q2xpZW50OjpkaWRQZXJmb3Jt Q2xpZW50UmVkaXJlY3QoV2ViQ29udGV4dCosIFdlYlBhZ2VQcm94eSogd2ViUGFnZVByb3h5LCBj b25zdCBXVEY6OlN0cmluZyYgc291cmNlVVJMLCBjb25zdCBXVEY6OlN0cmluZyYgZGVzdGluYXRp b25VUkwsIFdlYkZyYW1lUHJveHkqIHdlYkZyYW1lUHJveHkpCiB7CisgICAgaWYgKCF3ZWJGcmFt ZVByb3h5LT5pc01haW5GcmFtZSgpKQorICAgICAgICByZXR1cm47CisKICAgICBhdXRvJiBuYXZp Z2F0aW9uU3RhdGUgPSBOYXZpZ2F0aW9uU3RhdGU6OmZyb21XZWJQYWdlKCp3ZWJQYWdlUHJveHkp OwogCiAgICAgbmF2aWdhdGlvblN0YXRlLmRpZFBlcmZvcm1DbGllbnRSZWRpcmVjdChzb3VyY2VV UkwsIGRlc3RpbmF0aW9uVVJMKTsKQEAgLTU4LDYgKzY0LDkgQEAgdm9pZCBIaXN0b3J5Q2xpZW50 OjpkaWRQZXJmb3JtQ2xpZW50UmVkaQogCiB2b2lkIEhpc3RvcnlDbGllbnQ6OmRpZFBlcmZvcm1T ZXJ2ZXJSZWRpcmVjdChXZWJDb250ZXh0KiwgV2ViUGFnZVByb3h5KiB3ZWJQYWdlUHJveHksIGNv bnN0IFdURjo6U3RyaW5nJiBzb3VyY2VVUkwsIGNvbnN0IFdURjo6U3RyaW5nJiBkZXN0aW5hdGlv blVSTCwgV2ViRnJhbWVQcm94eSogd2ViRnJhbWVQcm94eSkKIHsKKyAgICBpZiAoIXdlYkZyYW1l UHJveHktPmlzTWFpbkZyYW1lKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGF1dG8mIG5hdmln YXRpb25TdGF0ZSA9IE5hdmlnYXRpb25TdGF0ZTo6ZnJvbVdlYlBhZ2UoKndlYlBhZ2VQcm94eSk7 CiAKICAgICBuYXZpZ2F0aW9uU3RhdGUuZGlkUGVyZm9ybVNlcnZlclJlZGlyZWN0KHNvdXJjZVVS TCwgZGVzdGluYXRpb25VUkwpOwpAQCAtNjUsNiArNzQsOSBAQCB2b2lkIEhpc3RvcnlDbGllbnQ6 OmRpZFBlcmZvcm1TZXJ2ZXJSZWRpCiAKIHZvaWQgSGlzdG9yeUNsaWVudDo6ZGlkVXBkYXRlSGlz dG9yeVRpdGxlKFdlYkNvbnRleHQqLCBXZWJQYWdlUHJveHkqIHdlYlBhZ2VQcm94eSwgY29uc3Qg V1RGOjpTdHJpbmcmIHRpdGxlLCBjb25zdCBXVEY6OlN0cmluZyYgdXJsLCBXZWJGcmFtZVByb3h5 KiB3ZWJGcmFtZVByb3h5KQogeworICAgIGlmICghd2ViRnJhbWVQcm94eS0+aXNNYWluRnJhbWUo KSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYXV0byYgbmF2aWdhdGlvblN0YXRlID0gTmF2aWdh dGlvblN0YXRlOjpmcm9tV2ViUGFnZSgqd2ViUGFnZVByb3h5KTsKIAogICAgIG5hdmlnYXRpb25T dGF0ZS5kaWRVcGRhdGVIaXN0b3J5VGl0bGUodGl0bGUsIHVybCk7Cg==