130224 2014-03-13 21:15:24 -0700 Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib 2014-03-13 22:19:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 1 juergen webkit-unassigned fpizlo rniwa oldest_to_newest 990282 0 juergen 2014-03-13 21:15:24 -0700 Only export initializeAndGetJSCLLVMAPI from libllvmForJSC.dylib 990284 1 226647 juergen 2014-03-13 21:19:23 -0700 Created attachment 226647 Patch 990287 2 226647 mrowe 2014-03-13 21:30:50 -0700 Comment on attachment 226647 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226647&action=review > Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:27 > // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols. This comment is no longer accurate. 990289 3 fpizlo 2014-03-13 21:35:36 -0700 (In reply to comment #2) > (From update of attachment 226647 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226647&action=review > > > Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:27 > > // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols. > > This comment is no longer accurate. Yup. I will remove it. 990292 4 juergen 2014-03-13 21:37:40 -0700 True. I was just looking at the weak binding list for the dylib and I see these operators (new, delete) exported, but that should be correct. The dylib itself only exports the initializeAndGetJSCLLVMAPI. 990295 5 fpizlo 2014-03-13 21:48:07 -0700 Landed in http://trac.webkit.org/changeset/165600 990299 6 rniwa 2014-03-13 22:13:09 -0700 Looks like this patch broke Mac builds. 990300 7 fpizlo 2014-03-13 22:13:33 -0700 (In reply to comment #6) > Looks like this patch broke Mac builds. Looking. 990301 8 fpizlo 2014-03-13 22:15:39 -0700 (In reply to comment #7) > (In reply to comment #6) > > Looks like this patch broke Mac builds. > > Looking. Oh, that's dumb. Fix coming shortly. 990302 9 fpizlo 2014-03-13 22:19:44 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Looks like this patch broke Mac builds. > > > > Looking. > > Oh, that's dumb. Fix coming shortly. Should be fixed in http://trac.webkit.org/changeset/165601! 226647 2014-03-13 21:19:23 -0700 2014-03-13 21:30:50 -0700 Patch bug-130224-20140313211900.patch text/plain 3255 juergen U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk OTViNDU3NTdlNTM5ODJjOTdhMjZkNWM3YjMzM2Y1NGRjOGI1ZTFhLi44ZDYwYmJiNGY3ZDgwMDVh MDExODM1OGNlMDNkMjRhMmY1OWM1YTVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNC0wMy0xMyAgSnVlcmdlbiBSaWJ1dHprYSAgPGp1ZXJnZW5AYXBwbGUu Y29tPgorCisgICAgICAgIE9ubHkgZXhwb3J0IGluaXRpYWxpemVBbmRHZXRKU0NMTFZNQVBJIGZy b20gbGlibGx2bUZvckpTQy5keWxpYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMwMjI0CisKKyAgICAgICAgVGhpcyBsaW1pdHMgdGhlIGV4cG9ydGVk IHN5bWJvbHMgdG8gb25seSBpbml0aWFsaXplQW5kR2V0SlNDTExWTUFQSSBmcm9tCisgICAgICAg IHRoZSBMTFZNIGR5bGliLiBUaGlzIGFsbG93cyB0aGUgZHlsaWIgdG8gYmUgc2FmZWx5IHVzZWQg d2l0aCBvdGhlciBMTFZNCisgICAgICAgIGR5bGlicyBvbiB0aGUgc2FtZSBzeXN0ZW0uIEl0IGFs c28gcmVkdWNlcyB0aGUgZHluYW1pYyBsaW5raW5nIG92ZXJoZWFkCisgICAgICAgIGFuZCBhbHNv IHJlZHVjZXMgdGhlIHNpemUgYnkgNk1CLCBiZWNhdXNlIHRoZSBsaW5rZXIgY2FuIG5vdyBkZWFk IHN0cmlwCisgICAgICAgIG1hbnkgdW51c2VkIGZ1bmN0aW9ucy4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0xMVk1Gb3JK U0MueGNjb25maWc6CisKIDIwMTQtMDMtMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmVydCAiU2hvcnQtY2lyY3VpdCBKU0dsb2JhbE9iamVjdEluc3Bl Y3RvckNvbnRyb2xsZXIgd2hlbiBub3QgaW5zcGVjdGluZy4iCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvTExWTUZvckpTQy54Y2NvbmZpZyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9MTFZNRm9ySlNDLnhjY29uZmlnCmluZGV4 IGJhMDEwZThmNGY0YThjNDMzM2JiZDI5YmE1Y2ViNTU4MmNlZDlkYzUuLjc2YzhhYzYxNjI0Nzgx NzM3N2Q0OTBiYWZjYTczMjdjMjM2ZTA3YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9Db25maWd1cmF0aW9ucy9MTFZNRm9ySlNDLnhjY29uZmlnCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9MTFZNRm9ySlNDLnhjY29uZmlnCkBAIC0yNSw3ICsy NSw3IEBACiAjaW5jbHVkZSAiVmVyc2lvbi54Y2NvbmZpZyIKIAogLy8gUHJldmVudCBDKysgc3Rh bmRhcmQgbGlicmFyeSBvcGVyYXRvciBuZXcsIGRlbGV0ZSBhbmQgdGhlaXIgcmVsYXRlZCBleGNl cHRpb24gdHlwZXMgZnJvbSBiZWluZyBleHBvcnRlZCBhcyB3ZWFrIHN5bWJvbHMuCi1PVEhFUl9M REZMQUdTX0hJREVfU1lNQk9MUyA9IC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fWlRJU3Q5 YmFkX2FsbG9jIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fWlRJU3Q5ZXhjZXB0aW9uIC1X bCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fWlRTU3Q5YmFkX2FsbG9jIC1XbCwtdW5leHBvcnRl ZF9zeW1ib2wgLVdsLF9fWlRTU3Q5ZXhjZXB0aW9uIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVds LF9fWmRsUHZTXyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pud21QdiAtV2wsLWFsbF9s b2FkOworT1RIRVJfTERGTEFHU19ISURFX1NZTUJPTFMgPSAtV2wsLWV4cG9ydGVkX3N5bWJvbCAt V2wsX2luaXRpYWxpemVBbmRHZXRKU0NMTFZNQVBJIC1XbCwtYWxsX2xvYWQ7CiAKIExMVk1fTElC U19pcGhvbmVvcyA9IC1sTExWTVRhYmxlR2VuIC1sTExWTURlYnVnSW5mbyAtbExMVk1PcHRpb24g LWxMTFZNQVJNNjREaXNhc3NlbWJsZXIgLWxMTFZNQVJNNjRBc21QYXJzZXIgLWxMTFZNQVJNNjRD b2RlR2VuIC1sTExWTVNlbGVjdGlvbkRBRyAtbExMVk1Bc21QcmludGVyIC1sTExWTUFSTTY0RGVz YyAtbExMVk1BUk02NEluZm8gLWxMTFZNQVJNNjRBc21QcmludGVyIC1sTExWTUlSUmVhZGVyIC1s TExWTUFzbVBhcnNlciAtbExMVk1NQ0Rpc2Fzc2VtYmxlciAtbExMVk1NQ1BhcnNlciAtbExMVk1J bnN0cnVtZW50YXRpb24gLWxMTFZNQml0UmVhZGVyIC1sTExWTUludGVycHJldGVyIC1sTExWTWlw byAtbExMVk1WZWN0b3JpemUgLWxMTFZNTGlua2VyIC1sTExWTUJpdFdyaXRlciAtbExMVk1NQ0pJ VCAtbExMVk1KSVQgLWxMTFZNQ29kZUdlbiAtbExMVk1PYmpDQVJDT3B0cyAtbExMVk1TY2FsYXJP cHRzIC1sTExWTUluc3RDb21iaW5lIC1sTExWTVRyYW5zZm9ybVV0aWxzIC1sTExWTWlwYSAtbExM Vk1BbmFseXNpcyAtbExMVk1SdW50aW1lRHlsZCAtbExMVk1FeGVjdXRpb25FbmdpbmUgLWxMTFZN VGFyZ2V0IC1sTExWTU1DIC1sTExWTU9iamVjdCAtbExMVk1Db3JlIC1sTExWTVN1cHBvcnQ7CiBM TFZNX0xJQlNfbWFjb3N4ID0gLWxMTFZNVGFibGVHZW4gLWxMTFZNRGVidWdJbmZvIC1sTExWTU9w dGlvbiAtbExMVk1YODZEaXNhc3NlbWJsZXIgLWxMTFZNWDg2QXNtUGFyc2VyIC1sTExWTVg4NkNv ZGVHZW4gLWxMTFZNU2VsZWN0aW9uREFHIC1sTExWTUFzbVByaW50ZXIgLWxMTFZNWDg2RGVzYyAt bExMVk1YODZJbmZvIC1sTExWTVg4NkFzbVByaW50ZXIgLWxMTFZNWDg2VXRpbHMgLWxMTFZNSVJS ZWFkZXIgLWxMTFZNQXNtUGFyc2VyIC1sTExWTU1DRGlzYXNzZW1ibGVyIC1sTExWTU1DUGFyc2Vy IC1sTExWTUluc3RydW1lbnRhdGlvbiAtbExMVk1CaXRSZWFkZXIgLWxMTFZNSW50ZXJwcmV0ZXIg LWxMTFZNaXBvIC1sTExWTVZlY3Rvcml6ZSAtbExMVk1MaW5rZXIgLWxMTFZNQml0V3JpdGVyIC1s TExWTU1DSklUIC1sTExWTUpJVCAtbExMVk1Db2RlR2VuIC1sTExWTU9iakNBUkNPcHRzIC1sTExW TVNjYWxhck9wdHMgLWxMTFZNSW5zdENvbWJpbmUgLWxMTFZNVHJhbnNmb3JtVXRpbHMgLWxMTFZN aXBhIC1sTExWTUFuYWx5c2lzIC1sTExWTVJ1bnRpbWVEeWxkIC1sTExWTUV4ZWN1dGlvbkVuZ2lu ZSAtbExMVk1UYXJnZXQgLWxMTFZNTUMgLWxMTFZNT2JqZWN0IC1sTExWTUNvcmUgLWxMTFZNU3Vw cG9ydDsK