130220 2014-03-13 18:29:53 -0700 webkit-patch land shouldn't add a reviewer for unreviewed build fixes 2014-03-18 11:30:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg webkit-unassigned commit-queue evab.u-szeged glenn joepeck ossy oldest_to_newest 990230 0 bburg 2014-03-13 18:29:53 -0700 If I put unreviewed in the non-bug title (not in the typical Reviewed By... place), it shouldn't try to pull a reviewer from any subsequently linked bugzilla bugs. 990231 1 joepeck 2014-03-13 18:32:48 -0700 Why include a bugzilla bug at all? I would include an r#### and say this is a follow-up to that. 990464 2 ossy 2014-03-14 07:27:02 -0700 It's super easy to fix it. This feature was added by http://trac.webkit.org/changeset/121873 , because it happened many times the developer accidentally removed the "reviewed by nobody oops" line. We only need to add one more check for "unreviewed/not reviewed" for this line: "if not found_nobody and not reviewer_text:" in changelog.py 990465 3 ossy 2014-03-14 07:29:29 -0700 cc-ing Éva, she hacked this part of webkitpy recently, maybe she is interested in it. 991228 4 evab.u-szeged 2014-03-17 08:29:11 -0700 Sounds interesting, I'll check it tomorrow. 991680 5 227054 evab.u-szeged 2014-03-18 08:53:08 -0700 Created attachment 227054 Patch 991745 6 227054 ossy 2014-03-18 10:58:59 -0700 Comment on attachment 227054 Patch r=me 991766 7 227054 commit-queue 2014-03-18 11:30:44 -0700 Comment on attachment 227054 Patch Clearing flags on attachment: 227054 Committed r165824: <http://trac.webkit.org/changeset/165824> 991767 8 commit-queue 2014-03-18 11:30:47 -0700 All reviewed patches have been landed. Closing bug. 227054 2014-03-18 08:53:08 -0700 2014-03-18 11:30:44 -0700 Patch bug-130220-20140318165245.patch text/plain 3643 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjU0N2Y3Yzg3MGQzMGQ2MDg1ZWYwYzA0YmQ3N2RiYmVm ZjA4MTg3Ni4uMzA1MTkwN2MzNTJjNzA1OGE5NjY3ZDgzOGIzOTAxZTIyMmJlMzViOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAzLTE4ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgd2Via2l0LXBhdGNoIGxhbmQgc2hvdWxkbid0IGFkZCBh IHJldmlld2VyIGZvciB1bnJldmlld2VkIGJ1aWxkIGZpeGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAyMjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoYW5nZWxvZy5weToKKyAgICAgICAgKENoYW5nZUxvZy5zZXRfcmV2aWV3ZXIpOgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0 dGVzdC5weToKKyAgICAgICAgKHRlc3Rfc2V0X3Jldmlld2VyKToKKwogMjAxNC0wMy0xNyAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICB3ZWJraXRweSB0ZXN0IHJl YmFzZWxpbmUuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9jaGFuZ2Vsb2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291 dC9jaGFuZ2Vsb2cucHkKaW5kZXggZjBjNTI1OThlMjhlMzhmMzQyNWM0OWY1N2JhNjE5OWEwMDFi ZTUzOS4uNDAyNjBiM2ViZGNjZjUzODcxMjBlMjJkNzRiZWE2ODNkYWE0YmY4ZCAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZy5weQpA QCAtNDA2LDggKzQwNiw4IEBAIGNsYXNzIENoYW5nZUxvZyhvYmplY3QpOgogICAgICAgICBsYXRl c3RfZW50cnlfY29udGVudHMgPSBsYXRlc3RfZW50cnkuY29udGVudHMoKQogICAgICAgICByZXZp ZXdlcl90ZXh0ID0gbGF0ZXN0X2VudHJ5LnJldmlld2VyKCkKICAgICAgICAgZm91bmRfbm9ib2R5 ID0gcmUuc2VhcmNoKCJOT0JPRFlccypcKE9PUFMhXCkiLCBsYXRlc3RfZW50cnlfY29udGVudHMs IHJlLk1VTFRJTElORSkKLQotICAgICAgICBpZiBub3QgZm91bmRfbm9ib2R5IGFuZCBub3QgcmV2 aWV3ZXJfdGV4dDoKKyAgICAgICAgZm91bmRfcmV2aWV3ZXJfb3JfdW5yZXZpZXdlZCA9IGxhdGVz dF9lbnRyeS5oYXNfdmFsaWRfcmV2aWV3ZXIoKQorICAgICAgICBpZiBub3QgZm91bmRfbm9ib2R5 IGFuZCBub3QgZm91bmRfcmV2aWV3ZXJfb3JfdW5yZXZpZXdlZCBhbmQgbm90IHJldmlld2VyX3Rl eHQ6CiAgICAgICAgICAgICBidWdfdXJsX251bWJlcl9vZl9pdGVtcyA9IGxlbihyZS5maW5kYWxs KGNvbmZpZ191cmxzLmJ1Z191cmxfbG9uZywgbGF0ZXN0X2VudHJ5X2NvbnRlbnRzLCByZS5NVUxU SUxJTkUpKQogICAgICAgICAgICAgYnVnX3VybF9udW1iZXJfb2ZfaXRlbXMgKz0gbGVuKHJlLmZp bmRhbGwoY29uZmlnX3VybHMuYnVnX3VybF9zaG9ydCwgbGF0ZXN0X2VudHJ5X2NvbnRlbnRzLCBy ZS5NVUxUSUxJTkUpKQogICAgICAgICAgICAgcmVzdWx0ID0gU3RyaW5nSU8oKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0 ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9n X3VuaXR0ZXN0LnB5CmluZGV4IDUxNjcxY2Y0NzZkYTQxZDc1YzJhOWE4ZTA3NWYxNGY2YjJhYjdh MzEuLjk4ZmM5OWU5ZDJlZTU5ZDE4Y2M3Y2Q1YWE3OGY2MGViMzFhYTljYTIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vs b2dfdW5pdHRlc3QucHkKQEAgLTU1Niw2ICs1NTYsMTYgQEAgY2xhc3MgQ2hhbmdlTG9nVGVzdCh1 bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICogU2NyaXB0cy9idWd6aWxsYS10b29sOgogJycn CiAKKyAgICBfbmV3X2VudHJ5X2JvaWxlcnBsYXRlX3dpdGhfdW5yZXZpZXdlZCA9ICcnJzIwMDkt MDgtMTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIE5lZWQgYSBz aG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDUKKworICAgICAgICBVbnJldmlld2VkLgorCisgICAgICAg ICogU2NyaXB0cy9idWd6aWxsYS10b29sOgorJycnCisKICAgICBfbmV3X2VudHJ5X2JvaWxlcnBs YXRlX3dpdGhfbXVsdGlwbGVfYnVndXJsID0gJycnMjAwOS0wOC0xOSAgRXJpYyBTZWlkZWwgIDxl cmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIChPT1BT ISkuCkBAIC01OTUsNiArNjA1LDEyIEBAIGNsYXNzIENoYW5nZUxvZ1Rlc3QodW5pdHRlc3QuVGVz dENhc2UpOgogICAgICAgICBleHBlY3RlZF9jb250ZW50cyA9IGNoYW5nZWxvZ19jb250ZW50cy5y ZXBsYWNlKCdOT0JPRFkgKE9PUFMhKScsIHJldmlld2VyX25hbWUpCiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoYWN0dWFsX2NvbnRlbnRzLnNwbGl0bGluZXMoKSwgZXhwZWN0ZWRfY29udGVudHMu c3BsaXRsaW5lcygpKQogCisgICAgICAgIGNoYW5nZWxvZ19jb250ZW50cyA9IHUiJXNcbiVzIiAl IChzZWxmLl9uZXdfZW50cnlfYm9pbGVycGxhdGVfd2l0aF91bnJldmlld2VkLCBzZWxmLl9leGFt cGxlX2NoYW5nZWxvZykKKyAgICAgICAgZnMud3JpdGVfdGV4dF9maWxlKHNlbGYuX2NoYW5nZWxv Z19wYXRoLCBjaGFuZ2Vsb2dfY29udGVudHMpCisgICAgICAgIENoYW5nZUxvZyhzZWxmLl9jaGFu Z2Vsb2dfcGF0aCwgZnMpLnNldF9yZXZpZXdlcihyZXZpZXdlcl9uYW1lKQorICAgICAgICBhY3R1 YWxfY29udGVudHMgPSBmcy5yZWFkX3RleHRfZmlsZShzZWxmLl9jaGFuZ2Vsb2dfcGF0aCkKKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChhY3R1YWxfY29udGVudHMuc3BsaXRsaW5lcygpLCBjaGFu Z2Vsb2dfY29udGVudHMuc3BsaXRsaW5lcygpKQorCiAgICAgICAgIGNoYW5nZWxvZ19jb250ZW50 c193aXRob3V0X3Jldmlld2VyX2xpbmUgPSB1IiVzXG4lcyIgJSAoc2VsZi5fbmV3X2VudHJ5X2Jv aWxlcnBsYXRlX3dpdGhvdXRfcmV2aWV3ZXJfbGluZSwgc2VsZi5fZXhhbXBsZV9jaGFuZ2Vsb2cp CiAgICAgICAgIGZzLndyaXRlX3RleHRfZmlsZShzZWxmLl9jaGFuZ2Vsb2dfcGF0aCwgY2hhbmdl bG9nX2NvbnRlbnRzX3dpdGhvdXRfcmV2aWV3ZXJfbGluZSkKICAgICAgICAgQ2hhbmdlTG9nKHNl bGYuX2NoYW5nZWxvZ19wYXRoLCBmcykuc2V0X3Jldmlld2VyKHJldmlld2VyX25hbWUpCg==