130216 2014-03-13 16:36:25 -0700 Web Inspector: Network.loadResource should include the response status code 2014-03-13 18:13:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned graouts joepeck timothy webkit-bug-importer oldest_to_newest 990196 0 joepeck 2014-03-13 16:36:25 -0700 Network.loadResource should include the response status code so even on successful 400/500 responses the frontend can consider them failures. 990202 1 226629 joepeck 2014-03-13 17:02:48 -0700 Created attachment 226629 [PATCH] Proposed Fix 990225 2 joepeck 2014-03-13 18:13:32 -0700 <http://trac.webkit.org/changeset/165583> 226629 2014-03-13 17:02:48 -0700 2014-03-13 18:09:33 -0700 [PATCH] Proposed Fix status-code.patch text/plain 6811 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMTA3ZTExLi4xNjg4MTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTQtMDMtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3JrLmxvYWRSZXNvdXJjZSBzaG91bGQgaW5jbHVk ZSB0aGUgcmVzcG9uc2Ugc3RhdHVzIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMDIxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3Bw OgorICAgICAgICBSZWNvcmQgYW5kIHNlbmQgdGhlIGh0dHAgc3RhdHVzIGNvZGUuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvcHJvdG9jb2wvTmV0d29yay5qc29uOgorICAgICAgICBJbmNsdWRlIHN0 YXR1cyBjb2RlIHByb3BlcnR5IGluIHRoZSBzdWNjZXNzIGNhbGxiYWNrLgorCisyMDE0LTAzLTEz ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIElu c3BlY3RvcjogTmV0d29yay5sb2FkUmVzb3VyY2UgWEhSIGNyYXNoIGlmIHBhZ2UgcmVsb2FkZWQg d2hpbGUgcmVxdWVzdCBpcyBvbmdvaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzAyMTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwCmluZGV4IDQyNjI5ZTYuLjlkODgzNmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2Vu dC5jcHAKQEAgLTkxLDYgKzkxLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNl aXZlUmVzcG9uc2UodW5zaWduZWQgbG9uZywgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9u c2UpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBtX21pbWVUeXBlID0gcmVzcG9uc2UubWltZVR5 cGUoKTsKKyAgICAgICAgbV9zdGF0dXNDb2RlID0gcmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKTsK IAogICAgICAgICAvLyBGSVhNRTogVGhpcyBhc3N1bWVzIHRleHQgb25seSByZXNwb25zZXMuIFdl IHNob3VsZCBzdXBwb3J0IG5vbi10ZXh0IHJlc3BvbnNlcyBhcyB3ZWxsLgogICAgICAgICBUZXh0 RW5jb2RpbmcgdGV4dEVuY29kaW5nKHJlc3BvbnNlLnRleHRFbmNvZGluZ05hbWUoKSk7CkBAIC0x MTgsNyArMTE5LDcgQEAgcHVibGljOgogICAgICAgICBpZiAobV9kZWNvZGVyKQogICAgICAgICAg ICAgbV9yZXNwb25zZVRleHQuYXBwZW5kKG1fZGVjb2Rlci0+Zmx1c2goKSk7CiAKLSAgICAgICAg bV9jYWxsYmFjay0+c2VuZFN1Y2Nlc3MobV9yZXNwb25zZVRleHQudG9TdHJpbmcoKSwgbV9taW1l VHlwZSk7CisgICAgICAgIG1fY2FsbGJhY2stPnNlbmRTdWNjZXNzKG1fcmVzcG9uc2VUZXh0LnRv U3RyaW5nKCksIG1fbWltZVR5cGUsIG1fc3RhdHVzQ29kZSk7CiAgICAgICAgIGRpc3Bvc2UoKTsK ICAgICB9CiAKQEAgLTE1Nyw2ICsxNTgsNyBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxUZXh0UmVz b3VyY2VEZWNvZGVyPiBtX2RlY29kZXI7CiAgICAgU3RyaW5nIG1fbWltZVR5cGU7CiAgICAgU3Ry aW5nQnVpbGRlciBtX3Jlc3BvbnNlVGV4dDsKKyAgICBpbnQgbV9zdGF0dXNDb2RlOwogfTsKIAog fSAvLyBuYW1lc3BhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9wcm90 b2NvbC9OZXR3b3JrLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvTmV0 d29yay5qc29uCmluZGV4IDRjNjMyYWEuLjcxNGY4YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9wcm90b2NvbC9OZXR3b3JrLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL3Byb3RvY29sL05ldHdvcmsuanNvbgpAQCAtMjAwLDcgKzIwMCw4IEBACiAgICAg ICAgICAgICBdLAogICAgICAgICAgICAgInJldHVybnMiOiBbCiAgICAgICAgICAgICAgICAgeyAi bmFtZSI6ICJjb250ZW50IiwgInR5cGUiOiAic3RyaW5nIiwgImRlc2NyaXB0aW9uIjogIlJlc291 cmNlIGNvbnRlbnQuIiB9LAotICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAibWltZVR5cGUiLCAi dHlwZSI6ICJzdHJpbmciLCAiZGVzY3JpcHRpb24iOiAiUmVzb3VyY2UgbWltZVR5cGUuIiB9Cisg ICAgICAgICAgICAgICAgeyAibmFtZSI6ICJtaW1lVHlwZSIsICJ0eXBlIjogInN0cmluZyIsICJk ZXNjcmlwdGlvbiI6ICJSZXNvdXJjZSBtaW1lVHlwZS4iIH0sCisgICAgICAgICAgICAgICAgeyAi bmFtZSI6ICJzdGF0dXMiLCAidHlwZSI6ICJudW1iZXIiLCAiZGVzY3JpcHRpb24iOiAiSFRUUCBy ZXNwb25zZSBzdGF0dXMgY29kZS4iIH0KICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAiZGVz Y3JpcHRpb24iOiAiTG9hZHMgYSByZXNvdXJjZSBpbiB0aGUgY29udGV4dCBvZiBhIGZyYW1lIG9u IHRoZSBpbnNwZWN0ZWQgcGFnZSB3aXRob3V0IGNyb3NzIG9yaWdpbiBjaGVja3MuIgogICAgICAg ICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1MjBjMWI0Li40NzkzNjZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNC0wMy0xMyAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5l dHdvcmsubG9hZFJlc291cmNlIHNob3VsZCBpbmNsdWRlIHRoZSByZXNwb25zZSBzdGF0dXMgY29k ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjE2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NvdXJjZU1hcE1hbmFnZXIuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU291cmNlTWFwTWFuYWdlci5wcm90b3R5cGUuc291cmNlTWFwTG9hZGVkKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VNYXBNYW5hZ2VyLnByb3RvdHlwZS5fbG9hZEFuZFBh cnNlU291cmNlTWFwKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9Tb3VyY2VNYXBS ZXNvdXJjZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VNYXBSZXNvdXJjZS5wcm90 b3R5cGUucmVxdWVzdENvbnRlbnRGcm9tQmFja2VuZC5zb3VyY2VNYXBSZXNvdXJjZUxvYWRlZCk6 CisgICAgICAgIElmIHRoZSByZXNwb25zZSBpcyA0MDAgb3IgbGFyZ2VyLCB0cmVhdCBpdCBhcyBh biBlcnJvciAvIGZhaWxlZCBsb2FkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Qcm90b2Nv bC9JbnNwZWN0b3JXZWJCYWNrZW5kQ29tbWFuZHMuanM6CisgICAgICAgIFVwZGF0ZSBwcm90b2Nv bCB0byBwcm92aWRlIHN0YXR1cyBjb2RlIHBhcmFtZXRlci4KKwogMjAxNC0wMy0xMiAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFtpT1MgNl0gdW5jYXVnaHQgZXhjZXB0aW9uIGF0dGVtcHRpbmcgdG8gdXNlIENTU0FnZW50Lmdl dE5hbWVkRmxvd0NvbGxlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NvdXJjZU1hcE1hbmFnZXIuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Tb3VyY2VNYXBNYW5hZ2VyLmpz CmluZGV4IDliYjEwNGQuLjhlODc5OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NvdXJjZU1hcE1hbmFnZXIuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvU291cmNlTWFwTWFu YWdlci5qcwpAQCAtODIsOSArODIsOSBAQCBXZWJJbnNwZWN0b3IuU291cmNlTWFwTWFuYWdlci5w cm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB0aGlzLl9kb3dubG9hZGluZ1NvdXJjZU1hcHNb c291cmNlTWFwVVJMXSA9IHRydWU7CiAKLSAgICAgICAgZnVuY3Rpb24gc291cmNlTWFwTG9hZGVk KGVycm9yLCBjb250ZW50LCBtaW1lVHlwZSkKKyAgICAgICAgZnVuY3Rpb24gc291cmNlTWFwTG9h ZGVkKGVycm9yLCBjb250ZW50LCBtaW1lVHlwZSwgc3RhdHVzQ29kZSkKICAgICAgICAgewotICAg ICAgICAgICAgaWYgKGVycm9yKSB7CisgICAgICAgICAgICBpZiAoZXJyb3IgfHwgc3RhdHVzQ29k ZSA+PSA0MDApIHsKICAgICAgICAgICAgICAgICB0aGlzLl9sb2FkQW5kUGFyc2VGYWlsZWQoc291 cmNlTWFwVVJMKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNl TWFwUmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvU291cmNlTWFwUmVzb3VyY2UuanMKaW5kZXggZTcyYzYyNS4uNjZhNTA5OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZU1hcFJl c291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9Tb3VyY2VNYXBSZXNvdXJjZS5qcwpAQCAtNzksMTEgKzc5LDExIEBAIFdlYkluc3BlY3Rvci5T b3VyY2VNYXBSZXNvdXJjZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICAgICAgfQogCi0gICAgICAgIGZ1bmN0aW9uIHNvdXJjZU1hcFJlc291cmNlTG9hZGVkKGVy cm9yLCBib2R5LCBtaW1lVHlwZSkKKyAgICAgICAgZnVuY3Rpb24gc291cmNlTWFwUmVzb3VyY2VM b2FkZWQoZXJyb3IsIGJvZHksIG1pbWVUeXBlLCBzdGF0dXNDb2RlKQogICAgICAgICB7CiAgICAg ICAgICAgICBjb25zdCBiYXNlNjRlbmNvZGVkID0gZmFsc2U7CiAKLSAgICAgICAgICAgIGlmIChl cnJvcikgeworICAgICAgICAgICAgaWYgKGVycm9yIHx8IHN0YXR1c0NvZGUgPj0gNDAwKSB7CiAg ICAgICAgICAgICAgICAgdGhpcy5tYXJrQXNGYWlsZWQoKTsKICAgICAgICAgICAgICAgICBjYWxs YmFjayhlcnJvciwgYm9keSwgYmFzZTY0ZW5jb2RlZCk7CiAgICAgICAgICAgICAgICAgcmV0dXJu OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9j b2wvSW5zcGVjdG9yV2ViQmFja2VuZENvbW1hbmRzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yV2ViQmFja2VuZENvbW1hbmRzLmpzCmlu ZGV4IGIwODgzYWIuLmEzZThhNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvcldlYkJhY2tlbmRDb21tYW5kcy5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JX ZWJCYWNrZW5kQ29tbWFuZHMuanMKQEAgLTIxMSw3ICsyMTEsNyBAQCBJbnNwZWN0b3JCYWNrZW5k LnJlZ2lzdGVyQ29tbWFuZCgiTmV0d29yay5jbGVhckJyb3dzZXJDYWNoZSIsIFtdLCBbXSk7CiBJ bnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyQ29tbWFuZCgiTmV0d29yay5jYW5DbGVhckJyb3dzZXJD b29raWVzIiwgW10sIFsicmVzdWx0Il0pOwogSW5zcGVjdG9yQmFja2VuZC5yZWdpc3RlckNvbW1h bmQoIk5ldHdvcmsuY2xlYXJCcm93c2VyQ29va2llcyIsIFtdLCBbXSk7CiBJbnNwZWN0b3JCYWNr ZW5kLnJlZ2lzdGVyQ29tbWFuZCgiTmV0d29yay5zZXRDYWNoZURpc2FibGVkIiwgW3sibmFtZSI6 ICJjYWNoZURpc2FibGVkIiwgInR5cGUiOiAiYm9vbGVhbiIsICJvcHRpb25hbCI6IGZhbHNlfV0s IFtdKTsKLUluc3BlY3RvckJhY2tlbmQucmVnaXN0ZXJDb21tYW5kKCJOZXR3b3JrLmxvYWRSZXNv dXJjZSIsIFt7Im5hbWUiOiAiZnJhbWVJZCIsICJ0eXBlIjogInN0cmluZyIsICJvcHRpb25hbCI6 IGZhbHNlfSwgeyJuYW1lIjogInVybCIsICJ0eXBlIjogInN0cmluZyIsICJvcHRpb25hbCI6IGZh bHNlfV0sIFsiY29udGVudCIsICJtaW1lVHlwZSJdKTsKK0luc3BlY3RvckJhY2tlbmQucmVnaXN0 ZXJDb21tYW5kKCJOZXR3b3JrLmxvYWRSZXNvdXJjZSIsIFt7Im5hbWUiOiAiZnJhbWVJZCIsICJ0 eXBlIjogInN0cmluZyIsICJvcHRpb25hbCI6IGZhbHNlfSwgeyJuYW1lIjogInVybCIsICJ0eXBl IjogInN0cmluZyIsICJvcHRpb25hbCI6IGZhbHNlfV0sIFsiY29udGVudCIsICJtaW1lVHlwZSIs ICJzdGF0dXMiXSk7CiAKIC8vIFBhZ2UuCiBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyUGFnZURp c3BhdGNoZXIgPSBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyRG9tYWluRGlzcGF0Y2hlci5iaW5k KEluc3BlY3RvckJhY2tlbmQsICJQYWdlIik7Cg==