130214 2014-03-13 15:57:49 -0700 Web Inspector: AXI: Include Role as an extra attribute in the page overlay. 2014-03-14 12:13:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jcraig jcraig commit-queue graouts jcraig joepeck timothy webkit-bug-importer oldest_to_newest 990191 0 jcraig 2014-03-13 15:57:49 -0700 Include Role as an extra attribute in the page overlay. - Source/WebCore/inspector/InspectorOverlay.cpp – InspectorOverlay::buildObjectForElementInfo includes a string property - Source/WebCore/inspector/InspectorOverlayPage.js – _createElementTitle 990525 1 226726 jcraig 2014-03-14 09:53:10 -0700 Created attachment 226726 patch 990529 2 jcraig 2014-03-14 09:56:25 -0700 <rdar://problem/16326756> 990601 3 226726 commit-queue 2014-03-14 12:13:50 -0700 Comment on attachment 226726 patch Clearing flags on attachment: 226726 Committed r165634: <http://trac.webkit.org/changeset/165634> 990602 4 commit-queue 2014-03-14 12:13:55 -0700 All reviewed patches have been landed. Closing bug. 226726 2014-03-14 09:53:10 -0700 2014-03-14 12:13:49 -0700 patch webkit130214.diff text/plain 2350 jcraig SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTYyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTE0ICBKYW1lcyBD cmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQVhJOiBJ bmNsdWRlIFJvbGUgYXMgYW4gZXh0cmEgYXR0cmlidXRlIGluIHRoZSBwYWdlIG92ZXJsYXkuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAyMTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgUm9s ZSB0byB0aGUgV2ViIEluc3BlY3RvciBlbGVtZW50IG92ZXJsYXkuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZE9iamVj dEZvckVsZW1lbnRJbmZvKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheVBh Z2UuanM6CisgICAgICAgIChfY3JlYXRlRWxlbWVudFRpdGxlKToKKwogMjAxNC0wMy0xNCAgS3J6 eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBNb3ZlIFdlYlNw ZWVjaCBjb2RlIHRvIHVzZSBzdGQ6OnVuaXF1ZV9wdHIKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAJKHJldmlzaW9uIDE2NTYwNSkKKysrIFNv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzAyLDYgKzcwMiwxNSBAQCBzdGF0aWMgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+ IGJ1aWxkCiAgICAgfQogI2VuZGlmCiAKKyAgICAvLyBOZWVkIHRvIGVuYWJsZSBBWCB0byBnZXQg dGhlIGNvbXB1dGVkIHJvbGUuCisgICAgaWYgKCFXZWJDb3JlOjpBWE9iamVjdENhY2hlOjphY2Nl c3NpYmlsaXR5RW5hYmxlZCgpKQorICAgICAgICBXZWJDb3JlOjpBWE9iamVjdENhY2hlOjplbmFi bGVBY2Nlc3NpYmlsaXR5KCk7CisKKyAgICBpZiAoQVhPYmplY3RDYWNoZSogYXhPYmplY3RDYWNo ZSA9IG5vZGUtPmRvY3VtZW50KCkuYXhPYmplY3RDYWNoZSgpKSB7CisgICAgICAgIGlmIChBY2Nl c3NpYmlsaXR5T2JqZWN0KiBheE9iamVjdCA9IGF4T2JqZWN0Q2FjaGUtPmdldE9yQ3JlYXRlKG5v ZGUpKQorICAgICAgICAgICAgZWxlbWVudEluZm8tPnNldFN0cmluZygicm9sZSIsIGF4T2JqZWN0 LT5jb21wdXRlZFJvbGVTdHJpbmcoKSk7CisgICAgfQorCiAgICAgcmV0dXJuIGVsZW1lbnRJbmZv LnJlbGVhc2UoKTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ck92ZXJsYXlQYWdlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JPdmVybGF5UGFnZS5qcwkocmV2aXNpb24gMTY1NjA1KQorKysgU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXlQYWdlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0z NjYsNiArMzY2LDcgQEAgZnVuY3Rpb24gX2NyZWF0ZUVsZW1lbnRUaXRsZShlbGVtZW50SW5mbwog ICAgIGJ1aWxkZXIuYXBwZW5kU3Bhbigibm9kZS1oZWlnaHQiLCBlbGVtZW50SW5mby5ub2RlSGVp Z2h0KTsKICAgICBidWlsZGVyLmFwcGVuZFNwYW4oInB4IiwgInB4Iik7CiAKKyAgICBidWlsZGVy LmFwcGVuZFByb3BlcnR5SWZOb3ROdWxsKCJyb2xlLW5hbWUiLCAiUm9sZSIsIGVsZW1lbnRJbmZv LnJvbGUpOwogICAgIGJ1aWxkZXIuYXBwZW5kUHJvcGVydHlJZk5vdE51bGwoInJlZ2lvbi1mbG93 LW5hbWUiLCAiUmVnaW9uIEZsb3ciLCBlbGVtZW50SW5mby5yZWdpb25GbG93SW5mbyA/IGVsZW1l bnRJbmZvLnJlZ2lvbkZsb3dJbmZvLm5hbWUgOiBudWxsKTsKICAgICBidWlsZGVyLmFwcGVuZFBy b3BlcnR5SWZOb3ROdWxsKCJjb250ZW50LWZsb3ctbmFtZSIsICJDb250ZW50IEZsb3ciLCBlbGVt ZW50SW5mby5jb250ZW50Rmxvd0luZm8gPyBlbGVtZW50SW5mby5jb250ZW50Rmxvd0luZm8ubmFt ZSA6IG51bGwpOwogCg==