130210 2014-03-13 14:28:15 -0700 Build fix with SUBPIXEL_LAYOUT disabled 2014-03-17 07:32:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda benjamin cmarcelo commit-queue dbates esprehn+autocc kangil.han kling webkit-ews zoltan oldest_to_newest 990160 0 thiago.lacerda 2014-03-13 14:28:15 -0700 Fixing increment operation in LayoutUnit value. 990163 1 226623 thiago.lacerda 2014-03-13 14:30:32 -0700 Created attachment 226623 Patch 990288 2 zoltan 2014-03-13 21:35:34 -0700 Yeah, we don't have postfix increment operator on LayoutUnit. The fix looks good to me, but I'm not a reviewer. 990319 3 226623 dbates 2014-03-13 23:46:53 -0700 Comment on attachment 226623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226623&action=review > Source/WebCore/ChangeLog:8 > + Fixing increment operation in LayoutUnit value. Although the change is straightforward, I suggest elaborating on the what is being fixed and why. Maybe something like: Use pre-incremeent operator for LayoutUnit instead of post-increment operator as LayoutUnit doesn't support the latter and we don't make use of the return value. 990322 4 dbates 2014-03-13 23:48:03 -0700 (In reply to comment #3) > (From update of attachment 226623 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226623&action=review > > > Source/WebCore/ChangeLog:8 > > + Fixing increment operation in LayoutUnit value. > > Although the change is straightforward, I suggest elaborating on the what is being fixed and why. Maybe something like: * "the what" => what > > Use pre-incremeent operator for LayoutUnit instead of post-increment operator as LayoutUnit doesn't support the latter and we don't make use of the return value. * pre-increment 990470 5 thiago.lacerda 2014-03-14 07:39:10 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 226623 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=226623&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Fixing increment operation in LayoutUnit value. > > > > Although the change is straightforward, I suggest elaborating on the what is being fixed and why. Maybe something like: > > * "the what" => what > > > > > Use pre-incremeent operator for LayoutUnit instead of post-increment operator as LayoutUnit doesn't support the latter and we don't make use of the return value. > > * pre-increment OK, changing it... 990471 6 226712 thiago.lacerda 2014-03-14 07:41:51 -0700 Created attachment 226712 Changes in ChangeLog 990473 7 226712 commit-queue 2014-03-14 07:44:04 -0700 Comment on attachment 226712 Changes in ChangeLog Rejecting attachment 226712 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 226712, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6619990564274176 990474 8 226713 thiago.lacerda 2014-03-14 07:47:36 -0700 Created attachment 226713 Forgot reviewed by 990488 9 226713 commit-queue 2014-03-14 08:24:37 -0700 Comment on attachment 226713 Forgot reviewed by Clearing flags on attachment: 226713 Committed r165617: <http://trac.webkit.org/changeset/165617> 990887 10 226623 darin 2014-03-15 14:22:12 -0700 Comment on attachment 226623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226623&action=review > Source/WebCore/dom/Element.cpp:-650 > - value++; Was this failing to compile? If not, then we need to fix LayoutUnit so this fails to compile or compiles correctly. We can’t leave this as a trap for future programmers! 991205 11 thiago.lacerda 2014-03-17 07:32:35 -0700 (In reply to comment #10) > (From update of attachment 226623 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226623&action=review > > > Source/WebCore/dom/Element.cpp:-650 > > - value++; > > Was this failing to compile? If not, then we need to fix LayoutUnit so this fails to compile or compiles correctly. We can’t leave this as a trap for future programmers! Darin, this was not compiling 226623 2014-03-13 14:30:32 -0700 2014-03-15 14:22:12 -0700 Patch bug-130210-20140313183008.patch text/plain 1266 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZhYTQzZmRlZDdiYjVj YzU4NzI1NWIzM2E4ZGI0MWIwMWZkOTUyMi4uOTViMjYzMzI2ZTZmNTYyYmVkNTUyNGY2YzFlZDE3 ZjE4OGZmZTI5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTEzICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEJ1aWxkIGZpeCB3aXRoIFNVQlBJWEVMX0xBWU9VVCBkaXNhYmxlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4aW5nIGluY3JlbWVudCBv cGVyYXRpb24gaW4gTGF5b3V0VW5pdCB2YWx1ZS4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdEZvckxvY2FsWm9vbSk6CisKIDIwMTQtMDMtMTMg IEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFRyeSB0byBzdG9w IGFzc2VydHMgaW4gZGVidWcgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggMzAzOTY5 NzQ4NWYxZGJmNGIxMWIzM2ZiNmMyN2NhMzU3MjU0M2U0Ni4uOTZmYmExY2UyZDY4ODdkOTA3NzE4 Mzk0NGQ4NzRhMmZlOTY4OTQwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtNjQ3LDcgKzY0 Nyw3IEBAIHN0YXRpYyBpbnQgYWRqdXN0Rm9yTG9jYWxab29tKExheW91dFVuaXQgdmFsdWUsIFJl bmRlckVsZW1lbnQqIHJlbmRlcmVyKQogI2Vsc2UKICAgICAvLyBOZWVkZWQgYmVjYXVzZSBjb21w dXRlTGVuZ3RoSW50IHRydW5jYXRlcyAocmF0aGVyIHRoYW4gcm91bmRzKSB3aGVuIHNjYWxpbmcg dXAuCiAgICAgaWYgKHpvb21GYWN0b3IgPiAxKQotICAgICAgICB2YWx1ZSsrOworICAgICAgICAr K3ZhbHVlOwogICAgIHJldHVybiBzdGF0aWNfY2FzdDxpbnQ+KHZhbHVlIC8gem9vbUZhY3Rvcik7 CiAjZW5kaWYKIH0K 226712 2014-03-14 07:41:51 -0700 2014-03-14 07:44:04 -0700 Changes in ChangeLog bug-130210-20140314114128.patch text/plain 1423 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIxN2U3MjkyYzczMTVk ZTlkNWQwNDEwYjRjOGExNDBjM2JmNGJiOS4uYzBjMjRlNDVlZjE0NjlhNTIxZDMxYTZkN2NhYmRh ZmEyYTgwM2ExMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTE0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEJ1aWxkIGZpeCB3aXRoIFNVQlBJWEVMX0xBWU9VVCBkaXNhYmxlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHByZS1pbmNyZW1lZW50 IG9wZXJhdG9yIGZvciBMYXlvdXRVbml0IGluc3RlYWQgb2YgcG9zdC1pbmNyZW1lbnQgb3BlcmF0 b3IgYXMgTGF5b3V0VW5pdCBkb2Vzbid0IHN1cHBvcnQgdGhlCisgICAgICAgIGxhdHRlciBhbmQg d2UgZG9uJ3QgbWFrZSB1c2Ugb2YgdGhlIHJldHVybiB2YWx1ZS4KKworICAgICAgICAqIGRvbS9F bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdEZvckxvY2FsWm9vbSk6CisKIDIw MTQtMDMtMTQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAg W0NTU1JlZ2lvbnNdIElubGluZS1ibG9jayBjaGlsZCBvZiBjb250ZW50IG5vZGUgaW5jb3JyZWN0 bHkgY2xpcHBlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IGJiMTViZGRjN2QyNjE1MDk1MjA3 MGRmYTNiN2NiYzM4M2I4MGEwMzguLjlhNzZiYzk0MmFhN2QzY2YzZDhmMDAwYjk0N2Y3OTM0M2Yx ZTczM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTY1Myw3ICs2NTMsNyBAQCBzdGF0aWMg aW50IGFkanVzdEZvckxvY2FsWm9vbShMYXlvdXRVbml0IHZhbHVlLCBSZW5kZXJFbGVtZW50KiBy ZW5kZXJlcikKICNlbHNlCiAgICAgLy8gTmVlZGVkIGJlY2F1c2UgY29tcHV0ZUxlbmd0aEludCB0 cnVuY2F0ZXMgKHJhdGhlciB0aGFuIHJvdW5kcykgd2hlbiBzY2FsaW5nIHVwLgogICAgIGlmICh6 b29tRmFjdG9yID4gMSkKLSAgICAgICAgdmFsdWUrKzsKKyAgICAgICAgKyt2YWx1ZTsKICAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8aW50Pih2YWx1ZSAvIHpvb21GYWN0b3IpOwogI2VuZGlmCiB9Cg== 226713 2014-03-14 07:47:36 -0700 2014-03-14 08:24:37 -0700 Forgot reviewed by bug-130210-20140314114712.patch text/plain 1421 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIxN2U3MjkyYzczMTVk ZTlkNWQwNDEwYjRjOGExNDBjM2JmNGJiOS4uMmQwYmYxMjZjN2ZiMmVhNTY0ZDExM2I1MzIxZDU3 MDViNWY4NTQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTE0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEJ1aWxkIGZpeCB3aXRoIFNVQlBJWEVMX0xBWU9VVCBkaXNhYmxlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMjEwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgorCisgICAgICAgIFVzZSBwcmUtaW5jcmVtZWVudCBv cGVyYXRvciBmb3IgTGF5b3V0VW5pdCBpbnN0ZWFkIG9mIHBvc3QtaW5jcmVtZW50IG9wZXJhdG9y IGFzIExheW91dFVuaXQgZG9lc24ndCBzdXBwb3J0IHRoZQorICAgICAgICBsYXR0ZXIgYW5kIHdl IGRvbid0IG1ha2UgdXNlIG9mIHRoZSByZXR1cm4gdmFsdWUuCisKKyAgICAgICAgKiBkb20vRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjphZGp1c3RGb3JMb2NhbFpvb20pOgorCiAyMDE0 LTAzLTE0ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFtD U1NSZWdpb25zXSBJbmxpbmUtYmxvY2sgY2hpbGQgb2YgY29udGVudCBub2RlIGluY29ycmVjdGx5 IGNsaXBwZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCBiYjE1YmRkYzdkMjYxNTA5NTIwNzBk ZmEzYjdjYmMzODNiODBhMDM4Li45YTc2YmM5NDJhYTdkM2NmM2Q4ZjAwMGI5NDdmNzkzNDNmMWU3 MzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC02NTMsNyArNjUzLDcgQEAgc3RhdGljIGlu dCBhZGp1c3RGb3JMb2NhbFpvb20oTGF5b3V0VW5pdCB2YWx1ZSwgUmVuZGVyRWxlbWVudCogcmVu ZGVyZXIpCiAjZWxzZQogICAgIC8vIE5lZWRlZCBiZWNhdXNlIGNvbXB1dGVMZW5ndGhJbnQgdHJ1 bmNhdGVzIChyYXRoZXIgdGhhbiByb3VuZHMpIHdoZW4gc2NhbGluZyB1cC4KICAgICBpZiAoem9v bUZhY3RvciA+IDEpCi0gICAgICAgIHZhbHVlKys7CisgICAgICAgICsrdmFsdWU7CiAgICAgcmV0 dXJuIHN0YXRpY19jYXN0PGludD4odmFsdWUgLyB6b29tRmFjdG9yKTsKICNlbmRpZgogfQo=