130208 2014-03-13 13:45:17 -0700 [iOS WebKit2] block selection should avoid large blocks 2014-03-13 15:37:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 990151 0 enrica 2014-03-13 13:45:17 -0700 When trying to create a block selection we should avoid any block that is larger than the visible portion of the document. <rdar://problem/16251785> 990152 1 226619 enrica 2014-03-13 13:52:08 -0700 Created attachment 226619 Patch 990185 2 enrica 2014-03-13 15:37:43 -0700 Committed revision 165572. 226619 2014-03-13 13:52:08 -0700 2014-03-13 15:15:18 -0700 Patch avoidlargeblocks.txt text/plain 5866 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTU2NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE0LTAzLTEzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXZWJLaXQyXSBibG9j ayBzZWxlY3Rpb24gc2hvdWxkIGF2b2lkIGxhcmdlIGJsb2Nrcy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDIwOAorICAgICAgICA8cmRhcjovL3By b2JsZW0vMTYyNTE3ODU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBjcmVhdGluZyBhIGJsb2NrIHNlbGVjdGlvbiwgd2Ugc2hvdWxkIGRpc2Nh cmQgYmxvY2tzIHRoYXQKKyAgICAgICAgYXJlIGxhcmdlciB0aGFuIG1vc3Qgb2YgdGhlIHZpc2li bGUgcG9ydGlvbiBvZiB0aGUgZG9jdW1lbnQuCisgICAgICAgIFRoaXMgcHJldmVudHMgdGhlIGFj Y2lkZW50YWwgc2VsZWN0aW9uIHRoZSBlbnRpcmUgZG9jdW1lbnQsIHdoaWNoCisgICAgICAgIGlz IGZhaXJseSBjb21tb24gd2hlbiB0YXBwaW5nIG92ZXIgZW1wdHkgYXJlYXMuCisKKyAgICAgICAg KiBTaGFyZWQvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uY3BwOgorICAgICAgICAo V2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjo6ZW5jb2RlKToKKyAgICAg ICAgKFdlYktpdDo6SW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb246OmRlY29kZSk6Cisg ICAgICAgICogU2hhcmVkL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLmg6IFJlbW92 ZWQgc2VsZWN0aW9uUmVjdHMgdGhhdCB3YXMgbm90IHJlYWxseSBuZWVkZWQgYW5kCisgICAgICAg IGFkZGVkIGlzU2VsZWN0YWJsZSB0byBpbmRpY2F0ZSB3aGV0aGVyIHRoZSBzZWxlY3Rpb24gY2Fu IHN0YXJ0LgorICAgICAgICAoV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlv bjo6SW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24pOgorICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IGhhc1NlbGVjdGFibGVQb3NpdGlvbkF0UG9pbnQ6XSk6IE5vdyB1c2VzIGlzU2VsZWN0YWJs ZS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24pOiBUYWtlcyBpbnRv IGFjY291bnQgdGhlIHVzZXJTZWxlY3QgcHJvcGVydHkKKyAgICAgICAgdG8gZmlndXJlIG91dCBp ZiB0aGUgZWxlbWVudCBjYW4gYmUgc2VsZWN0ZWQgYW5kIGRpc2NhcmRzIGJsb2NrcyB0aGF0IGFy ZQorICAgICAgICBsYXJnZXIgdGhhbiA5NyUgb2YgdGhlIHZpc2libGUgYXJlYSBvZiB0aGUgZG9j dW1lbnQuCisKIDIwMTQtMDMtMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KIAogICAgICAgICBSZW5hbWUgV0tWaXNpdGVkTGlua1Byb3ZpZGVyIHRvIF9XS1Zpc2l0ZWRM aW5rUHJvdmlkZXIgYW5kIG1ha2UgaXQgcHJpdmF0ZQpJbmRleDogU291cmNlL1dlYktpdDIvU2hh cmVkL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uY3Bw CShyZXZpc2lvbiAxNjU1NDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvSW50ZXJhY3Rpb25J bmZvcm1hdGlvbkF0UG9zaXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiwxMCArMzYsMTAg QEAgdm9pZCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjo6ZQogewogICAgIGVuY29k ZXIgPDwgcG9pbnQ7CiAgICAgZW5jb2RlciA8PCBub2RlQXRQb3NpdGlvbklzQXNzaXN0ZWROb2Rl OworICAgIGVuY29kZXIgPDwgaXNTZWxlY3RhYmxlOwogICAgIGVuY29kZXIgPDwgY2xpY2thYmxl RWxlbWVudE5hbWU7CiAgICAgZW5jb2RlciA8PCB1cmw7CiAgICAgZW5jb2RlciA8PCB0aXRsZTsK LSAgICBlbmNvZGVyIDw8IHNlbGVjdGlvblJlY3RzOwogICAgIGVuY29kZXIgPDwgYm91bmRzOwog fQogCkBAIC01MSw2ICs1MSw5IEBAIGJvb2wgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRp b246OmQKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5ub2RlQXRQb3NpdGlvbklzQXNz aXN0ZWROb2RlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKCFkZWNvZGVyLmRl Y29kZShyZXN1bHQuaXNTZWxlY3RhYmxlKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAg aWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuY2xpY2thYmxlRWxlbWVudE5hbWUpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKQEAgLTYwLDkgKzYzLDYgQEAgYm9vbCBJbnRlcmFjdGlvbkluZm9y bWF0aW9uQXRQb3NpdGlvbjo6ZAogICAgIGlmICghZGVjb2Rlci5kZWNvZGUocmVzdWx0LnRpdGxl KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1 bHQuc2VsZWN0aW9uUmVjdHMpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICBpZiAoIWRl Y29kZXIuZGVjb2RlKHJlc3VsdC5ib3VuZHMpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlv bi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9JbnRlcmFjdGlvbkluZm9y bWF0aW9uQXRQb3NpdGlvbi5oCShyZXZpc2lvbiAxNjU1NDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uaAkod29ya2luZyBjb3B5KQpA QCAtMzcsMTUgKzM3LDE2IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogc3RydWN0IEludGVyYWN0aW9u SW5mb3JtYXRpb25BdFBvc2l0aW9uIHsKICAgICBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3Np dGlvbigpCiAgICAgICAgIDogbm9kZUF0UG9zaXRpb25Jc0Fzc2lzdGVkTm9kZShmYWxzZSkKKyAg ICAgICAgLCBpc1NlbGVjdGFibGUoZmFsc2UpCiAgICAgewogICAgIH0KIAogICAgIFdlYkNvcmU6 OkludFBvaW50IHBvaW50OwogICAgIGJvb2wgbm9kZUF0UG9zaXRpb25Jc0Fzc2lzdGVkTm9kZTsK KyAgICBib29sIGlzU2VsZWN0YWJsZTsKICAgICBTdHJpbmcgY2xpY2thYmxlRWxlbWVudE5hbWU7 CiAgICAgU3RyaW5nIHVybDsKICAgICBTdHJpbmcgdGl0bGU7Ci0gICAgVmVjdG9yPFdlYkNvcmU6 OlNlbGVjdGlvblJlY3Q+IHNlbGVjdGlvblJlY3RzOwogICAgIFdlYkNvcmU6OkludFJlY3QgYm91 bmRzOwogCiAgICAgdm9pZCBlbmNvZGUoSVBDOjpBcmd1bWVudEVuY29kZXImKSBjb25zdDsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAxNjU1NDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpA QCAtNTc0LDkgKzU3NCw3IEBAIC0gKHZvaWQpX2NhbmNlbEludGVyYWN0aW9uCiAtIChCT09MKWhh c1NlbGVjdGFibGVQb3NpdGlvbkF0UG9pbnQ6KENHUG9pbnQpcG9pbnQKIHsKICAgICBbc2VsZiBl bnN1cmVQb3NpdGlvbkluZm9ybWF0aW9uSXNVcFRvRGF0ZTpwb2ludF07Ci0gICAgLy8gRklYTUU6 IFRoaXMgY2hlY2sgbmVlZHMgdG8gYmUgZXh0ZW5kZWQgdG8gaW5jbHVkZSBvdGhlciBlbGVtZW50 cy4KLSAgICAvLyBGSVhNRTogV2UgbmVlZCB0byByZWplY3QgcG9zaXRpb25zIHRoYXQgd2lsbCBs ZWFkIHRvIGEgdmVyeSBsYXJnZSBzZWxlY3Rpb24uCi0gICAgcmV0dXJuIF9wb3NpdGlvbkluZm9y bWF0aW9uLmNsaWNrYWJsZUVsZW1lbnROYW1lICE9ICJJTUciICYmIF9wb3NpdGlvbkluZm9ybWF0 aW9uLmNsaWNrYWJsZUVsZW1lbnROYW1lICE9ICJBIiAmJiAhX3Bvc2l0aW9uSW5mb3JtYXRpb24u c2VsZWN0aW9uUmVjdHMuaXNFbXB0eSgpOworICAgIHJldHVybiBfcG9zaXRpb25JbmZvcm1hdGlv bi5pc1NlbGVjdGFibGU7CiB9CiAKIC0gKEJPT0wpcG9pbnRJc0luQXNzaXN0ZWROb2RlOihDR1Bv aW50KXBvaW50CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tCShyZXZpc2lvbiAxNjU1NDYpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHdvcmtpbmcgY29weSkKQEAg LTE0OTEsOSArMTQ5MSwxMiBAQCB2b2lkIFdlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24o Y29uCiAgICAgICAgIGhpdE5vZGUgPSByZXN1bHQuaW5uZXJOb2RlKCk7CiAgICAgICAgIC8vIEhp dCB0ZXN0IGNvdWxkIHJldHVybiBIVE1MSHRtbEVsZW1lbnQgdGhhdCBoYXMgbm8gcmVuZGVyZXIs IGlmIHRoZSBib2R5IGlzIHNtYWxsZXIgdGhhbiB0aGUgZG9jdW1lbnQuCiAgICAgICAgIGlmICho aXROb2RlICYmIGhpdE5vZGUtPnJlbmRlcmVyKCkpIHsKKyAgICAgICAgICAgIFJlbmRlck9iamVj dCogcmVuZGVyZXIgPSBoaXROb2RlLT5yZW5kZXJlcigpOwogICAgICAgICAgICAgbV9wYWdlLT5m b2N1c0NvbnRyb2xsZXIoKS5zZXRGb2N1c2VkRnJhbWUocmVzdWx0LmlubmVyTm9kZUZyYW1lKCkp OwotICAgICAgICAgICAgaW5mby5zZWxlY3Rpb25SZWN0cy5hcHBlbmQoU2VsZWN0aW9uUmVjdCho aXROb2RlLT5yZW5kZXJlcigpLT5hYnNvbHV0ZUJvdW5kaW5nQm94UmVjdCh0cnVlKSwgdHJ1ZSwg MCkpOwotICAgICAgICAgICAgaW5mby5ib3VuZHMgPSBoaXROb2RlLT5yZW5kZXJlcigpLT5hYnNv bHV0ZUJvdW5kaW5nQm94UmVjdCgpOworICAgICAgICAgICAgaW5mby5ib3VuZHMgPSByZW5kZXJl ci0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3QodHJ1ZSk7CisgICAgICAgICAgICAvLyBXZSBkb24n dCB3YW50IHRvIHNlbGVjdCBibG9ja3MgdGhhdCBhcmUgbGFyZ2VyIHRoYW4gOTclIG9mIHRoZSB2 aXNpYmxlIGFyZWEgb2YgdGhlIGRvY3VtZW50LgorICAgICAgICAgICAgY29uc3Qgc3RhdGljIENH RmxvYXQgZmFjdG9yID0gMC45NzsKKyAgICAgICAgICAgIGluZm8uaXNTZWxlY3RhYmxlID0gcmVu ZGVyZXItPnN0eWxlKCkudXNlclNlbGVjdCgpICE9IFNFTEVDVF9OT05FICYmIGluZm8uYm91bmRz LmhlaWdodCgpIDwgcmVzdWx0LmlubmVyTm9kZUZyYW1lKCktPnZpZXcoKS0+dW5vYnNjdXJlZENv bnRlbnRSZWN0KCkuaGVpZ2h0KCkgKiBmYWN0b3I7CiAgICAgICAgIH0KICAgICB9CiB9Cg==