130200 2014-03-13 11:53:44 -0700 [iOS WebKit2] Crash on iPad when displaying a select element with options 2014-03-13 12:21:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 990099 0 enrica 2014-03-13 11:53:44 -0700 _singleSelectionIndex should be initialized to NSNotFound for multiSelect elements. <rdar://problem/16316187> 990100 1 226606 enrica 2014-03-13 11:55:23 -0700 Created attachment 226606 Patch 990101 2 226607 enrica 2014-03-13 11:57:21 -0700 Created attachment 226607 Patch with ChangeLog 990109 3 226607 simon.fraser 2014-03-13 12:18:51 -0700 Comment on attachment 226607 Patch with ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=226607&action=review > Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm:118 > NSInteger currentIndex = 0; > + _singleSelectionIndex = NSNotFound; Please swap these two lines. 990114 4 enrica 2014-03-13 12:21:13 -0700 Committed revision 165554. 226606 2014-03-13 11:55:23 -0700 2014-03-13 11:57:21 -0700 Patch multiselectcrash.txt text/plain 1327 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTU1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAzLTEzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2Ny aXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9p b3MvZm9ybXMvV0tGb3JtU2VsZWN0UG9wb3Zlci5tbToKKyAgICAgICAgKC1bV0tTZWxlY3RUYWJs ZVZpZXdDb250cm9sbGVyIGluaXRXaXRoVmlldzpoYXNHcm91cHM6XSk6CisKIDIwMTQtMDMtMTMg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIENsb3NlIHRoZSBjb25uZWN0aW9uIHdoZW4gd2UgZmFpbCB0byByZWFkIGZyb20gdGhlIHNv Y2tldCBmb3IgYW55IHVuaGFuZGxlZCBlcnJvcgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2lvcy9mb3Jtcy9XS0Zvcm1TZWxlY3RQb3BvdmVyLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtU2VsZWN0UG9wb3Zlci5tbQkocmV2 aXNpb24gMTY1NTQ2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zv cm1TZWxlY3RQb3BvdmVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTUsNiArMTE1LDcgQEAgLSAo aWQpaW5pdFdpdGhWaWV3OihXS0NvbnRlbnRWaWV3ICopdmlldwogICAgIC8vIEV2ZW4gaWYgdGhl IHNlbGVjdCBpcyBlbXB0eSwgdGhlcmUgaXMgYXQgbGVhc3Qgb25lIHRhYmxldmlldyBzZWN0aW9u LgogICAgIF9udW1iZXJPZlNlY3Rpb25zID0gMTsKICAgICBOU0ludGVnZXIgY3VycmVudEluZGV4 ID0gMDsKKyAgICBfc2luZ2xlU2VsZWN0aW9uSW5kZXggPSBOU05vdEZvdW5kOwogICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgc2VsZWN0T3B0aW9ucy5zaXplKCk7ICsraSkgewogICAgICAgICBj b25zdCBXS09wdGlvbkl0ZW0mIGl0ZW0gPSBzZWxlY3RPcHRpb25zW2ldOwogICAgICAgICBpZiAo aXRlbS5pc0dyb3VwKSB7Cg== 226607 2014-03-13 11:57:21 -0700 2014-03-13 12:18:48 -0700 Patch with ChangeLog multiselectcrash.txt text/plain 1527 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTU1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTEzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyBXZWJLaXQyXSBDcmFz aCBvbiBpUGFkIHdoZW4gZGlzcGxheWluZyBhIHNlbGVjdCBlbGVtZW50IHdpdGggb3B0aW9ucy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDIwMAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYzMTYxODc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgX3NpbmdsZVNlbGVjdGlvbkluZGV4IHNob3VsZCBi ZSBpbml0aWFsaXplZCB0byBOU05vdEZvdW5kIGZvciBtdWx0aVNlbGVjdCBlbGVtZW50cy4KKyAg ICAgICAgCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1TZWxlY3RQb3BvdmVy Lm1tOgorICAgICAgICAoLVtXS1NlbGVjdFRhYmxlVmlld0NvbnRyb2xsZXIgaW5pdFdpdGhWaWV3 Omhhc0dyb3VwczpdKToKKwogMjAxNC0wMy0xMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQ2xvc2UgdGhlIGNvbm5lY3Rpb24gd2hl biB3ZSBmYWlsIHRvIHJlYWQgZnJvbSB0aGUgc29ja2V0IGZvciBhbnkgdW5oYW5kbGVkIGVycm9y CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBv cG92ZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jt cy9XS0Zvcm1TZWxlY3RQb3BvdmVyLm1tCShyZXZpc2lvbiAxNjU1NDYpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBvcG92ZXIubW0JKHdvcmtpbmcg Y29weSkKQEAgLTExNSw2ICsxMTUsNyBAQCAtIChpZClpbml0V2l0aFZpZXc6KFdLQ29udGVudFZp ZXcgKil2aWV3CiAgICAgLy8gRXZlbiBpZiB0aGUgc2VsZWN0IGlzIGVtcHR5LCB0aGVyZSBpcyBh dCBsZWFzdCBvbmUgdGFibGV2aWV3IHNlY3Rpb24uCiAgICAgX251bWJlck9mU2VjdGlvbnMgPSAx OwogICAgIE5TSW50ZWdlciBjdXJyZW50SW5kZXggPSAwOworICAgIF9zaW5nbGVTZWxlY3Rpb25J bmRleCA9IE5TTm90Rm91bmQ7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzZWxlY3RPcHRp b25zLnNpemUoKTsgKytpKSB7CiAgICAgICAgIGNvbnN0IFdLT3B0aW9uSXRlbSYgaXRlbSA9IHNl bGVjdE9wdGlvbnNbaV07CiAgICAgICAgIGlmIChpdGVtLmlzR3JvdXApIHsK