13020 2007-03-08 23:06:46 -0800 REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab 2008-01-21 04:47:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://enfinitystudios.thaposse.net/ InRadar, Regression P1 Normal --- 1 esprehn webkit-unassigned adele ap oldest_to_newest 19821 0 esprehn 2007-03-08 23:06:46 -0800 An onkeypress event handler for an input element which returns false to abort the key press will be ignored when the key that was pressed was Tab. The return value of false is obeyed when the key is not the Tab key. However, If the onkeydown event is used instead the return value of false will be obeyed for Tab. This new behavior is consistent with IE, however it is inconsistent with Gecko and previous versions of Safari. Reproducible in latest nightly: (Fri Mar 9 6:30:40 GMT 2007) 19792 1 13554 esprehn 2007-03-08 23:18:45 -0800 Created attachment 13554 Test Case In this test case pressing tab in both inputs should do nothing as per previous Safari behavior. However in the input where the event handler was attached with onkeypress the return value of false is ignored and the focus jumps off the input to the Back button in the browser. 19793 2 esprehn 2007-03-08 23:20:40 -0800 It should also be noted that Gecko allows aborting Tab key presses with onkeypress, but *not* with onkeydown, which is the exact opposite of this bug. 19764 3 ap 2007-03-09 09:20:36 -0800 Confirmed as a regression with r20057. 19003 4 mrowe 2007-03-13 16:22:00 -0700 <rdar://problem/5061024> 17582 5 adele 2007-03-23 14:25:51 -0700 Committed revision 20453. 67839 6 ap 2008-01-21 04:47:22 -0800 We no longer dispatch keypress event for tab, arrow keys etc., so this fix has been effectively undone. 13554 2007-03-08 23:18:45 -0800 2007-03-08 23:18:45 -0800 Test Case keypress-error.html text/html 884 esprehn PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIgogICAgICAg ICJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9zdHJpY3QuZHRkIj4KCjxodG1sPgoKPGhlYWQ+ Cgk8dGl0bGU+QWJvcnQgVGFiIFByZXNzPC90aXRsZT4KCTxtZXRhIGh0dHAtZXF1aXY9ImNvbnRl bnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KCQoJPHN0eWxlIHR5 cGU9InRleHQvY3NzIj4KCTwvc3R5bGU+CgkKCTxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0 Ij4KCQlrZXloYW5kbGVyID0gZnVuY3Rpb24oZSkgewoJCQl2YXIgZWwgPSBlLnRhcmdldDsKCQkJ dmFyIGtjID0gZS5rZXlDb2RlP2Uua2V5Q29kZTplLndoaWNoOwoJCQkKCQkJLy8gdHJhcCB0YWJz CgkJCWlmKCBrYyA9PSA5ICkgewoJCQkJcmV0dXJuIGZhbHNlOwoJCQl9CgkJCQoJCQlyZXR1cm4g dHJ1ZTsKCQl9CQoJCgkJd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgewoJCQlkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgib25rZXlwcmVzcyIpLm9ua2V5cHJlc3MgPSBrZXloYW5kbGVyOwoJCQlk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgib25rZXlkb3duIikub25rZXlkb3duID0ga2V5aGFuZGxl cjsJCQkKCQl9Cgk8L3NjcmlwdD4KCQo8L2hlYWQ+Cjxib2R5PgoJPGZvcm0gYWN0aW9uPSIiPgoJ CTxkaXY+CgkJCTxsYWJlbD5XaXRoIG9ua2V5cHJlc3M8aW5wdXQgdHlwZT0idGV4dCIgaWQ9Im9u a2V5cHJlc3MiIG5hbWU9InRlc3QiPjwvbGFiZWw+CgkJCTxsYWJlbD5XaXRoIG9ua2V5ZG93bjxp bnB1dCB0eXBlPSJ0ZXh0IiBpZD0ib25rZXlkb3duIiBuYW1lPSJ0ZXN0Ij48L2xhYmVsPgoJCTwv ZGl2PgoJPC9mb3JtPgo8L2JvZHk+CjwvaHRtbD4=