130193 2014-03-13 07:15:35 -0700 Fix the !ENABLE(SVG_FONTS) build 2014-03-14 03:13:28 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zsborbely.u-szeged webkit-unassigned commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan krit pdr schenney sergio webkit-ews zimmermann oldest_to_newest 989999 0 zsborbely.u-szeged 2014-03-13 07:15:35 -0700 tested on r165529: Tools/Scripts/build-webkit --efl --no-svg-fonts build log: ... Linking CXX shared library ../../lib/libewebkit2.so ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/InlineTextBox.cpp.o: In function `WebCore::InlineTextBox::constructTextRun(WebCore::RenderStyle const&, WebCore::Font const&, WTF::String, int, WebCore::BufferForAppendingHyphen*) const': InlineTextBox.cpp:(.text._ZNK7WebCore13InlineTextBox16constructTextRunERKNS_11RenderStyleERKNS_4FontEN3WTF6StringEiPNS_24BufferForAppendingHyphenE+0x3d9): undefined reference to `vtable for WebCore::SVGTextRunRenderingContext' ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o: In function `WebCore::TextRun WebCore::constructTextRunInternal<unsigned char>(WebCore::RenderObject*, WebCore::Font const&, unsigned char const*, int, WebCore::RenderStyle const&, unsigned int)': RenderBlock.cpp:(.text._ZN7WebCoreL24constructTextRunInternalIhEENS_7TextRunEPNS_12RenderObjectERKNS_4FontEPKT_iRKNS_11RenderStyleEj+0xcd): undefined reference to `vtable for WebCore::SVGTextRunRenderingContext' ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o: In function `WebCore::TextRun WebCore::constructTextRunInternal<unsigned short>(WebCore::RenderObject*, WebCore::Font const&, unsigned short const*, int, WebCore::RenderStyle const&, unsigned int)': RenderBlock.cpp:(.text._ZN7WebCoreL24constructTextRunInternalItEENS_7TextRunEPNS_12RenderObjectERKNS_4FontEPKT_iRKNS_11RenderStyleEj+0xcd): undefined reference to `vtable for WebCore::SVGTextRunRenderingContext' ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o: In function `WebCore::RenderBlock::constructTextRun(WebCore::RenderObject*, WebCore::Font const&, WTF::String const&, WebCore::RenderStyle const&, unsigned int, unsigned int)': RenderBlock.cpp:(.text._ZN7WebCore11RenderBlock16constructTextRunEPNS_12RenderObjectERKNS_4FontERKN3WTF6StringERKNS_11RenderStyleEjj+0x27d): undefined reference to `vtable for WebCore::SVGTextRunRenderingContext' ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o: In function `WebCore::RenderBlock::constructTextRun(WebCore::RenderObject*, WebCore::Font const&, unsigned short const*, int, WebCore::RenderStyle const&, unsigned int)': RenderBlock.cpp:(.text._ZN7WebCore11RenderBlock16constructTextRunEPNS_12RenderObjectERKNS_4FontEPKtiRKNS_11RenderStyleEj+0xcd): undefined reference to `vtable for WebCore::SVGTextRunRenderingContext' ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/svg/SVGInlineTextBox.cpp.o:SVGInlineTextBox.cpp:(.text._ZNK7WebCore16SVGInlineTextBox16constructTextRunEPNS_11RenderStyleERKNS_15SVGTextFragmentE+0x171): more undefined references to `vtable for WebCore::SVGTextRunRenderingContext' follow collect2: error: ld returned 1 exit status make[2]: *** [lib/libewebkit2.so.0.1.0] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [all] Error 2 Reason: When SVG_FONTS disabled, the virtual createGlyphToPathTranslator() function there is not defined, we get linker errors. 990000 1 226591 zsborbely.u-szeged 2014-03-13 07:18:31 -0700 Created attachment 226591 Proposed patch 990375 2 226591 commit-queue 2014-03-14 03:13:22 -0700 Comment on attachment 226591 Proposed patch Clearing flags on attachment: 226591 Committed r165611: <http://trac.webkit.org/changeset/165611> 990376 3 commit-queue 2014-03-14 03:13:28 -0700 All reviewed patches have been landed. Closing bug. 226591 2014-03-13 07:18:31 -0700 2014-03-14 03:13:22 -0700 Proposed patch svgfonts.patch text/plain 2634 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMDA1MDk3Li42ZTI5ZjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDMtMTMgIFpzb2x0IEJvcmJlbHkgIDxib3JiZXpzQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBGaXggdGhlICFFTkFCTEUoU1ZHX0ZPTlRTKSBidWlsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMTkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgRU5BQkxFKFNW R19GT05UUykgZ3VhcmRzIGZvciBjcmVhdGVHbHlwaFRvUGF0aFRyYW5zbGF0b3IoKSBmdW5jdGlv bgorICAgICAgICBpbiBTVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5oIGFuZCBUZXh0UnVuLmgs IGJlY2F1c2Ugd2hlbiB0aGUgU1ZHX0ZPTlRTIGFyZQorICAgICAgICBkaXNhYmxlZCB0aGUgZnVu Y3Rpb24gaXMgbm90IGltcGxlbWVudGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv VGV4dFJ1bi5oOgorICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0Nv bnRleHQuaDoKKwogMjAxNC0wMy0xMiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgUmVwbGF5OiBhZGQgaW5mcmFzdHJ1Y3R1cmUgZm9yIG1lbW9pemluZyBub25k ZXRlcm1pbmlzdGljIERPTSBBUElzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9UZXh0UnVuLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9U ZXh0UnVuLmgKaW5kZXggMjMwYmRmMy4uNjk4NTQxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGV4dFJ1bi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL1RleHRSdW4uaApAQCAtMTg5LDcgKzE4OSw2IEBAIHB1YmxpYzoKIAogICAg IGNsYXNzIFJlbmRlcmluZ0NvbnRleHQgOiBwdWJsaWMgUmVmQ291bnRlZDxSZW5kZXJpbmdDb250 ZXh0PiB7CiAgICAgcHVibGljOgotICAgICAgICB2aXJ0dWFsIHN0ZDo6dW5pcXVlX3B0cjxHbHlw aFRvUGF0aFRyYW5zbGF0b3I+IGNyZWF0ZUdseXBoVG9QYXRoVHJhbnNsYXRvcihjb25zdCBTaW1w bGVGb250RGF0YSYsIGNvbnN0IEdseXBoQnVmZmVyJiwgaW50IGZyb20sIGludCBudW1HbHlwaHMs IGNvbnN0IEZsb2F0UG9pbnQmKSBjb25zdCA9IDA7CiAgICAgICAgIHZpcnR1YWwgflJlbmRlcmlu Z0NvbnRleHQoKSB7IH0KIAogI2lmIEVOQUJMRShTVkdfRk9OVFMpCkBAIC0xOTcsNiArMTk2LDcg QEAgcHVibGljOgogICAgICAgICB2aXJ0dWFsIHZvaWQgZHJhd1NWR0dseXBocyhHcmFwaGljc0Nv bnRleHQqLCBjb25zdCBTaW1wbGVGb250RGF0YSosIGNvbnN0IEdseXBoQnVmZmVyJiwgaW50IGZy b20sIGludCB0bywgY29uc3QgRmxvYXRQb2ludCYpIGNvbnN0ID0gMDsKICAgICAgICAgdmlydHVh bCBmbG9hdCBmbG9hdFdpZHRoVXNpbmdTVkdGb250KGNvbnN0IEZvbnQmLCBjb25zdCBUZXh0UnVu JiwgaW50JiBjaGFyc0NvbnN1bWVkLCBTdHJpbmcmIGdseXBoTmFtZSkgY29uc3QgPSAwOwogICAg ICAgICB2aXJ0dWFsIGJvb2wgYXBwbHlTVkdLZXJuaW5nKGNvbnN0IFNpbXBsZUZvbnREYXRhKiwg V2lkdGhJdGVyYXRvciYsIEdseXBoQnVmZmVyKiwgaW50IGZyb20pIGNvbnN0ID0gMDsKKyAgICAg ICAgdmlydHVhbCBzdGQ6OnVuaXF1ZV9wdHI8R2x5cGhUb1BhdGhUcmFuc2xhdG9yPiBjcmVhdGVH bHlwaFRvUGF0aFRyYW5zbGF0b3IoY29uc3QgU2ltcGxlRm9udERhdGEmLCBjb25zdCBHbHlwaEJ1 ZmZlciYsIGludCBmcm9tLCBpbnQgbnVtR2x5cGhzLCBjb25zdCBGbG9hdFBvaW50JikgY29uc3Qg PSAwOwogI2VuZGlmCiAgICAgfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5oCmluZGV4IGI2ZTI1OWYuLjUz NjgxZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1 blJlbmRlcmluZ0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NW R1RleHRSdW5SZW5kZXJpbmdDb250ZXh0LmgKQEAgLTU5LDcgKzU5LDkgQEAgcHJpdmF0ZToKIAog ICAgIHZpcnR1YWwgflNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0KCkgeyB9CiAKKyNpZiBFTkFC TEUoU1ZHX0ZPTlRTKQogICAgIHZpcnR1YWwgc3RkOjp1bmlxdWVfcHRyPEdseXBoVG9QYXRoVHJh bnNsYXRvcj4gY3JlYXRlR2x5cGhUb1BhdGhUcmFuc2xhdG9yKGNvbnN0IFNpbXBsZUZvbnREYXRh JiwgY29uc3QgR2x5cGhCdWZmZXImLCBpbnQgZnJvbSwgaW50IG51bUdseXBocywgY29uc3QgRmxv YXRQb2ludCYpIGNvbnN0IG92ZXJyaWRlOworI2VuZGlmCiAKICAgICBSZW5kZXJPYmplY3QmIG1f cmVuZGVyZXI7CiAK