13019 2007-03-08 20:46:24 -0800 REGRESSION (r20074): Forms don't submit on a variety of websites 2007-03-11 09:59:24 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://www.facebook.com Regression P1 Normal --- 1 jgrybows webkit-unassigned ap darin ernest.prabhakar oldest_to_newest 19836 0 jgrybows 2007-03-08 20:46:24 -0800 Steps to reproduce: 1.Using nightly build r20077, go to a number of sites, e.g. Facebook.com 2. Try to log in by entering info and clicking "login" Expected result: the form submits and you log in. Actual result: nothing happens. This seems to happen on a variety of websites, including (I'm told) Yahoo Mail. However, it's not universal, as Google still seems to work just fine. I'm told this regressed in r20076 or r20077, so it's probably one of those changes that caused this. I'd really appreciate a fix soon, as this renders using TOT Webkit incredibly frustrating (hence my typing this in Firefox). 19825 1 jgrybows 2007-03-08 20:48:29 -0800 (In reply to comment #0) > I'm told this regressed in r20076 or r20077, so it's probably one of those > changes that caused this. Okay, now I'm told that this happened before either of those revisions. But at the very least, it happened _after_ r20057. 19824 2 13552 ddkilzer 2007-03-08 21:36:34 -0800 Created attachment 13552 Patch v1 This fixes the issue, but I think we need a layout test to prevent this from happening again. It was a bit of stray code that made it into the patch. 19817 3 ddkilzer 2007-03-08 21:59:32 -0800 This is a regression from r20074: http://trac.webkit.org/projects/webkit/changeset/20074 19818 4 13553 ddkilzer 2007-03-08 22:06:05 -0800 Created attachment 13553 Patch v2 (now with ChangeLog!) Added ChangeLog. Change covered by existing layout tests which are currently failing. 19819 5 13553 bdakin 2007-03-08 22:08:19 -0800 Comment on attachment 13553 Patch v2 (now with ChangeLog!) wooh! 19820 6 ddkilzer 2007-03-08 22:18:49 -0800 Committed revision 20084. 19506 7 ddkilzer 2007-03-11 09:59:24 -0700 *** Bug 13032 has been marked as a duplicate of this bug. *** 13552 2007-03-08 21:36:34 -0800 2007-03-08 22:06:05 -0800 Patch v1 bug-13019-v1.diff text/plain 577 ddkilzer SW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyMDA3NCkKKysrIFdlYkNv cmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjMsOCArNDIz LDYgQEAgdm9pZCBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdChFdmVudCogZXZlbgogICAgIGlmIChu ZWVkQnV0dG9uQWN0aXZhdGlvbiAmJiBmaXJzdFN1Y2Nlc3NmdWxTdWJtaXRCdXR0b24pCiAgICAg ICAgIGZpcnN0U3VjY2Vzc2Z1bFN1Ym1pdEJ1dHRvbi0+c2V0QWN0aXZhdGVkU3VibWl0KHRydWUp OwogCi0gICAgaWYgKCFtX3Bvc3QpCi0KICAgICBpZiAobV9wb3N0KSB7CiAgICAgICAgIGlmICgh bV9tdWx0aXBhcnQpCiAgICAgICAgICAgICBmcmFtZS0+bG9hZGVyKCktPnN1Ym1pdEZvcm0oIlBP U1QiLCBtX3VybCwgZm9ybURhdGEoMCksIG1fdGFyZ2V0LCBlbmN0eXBlKCksIFN0cmluZygpLCBl dmVudCk7Cg== 13553 2007-03-08 22:06:05 -0800 2007-03-08 22:08:19 -0800 Patch v2 (now with ChangeLog!) bug-13019-v2.diff text/plain 1327 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDA4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDMtMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg LSBmaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMTkKKyAgICAg ICAgICBSRUdSRVNTSU9OIChyMjAwNzQpOiBGb3JtcyBkb24ndCBzdWJtaXQgb24gYSB2YXJpZXR5 IG9mIHdlYnNpdGVzCisKKyAgICAgICAgTm8gdGVzdHMgYWRkZWQgc2luY2UgTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9kb2N1bWVudC13cml0ZS5odG1sIHdhcyB0aW1pbmcgb3V0CisgICAgICAgIGFu ZCBjYXVzaW5nIGEgbGF5b3V0IHRlc3QgZmFpbHVyZS4KKworICAgICAgICAqIGh0bWwvSFRNTEZv cm1FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6c3VibWl0 KTogUmVtb3ZlZCBzdHJheSBjb2RlLgorCiAyMDA3LTAzLTA4ICBLcnp5c3p0b2YgS293YWxjenlr ICA8a2tvd2FsY3p5a0BnbWFpbC5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkIC0gZ2RrIGJ1 aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyMDA3NCkK KysrIFdlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 MjMsOCArNDIzLDYgQEAgdm9pZCBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdChFdmVudCogZXZlbgog ICAgIGlmIChuZWVkQnV0dG9uQWN0aXZhdGlvbiAmJiBmaXJzdFN1Y2Nlc3NmdWxTdWJtaXRCdXR0 b24pCiAgICAgICAgIGZpcnN0U3VjY2Vzc2Z1bFN1Ym1pdEJ1dHRvbi0+c2V0QWN0aXZhdGVkU3Vi bWl0KHRydWUpOwogCi0gICAgaWYgKCFtX3Bvc3QpCi0KICAgICBpZiAobV9wb3N0KSB7CiAgICAg ICAgIGlmICghbV9tdWx0aXBhcnQpCiAgICAgICAgICAgICBmcmFtZS0+bG9hZGVyKCktPnN1Ym1p dEZvcm0oIlBPU1QiLCBtX3VybCwgZm9ybURhdGEoMCksIG1fdGFyZ2V0LCBlbmN0eXBlKCksIFN0 cmluZygpLCBldmVudCk7Cg==