130183 2014-03-13 01:30:46 -0700 [EFL] Fix the !ENABLE(BATTERY_STATUS) build 2014-04-01 09:19:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbatyai.u-szeged webkit-unassigned bunhere commit-queue gyuyoung.kim gyuyoung.kim rakuco sergio webkit-ews oldest_to_newest 989958 0 dbatyai.u-szeged 2014-03-13 01:30:46 -0700 In file included from WebKit/Tools/MiniBrowser/efl/main.c:27:0: WebKit/WebKitBuild/Dependencies/Root/include/elementary-1/Elementary.h:77:20: fatal error: E_DBus.h: No such file or directory compilation terminated. 989959 1 226582 dbatyai.u-szeged 2014-03-13 01:31:45 -0700 Created attachment 226582 Proposed patch 989976 2 226582 ryuan.choi 2014-03-13 03:13:23 -0700 Comment on attachment 226582 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=226582&action=review > Source/cmake/OptionsEfl.cmake:168 > -if (ENABLE_BATTERY_STATUS) > - find_package(DBus REQUIRED) > - find_package(E_DBus 1.7 COMPONENTS EUKit) > -endif () > +find_package(DBus REQUIRED) > +find_package(E_DBus 1.7 COMPONENTS EUKit) If we are trying to build on EFL 1.8 or latest version without BATTERY_STATUS and E_Dbus, we will have errors like below. CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: E_DBUS_EUKIT_LIBRARIES linked by target "WebCore" in directory /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebCore E_DBUS_LIBRARIES linked by target "WebCore" in directory /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebCor Because EFL 1.8, 1.9 and later does not require E_Dbus, it should be also fine. 990424 3 226693 dbatyai.u-szeged 2014-03-14 05:37:14 -0700 Created attachment 226693 Proposed patch 996308 4 226693 commit-queue 2014-04-01 09:19:05 -0700 Comment on attachment 226693 Proposed patch Clearing flags on attachment: 226693 Committed r166592: <http://trac.webkit.org/changeset/166592> 996309 5 commit-queue 2014-04-01 09:19:10 -0700 All reviewed patches have been landed. Closing bug. 226582 2014-03-13 01:31:45 -0700 2014-03-14 05:36:09 -0700 Proposed patch proposedpatch.patch text/plain 1044 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiY2QzMjk5Li4yMWIwZWVi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTQtMDMtMTMgIETDoW5pZWwgQsOhdHlhaSAgPGRiYXR5YWkudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBGaXggdGhlICFFTkFCTEUoQkFUVEVSWV9TVEFUVVMpIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAx ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorCiAyMDE0LTAzLTEwICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1 cHBvcnQgZm9yIEdlb2NsdWUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5j bWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDJhYmZjM2MuLjVmYTY0 OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xNjQsMTAgKzE2NCw4IEBAIGlmIChFTkFCTEVf V0VCS0lUMiBBTkQgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgc2V0KEVOQUJMRV9Q TFVHSU5fUFJPQ0VTUyAxKQogZW5kaWYgKCkKIAotaWYgKEVOQUJMRV9CQVRURVJZX1NUQVRVUykK LSAgICBmaW5kX3BhY2thZ2UoREJ1cyBSRVFVSVJFRCkKLSAgICBmaW5kX3BhY2thZ2UoRV9EQnVz IDEuNyBDT01QT05FTlRTIEVVS2l0KQotZW5kaWYgKCkKK2ZpbmRfcGFja2FnZShEQnVzIFJFUVVJ UkVEKQorZmluZF9wYWNrYWdlKEVfREJ1cyAxLjcgQ09NUE9ORU5UUyBFVUtpdCkKIAogaWYgKEVO QUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQogICAgIHNldChHU1RSRUFNRVJfQ09NUE9O RU5UUyBhcHAgcGJ1dGlscykK 226693 2014-03-14 05:37:14 -0700 2014-04-01 09:19:04 -0700 Proposed patch proposedpatch.patch text/plain 2319 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiY2QzMjk5Li4yMWIwZWVi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTQtMDMtMTMgIETDoW5pZWwgQsOhdHlhaSAgPGRiYXR5YWkudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICBGaXggdGhlICFFTkFCTEUoQkFUVEVSWV9TVEFUVVMpIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAx ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorCiAyMDE0LTAzLTEwICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1 cHBvcnQgZm9yIEdlb2NsdWUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVm bC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDcxN2ViNzMu LjJlNTcyMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisr KyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0xODIsOSArMTgyLDEzIEBA IGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3JtL3RleHQvZW5jaGFudC9U ZXh0Q2hlY2tlckVuY2hhbnQuY3BwCiApCiAKLWlmIChFTkFCTEVfQkFUVEVSWV9TVEFUVVMpCitp ZiAoRU5BQkxFX0JBVFRFUllfU1RBVFVTIE9SIChFRkxfUkVRVUlSRURfVkVSU0lPTiBWRVJTSU9O X0xFU1MgMS44KSkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMg JHtEQlVTX0lOQ0xVREVfRElSU30pCisgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJ UkVDVE9SSUVTICR7RV9EQlVTX0lOQ0xVREVfRElSU30pCisgICAgbGlzdChBUFBFTkQgV2ViQ29y ZV9JTkNMVURFX0RJUkVDVE9SSUVTICR7RV9EQlVTX0VVS0lUX0lOQ0xVREVfRElSU30pCiAgICAg bGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMgJHtEQlVTX0xJQlJBUklFU30pCisgICAgbGlz dChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMgJHtFX0RCVVNfTElCUkFSSUVTfSkKKyAgICBsaXN0 KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUyAke0VfREJVU19FVUtJVF9MSUJSQVJJRVN9KQogZW5k aWYgKCkKIAogaWYgKEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJKQpAQCAtMjE4LDggKzIyMiw2 IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCiAgICAgJHtFSU5BX0xJQlJBUklFU30K ICAgICAke0VPX0xJQlJBUklFU30KICAgICAke0VWQVNfTElCUkFSSUVTfQotICAgICR7RV9EQlVT X0VVS0lUX0xJQlJBUklFU30KLSAgICAke0VfREJVU19MSUJSQVJJRVN9CiAgICAgJHtGT05UQ09O RklHX0xJQlJBUklFU30KICAgICAke0ZSRUVUWVBFX0xJQlJBUklFU30KICAgICAke0dMSUJfR0lP X0xJQlJBUklFU30KQEAgLTI0Miw4ICsyNDQsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xV REVfRElSRUNUT1JJRVMKICAgICAke0VDT1JFX0ZJTEVfSU5DTFVERV9ESVJTfQogICAgICR7RUNP UkVfWF9JTkNMVURFX0RJUlN9CiAgICAgJHtFT19JTkNMVURFX0RJUlN9Ci0gICAgJHtFX0RCVVNf SU5DTFVERV9ESVJTfQotICAgICR7RV9EQlVTX0VVS0lUX0lOQ0xVREVfRElSU30KICAgICAke0VE SkVfSU5DTFVERV9ESVJTfQogICAgICR7RUVaRV9JTkNMVURFX0RJUlN9CiAgICAgJHtFSU5BX0lO Q0xVREVfRElSU30KZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIGIv U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXggMmFiZmMzYy4uNDM3Y2Q1MiAxMDA2 NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2NtYWtl L09wdGlvbnNFZmwuY21ha2UKQEAgLTE2NCw3ICsxNjQsNyBAQCBpZiAoRU5BQkxFX1dFQktJVDIg QU5EIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAgIHNldChFTkFCTEVfUExVR0lOX1BS T0NFU1MgMSkKIGVuZGlmICgpCiAKLWlmIChFTkFCTEVfQkFUVEVSWV9TVEFUVVMpCitpZiAoRU5B QkxFX0JBVFRFUllfU1RBVFVTIE9SIChFRkxfUkVRVUlSRURfVkVSU0lPTiBWRVJTSU9OX0xFU1Mg MS44KSkKICAgICBmaW5kX3BhY2thZ2UoREJ1cyBSRVFVSVJFRCkKICAgICBmaW5kX3BhY2thZ2Uo RV9EQnVzIDEuNyBDT01QT05FTlRTIEVVS2l0KQogZW5kaWYgKCkK