13018 2007-03-08 17:37:31 -0800 allow embedders to override the definition of CRASH() 2007-03-08 19:25:19 -0800 1 1 1 Unclassified WebKit Platform 523.x (Safari 3) All All RESOLVED FIXED P2 Enhancement --- 1 fishd fishd oldest_to_newest 19828 0 fishd 2007-03-08 17:37:31 -0800 allow embedders to override the definition of CRASH() on some platforms, dereferencing 0xbbadbeef and writing 0 is really not the most ideal way to get attention in response to an assertion failure. for example, __asm {int 3} is much nicer on the windows platform where JIT debugging can present the user with the option to continue past the assertion with the click of a button, and if you are already running in the debugger, the instruction will be treated like an ordinary breakpoint. other platforms may have other preferred ways as well. 19829 1 13551 fishd 2007-03-08 17:42:58 -0800 Created attachment 13551 patch simple patch to make it possible for the embedder to override the meaning of CRASH() 19830 2 13551 darin 2007-03-08 17:46:02 -0800 Comment on attachment 13551 patch Do you have a better implementation for any particular platform? The 0xbbadbeef thing is really sorta Mac-OS-X-specific. r=me 19831 3 fishd 2007-03-08 18:29:04 -0800 yes, PLATFORM(WIN_OS) should call DebugBreak() or __asm {int 3}. the latter is good for x86-Linux too. 19835 4 mrowe 2007-03-08 19:25:19 -0800 Landed in r20079. 13551 2007-03-08 17:42:58 -0800 2007-03-08 17:46:02 -0800 patch crash-patch.diff text/plain 884 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDcx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNy0wMy0w OCAgTW9yZ2FuTCAgPG1vcmdhbmwud2Via2l0QHlhaG9vLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6IG1ha2Ug aXQgcG9zc2libGUgdG8gb3ZlcnJpZGUgQ1JBU0gKKwogMjAwNy0wMy0wNyAgQW5yb25nIEh1ICA8 aHVhbnJAeWFob28uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IHd0 Zi9Bc3NlcnRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd3RmL0Fzc2VydGlvbnMuaAkocmV2aXNpb24g MjAwNzEpCisrKyB3dGYvQXNzZXJ0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsNyArMTAy LDkgQEAgdm9pZCBXVEZMb2coY29uc3QgY2hhciAqZmlsZSwgaW50IGxpbmUsIAogCiAvKiBDUkFT SCAtLSBnZXRzIHVzIGludG8gdGhlIGRlYnVnZ2VyIG9yIHRoZSBjcmFzaCByZXBvcnRlciAtLSBz aWduYWxzIGFyZSBpZ25vcmVkIGJ5IHRoZSBjcmFzaCByZXBvcnRlciBzbyB3ZSBtdXN0IGRvIGJl dHRlciAqLwogCisjaWZuZGVmIENSQVNICiAjZGVmaW5lIENSQVNIKCkgKihpbnQgKikodWludHB0 cl90KTB4YmJhZGJlZWYgPSAwCisjZW5kaWYKIAogLyogQVNTRVJULCBBU1NFUlRfV0lUSF9NRVNT QUdFLCBBU1NFUlRfTk9UX1JFQUNIRUQgKi8KIAo=