130176 2014-03-12 21:41:24 -0700 WebKit shouldn't crash on uniprocessor machines 2014-03-13 12:15:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 989920 0 fpizlo 2014-03-12 21:41:24 -0700 Patch forthcoming. 989925 1 226574 fpizlo 2014-03-12 21:56:52 -0700 Created attachment 226574 the patch 989931 2 226574 ggaren 2014-03-12 22:22:32 -0700 Comment on attachment 226574 the patch r=me 989933 3 226574 msaboff 2014-03-12 22:36:17 -0700 Comment on attachment 226574 the patch It seems to me that the "minimum" in computeNumberOfWorkerThreads() is not really the minimum after the subtraction of 1 in Options.h. Could computeNumberOfWorkerThreads() always have a true minimum of 1 and pass 1 or 7 as the maximum? Or subtract the 1 in computeNumberOfWorkerThreads. Seems a little better to have all the min/max calculation in one place, computeNumberOfWorkerThreads. 989934 4 226574 msaboff 2014-03-12 22:37:25 -0700 Comment on attachment 226574 the patch Didn't mean to change the r+ from Geoff. 989936 5 fpizlo 2014-03-12 22:46:04 -0700 (In reply to comment #3) > (From update of attachment 226574 [details]) > It seems to me that the "minimum" in computeNumberOfWorkerThreads() is not really the minimum after the subtraction of 1 in Options.h. Could computeNumberOfWorkerThreads() always have a true minimum of 1 and pass 1 or 7 as the maximum? Or subtract the 1 in computeNumberOfWorkerThreads. Seems a little better to have all the min/max calculation in one place, computeNumberOfWorkerThreads. Yeah it's weird. It's the result of sharing this function with the GC. The GC wants to know the number of worker threads including the main thread while the JIT wants to know the number of worker threads excluding the main thread. The minus-1 is the exclusion of the main thread. 990108 6 fpizlo 2014-03-13 12:15:19 -0700 Landed in http://trac.webkit.org/changeset/165553 226574 2014-03-12 21:56:52 -0700 2014-03-12 22:46:24 -0700 the patch blah.patch text/plain 2569 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1NTI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTAzLTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg V2ViS2l0IHNob3VsZG4ndCBjcmFzaCBvbiB1bmlwcm9jZXNzb3IgbWFjaGluZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDE3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgUHJldmlvdXNs eSB0aGUgbWF0aCBmb3IgY29tcHV0aW5nIHRoZSBudW1iZXIgb2YgSklUIGNvbXBpbGVyIHRocmVh ZHMgd291bGQgY29tZSB1cCB3aXRoCisgICAgICAgIHplcm8gdGhyZWFkcyBvbiB1bmlwcm9jZXNz b3IgbWFjaGluZXMsIGFuZCB0aGVuIHRoZSBXb3JrbGlzdCBjb2RlIHdvdWxkIGFzc2VydC4KKwor ICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OmNvbXB1dGVOdW1i ZXJPZldvcmtlclRocmVhZHMpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAyMDE0 LTAzLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJU SU9OIEZBSUxFRDogbm9kZS0+b3AoKSA9PSBQaGkgfHwgbm9kZS0+b3AoKSA9PSBTZXRBcmd1bWVu dApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHJldmlz aW9uIDE2NTUyMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC05MiwxNiArOTIsMTMgQEAgYm9vbCBvdmVycmlkZU9wdGlvbldp dGhIZXVyaXN0aWMoVCYgdmFyaQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotc3RhdGljIHVuc2ln bmVkIGNvbXB1dGVOdW1iZXJPZldvcmtlclRocmVhZHMoaW50IG1heE51bWJlck9mV29ya2VyVGhy ZWFkcykKK3N0YXRpYyB1bnNpZ25lZCBjb21wdXRlTnVtYmVyT2ZXb3JrZXJUaHJlYWRzKGludCBt YXhOdW1iZXJPZldvcmtlclRocmVhZHMsIGludCBtaW5pbXVtID0gMSkKIHsKICAgICBpbnQgY3B1 c1RvVXNlID0gc3RkOjptaW4oV1RGOjpudW1iZXJPZlByb2Nlc3NvckNvcmVzKCksIG1heE51bWJl ck9mV29ya2VyVGhyZWFkcyk7CiAKICAgICAvLyBCZSBwYXJhbm9pZCwgaXQgaXMgdGhlIE9TIHdl J3JlIGRlYWxpbmcgd2l0aCwgYWZ0ZXIgYWxsLgogICAgIEFTU0VSVChjcHVzVG9Vc2UgPj0gMSk7 Ci0gICAgaWYgKGNwdXNUb1VzZSA8IDEpCi0gICAgICAgIGNwdXNUb1VzZSA9IDE7Ci0gICAgCi0g ICAgcmV0dXJuIGNwdXNUb1VzZTsKKyAgICByZXR1cm4gc3RkOjptYXgoY3B1c1RvVXNlLCBtaW5p bXVtKTsKIH0KIAogc3RhdGljIHVuc2lnbmVkIGNvbXB1dGVOdW1iZXJPZkdDTWFya2Vycyh1bnNp Z25lZCBtYXhOdW1iZXJPZkdDTWFya2VycykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgJKHJldmlzaW9uIDE2NTUyMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTU4LDggKzE1OCw4IEBAIHR5 cGVkZWYgT3B0aW9uUmFuZ2Ugb3B0aW9uUmFuZ2U7CiAgICAgdihib29sLCBmdGxDcmFzaGVzLCBm YWxzZSkgLyogZm9vbC1wcm9vZiB3YXkgb2YgY2hlY2tpbmcgdGhhdCB5b3UgZW5kZWQgdXAgaW4g dGhlIEZUTC4gOy0pICovXAogICAgIFwKICAgICB2KGJvb2wsIGVuYWJsZUNvbmN1cnJlbnRKSVQs IHRydWUpIFwKLSAgICB2KHVuc2lnbmVkLCBudW1iZXJPZkRGR0NvbXBpbGVyVGhyZWFkcywgY29t cHV0ZU51bWJlck9mV29ya2VyVGhyZWFkcygyKSAtIDEpIFwKLSAgICB2KHVuc2lnbmVkLCBudW1i ZXJPZkZUTENvbXBpbGVyVGhyZWFkcywgY29tcHV0ZU51bWJlck9mV29ya2VyVGhyZWFkcyg4KSAt IDEpIFwKKyAgICB2KHVuc2lnbmVkLCBudW1iZXJPZkRGR0NvbXBpbGVyVGhyZWFkcywgY29tcHV0 ZU51bWJlck9mV29ya2VyVGhyZWFkcygyLCAyKSAtIDEpIFwKKyAgICB2KHVuc2lnbmVkLCBudW1i ZXJPZkZUTENvbXBpbGVyVGhyZWFkcywgY29tcHV0ZU51bWJlck9mV29ya2VyVGhyZWFkcyg4LCAy KSAtIDEpIFwKICAgICBcCiAgICAgdihib29sLCBlbmFibGVQcm9maWxlciwgZmFsc2UpIFwKICAg ICBcCg==