130169 2014-03-12 17:29:07 -0700 [iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments 2014-04-10 08:24:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 sam sam ddkilzer simon.fraser oldest_to_newest 989877 0 sam 2014-03-12 17:29:07 -0700 [iOS] Use the window size instead of the device size to compute device-width/device-height viewport arguments 989878 1 226564 sam 2014-03-12 17:29:30 -0700 Created attachment 226564 Patch 989887 2 226564 benjamin 2014-03-12 18:00:59 -0700 Comment on attachment 226564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review > Source/WebCore/dom/Document.cpp:2940 > + finalizeViewportArguments(m_viewportArguments, page()->chrome().windowRect().size()); I don't think that works. The value from windowRect() will have the orientation taken into account (and the window size could be smaller than the screen size in some cases). 989888 3 226564 benjamin 2014-03-12 18:08:13 -0700 Comment on attachment 226564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226564&action=review > Source/WebCore/dom/ViewportArguments.cpp:-419 > +void finalizeViewportArguments(ViewportArguments& arguments, FloatSize screenSize) > { > - CGSize screenSize = wkGetViewportScreenSize(); > - As a temporary workaround: What about modifying the screenSize to make it "in portrait", then use that value to update ViewportArguments? 989895 4 226564 sam 2014-03-12 18:53:36 -0700 Comment on attachment 226564 Patch Removing this. I have a better fix. 226564 2014-03-12 17:29:30 -0700 2014-03-12 18:53:36 -0700 Patch bug-130169-20140312172907.patch text/plain 3546 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTUxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTEyICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2lPU10gVXNlIHRoZSB3aW5kb3cgc2l6 ZSBpbnN0ZWFkIG9mIHRoZSBkZXZpY2Ugc2l6ZSB0byBjb21wdXRlIGRldmljZS13aWR0aC9kZXZp Y2UtaGVpZ2h0IHZpZXdwb3J0IGFyZ3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OnByb2Nlc3NWaWV3cG9ydCk6CisgICAgICAgICogZG9tL1ZpZXdwb3J0QXJn dW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZpbmFsaXplVmlld3BvcnRBcmd1bWVudHMp OgorICAgICAgICAqIGRvbS9WaWV3cG9ydEFyZ3VtZW50cy5oOgorCiAyMDE0LTAzLTEyICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogT1MgWCBWaWV3IEluZGljYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2 aXNpb24gMTY1NTAxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjkzNiwxMSArMjkzNiw4IEBAIHZvaWQgRG9jdW1lbnQ6OnByb2Nlc3NWaWV3 cG9ydChjb25zdCBTdHIKICAgICBwcm9jZXNzQXJndW1lbnRzKGZlYXR1cmVzLCAodm9pZCopJm1f dmlld3BvcnRBcmd1bWVudHMsICZzZXRWaWV3cG9ydEZlYXR1cmUpOwogCiAjaWYgUExBVEZPUk0o SU9TKQotICAgIC8vIEZJWE1FOiA8cmRhcjovL3Byb2JsZW0vODk1NTk1OT4gSW52ZXN0aWdhdGUg bW92aW5nIHRvIFRvVCBXZWJLaXQncyBleHRlbmRlZCBWaWV3cG9ydCBJbXBsZW1lbnRhdGlvbgot ICAgIC8vIE1vdmluZyB0byBUb1QncyBpbXBsZW1lbnRhdGlvbiB3b3VsZCBtZWFuIGNhbGxpbmcg ZmluZENvbmZpZ3VyYXRpb25Gb3JWaWV3cG9ydERhdGEsIHdoaWNoIGRvZXMKLSAgICAvLyBib3Vu ZHMgY2hlY2tpbmcgYW5kIGRldGVybWluaW5nIGNvbmNyZXRlIHZhbHVlcyBmb3IgVmFsdWVBdXRv IHdoaWNoIHdlIGFscmVhZHkgZG8gaW4gVUlLaXQuCi0gICAgLy8gVG8gbWFpbnRhaW4gb2xkIGJl aGF2aW9yLCB3ZSBqdXN0IG5lZWQgdG8gdXBkYXRlIGEgZmV3IHZhbHVlcywgbGVhdmluZyBBdXRv J3MgZm9yIFVJS2l0LgotICAgIGZpbmFsaXplVmlld3BvcnRBcmd1bWVudHMobV92aWV3cG9ydEFy Z3VtZW50cyk7CisgICAgaWYgKHBhZ2UoKSkKKyAgICAgICAgZmluYWxpemVWaWV3cG9ydEFyZ3Vt ZW50cyhtX3ZpZXdwb3J0QXJndW1lbnRzLCBwYWdlKCktPmNocm9tZSgpLndpbmRvd1JlY3QoKS5z aXplKCkpOwogI2VuZGlmCiAKICAgICB1cGRhdGVWaWV3cG9ydEFyZ3VtZW50cygpOwpJbmRleDog U291cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9kb20vVmlld3BvcnRBcmd1bWVudHMuY3BwCShyZXZpc2lvbiAxNjU1MDEp CisrKyBTb3VyY2UvV2ViQ29yZS9kb20vVmlld3BvcnRBcmd1bWVudHMuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00MTMsMTkgKzQxMywxNyBAQCB2b2lkIHNldFZpZXdwb3J0RmVhdHVyZShjb25zdCBT dHJpbmcmIGtlCiB9CiAKICNpZiBQTEFURk9STShJT1MpCi12b2lkIGZpbmFsaXplVmlld3BvcnRB cmd1bWVudHMoVmlld3BvcnRBcmd1bWVudHMmIGFyZ3VtZW50cykKK3ZvaWQgZmluYWxpemVWaWV3 cG9ydEFyZ3VtZW50cyhWaWV3cG9ydEFyZ3VtZW50cyYgYXJndW1lbnRzLCBGbG9hdFNpemUgc2Ny ZWVuU2l6ZSkKIHsKLSAgICBDR1NpemUgc2NyZWVuU2l6ZSA9IHdrR2V0Vmlld3BvcnRTY3JlZW5T aXplKCk7Ci0KICAgICBpZiAoYXJndW1lbnRzLndpZHRoID09IFZpZXdwb3J0QXJndW1lbnRzOjpW YWx1ZURldmljZVdpZHRoKQotICAgICAgICBhcmd1bWVudHMud2lkdGggPSBzY3JlZW5TaXplLndp ZHRoOworICAgICAgICBhcmd1bWVudHMud2lkdGggPSBzY3JlZW5TaXplLndpZHRoKCk7CiAgICAg ZWxzZSBpZiAoYXJndW1lbnRzLndpZHRoID09IFZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZURldmlj ZUhlaWdodCkKLSAgICAgICAgYXJndW1lbnRzLndpZHRoID0gc2NyZWVuU2l6ZS5oZWlnaHQ7Cisg ICAgICAgIGFyZ3VtZW50cy53aWR0aCA9IHNjcmVlblNpemUuaGVpZ2h0KCk7CiAKICAgICBpZiAo YXJndW1lbnRzLmhlaWdodCA9PSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVEZXZpY2VXaWR0aCkK LSAgICAgICAgYXJndW1lbnRzLmhlaWdodCA9IHNjcmVlblNpemUud2lkdGg7CisgICAgICAgIGFy Z3VtZW50cy5oZWlnaHQgPSBzY3JlZW5TaXplLndpZHRoKCk7CiAgICAgZWxzZSBpZiAoYXJndW1l bnRzLmhlaWdodCA9PSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVEZXZpY2VIZWlnaHQpCi0gICAg ICAgIGFyZ3VtZW50cy5oZWlnaHQgPSBzY3JlZW5TaXplLmhlaWdodDsKKyAgICAgICAgYXJndW1l bnRzLmhlaWdodCA9IHNjcmVlblNpemUuaGVpZ2h0KCk7CiB9CiAjZW5kaWYKIApJbmRleDogU291 cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmgJKHJldmlzaW9uIDE2NTUwMSkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5oCSh3b3JraW5nIGNvcHkpCkBAIC0x NTQsNyArMTU0LDcgQEAgdm9pZCBzZXRWaWV3cG9ydEZlYXR1cmUoY29uc3QgU3RyaW5nJiBrZQog dm9pZCByZXBvcnRWaWV3cG9ydFdhcm5pbmcoRG9jdW1lbnQqLCBWaWV3cG9ydEVycm9yQ29kZSwg Y29uc3QgU3RyaW5nJiByZXBsYWNlbWVudDEsIGNvbnN0IFN0cmluZyYgcmVwbGFjZW1lbnQyKTsK IAogI2lmIFBMQVRGT1JNKElPUykKLXZvaWQgZmluYWxpemVWaWV3cG9ydEFyZ3VtZW50cyhWaWV3 cG9ydEFyZ3VtZW50cyYpOwordm9pZCBmaW5hbGl6ZVZpZXdwb3J0QXJndW1lbnRzKFZpZXdwb3J0 QXJndW1lbnRzJiwgRmxvYXRTaXplIHNjcmVlblNpemUpOwogI2VuZGlmCiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUK