130161 2014-03-12 15:38:40 -0700 Web Inspector: Classname stuff in WebInspector.displayNameForNode should join DOMTokenList classList instead of using string parsing and concatenation 2014-03-13 09:25:50 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 jcraig webkit-unassigned graouts joepeck timothy webkit-bug-importer oldest_to_newest 989843 0 jcraig 2014-03-12 15:38:40 -0700 Web Inspector: Classname stuff in WebInspector.displayNameForNode should join DOMTokenList classList instead of using string parsing and concatenation. Unless I'm missing something, I expect this was just written before DOMTokenList classList was available. var classAttribute = node.getAttribute("class"); if (classAttribute) { var classes = classAttribute.trim().split(/\s+/); var foundClasses = {}; for (var i = 0; i < classes.length; ++i) { var className = classes[i]; if (className && !(className in foundClasses)) { title += "." + className; foundClasses[className] = true; } } } 989869 1 timothy 2014-03-12 17:11:28 -0700 node is not a real DOMNode, it is our DOMNode proxy. So we don't have access to classList unless we go to the injected script for it. That is why we do what we do here. 990022 2 jcraig 2014-03-13 09:25:50 -0700 Gotcha. Makes sense.