13015 2007-03-08 13:52:47 -0800 REGRESSION (r17233-r17241): Repro crash when leaving a page whose unload handler submits a form 2007-03-12 21:02:56 -0700 1 1 1 Unclassified WebKit Page Loading 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED Regression P1 Major --- 1 mitz webkit-unassigned ddkilzer mrowe oldest_to_newest 19929 0 mitz 2007-03-08 13:52:47 -0800 Steps to reproduce: 1) Open WebCore/manual-tests/onunload-form-submit-crash.html 2) Enter "about:blank" in Safari's address bar Backtrace: 0 WebCore::FrameLoader::finishedLoadingDocument(WebCore::DocumentLoader*) + 0 1 WebCore::DocumentLoader::finishedLoading() + 48 2 WebCore::FrameLoader::finishedLoading() + 92 3 WebCore::MainResourceLoader::didFinishLoading() + 56 4 WebCore::MainResourceLoader::continueAfterContentPolicy(WebCore::PolicyAction, WebCore::ResourceResponse const&) + 1096 5 WebCore::MainResourceLoader::continueAfterContentPolicy(WebCore::PolicyAction) + 64 6 WebCore::FrameLoader::continueAfterContentPolicy(WebCore::PolicyAction) + 476 7 -[WebFramePolicyListener receivedPolicyDecision:] + 80 8 0x1000 + 121228 9 objc_msgSendv + 180 Note: Following the instructions on the manual test does not result in a crash. 19931 1 13547 mitz 2007-03-08 14:14:17 -0800 Created attachment 13547 Add missing null check 19936 2 13547 beidson 2007-03-08 14:19:23 -0800 Comment on attachment 13547 Add missing null check Sure! 19834 3 mrowe 2007-03-08 19:22:17 -0800 Landed in r20078. 19787 4 mrowe 2007-03-09 02:14:16 -0800 Rolled out again in r20088 as this is causing crashes during layout tests. 19783 5 13547 mitz 2007-03-09 03:11:54 -0800 Comment on attachment 13547 Add missing null check The test was a trap - as DRT tried to load the next test, it kept returning to the previous one. 19766 6 13555 mitz 2007-03-09 03:27:43 -0800 Created attachment 13555 Add missing null check Changed the test so that it won't submit the form the second time. I'm not flagging this for review yet because the "bad" test also managed to crash DRT and I'm still investigating that. 19761 7 darin 2007-03-09 09:07:05 -0800 I think the issue is probably that we need to retain the frame? 19762 8 darin 2007-03-09 09:07:46 -0800 I mean ref() the frame. Also if we're no longer the main document maybe it's too late to call end()? We should ask Anders about this. 19266 9 13555 andersca 2007-03-12 17:54:32 -0700 Comment on attachment 13555 Add missing null check r=me 19267 10 andersca 2007-03-12 17:55:58 -0700 This regressed in http://trac.webkit.org/projects/webkit/changeset/17238 and I've verified that the bad test also crashes in DRT in revision 17237 so that is unrelated. 19231 11 ddkilzer 2007-03-12 21:02:56 -0700 Committed revision 20135. 13547 2007-03-08 14:14:17 -0800 2007-03-09 03:11:54 -0800 Add missing null check 13015_r1.patch text/plain 3465 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDY1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDMtMDggIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMwMTUKKyAgICAgICAgICBSRUdSRVNTSU9OIChyMTcyMzMtcjE3MjQxKTogUmVwcm8gY3Jhc2gg d2hlbiBsZWF2aW5nIGEgcGFnZSB3aG9zZSB1bmxvYWQgaGFuZGxlciBzdWJtaXRzIGEgZm9ybQor CisgICAgICAgICogZmFzdC9sb2FkZXIvb251bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gtMi1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL29udW5sb2FkLWZvcm0tc3Vi bWl0LWNyYXNoLTIuaHRtbDogQWRkZWQuCisKIDIwMDctMDMtMDggIEp1c3RpbiBHYXJjaWEgIDxq dXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBoYXJyaXNvbgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvb251bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gt Mi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvb251 bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gtMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9vbnVubG9hZC1mb3JtLXN1Ym1pdC1jcmFzaC0yLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitTVUNDRVNTCisKKwpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvb251bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gtMi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL29udW5sb2FkLWZvcm0tc3Vi bWl0LWNyYXNoLTIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVy L29udW5sb2FkLWZvcm0tc3VibWl0LWNyYXNoLTIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwyOCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+VGVzdCBmb3IgaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMTU8L3RpdGxlPgorICAgIDxzY3JpcHQ+Cisg ICAgICAgIGZ1bmN0aW9uIHRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAobG9jYXRp b24uaHJlZi5pbmRleE9mKCI/IikgPT0gLTEpIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAg ICAgICBsb2NhdGlvbi5ocmVmID0gImFib3V0OmJsYW5rIjsKKyAgICAgICAgICAgIH0gZWxzZSB7 CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVy VGV4dCA9ICJTVUNDRVNTIjsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpIiBvblVubG9hZD0iZG9jdW1lbnQubXlGb3JtLnN1Ym1p dCgpIj4KKyAgICA8Zm9ybSBuYW1lPSJteUZvcm0iPgorICAgIDwvZm9ybT4KKyAgICA8cCBpZD0i cmVzdWx0Ij4KKyAgICAgICAgVGVzdCBkaWQgbm90IGZpbmlzaC4KKyAgICA8L3A+Cis8L2JvZHk+ Cis8aHRtbD4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv Q2hhbmdlTG9nCShyZXZpc2lvbiAyMDA2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDMtMDggIE1pdHogUGV0dGVsICA8bWl0ekB3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIC0gZml4IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDE1Cisg ICAgICAgICAgUkVHUkVTU0lPTiAocjE3MjMzLXIxNzI0MSk6IFJlcHJvIGNyYXNoIHdoZW4gbGVh dmluZyBhIHBhZ2Ugd2hvc2UgdW5sb2FkIGhhbmRsZXIgc3VibWl0cyBhIGZvcm0KKworICAgICAg ICBUZXN0OiBmYXN0L2xvYWRlci9vbnVubG9hZC1mb3JtLXN1Ym1pdC1jcmFzaC0yLmh0bWwKKwor ICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudExvYWRlcjo6ZmluaXNoZWRMb2FkaW5nKTogQWRkZWQgbnVsbCBjaGVjay4KKwogMjAw Ny0wMy0wOCAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IGhhcnJpc29uCkluZGV4OiBXZWJDb3JlL2xvYWRlci9Eb2N1bWVudExv YWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3Bw CShyZXZpc2lvbiAyMDA2NCkKKysrIFdlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzA5LDggKzMwOSwxMCBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpm aW5pc2hlZExvYWRpbmcoKQogewogICAgIG1fZ290Rmlyc3RCeXRlID0gdHJ1ZTsgICAKICAgICBj b21taXRJZlJlYWR5KCk7Ci0gICAgZnJhbWVMb2FkZXIoKS0+ZmluaXNoZWRMb2FkaW5nRG9jdW1l bnQodGhpcyk7Ci0gICAgbV9mcmFtZS0+bG9hZGVyKCktPmVuZCgpOworICAgIGlmIChGcmFtZUxv YWRlciogbG9hZGVyID0gZnJhbWVMb2FkZXIoKSkgeworICAgICAgICBsb2FkZXItPmZpbmlzaGVk TG9hZGluZ0RvY3VtZW50KHRoaXMpOworICAgICAgICBsb2FkZXItPmVuZCgpOworICAgIH0KIH0K IAogdm9pZCBEb2N1bWVudExvYWRlcjo6c2V0Q29tbWl0dGVkKGJvb2wgZikK 13555 2007-03-09 03:27:43 -0800 2007-03-12 17:54:32 -0700 Add missing null check 13015_r2.patch text/plain 3598 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDMtMDkgIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMwMTUKKyAgICAgICAgICBSRUdSRVNTSU9OIChyMTcyMzMtcjE3MjQxKTogUmVwcm8gY3Jhc2gg d2hlbiBsZWF2aW5nIGEgcGFnZSB3aG9zZSB1bmxvYWQgaGFuZGxlciBzdWJtaXRzIGEgZm9ybQor CisgICAgICAgICogZmFzdC9sb2FkZXIvb251bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gtMi1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL29udW5sb2FkLWZvcm0tc3Vi bWl0LWNyYXNoLTIuaHRtbDogQWRkZWQuCisKIDIwMDctMDMtMDggIEp1c3RpbiBHYXJjaWEgIDxq dXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBoYXJyaXNvbgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvb251bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gt Mi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvb251 bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gtMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9vbnVubG9hZC1mb3JtLXN1Ym1pdC1jcmFzaC0yLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitTVUNDRVNTCisKKwpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvb251bmxvYWQtZm9ybS1zdWJtaXQtY3Jhc2gtMi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL29udW5sb2FkLWZvcm0tc3Vi bWl0LWNyYXNoLTIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVy L29udW5sb2FkLWZvcm0tc3VibWl0LWNyYXNoLTIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwzNCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+VGVzdCBmb3IgaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMTU8L3RpdGxlPgorICAgIDxzY3JpcHQ+Cisg ICAgICAgIGZ1bmN0aW9uIHRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAobG9jYXRp b24uaHJlZi5pbmRleE9mKCI/IikgPT0gLTEpIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAg ICAgICBsb2NhdGlvbi5ocmVmID0gImFib3V0OmJsYW5rIjsKKyAgICAgICAgICAgIH0gZWxzZSB7 CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVy VGV4dCA9ICJTVUNDRVNTIjsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBo YW5kbGVVbmxvYWQoKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAobG9jYXRpb24uaHJlZi5p bmRleE9mKCI/IikgPT0gLTEpCisgICAgICAgICAgICAgICAgZG9jdW1lbnQubXlGb3JtLnN1Ym1p dCgpOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRl c3QoKSIgb251bmxvYWQ9ImhhbmRsZVVubG9hZCgpIj4KKyAgICA8Zm9ybSBuYW1lPSJteUZvcm0i PgorICAgIDwvZm9ybT4KKyAgICA8cCBpZD0icmVzdWx0Ij4KKyAgICAgICAgVGVzdCBkaWQgbm90 IGZpbmlzaC4KKyAgICA8L3A+Cis8L2JvZHk+Cis8aHRtbD4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDA4OCkKKysr IFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDct MDMtMDkgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMDE1CisgICAgICAgICAgUkVHUkVTU0lPTiAocjE3MjMzLXIx NzI0MSk6IFJlcHJvIGNyYXNoIHdoZW4gbGVhdmluZyBhIHBhZ2Ugd2hvc2UgdW5sb2FkIGhhbmRs ZXIgc3VibWl0cyBhIGZvcm0KKworICAgICAgICBUZXN0OiBmYXN0L2xvYWRlci9vbnVubG9hZC1m b3JtLXN1Ym1pdC1jcmFzaC0yLmh0bWwKKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6ZmluaXNoZWRMb2FkaW5n KTogQWRkZWQgbnVsbCBjaGVjay4KKwogMjAwNy0wMy0wOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoLgpJbmRleDogV2ViQ29y ZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVy L0RvY3VtZW50TG9hZGVyLmNwcAkocmV2aXNpb24gMjAwODgpCisrKyBXZWJDb3JlL2xvYWRlci9E b2N1bWVudExvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwOSw4ICszMDksMTAgQEAgdm9p ZCBEb2N1bWVudExvYWRlcjo6ZmluaXNoZWRMb2FkaW5nKCkKIHsKICAgICBtX2dvdEZpcnN0Qnl0 ZSA9IHRydWU7ICAgCiAgICAgY29tbWl0SWZSZWFkeSgpOwotICAgIGZyYW1lTG9hZGVyKCktPmZp bmlzaGVkTG9hZGluZ0RvY3VtZW50KHRoaXMpOwotICAgIG1fZnJhbWUtPmxvYWRlcigpLT5lbmQo KTsKKyAgICBpZiAoRnJhbWVMb2FkZXIqIGxvYWRlciA9IGZyYW1lTG9hZGVyKCkpIHsKKyAgICAg ICAgbG9hZGVyLT5maW5pc2hlZExvYWRpbmdEb2N1bWVudCh0aGlzKTsKKyAgICAgICAgbG9hZGVy LT5lbmQoKTsKKyAgICB9CiB9CiAKIHZvaWQgRG9jdW1lbnRMb2FkZXI6OnNldENvbW1pdHRlZChi b29sIGYpCg==