130149 2014-03-12 11:39:38 -0700 [GTK][CMake] Credential storage is not enabled 2014-03-17 09:43:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson bunhere gyuyoung.kim rakuco sergio webkit-ews oldest_to_newest 989760 0 mrobinson 2014-03-12 11:39:38 -0700 We need to ensure that this is properly enabled when libsecret is found. 990001 1 226592 mrobinson 2014-03-13 07:21:14 -0700 Created attachment 226592 Patch 990954 2 226592 pnormand 2014-03-16 03:35:35 -0700 Comment on attachment 226592 Patch Looks good! 991258 3 226592 mrobinson 2014-03-17 09:43:20 -0700 Comment on attachment 226592 Patch Clearing flags on attachment: 226592 Committed r165738: <http://trac.webkit.org/changeset/165738> 991259 4 mrobinson 2014-03-17 09:43:25 -0700 All reviewed patches have been landed. Closing bug. 226592 2014-03-13 07:21:14 -0700 2014-03-17 09:43:20 -0700 Patch bug-130149-20140313072050.patch text/plain 6286 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjAwNTA5N2Q1ZWY3MDk0 NjNhOGIwNDk4MjZhNGVjN2UxYTE5NTM3NS4uMjQxZmFhMmY1YzcxYThmMzVhYWU2Zjg5MWQxOTA1 ODBiMmNhYjU0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAzLTEzICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtDTWFr ZV0gQ3JlZGVudGlhbCBzdG9yYWdlIGlzIG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAxNDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOiBBZGQgdGhl IGxpYnNlY3JldCBpbmNsdWRlIGRpcmVjdG9yaWVzIGFuZCBsaW5rIGxpbmUgdG8gdGhlIGJ1aWxk LgorCiAyMDE0LTAzLTEyICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBSZXBsYXk6IGFkZCBpbmZyYXN0cnVjdHVyZSBmb3IgbWVtb2l6aW5nIG5vbmRldGVybWlu aXN0aWMgRE9NIEFQSXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt YWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggOWU0ZmIwN2VjNjdk MDU1NzhkYTYwOGVkMTkzNGI3NDJlOWRmMWE3Ny4uNWUyOTdiYThjNTlkZGNkYjhlMzA1YzE5YmJl MGJlNjQ5MGM0NWQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21h a2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTMwNCw2ICszMDQs NyBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwogICAgICR7SEFSRkJVWlpfTElCUkFS SUVTfQogICAgICR7SUNVX0xJQlJBUklFU30KICAgICAke0pQRUdfTElCUkFSSUVTfQorICAgICR7 TElCU0VDUkVUX0xJQlJBUklFU30KICAgICAke0xJQlNPVVBfTElCUkFSSUVTfQogICAgICR7TElC WE1MMl9MSUJSQVJJRVN9CiAgICAgJHtMSUJYU0xUX0xJQlJBUklFU30KQEAgLTMyOSw2ICszMzAs NyBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAke0dVREVW X0lOQ0xVREVfRElSU30KICAgICAke0hBUkZCVVpaX0lOQ0xVREVfRElSU30KICAgICAke0lDVV9J TkNMVURFX0RJUlN9CisgICAgJHtMSUJTRUNSRVRfSU5DTFVERV9ESVJTfQogICAgICR7TElCU09V UF9JTkNMVURFX0RJUlN9CiAgICAgJHtMSUJYTUwyX0lOQ0xVREVfRElSfQogICAgICR7TElCWFNM VF9JTkNMVURFX0RJUn0KZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kTGlic2VjcmV0LmNt YWtlIGIvU291cmNlL2NtYWtlL0ZpbmRMaWJzZWNyZXQuY21ha2UKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDMzMjI4 YTc3YTQyZDM3N2VmZjFkYTczZTU3MDAzZTY3ZDJjMjJhZgotLS0gL2Rldi9udWxsCisrKyBiL1Nv dXJjZS9jbWFrZS9GaW5kTGlic2VjcmV0LmNtYWtlCkBAIC0wLDAgKzEsNDkgQEAKKyMgLSBUcnkg dG8gZmluZCBsaWJzZWNyZXQKKyMgT25jZSBkb25lLCB0aGlzIHdpbGwgZGVmaW5lCisjCisjICBM SUJTRUNSRVRfRk9VTkQgLSBzeXN0ZW0gaGFzIGxpYnNlY3JldAorIyAgTElCU0VDUkVUX0lOQ0xV REVfRElSUyAtIHRoZSBsaWJzZWNyZXQgaW5jbHVkZSBkaXJlY3RvcmllcworIyAgTElCU0VDUkVU X0xJQlJBUklFUyAtIGxpbmsgdGhlc2UgdG8gdXNlIGxpYnNlY3JldAorIworIyBDb3B5cmlnaHQg KEMpIDIwMTIgUmFwaGFlbCBLdWJvIGRhIENvc3RhIDxyYWt1Y29Ad2Via2l0Lm9yZz4KKyMgQ29w eXJpZ2h0IChDKSAyMDE0IElnYWxpYSBTLkwuCisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK KyMgYXJlIG1ldDoKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjIDIuICBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorIyAg ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyIGluIHRoZQorIyAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxz IHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFT CisjIElTJycgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5H LCBCVVQgTk9UIExJTUlURUQgVE8sCisjIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hB TlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyMgUFVSUE9TRSBBUkUgRElT Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVCBIT0xERVIgT1IgSVRTCisj IENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVO VEFMLCBTUEVDSUFMLAorIyBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5D TFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisjIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUg R09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOworIyBPUiBC VVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9G IExJQUJJTElUWSwKKyMgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1Ig VE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IKKyMgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFO WSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRgorIyBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworZmluZF9wYWNrYWdlKFBrZ0Nv bmZpZykKK3BrZ19jaGVja19tb2R1bGVzKExJQlNFQ1JFVCBsaWJzZWNyZXQtMSkKKworc2V0KFZF UlNJT05fT0sgVFJVRSkKK2lmIChMSUJTRUNSRVRfVkVSU0lPTikKKyAgICBpZiAoTElCU0VDUkVU X0ZJTkRfVkVSU0lPTl9FWEFDVCkKKyAgICAgICAgaWYgKE5PVCgiJHtMSUJTRUNSRVRfRklORF9W RVJTSU9OfSIgVkVSU0lPTl9FUVVBTCAiJHtMSUJTRUNSRVRfVkVSU0lPTn0iKSkKKyAgICAgICAg ICAgIHNldChWRVJTSU9OX09LIEZBTFNFKQorICAgICAgICBlbmRpZiAoKQorICAgIGVsc2UgKCkK KyAgICAgICAgaWYgKCIke0xJQlNFQ1JFVF9WRVJTSU9OfSIgVkVSU0lPTl9MRVNTICIke0xJQlNF Q1JFVF9GSU5EX1ZFUlNJT059IikKKyAgICAgICAgICAgIHNldChWRVJTSU9OX09LIEZBTFNFKQor ICAgICAgICBlbmRpZiAoKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCitpbmNsdWRlKEZpbmRQ YWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQorRklORF9QQUNLQUdFX0hBTkRMRV9TVEFOREFSRF9B UkdTKExJQlNFQ1JFVCBERUZBVUxUX01TRyBMSUJTRUNSRVRfSU5DTFVERV9ESVJTIExJQlNFQ1JF VF9MSUJSQVJJRVMgVkVSU0lPTl9PSykKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25z R1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggMzIzOTNjZDgy ZjY3MTVkODk1MWJjZjc2Yzc3NDA3YTZhNzgwN2U5OC4uMDc0M2NiNTk4NTRlMjI5YWFkMDcwNGVi YmZkNWJmMjlhZTYyYWFhZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKQEAgLTI2LDYgKzI2LDcgQEAg c2V0KFdFQktJVF9NSU5PUl9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01JTk9SfSkKIHNldChX RUJLSVRfTUFKT1JfVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTl9NQUpPUn0pCiAKIHNldChVU0Vf R1RLMiBPRkYgQ0FDSEUgQk9PTCAiV2hldGhlciBvciBub3QgdG8gdXNlIEdUSysgMi4gV2ViS2l0 MiBvbmx5IHN1cHBvcnRzIEdUSysgMy4iKQorc2V0KEVOQUJMRV9DUkVERU5USUFMX1NUT1JBR0Ug T04gQ0FDSEUgQk9PTCAiV2hldGhlciBvciBub3QgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIGNyZWRl bnRpYWwgc3RvcmFnZSB1c2luZyBsaWJzZWNyZXQuIikKIAogIyBGSVhNRTogV2Ugd2FudCB0byBl eHBvc2UgZmV3ZXIgb3B0aW9ucyB0byBkb3duc3RyZWFtLCBidXQgZm9yIG5vdyBldmVyeXRoaW5n IGlzIHB1YmxpYy4KIFdFQktJVF9PUFRJT05fQkVHSU4oKQpAQCAtMjE0LDYgKzIxNSwxMSBAQCBp ZiAoRU5BQkxFX0dFT0xPQ0FUSU9OKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCitpZiAoRU5B QkxFX0NSRURFTlRJQUxfU1RPUkFHRSkKKyAgICBmaW5kX3BhY2thZ2UoTGlic2VjcmV0KQorICAg IHNldChFTkFCTEVfQ1JFREVOVElBTF9TVE9SQUdFIDEpCitlbmRpZiAoKQorCiAjIFdlIGRvbid0 IHVzZSBmaW5kX3BhY2thZ2UgZm9yIEdMWCBiZWNhdXNlIGl0IGlzIHBhcnQgb2YgLWxHTCwgdW5s aWtlIEVHTC4KIGZpbmRfcGFja2FnZShPcGVuR0wpCiBjaGVja19pbmNsdWRlX2ZpbGVzKCJHTC9n bHguaCIgR0xYX0ZPVU5EKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2Ug Yi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRleCAxMzAwNWVjNTAzNDQyNTBlY2UxMzVm NWVhMmNlZWUzNjZkZGI0NmViLi5hZTkyMDdkZDAxZjFkYTA4OTI4NGU4MmViNWNkNDMyMzExNjJh ODk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQorKysgYi9Tb3VyY2Uv Y21ha2Vjb25maWcuaC5jbWFrZQpAQCAtMTIsNiArMTIsNyBAQAogI2NtYWtlZGVmaW5lMDEgRU5B QkxFX0NBTlZBU19QUk9YWQogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5H CiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ09OVEVYVF9NRU5VUworI2NtYWtlZGVmaW5lMDEgRU5B QkxFX0NSRURFTlRJQUxfU1RPUkFHRQogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTUF9ORVhUCiAj Y21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTM19URVhUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NT M19URVhUX0xJTkVfQlJFQUsKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCA1ZjhkYjhjZjQyODdlNGY2M2FjMjU2ZmY0YjlkMzAyYzM0ZGM2NjNjLi5iZmQzZWEzZDg0YTZm NTY3ZjhmNjNjNzY0MzU0Nzg5NGNkNjM4MWMzIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDMtMTMgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW0NNYWtlXSBDcmVkZW50aWFs IHN0b3JhZ2UgaXMgbm90IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMDE0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IEFkZCBhbiBF TkFCTEVfQ1JFREVOVElBTF9TVE9SQUdFIG9wdGlvbiB0byB0aGUgY29uZmlndXJhdGlvbgorICAg ICAgICBhbmQgbG9vayBsaWJzZWNyZXQgd2hlbiBpdCdzIGVuYWJsZWQuCisgICAgICAgICogU291 cmNlL2NtYWtlY29uZmlnLmguY21ha2U6IEV4cG9zZSB0aGUgRU5BQkxFX0NSRURFTlRJQUxfU1RP UkFHRSBvcHRpb24gdG8gdGhlIGJ1aWxkLgorCiAyMDE0LTAzLTEyICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIENoYW5nZXMgdG8gdGhl IGJpbmRpbmdzIGdlbmVyYXRvciBQZXJsIG1vZHVsZXMgZG8gbm90IHRyaWdnZXIgcmVnZW5lcmF0 aW9uIG9mIGJpbmRpbmdzCg==