130140 2014-03-12 10:36:14 -0700 BundlePageDiagnosticLoggingClient leaks every string passing through it. 2014-04-10 22:24:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 130151 1 kling kling commit-queue kling mitz oldest_to_newest 989702 0 kling 2014-03-12 10:36:14 -0700 <rdar://problem/15416838> 989708 1 226527 kling 2014-03-12 10:45:48 -0700 Created attachment 226527 Patch 989721 2 kling 2014-03-12 11:00:45 -0700 Committed r165481: <http://trac.webkit.org/changeset/165481> 989776 3 commit-queue 2014-03-12 11:52:49 -0700 Re-opened since this is blocked by bug 130151 999434 4 229023 mitz 2014-04-09 23:10:45 -0700 Created attachment 229023 Patch 999786 5 229023 bfulgham 2014-04-10 22:15:28 -0700 Comment on attachment 229023 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229023&action=review r=me. > Source/WebKit2/ChangeLog:9 > + (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Don’t copy the Looks like a smart quote got into this ASCII file. 999791 6 mitz 2014-04-10 22:24:17 -0700 Fixed in <http://trac.webkit.org/r167113>. 226527 2014-03-12 10:45:48 -0700 2014-04-09 23:10:42 -0700 Patch bug-130140.diff text/plain 1686 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlYzQxZjkxLi4zZmI4Y2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDMtMTIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEJ1bmRsZVBhZ2VEaWFnbm9zdGljTG9nZ2luZ0NsaWVudCBsZWFrcyBldmVyeSBzdHJpbmcg cGFzc2luZyB0aHJvdWdoIGl0LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMwMTQw PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU0MTY4Mzg+CisKKyAgICAgICAgVXNlIHRvQVBJ KCkgaW5zdGVhZCBvZiB0b0NvcGllZEFQSSgpIHNvIHRoZSByZWNlaXZpbmcgZW5kIGRvZXNuJ3Qg bmVlZAorICAgICAgICB0byB3b3JyeSBhYm91dCBhZG9wdGluZyB0aGUgV0tTdHJpbmdSZWYuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZURpYWdub3N0aWNMb2dnaW5nQ2xp ZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xv Z2dpbmdDbGllbnQ6OmxvZ0RpYWdub3N0aWNNZXNzYWdlKToKKwogMjAxNC0wMy0xMSAgQmV0aCBE YWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgX3BhZ2VFeHRlbmRlZEJhY2tncm91 bmRDb2xvciBzaG91bGQgbm90IGJlIGV4cG9zZWQgb24gV0tXZWJWaWV3CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFn ZURpYWdub3N0aWNMb2dnaW5nQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQu Y3BwCmluZGV4IDA2ZmNjNWEuLjJiMWI4ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xvZ2dp bmdDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvSW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQuY3BwCkBAIC0zNSw3 ICszNSw3IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQ6 OmxvZ0RpYWdub3N0aWNNZXNzYWdlKFdlYlBhZ2UqIHBhCiB7CiAgICAgaWYgKCFtX2NsaWVudC5s b2dEaWFnbm9zdGljTWVzc2FnZSkKICAgICAgICAgcmV0dXJuOwotICAgIG1fY2xpZW50LmxvZ0Rp YWdub3N0aWNNZXNzYWdlKHRvQVBJKHBhZ2UpLCB0b0NvcGllZEFQSShtZXNzYWdlKSwgdG9Db3Bp ZWRBUEkoZGVzY3JpcHRpb24pLCB0b0NvcGllZEFQSShzdWNjZXNzKSwgbV9jbGllbnQuYmFzZS5j bGllbnRJbmZvKTsKKyAgICBtX2NsaWVudC5sb2dEaWFnbm9zdGljTWVzc2FnZSh0b0FQSShwYWdl KSwgdG9BUEkobWVzc2FnZSksIHRvQVBJKGRlc2NyaXB0aW9uKSwgdG9BUEkoc3VjY2VzcyksIG1f Y2xpZW50LmJhc2UuY2xpZW50SW5mbyk7CiB9CiAKIH0K 229023 2014-04-09 23:10:45 -0700 2014-04-10 22:15:28 -0700 Patch bug-130140-20140409231029.patch text/plain 1580 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzA2NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTA5ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgQnVuZGxlUGFnZURpYWdub3N0aWNM b2dnaW5nQ2xpZW50IGxlYWtzIGV2ZXJ5IHN0cmluZyBwYXNzaW5nIHRocm91Z2ggaXQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAxNDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQu Y3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZVBhZ2VEaWFnbm9zdGljTG9nZ2lu Z0NsaWVudDo6bG9nRGlhZ25vc3RpY01lc3NhZ2UpOiBEb27igJl0IGNvcHkgdGhlCisgICAgICAg IHN0cmluZ3MgcGFzc2VkIGludG8gdGhlIGJ1bmRsZSBjbGllbnQuCisKIDIwMTQtMDQtMDkgIEpl cmVteSBKb25lcyAgPGplcmVteWpAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBidWlsZCBmYWls dXJlIHdoZW4gI2lmIFVTRShYUENfU0VSVklDRVMpIGlzIGZhbHNlLgpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VEaWFnbm9z dGljTG9nZ2luZ0NsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VEaWFnbm9zdGljTG9nZ2luZ0Ns aWVudC5jcHAJKHJldmlzaW9uIDE2NzA2MCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGVQ YWdlRGlhZ25vc3RpY0xvZ2dpbmcKIHsKICAgICBpZiAoIW1fY2xpZW50LmxvZ0RpYWdub3N0aWNN ZXNzYWdlKQogICAgICAgICByZXR1cm47Ci0gICAgbV9jbGllbnQubG9nRGlhZ25vc3RpY01lc3Nh Z2UodG9BUEkocGFnZSksIHRvQ29waWVkQVBJKG1lc3NhZ2UpLCB0b0NvcGllZEFQSShkZXNjcmlw dGlvbiksIHRvQ29waWVkQVBJKHN1Y2Nlc3MpLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8pOwor ICAgIG1fY2xpZW50LmxvZ0RpYWdub3N0aWNNZXNzYWdlKHRvQVBJKHBhZ2UpLCB0b0FQSShtZXNz YWdlLmltcGwoKSksIHRvQVBJKGRlc2NyaXB0aW9uLmltcGwoKSksIHRvQVBJKHN1Y2Nlc3MuaW1w bCgpKSwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZvKTsKIH0KIAogfQo=