130132 2014-03-12 08:42:33 -0700 [EFL][WK2] Fix compilation warning in Minibrowser 2014-03-13 19:31:56 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sh53.lee webkit-unassigned commit-queue lucas.de.marchi ossy oldest_to_newest 989632 0 sh53.lee 2014-03-12 08:42:33 -0700 Replace mktemp() to mkdtemp() to fix compilation warning in MiniBrowser. CMakeFiles/MiniBrowser.dir/main.c.o: In function `on_download_request': main.c:(.text.on_download_request+0x71): warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp' 989640 1 226511 sh53.lee 2014-03-12 08:49:27 -0700 Created attachment 226511 Patch 989689 2 226511 ossy 2014-03-12 10:15:05 -0700 Comment on attachment 226511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226511&action=review > Tools/ChangeLog:8 > + Replace mktemp() with mkdtemp() to fix compilation warning in MiniBrowser. typo: you meant mkstemp instead of mkdtemp > Tools/MiniBrowser/efl/main.c:606 > - eina_strbuf_append(destination_path, mktemp(unique_path)); > + mkstemp(unique_path); > + eina_strbuf_append(destination_path, unique_path); Shouldn't we check if the return value is -1 ? 989889 3 226566 sh53.lee 2014-03-12 18:08:52 -0700 Created attachment 226566 Patch 989891 4 sh53.lee 2014-03-12 18:20:41 -0700 (In reply to comment #3) > Created an attachment (id=226566) [details] > Patch (In reply to comment #2) > (From update of attachment 226511 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226511&action=review > > > Tools/ChangeLog:8 > > + Replace mktemp() with mkdtemp() to fix compilation warning in MiniBrowser. > > typo: you meant mkstemp instead of mkdtemp > > > Tools/MiniBrowser/efl/main.c:606 > > - eina_strbuf_append(destination_path, mktemp(unique_path)); > > + mkstemp(unique_path); > > + eina_strbuf_append(destination_path, unique_path); > > Shouldn't we check if the return value is -1 ? Thanks for review. I fixed it. 989892 5 sh53.lee 2014-03-12 18:22:05 -0700 (In reply to comment #2) > (From update of attachment 226511 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226511&action=review > > > Tools/ChangeLog:8 > > + Replace mktemp() with mkdtemp() to fix compilation warning in MiniBrowser. > > typo: you meant mkstemp instead of mkdtemp > > > Tools/MiniBrowser/efl/main.c:606 > > - eina_strbuf_append(destination_path, mktemp(unique_path)); > > + mkstemp(unique_path); > > + eina_strbuf_append(destination_path, unique_path); > > Shouldn't we check if the return value is -1 ? Thanks for review. I fixed it. 990256 6 226566 commit-queue 2014-03-13 19:31:53 -0700 Comment on attachment 226566 Patch Clearing flags on attachment: 226566 Committed r165596: <http://trac.webkit.org/changeset/165596> 990257 7 commit-queue 2014-03-13 19:31:56 -0700 All reviewed patches have been landed. Closing bug. 226511 2014-03-12 08:49:27 -0700 2014-03-12 18:08:43 -0700 Patch bug-130132-20140313004903.patch text/plain 1462 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTc0NmY0YjM2ODFhYzNkYzdlOWE5NDcyNjc2Y2Q0NzZi OGZkYjIyMS4uZDM5MGYwYWZiYmZjMmVkOTY4OGI2OWVjNWFhYjIxMTE2MTk4NDM4NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAzLTEyICBTYW5naHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtXSzJdIEZpeCBjb21waWxhdGlvbiB3YXJuaW5nIGluIE1pbmlicm93c2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAxMzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNl IG1rdGVtcCgpIHdpdGggbWtkdGVtcCgpIHRvIGZpeCBjb21waWxhdGlvbiB3YXJuaW5nIGluIE1p bmlCcm93c2VyLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAg KG9uX2Rvd25sb2FkX3JlcXVlc3QpOgorCiAyMDE0LTAzLTEyICBSeXVhbiBDaG9pICA8cnl1YW4u Y2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBvbiB0aGUg RUZMIHBvcnQgd2hlbiB1c2VkIGxvd2VyIHZlcnNpb24gb2YgQVRLCmRpZmYgLS1naXQgYS9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpp bmRleCBhNDU3NDgwZDIzNDVkZTc5YTBiMGViYWM3YzBmMGFjMWY3MTI3OTFhLi4zNTg3ZDgwYTNj Y2JjYWM2ZGYwZWU0Y2M3ZTkyYTdjNmVhZWIxZDM0IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJv d3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTYw Miw3ICs2MDIsOCBAQCBvbl9kb3dubG9hZF9yZXF1ZXN0KHZvaWQgKnVzZXJfZGF0YSwgRXZhc19P YmplY3QgKmV3a192aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgIGVsc2UgewogICAgICAgICAv LyBHZW5lcmF0ZSBhIHVuaXF1ZSBmaWxlIG5hbWUgc2luY2Ugbm8gbmFtZSB3YXMgc3VnZ2VzdGVk LgogICAgICAgICBjaGFyIHVuaXF1ZV9wYXRoW10gPSAiL3RtcC9kb3dubG9hZGVkLWZpbGUuWFhY WFhYIjsKLSAgICAgICAgZWluYV9zdHJidWZfYXBwZW5kKGRlc3RpbmF0aW9uX3BhdGgsIG1rdGVt cCh1bmlxdWVfcGF0aCkpOworICAgICAgICBta3N0ZW1wKHVuaXF1ZV9wYXRoKTsKKyAgICAgICAg ZWluYV9zdHJidWZfYXBwZW5kKGRlc3RpbmF0aW9uX3BhdGgsIHVuaXF1ZV9wYXRoKTsKICAgICB9 CiAKICAgICBld2tfZG93bmxvYWRfam9iX2Rlc3RpbmF0aW9uX3NldChkb3dubG9hZCwgZWluYV9z dHJidWZfc3RyaW5nX2dldChkZXN0aW5hdGlvbl9wYXRoKSk7Cg== 226566 2014-03-12 18:08:52 -0700 2014-03-13 19:31:53 -0700 Patch bug-130132-20140313100832.patch text/plain 1561 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NTEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjIzNjJhZGIxNGIxZDYzOWQ4ZjcwMzJkMDAyZjU4MmMw MzNhNjZjYS4uNTFiMjdhODA1OWQ1YzE4NTgxZjQxOTk0NmYxZDEwN2Q3MjM0YThjMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAzLTEyICBTYW5naHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtXSzJdIEZpeCBjb21waWxhdGlvbiB3YXJuaW5nIGluIE1pbmlicm93c2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAxMzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNl IG1rdGVtcCgpIHdpdGggbWtzdGVtcCgpIHRvIGZpeCBjb21waWxhdGlvbiB3YXJuaW5nIGluIE1p bmlCcm93c2VyLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAg KG9uX2Rvd25sb2FkX3JlcXVlc3QpOgorCiAyMDE0LTAzLTEyICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR1RLKyBj bWFrZSBidWlsZCBhZnRlciByMTY1NDg4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIv ZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggYTQ1NzQ4MGQy MzQ1ZGU3OWEwYjBlYmFjN2MwZjBhYzFmNzEyNzkxYS4uMGU2NTYwMWE5MjEyNTJkYTM2NzIzYjA5 ZjczM2U1NjcwMTViZjM5ZCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4u YworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC02MDIsNyArNjAyLDExIEBA IG9uX2Rvd25sb2FkX3JlcXVlc3Qodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqZXdrX3Zp ZXcsIHZvaWQgKmV2ZW50X2luZm8pCiAgICAgZWxzZSB7CiAgICAgICAgIC8vIEdlbmVyYXRlIGEg dW5pcXVlIGZpbGUgbmFtZSBzaW5jZSBubyBuYW1lIHdhcyBzdWdnZXN0ZWQuCiAgICAgICAgIGNo YXIgdW5pcXVlX3BhdGhbXSA9ICIvdG1wL2Rvd25sb2FkZWQtZmlsZS5YWFhYWFgiOwotICAgICAg ICBlaW5hX3N0cmJ1Zl9hcHBlbmQoZGVzdGluYXRpb25fcGF0aCwgbWt0ZW1wKHVuaXF1ZV9wYXRo KSk7CisgICAgICAgIGlmIChta3N0ZW1wKHVuaXF1ZV9wYXRoKSA9PSAtMSkgeworICAgICAgICAg ICAgaW5mbygiRVJST1I6IENvdWxkIG5vdCBnZW5lcmF0ZSBhIHVuaXF1ZSBmaWxlIG5hbWUuIik7 CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgZWluYV9zdHJidWZfYXBw ZW5kKGRlc3RpbmF0aW9uX3BhdGgsIHVuaXF1ZV9wYXRoKTsKICAgICB9CiAKICAgICBld2tfZG93 bmxvYWRfam9iX2Rlc3RpbmF0aW9uX3NldChkb3dubG9hZCwgZWluYV9zdHJidWZfc3RyaW5nX2dl dChkZXN0aW5hdGlvbl9wYXRoKSk7Cg==