130127 2014-03-12 06:54:13 -0700 Nested use of same SVG resource fails 2023-06-15 15:56:00 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=258171 InRadar P2 Normal --- 1 krit rniwa ahmad.saleem792 mihnea ntim rniwa webkit-bug-importer WebkitBugTracker zimmermann oldest_to_newest 989606 0 226500 krit 2014-03-12 06:54:13 -0700 Created attachment 226500 Example - passes if you see a circle An element is filled with a pattern #p1. The element gets masked as well. If this mask makes use of #p1 as well, then it fails. This is probably a problem with the cycle detection code for SVG resources. For some reason the code detects a cycle even though this is absolutely fine. Creating a second pattern with a different id makes the example work. The example passes if you see a circle. 1923858 1 ahmad.saleem792 2023-01-07 15:31:35 -0800 It is still happening with Safari 16.2 and Safari Technology Preview 160, it was fixed in Blink with following commit: Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=175129 & https://src.chromium.org/viewvc/blink?revision=174862&view=revision WebKit Source (Example) - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp#53 Just wanted to share this. Might be bit out of my area of expertise to try to merge this and don't want to cause collision with on-going LBSE work as well (if it reaches in this realm). Just wanted to share. Thanks! 1923870 2 ntim 2023-01-07 16:53:31 -0800 > Might be bit out of my area of expertise to try to merge this and don't want to cause collision with on-going LBSE work as well (if it reaches in this realm). I don't think there is any collision with LBSE in this case. LBSE does not affect resource resolution. 1955295 3 ahmad.saleem792 2023-05-14 03:51:43 -0700 (In reply to Ahmad Saleem from comment #1) > It is still happening with Safari 16.2 and Safari Technology Preview 160, it > was fixed in Blink with following commit: > > Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=175129 > & https://src.chromium.org/viewvc/blink?revision=174862&view=revision > > WebKit Source (Example) - > https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/ > SVGResourcesCycleSolver.cpp#53 > > Just wanted to share this. Might be bit out of my area of expertise to try > to merge this and don't want to cause collision with on-going LBSE work as > well (if it reaches in this realm). Just wanted to share. Thanks! We only need to do: https://src.chromium.org/viewvc/blink?view=revision&revision=175129 ^ I tried but I think our code has also evolved, so it is not 1-1, there are still some similarities but we have WeakHashSet intro in this code as well. @Ryosuke did some WeakHashSet intro in various places of code. Might be something you can have a look? 1957850 4 rniwa 2023-05-25 02:15:43 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14338 1958353 5 ews-feeder 2023-05-26 20:52:07 -0700 Committed 264618@main (99265dce4d2f): <https://commits.webkit.org/264618@main> Reviewed commits have been landed. Closing PR #14338 and removing active labels. 1958354 6 webkit-bug-importer 2023-05-26 20:53:16 -0700 <rdar://problem/109917889> 226500 2014-03-12 06:54:13 -0700 2014-03-12 06:54:13 -0700 Example - passes if you see a circle cycle-detection-bug.svg image/svg+xml 343 krit PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPg0KPHBhdHRlcm4gd2lkdGg9 IjEwMCUiIGhlaWdodD0iMTAwJSIgaWQ9InBhdHRlcm4iIHZpZXdCb3g9IjAgMCAxMDAgMTAwIj4N CiAgPHJlY3Qgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9ImdyYXkiLz4NCjwvcGF0dGVy bj4NCjxtYXNrIGlkPSJtYXNrIj4NCiAgPGNpcmNsZSBmaWxsPSJ1cmwoI3BhdHRlcm4pIiBjeD0i MTAwIiBjeT0iMTAwIiByPSIxMDAiLz4NCjwvbWFzaz4NCjxyZWN0IHdpZHRoPSIyMDAiIGhlaWdo dD0iMjAwIiBtYXNrPSJ1cmwoI21hc2spIiBmaWxsPSJ1cmwoI3BhdHRlcm4pIi8+DQo8L3N2Zz4N Cg==