<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>130117</bug_id>
          
          <creation_ts>2014-03-11 23:08:36 -0700</creation_ts>
          <short_desc>Make HTMLCanvasElement::is3D private</short_desc>
          <delta_ts>2014-03-12 17:39:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jae Hyun Park">jaepark</reporter>
          <assigned_to name="Jae Hyun Park">jaepark</assigned_to>
          <cc>andersca</cc>
    
    <cc>kling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>989543</commentid>
    <comment_count>0</comment_count>
    <who name="Jae Hyun Park">jaepark</who>
    <bug_when>2014-03-11 23:08:36 -0700</bug_when>
    <thetext>HTMLCanvasElement::is3D is only used in HTMLCanvasElement, so make is3D private.
Also, make more use of is3D.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>989544</commentid>
    <comment_count>1</comment_count>
      <attachid>226478</attachid>
    <who name="Jae Hyun Park">jaepark</who>
    <bug_when>2014-03-11 23:12:54 -0700</bug_when>
    <thetext>Created attachment 226478
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>989884</commentid>
    <comment_count>2</comment_count>
    <who name="Jae Hyun Park">jaepark</who>
    <bug_when>2014-03-12 17:39:37 -0700</bug_when>
    <thetext>Committed r165520: &lt;http://trac.webkit.org/changeset/165520&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>226478</attachid>
            <date>2014-03-11 23:12:54 -0700</date>
            <delta_ts>2014-03-12 07:30:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130117-20140312151241.patch</filename>
            <type>text/plain</type>
            <size>2771</size>
            <attacher name="Jae Hyun Park">jaepark</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThjMmZlZmExNmM1YzJi
YjhlOGFmMTEzZTc5OTM5OTJkMDc5N2M1OS4uN2MwNjY1MGVlZDJiYjJiY2Y2NmRjYmZlNmNlMTE1
MjVmNGMxZWM4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAzLTExICBKYWUg
SHl1biBQYXJrICA8amFlcGFya0B3ZWJraXQub3JnPgorCisgICAgICAgIE1ha2UgSFRNTENhbnZh
c0VsZW1lbnQ6OmlzM0QgcHJpdmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTMwMTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgSFRNTENhbnZhc0VsZW1lbnQ6OmlzM0QgaXMgbm90IHVzZWQgYW55d2hl
cmUgZXhjZXB0IEhUTUxDYW52YXNFbGVtZW50LgorICAgICAgICBTbywgbWFrZSBIVE1MQ2FudmFz
RWxlbWVudDo6aXMzRCBhIHByaXZhdGUgbWV0aG9kLiBBbHNvLCBtYWtlIG1vcmUgdXNlCisgICAg
ICAgIG9mIGlzM0QgbWV0aG9kLgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6cmVzZXQpOgorICAgICAg
ICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OmdldEltYWdlRGF0YSk6CisgICAgICAgICog
aHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oOgorCiAyMDE0LTAzLTExICBSeXVhbiBDaG9pICA8cnl1
YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIG1ldGhvZCBmcm9t
IEJhdHRlcnlDb250cm9sbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxD
YW52YXNFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQu
Y3BwCmluZGV4IDc0YzA3NWQwYjc4NDkyODQ1NTgwYjJiYTYxYmQxMGRhZTVlZTFhNDcuLjlhYjFi
MGQ5NjY3MzZlNjA4YTc1MTEwZmIzMjQ1MmZmMzdmNDE4N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0
bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCkBAIC0zMzUsNyArMzM1LDcgQEAgdm9pZCBIVE1MQ2Fu
dmFzRWxlbWVudDo6cmVzZXQoKQogICAgIHNldFN1cmZhY2VTaXplKG5ld1NpemUpOwogCiAjaWYg
RU5BQkxFKFdFQkdMKQotICAgIGlmIChtX2NvbnRleHQgJiYgbV9jb250ZXh0LT5pczNkKCkgJiYg
b2xkU2l6ZSAhPSBzaXplKCkpCisgICAgaWYgKGlzM0QoKSAmJiBvbGRTaXplICE9IHNpemUoKSkK
ICAgICAgICAgc3RhdGljX2Nhc3Q8V2ViR0xSZW5kZXJpbmdDb250ZXh0Kj4obV9jb250ZXh0Lmdl
dCgpKS0+cmVzaGFwZSh3aWR0aCgpLCBoZWlnaHQoKSk7CiAjZW5kaWYKIApAQCAtNDg5LDE1ICs0
ODksMTUgQEAgU3RyaW5nIEhUTUxDYW52YXNFbGVtZW50Ojp0b0RhdGFVUkwoY29uc3QgU3RyaW5n
JiBtaW1lVHlwZSwgY29uc3QgZG91YmxlKiBxdWFsaXQKIAogUGFzc1JlZlB0cjxJbWFnZURhdGE+
IEhUTUxDYW52YXNFbGVtZW50OjpnZXRJbWFnZURhdGEoKQogewotICAgIGlmICghbV9jb250ZXh0
IHx8ICFtX2NvbnRleHQtPmlzM2QoKSkKLSAgICAgICByZXR1cm4gMDsKKyNpZiBFTkFCTEUoV0VC
R0wpCisgICAgaWYgKCFpczNEKCkpCisgICAgICAgIHJldHVybiBudWxscHRyOwogCi0jaWYgRU5B
QkxFKFdFQkdMKSAgICAKICAgICBXZWJHTFJlbmRlcmluZ0NvbnRleHQqIGN0eCA9IHN0YXRpY19j
YXN0PFdlYkdMUmVuZGVyaW5nQ29udGV4dCo+KG1fY29udGV4dC5nZXQoKSk7CiAKICAgICByZXR1
cm4gY3R4LT5wYWludFJlbmRlcmluZ1Jlc3VsdHNUb0ltYWdlRGF0YSgpOwogI2Vsc2UKLSAgICBy
ZXR1cm4gMDsKKyAgICByZXR1cm4gbnVsbHB0cjsKICNlbmRpZgogfQogCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9o
dG1sL0hUTUxDYW52YXNFbGVtZW50LmgKaW5kZXggZGMzNzViOTI0NTU2OTA3YWNkM2IxZDExMGFl
MzNmMDdkZmU2YTdkOS4uNWYzYjcwMzYyYTcxODc2MjRlMjNjOGVhZDZlNjcwODMxMzg0ZjQ0NCAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisrKyBi
L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaApAQCAtMTM2LDEwICsxMzYs
NiBAQCBwdWJsaWM6CiAKICAgICBBZmZpbmVUcmFuc2Zvcm0gYmFzZVRyYW5zZm9ybSgpIGNvbnN0
OwogCi0jaWYgRU5BQkxFKFdFQkdMKSAgICAKLSAgICBib29sIGlzM0QoKSBjb25zdDsKLSNlbmRp
ZgotCiAgICAgdm9pZCBtYWtlUmVuZGVyaW5nUmVzdWx0c0F2YWlsYWJsZSgpOwogICAgIGJvb2wg
aGFzQ3JlYXRlZEltYWdlQnVmZmVyKCkgY29uc3QgeyByZXR1cm4gbV9oYXNDcmVhdGVkSW1hZ2VC
dWZmZXI7IH0KIApAQCAtMTY4LDYgKzE2NCwxMCBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBwYWlu
dHNJbnRvQ2FudmFzQnVmZmVyKCkgY29uc3Q7CiAKKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgYm9v
bCBpczNEKCkgY29uc3Q7CisjZW5kaWYKKwogICAgIEhhc2hTZXQ8Q2FudmFzT2JzZXJ2ZXIqPiBt
X29ic2VydmVyczsKIAogICAgIEludFNpemUgbV9zaXplOwo=
</data>
<flag name="review"
          id="250715"
          type_id="1"
          status="+"
          setter="andersca"
    />
    <flag name="commit-queue"
          id="250716"
          type_id="3"
          status="+"
          setter="andersca"
    />
          </attachment>
      

    </bug>

</bugzilla>