130113 2014-03-11 20:02:21 -0700 Fix a bunch of mistakes in the parsing of ::cue( and ::cue 2014-03-13 17:31:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin allan.jensen esprehn+autocc glenn gyuyoung.kim macpherson menard webkit-ews oldest_to_newest 989515 0 benjamin 2014-03-11 20:02:21 -0700 Fix a bunch of mistakes in the parsing of ::cue( and ::cue 989526 1 226470 benjamin 2014-03-11 20:49:24 -0700 Created attachment 226470 Patch 990213 2 226470 benjamin 2014-03-13 17:31:42 -0700 Comment on attachment 226470 Patch Clearing flags on attachment: 226470 Committed r165579: <http://trac.webkit.org/changeset/165579> 990214 3 benjamin 2014-03-13 17:31:47 -0700 All reviewed patches have been landed. Closing bug. 226470 2014-03-11 20:49:24 -0700 2014-03-13 17:31:42 -0700 Patch bug-130113-20140311204851.patch text/plain 4025 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVlNDQ5ZWRjZjY5MWIy ZmM0YmIzYWY4OWQ2YmU1MjIyNmNhMTA2NC4uMWI2ZmU3OTBkMWNiNzAxOTkxN2U2MTkwNWJhMWYz NjA3MDU5MmVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE0LTAzLTExICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBhIGJ1bmNo IG9mIG1pc3Rha2VzIGluIHRoZSBwYXJzaW5nIG9mIDo6Y3VlKCBhbmQgOjpjdWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDExMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3NzL0NTU0dyYW1tYXIu eS5pbjoKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyVmFsdWVzLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1BhcnNlclNlbGVjdG9yOjpzZXRQc2V1ZG9UeXBlVmFsdWUpOgorICAgICAgICBUaGUg OjpjdWUoKSBwc2V1ZG8gZWxlbWVudCAiZnVuY3Rpb24iIHdhcyBwYXNzZWQgYXMgYSBQc2V1ZG9D bGFzcy4KKyAgICAgICAgVGhlIHR5cGUgd2FzIHRoZW4gcGFyc2VkIGFuZCBjb25zaWRlcmVkIGFz IGEgY29tcGF0aWJpbGl0eSB0eXBlIHRvIGZsaXAKKyAgICAgICAgdGhlIG1hdGNoIHR5cGUgYmFj ayB0byBQc2V1ZG9FbGVtZW50LgorCisgICAgICAgIEluc3RlYWQgb2YgYWxsIHRoYXQgamF6eiwg anVzdCBwYXNzIHRoZSByaWdodCB0eXBlIGZyb20gdGhlIGdyYW1tYXIuCisKKyAgICAgICAgKiBj c3MvQ1NTU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU2VsZWN0b3I6OnBhcnNl UHNldWRvVHlwZSk6CisgICAgICAgIFRoZSBub24tZnVuY3Rpb24gOjpjdWUgcHNldWRvIGVsZW1l bnQgdXNlIHNoYWRvdyBwc2V1ZG8gSUQgZm9yIG1hdGNoaW5nIHRoZSBlbGVtZW50LgorICAgICAg ICBTaW5jZSBpdCBpcyB1bnByZWZpeGVkLCBpdCBuZWVkcyB0byBtYXAgdG8gb25lIG9mIHRoZSBD dXN0b20gdHlwZXMuIFRoZSBwcmV2aW91cyBjb2RlCisgICAgICAgIHdhcyB1c2luZyBTdHJpbmc6 OnN0YXJ0c1dpdGgoKSBmb3Igc29tZSByZWFzb24sIGNoYW5nZSB0aGF0IHRvIGEgc2ltcGxlIGVx dWFsaXR5LgorCisyMDE0LTAzLTExICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUu Y29tPgorCiAgICAgICAgIFJlbW92ZSBJTlBVVF9MSVNUX0JVVFRPTiBmcm9tIHRoZSBQc2V1ZG9J ZHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDEw OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluIGIvU291 cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbgppbmRleCAxN2NhOWM0OTViNGRmOGZhNTgz NTExOGY3NzgyZDk1NTZjY2ZhMGE4Li45MWI1MzU2YWIzOTU5MTM3OTQ1ODljNDZhMDI1M2E2M2I5 ZjQxNjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4KQEAgLTExOTgsMTEgKzExOTgs MTEgQEAgcHNldWRvOgogICAgICAgICAkJCA9IG51bGxwdHI7CiAgICAgICAgIGlmICgkNSkgewog ICAgICAgICAgICAgYXV0byBzZWxlY3RvciA9IHN0ZDo6bWFrZV91bmlxdWU8Q1NTUGFyc2VyU2Vs ZWN0b3I+KCk7Ci0gICAgICAgICAgICBzZWxlY3Rvci0+c2V0TWF0Y2goQ1NTU2VsZWN0b3I6OlBz ZXVkb0NsYXNzKTsKKyAgICAgICAgICAgIHNlbGVjdG9yLT5zZXRNYXRjaChDU1NTZWxlY3Rvcjo6 UHNldWRvRWxlbWVudCk7CiAgICAgICAgICAgICBzZWxlY3Rvci0+YWRvcHRTZWxlY3RvclZlY3Rv cigqc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8Q1NTUGFyc2VyU2VsZWN0 b3I+Pj4oJDUpKTsKICAgICAgICAgICAgIHNlbGVjdG9yLT5zZXRQc2V1ZG9UeXBlVmFsdWUoJDMp OwotICAgICAgICAgICAgaWYgKHNlbGVjdG9yLT5wc2V1ZG9UeXBlKCkgPT0gQ1NTU2VsZWN0b3I6 OlBzZXVkb0N1ZSkKLSAgICAgICAgICAgICAgICAkJCA9IHNlbGVjdG9yLnJlbGVhc2UoKTsKKyAg ICAgICAgICAgIEFTU0VSVChzZWxlY3Rvci0+cHNldWRvVHlwZSgpID09IENTU1NlbGVjdG9yOjpQ c2V1ZG9DdWUpOworICAgICAgICAgICAgJCQgPSBzZWxlY3Rvci5yZWxlYXNlKCk7CiAgICAgICAg IH0KICAgICB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXJWYWx1ZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlclZhbHVlcy5jcHAKaW5k ZXggZjJkNzI0NDMxNjM0M2ZhZTFmMjJjMzQ0YzgwM2FkNTQyYjNlNzdkOS4uNTJkZjNmMzhjZmUz NWVmNmM4MjZkMTIyMjUzOGVjMDFlZGYzOWM1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1BhcnNlclZhbHVlcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl clZhbHVlcy5jcHAKQEAgLTIwOCwxMyArMjA4LDEzIEBAIHZvaWQgQ1NTUGFyc2VyU2VsZWN0b3I6 OnNldFBzZXVkb1R5cGVWYWx1ZShjb25zdCBDU1NQYXJzZXJTdHJpbmcmIHBzZXVkb1R5cGVTdHJp CiAgICAgc3dpdGNoIChwc2V1ZG9UeXBlKSB7CiAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRv QWZ0ZXI6CiAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvQmVmb3JlOgotI2lmIEVOQUJMRShW SURFT19UUkFDSykKLSAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9DdWU6Ci0jZW5kaWYKICAg ICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9GaXJzdExldHRlcjoKICAgICBjYXNlIENTU1NlbGVj dG9yOjpQc2V1ZG9GaXJzdExpbmU6CiAgICAgICAgIGNvbXBhdCA9IHRydWU7CiAgICAgICAgIEZB TExUSFJPVUdIOworI2lmIEVOQUJMRShWSURFT19UUkFDSykKKyAgICBjYXNlIENTU1NlbGVjdG9y OjpQc2V1ZG9DdWU6CisjZW5kaWYKICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9SZXNpemVy OgogICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb1Njcm9sbGJhcjoKICAgICBjYXNlIENTU1Nl bGVjdG9yOjpQc2V1ZG9TY3JvbGxiYXJDb3JuZXI6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTU2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNw cAppbmRleCA4NzQ4YjQ2MmM3NjJhOWI4ZDRhNDM0NDNhOTUwNzNjZWY5MmY1YjFmLi40OGNlNjgx M2U0MjM4M2UyMWY1NzgzYzAxMTNiZmZjODMxM2E5OTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxl Y3Rvci5jcHAKQEAgLTI1OSw4ICsyNTksMTAgQEAgQ1NTU2VsZWN0b3I6OlBzZXVkb1R5cGUgQ1NT U2VsZWN0b3I6OnBhcnNlUHNldWRvVHlwZShjb25zdCBTdHJpbmcmIG5hbWUpCiAgICAgICAgIGlm IChuYW1lLnN0YXJ0c1dpdGgoIi13ZWJraXQtIikpCiAgICAgICAgICAgICB0eXBlID0gUHNldWRv V2ViS2l0Q3VzdG9tRWxlbWVudDsKIAotICAgICAgICAvLyBGSVhNRTogVGhpcyBpcyBzdHJhbmdl LiBXaHkgd291bGQgYWxsIHN0cmluZ3MgdGhhdCBzdGFydCB3aXRoICJjdWUiIGJlICJ1c2VyIGFn ZW50IGN1c3RvbSI/Ci0gICAgICAgIGlmIChuYW1lLnN0YXJ0c1dpdGgoIngtIikgfHwgbmFtZS5z dGFydHNXaXRoKCJjdWUiKSkKKyAgICAgICAgaWYgKG5hbWUgPT0gImN1ZSIpCisgICAgICAgICAg ICB0eXBlID0gUHNldWRvV2ViS2l0Q3VzdG9tRWxlbWVudDsKKworICAgICAgICBpZiAobmFtZS5z dGFydHNXaXRoKCJ4LSIpKQogICAgICAgICAgICAgdHlwZSA9IFBzZXVkb1VzZXJBZ2VudEN1c3Rv bUVsZW1lbnQ7CiAgICAgfQogICAgIHJldHVybiB0eXBlOwo=