130109 2014-03-11 19:21:46 -0700 Remove HandleSet::m_nextToFinalize 2014-03-12 11:31:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 989505 0 mhahnenberg 2014-03-11 19:21:46 -0700 This is a remnant of when HandleSet contained things that needed to be finalized. WeakSet handles all of this now. 989507 1 mhahnenberg 2014-03-11 19:22:23 -0700 (In reply to comment #0) > WeakSet handles all of this now. No pun intended :-) 989508 2 226466 mhahnenberg 2014-03-11 19:23:48 -0700 Created attachment 226466 Patch 989512 3 226466 mark.lam 2014-03-11 19:42:28 -0700 Comment on attachment 226466 Patch r=me 989750 4 mhahnenberg 2014-03-12 11:29:35 -0700 Committed r165490: <http://trac.webkit.org/changeset/165490> 989751 5 226466 mhahnenberg 2014-03-12 11:31:09 -0700 Comment on attachment 226466 Patch Clearing review flag. 226466 2014-03-11 19:23:48 -0700 2014-03-12 11:31:09 -0700 Patch bug-130109-20140311192324.patch text/plain 2910 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1NDU4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAzLTExICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIEhhbmRsZVNldDo6bV9uZXh0VG9GaW5hbGl6ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMTA5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBhIHJlbW5hbnQgb2Yg d2hlbiBIYW5kbGVTZXQgY29udGFpbmVkIHRoaW5ncyB0aGF0IG5lZWRlZCB0byBiZSBmaW5hbGl6 ZWQuIAorCisgICAgICAgICogaGVhcC9IYW5kbGVTZXQuY3BwOgorICAgICAgICAoSlNDOjpIYW5k bGVTZXQ6OkhhbmRsZVNldCk6CisgICAgICAgIChKU0M6OkhhbmRsZVNldDo6d3JpdGVCYXJyaWVy KToKKyAgICAgICAgKiBoZWFwL0hhbmRsZVNldC5oOgorICAgICAgICAoSlNDOjpIYW5kbGVTZXQ6 OmFsbG9jYXRlKToKKyAgICAgICAgKEpTQzo6SGFuZGxlU2V0OjpkZWFsbG9jYXRlKToKKwogMjAx NC0wMy0xMSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAg ICAgIE1hcmtlZEJsb2NrcyB0aGF0IGFyZSAiZnVsbCBlbm91Z2giIHNob3VsZG4ndCBiZSBzd2Vw dCBhZnRlciBFZGVuQ29sbGVjdGlvbnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0hhbmRsZVNldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGFuZGxlU2V0LmNwcAkocmV2aXNpb24gMTY1NDU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSGFuZGxlU2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNiBAQCBuYW1l c3BhY2UgSlNDIHsKIAogSGFuZGxlU2V0OjpIYW5kbGVTZXQoVk0qIHZtKQogICAgIDogbV92bSh2 bSkKLSAgICAsIG1fbmV4dFRvRmluYWxpemUoMCkKIHsKICAgICBncm93KCk7CiB9CkBAIC03Mywx MCArNzIsNiBAQCB2b2lkIEhhbmRsZVNldDo6dmlzaXRTdHJvbmdIYW5kbGVzKEhlYXBSCiAKIHZv aWQgSGFuZGxlU2V0Ojp3cml0ZUJhcnJpZXIoSGFuZGxlU2xvdCBzbG90LCBjb25zdCBKU1ZhbHVl JiB2YWx1ZSkKIHsKLSAgICAvLyBGb3JiaWQgYXNzaWdubWVudCB0byBoYW5kbGVzIGR1cmluZyB0 aGUgZmluYWxpemF0aW9uIHBoYXNlLCBzaW5jZSBpdCB3b3VsZCB2aW9sYXRlIG1hbnkgR0MgaW52 YXJpYW50cy4KLSAgICAvLyBGaWxlIGEgYnVnIHdpdGggc3RhY2sgdHJhY2UgaWYgeW91IGhpdCB0 aGlzLgotICAgIFJFTEVBU0VfQVNTRVJUKCFtX25leHRUb0ZpbmFsaXplKTsKLQogICAgIGlmICgh dmFsdWUgPT0gISpzbG90ICYmIHNsb3QtPmlzQ2VsbCgpID09IHZhbHVlLmlzQ2VsbCgpKQogICAg ICAgICByZXR1cm47CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hhbmRsZVNl dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hhbmRsZVNldC5o CShyZXZpc2lvbiAxNjU0NTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IYW5kbGVT ZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMTAwLDcgKzEwMCw2IEBAIHByaXZhdGU6CiAgICAgU2Vu dGluZWxMaW5rZWRMaXN0PE5vZGU+IG1fc3Ryb25nTGlzdDsKICAgICBTZW50aW5lbExpbmtlZExp c3Q8Tm9kZT4gbV9pbW1lZGlhdGVMaXN0OwogICAgIFNpbmdseUxpbmtlZExpc3Q8Tm9kZT4gbV9m cmVlTGlzdDsKLSAgICBOb2RlKiBtX25leHRUb0ZpbmFsaXplOwogfTsKIAogaW5saW5lIEhhbmRs ZVNldCogSGFuZGxlU2V0OjpoZWFwRm9yKEhhbmRsZVNsb3QgaGFuZGxlKQpAQCAtMTI1LDEwICsx MjQsNiBAQCBpbmxpbmUgSGFuZGxlU2V0OjpOb2RlKiBIYW5kbGVTZXQ6OnRvTm9kCiAKIGlubGlu ZSBIYW5kbGVTbG90IEhhbmRsZVNldDo6YWxsb2NhdGUoKQogewotICAgIC8vIEZvcmJpZCBhc3Np Z25tZW50IHRvIGhhbmRsZXMgZHVyaW5nIHRoZSBmaW5hbGl6YXRpb24gcGhhc2UsIHNpbmNlIGl0 IHdvdWxkIHZpb2xhdGUgbWFueSBHQyBpbnZhcmlhbnRzLgotICAgIC8vIEZpbGUgYSBidWcgd2l0 aCBzdGFjayB0cmFjZSBpZiB5b3UgaGl0IHRoaXMuCi0gICAgUkVMRUFTRV9BU1NFUlQoIW1fbmV4 dFRvRmluYWxpemUpOwotCiAgICAgaWYgKG1fZnJlZUxpc3QuaXNFbXB0eSgpKQogICAgICAgICBn cm93KCk7CiAKQEAgLTE0MSwxMSArMTM2LDYgQEAgaW5saW5lIEhhbmRsZVNsb3QgSGFuZGxlU2V0 OjphbGxvY2F0ZSgpCiBpbmxpbmUgdm9pZCBIYW5kbGVTZXQ6OmRlYWxsb2NhdGUoSGFuZGxlU2xv dCBoYW5kbGUpCiB7CiAgICAgSGFuZGxlU2V0OjpOb2RlKiBub2RlID0gdG9Ob2RlKGhhbmRsZSk7 Ci0gICAgaWYgKG5vZGUgPT0gbV9uZXh0VG9GaW5hbGl6ZSkgewotICAgICAgICBBU1NFUlQobV9u ZXh0VG9GaW5hbGl6ZS0+bmV4dCgpKTsKLSAgICAgICAgbV9uZXh0VG9GaW5hbGl6ZSA9IG1fbmV4 dFRvRmluYWxpemUtPm5leHQoKTsKLSAgICB9Ci0KICAgICBTZW50aW5lbExpbmtlZExpc3Q8SGFu ZGxlU2V0OjpOb2RlPjo6cmVtb3ZlKG5vZGUpOwogICAgIG1fZnJlZUxpc3QucHVzaChub2RlKTsK IH0K