130100 2014-03-11 16:26:15 -0700 REGRESSION (r165356): [Mac] Multi-part key bindings don't work 2014-03-12 10:21:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 1 ap ap darin enrica oldest_to_newest 989451 0 ap 2014-03-11 16:26:15 -0700 If you have this in ~/Library/KeyBindings/DefaultKeyBinding.dict, then pressing Ctrl+m Ctrl+x should insert Esc key glyph: { "^m" = { "^x" = ("insertText:", "\U238B"); /* C-x escape */ }; } This is broken because we now pass keyups through -interpretKeyEvents:, and interpreting that resets internal state of key bindings. 989539 1 226474 ap 2014-03-11 22:38:40 -0700 Created attachment 226474 proposed fix 989696 2 ap 2014-03-12 10:21:07 -0700 Committed <http://trac.webkit.org/r165477>. Also changed NO to false - I remembered that the argument was a C++ bool now. 226474 2014-03-11 22:38:40 -0700 2014-03-12 10:09:46 -0700 proposed fix KeyUp.txt text/plain 2346 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTQ2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAzLTExICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNjUz NTYpOiBbTWFjXSBNdWx0aS1wYXJ0IGtleSBiaW5kaW5ncyBkb24ndCB3b3JrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAxMDAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXN0b3JlIHRoZSBwcmV2aW91 cyBiZWhhdmlvciwgd2hlcmUgd2Ugb25seSBpbnRlcnByZXRlZCBrZXlkb3ducyAoaW5jbHVkaW5n IHRob3NlCisgICAgICAgIGNvbWluZyB0aHJvdWdoIHBlcmZvcm1LZXlFcXVpdmFsZW50KS4KKwor ICAgICAgICBJbiB0aGUgZnV0dXJlLCB3ZSBtaWdodCBzZW5kIGFsbCBldmVudHMgdG8gaW5wdXQg bWV0aG9kcywgYnV0IG5vdCB0byBrZXkgYmluZGluZ3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBrZXlVcDpdKToKKyAgICAgICAg KC1bV0tWaWV3IGZsYWdzQ2hhbmdlZDpdKToKKwogMjAxNC0wMy0xMSAgQmV0aCBEYWtpbiAgPGJk YWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgX3BhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvciBz aG91bGQgbm90IGJlIGV4cG9zZWQgb24gV0tXZWJWaWV3CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiAxNjU0NTQpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTEz MzQsMTEgKzEzMzQsOCBAQCAtIChCT09MKXBlcmZvcm1LZXlFcXVpdmFsZW50OihOU0V2ZW50ICop CiAtICh2b2lkKWtleVVwOihOU0V2ZW50ICopdGhlRXZlbnQKIHsKICAgICBMT0coVGV4dElucHV0 LCAia2V5VXA6JXAgJUAiLCB0aGVFdmVudCwgdGhlRXZlbnQpOwotCi0gICAgVmVjdG9yPEtleXBy ZXNzQ29tbWFuZD4gY29tbWFuZHM7Ci0gICAgQk9PTCBoYW5kbGVkQnlJbnB1dE1ldGhvZCA9IFtz ZWxmIF9pbnRlcnByZXRLZXlFdmVudDp0aGVFdmVudCBzYXZpbmdDb21tYW5kc1RvOmNvbW1hbmRz XTsKLQotICAgIF9kYXRhLT5fcGFnZS0+aGFuZGxlS2V5Ym9hcmRFdmVudChOYXRpdmVXZWJLZXli b2FyZEV2ZW50KHRoZUV2ZW50LCBoYW5kbGVkQnlJbnB1dE1ldGhvZCwgY29tbWFuZHMpKTsKKyAg ICAvLyBXZSBkb24ndCBpbnRlcnByZXQgdGhlIGtleVVwIGV2ZW50LCBhcyB0aGlzIGJyZWFrcyBr ZXkgYmluZGluZ3MgKHNlZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMDEwMD4pLgorICAgIF9kYXRhLT5fcGFnZS0+aGFuZGxlS2V5Ym9hcmRFdmVudChOYXRpdmVX ZWJLZXlib2FyZEV2ZW50KHRoZUV2ZW50LCBOTywgVmVjdG9yPEtleXByZXNzQ29tbWFuZD4oKSkp OwogfQogCiAtICh2b2lkKV9kaXNhYmxlQ29tcGxleFRleHRJbnB1dElmTmVjZXNzYXJ5CkBAIC0x NDQwLDEwICsxNDM3LDcgQEAgLSAodm9pZClmbGFnc0NoYW5nZWQ6KE5TRXZlbnQgKil0aGVFdmVu dAogICAgIGlmICgha2V5Q29kZSB8fCBrZXlDb2RlID09IDEwIHx8IGtleUNvZGUgPT0gNjMpCiAg ICAgICAgIHJldHVybjsKIAotICAgIFZlY3RvcjxLZXlwcmVzc0NvbW1hbmQ+IGNvbW1hbmRzOwot ICAgIEJPT0wgaGFuZGxlZEJ5SW5wdXRNZXRob2QgPSBbc2VsZiBfaW50ZXJwcmV0S2V5RXZlbnQ6 dGhlRXZlbnQgc2F2aW5nQ29tbWFuZHNUbzpjb21tYW5kc107Ci0KLSAgICBfZGF0YS0+X3BhZ2Ut PmhhbmRsZUtleWJvYXJkRXZlbnQoTmF0aXZlV2ViS2V5Ym9hcmRFdmVudCh0aGVFdmVudCwgaGFu ZGxlZEJ5SW5wdXRNZXRob2QsIGNvbW1hbmRzKSk7CisgICAgX2RhdGEtPl9wYWdlLT5oYW5kbGVL ZXlib2FyZEV2ZW50KE5hdGl2ZVdlYktleWJvYXJkRXZlbnQodGhlRXZlbnQsIE5PLCBWZWN0b3I8 S2V5cHJlc3NDb21tYW5kPigpKSk7CiB9CiAKIC0gKHZvaWQpX2V4ZWN1dGVTYXZlZEtleXByZXNz Q29tbWFuZHMK