130096 2014-03-11 16:02:52 -0700 Build fix after r165439 2014-03-12 04:15:35 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda gyuyoung.kim mario mrobinson ossy webkit-bug-importer oldest_to_newest 989442 0 thiago.lacerda 2014-03-11 16:02:52 -0700 AccessibilityUIElementAtk::y() should access the y local variable, instead of non existing x one. 989444 1 226442 thiago.lacerda 2014-03-11 16:06:22 -0700 Created attachment 226442 Patch 989567 2 226442 ryuan.choi 2014-03-12 03:16:50 -0700 Comment on attachment 226442 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226442&action=review > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128 > - atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, nullptr, ATK_XY_SCREEN); > + atk_component_get_position(ATK_COMPONENT(m_element.get()), &y, nullptr, ATK_XY_SCREEN); First, sorry, I didn't see it before I landed. I landed the patch at r165463. Anyway, I thought that we should fix it .... nullptr, &y, ATK_XY_SCREEN); If I am wrong, please rebase the patch. 989587 3 mario 2014-03-12 04:15:35 -0700 (In reply to comment #2) > (From update of attachment 226442 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226442&action=review > > > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1128 > > - atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, nullptr, ATK_XY_SCREEN); > > + atk_component_get_position(ATK_COMPONENT(m_element.get()), &y, nullptr, ATK_XY_SCREEN); > > First, sorry, I didn't see it before I landed. > No worries, I think the important thing is that is now fixed. > I landed the patch at r165463. > > Anyway, I thought that we should fix it > .... nullptr, &y, ATK_XY_SCREEN); > > If I am wrong, please rebase the patch. Actually, you are right. I didn't realize when reviewing it (my bad). Now resolving this as fixed 226442 2014-03-11 16:06:22 -0700 2014-03-12 03:16:50 -0700 Patch bug-130096-20140311200558.patch text/plain 1534 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NDUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWU2MTJjZTY0NGUzOWI2ZjhiMzM2YWRjNGY0ZTdmNTU1 MzU0NmQwMC4uYjY4N2UyZjU2OWE1ZjA5ZTViMWYwMzc0N2U2ZTM5OGY2ZDBmYmRjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTAzLTExICBUaGlhZ28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJk YUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEJ1aWxkIGZpeCBhZnRlciByMTY1NDM5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAwOTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgor ICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojp5KToKKwogMjAxNC0wMy0xMSAg TWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g VGhlIGpoYnVpbGQgZW52aXJvbm1lbnQgc2hvdWxkIHNldCBDTUFLRV9QUkVGSVhfUEFUSCBhbmQg Q01BS0VfTElCUkFSWV9QQVRICmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcCBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRB dGsuY3BwCmluZGV4IGNkNjhlMWZjMzFlZDUyYjA3OTUxOTU2NGM5YjllOWRjOTFhZjY3NmIuLjY2 YjYyOWZlZGJjZmY1NTE3ZjgzZTU1NGQ3YWJiNzA1NGYyOWU2M2YgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRBdGsuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRr L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCkBAIC0xMTI1LDcgKzExMjUsNyBAQCBkb3Vi bGUgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6eSgpCiAjaWYgQVRLX0NIRUNLX1ZFUlNJT04oMiwx MSw5MCkKICAgICBhdGtfY29tcG9uZW50X2dldF9leHRlbnRzKEFUS19DT01QT05FTlQobV9lbGVt ZW50LmdldCgpKSwgbnVsbHB0ciwgJnksIG51bGxwdHIsIG51bGxwdHIsIEFUS19YWV9TQ1JFRU4p OwogI2Vsc2UKLSAgICBhdGtfY29tcG9uZW50X2dldF9wb3NpdGlvbihBVEtfQ09NUE9ORU5UKG1f ZWxlbWVudC5nZXQoKSksICZ4LCAgbnVsbHB0ciwgQVRLX1hZX1NDUkVFTik7CisgICAgYXRrX2Nv bXBvbmVudF9nZXRfcG9zaXRpb24oQVRLX0NPTVBPTkVOVChtX2VsZW1lbnQuZ2V0KCkpLCAmeSwg IG51bGxwdHIsIEFUS19YWV9TQ1JFRU4pOwogI2VuZGlmCiAgICAgcmV0dXJuIHk7CiB9Cg==