130093 2014-03-11 15:34:54 -0700 _pageExtendedBackgroundColor should not be exposed on WKWebView 2014-03-11 19:17:19 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin benjamin simon.fraser thorton oldest_to_newest 989425 0 bdakin 2014-03-11 15:34:54 -0700 _pageExtendedBackgroundColor should not be exposed on WKWebView for iOS. <rdar://problem/16256627> 989437 1 226439 bdakin 2014-03-11 15:48:10 -0700 Created attachment 226439 Patch 989503 2 thorton 2014-03-11 19:17:19 -0700 http://trac.webkit.org/projects/webkit/changeset/165454 226439 2014-03-11 15:48:10 -0700 2014-03-11 15:53:44 -0700 Patch for-review.txt text/plain 5355 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTQ1MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE0LTAzLTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBfcGFnZUV4dGVuZGVkQmFja2dyb3Vu ZENvbG9yIHNob3VsZCBub3QgYmUgZXhwb3NlZCBvbiBXS1dlYlZpZXcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA5MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGNvbW1lbnQgaW5kaWNhdGlu ZyB0aGF0IF9wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IgaXMgZGVwcmVjYXRlZC4KKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaDoKKworICAgICAgICBfcGFn ZUV4dGVuZGVkQmFja2dyb3VuZENvbG9yIG5vdyByZXR1cm5zIG5pbCwgYnV0IHRoZSBjb252ZXJz YXRpb24gZnVuY3Rpb25hbGl0eSAKKyAgICAgICAgaXMgbWFpbnRhaW5lZCB3aXRoIGEgY29udmVu aWVuY2UgbWV0aG9kIHBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvci4KKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IHBhZ2VF eHRlbmRlZEJhY2tncm91bmRDb2xvcl0pOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2RpZENvbW1p dExheWVyVHJlZTpXZWJLaXQ6Ol0pOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3BhZ2VFeHRlbmRl ZEJhY2tncm91bmRDb2xvcl0pOgorCisgICAgICAgIEFkZGVkIGNvbW1lbnQgaW5kaWNhdGluZyB0 aGF0IF9wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IgaXMgZGVwcmVjYXRlZC4KKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKworICAgICAgICBSZXR1 cm4gbmlsLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbToKKyAgICAg ICAgKC1bV0tWaWV3IF9wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3JdKToKKwogMjAxNC0wMy0x MSAgSmFlIEh5dW4gUGFyayAgPGphZXBhcmtAd2Via2l0Lm9yZz4KIAogICAgICAgICBbR1RLXVtD TWFrZV0gQWRkIEhBUkZCVVpaX0lOQ0xVREVfRElSUyB0byBXZWJLaXQgYW5kIFdlYktpdDIKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJp dmF0ZS5oCShyZXZpc2lvbiAxNjU0MDQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLVmlld1ByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDgsNiArNDgsOCBAQAog QHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0T2JzY3VyZWRJbnNldHM6KSBVSUVkZ2VJ bnNldHMgX29ic2N1cmVkSW5zZXRzOwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9z ZXRCYWNrZ3JvdW5kRXh0ZW5kc0JleW9uZFBhZ2U6KSBCT09MIF9iYWNrZ3JvdW5kRXh0ZW5kc0Jl eW9uZFBhZ2U7CisKKy8vIFRoaXMgaXMgZGVwcmVjYXRlZC4KIEBwcm9wZXJ0eSAocmVhZG9ubHkp IFVJQ29sb3IgKl9wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3I7CiAKIC0gKHZvaWQpX2JlZ2lu SW50ZXJhY3RpdmVPYnNjdXJlZEluc2V0c0NoYW5nZTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCShyZXZpc2lvbiAxNjU0MDkpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMzc1LDYgKzM3NSwxNiBAQCAtICh2b2lkKV9kaWRDb21taXRMb2FkRm9yTWFp bkZyYW1lCiAgICAgX2lzV2FpdGluZ0Zvck5ld0xheWVyVHJlZUFmdGVyRGlkQ29tbWl0TG9hZCA9 IFlFUzsKIH0KIAorLy8gVGhpcyBpcyBhIGNvbnZlbmllbmNlIG1ldGhvZCB0aGF0IHdpbGwgY29u dmVydCBfcGFnZS0+cGFnZUV4dGVuZGVkQmFja2dyb3VuZENvbG9yKCkgZnJvbSBhIFdlYkNvcmU6 OkNvbG9yIHRvIGEgVUlDb2xvciAqLgorLSAoVUlDb2xvciAqKXBhZ2VFeHRlbmRlZEJhY2tncm91 bmRDb2xvcgoreworICAgIFdlYkNvcmU6OkNvbG9yIGNvbG9yID0gX3BhZ2UtPnBhZ2VFeHRlbmRl ZEJhY2tncm91bmRDb2xvcigpOworICAgIGlmICghY29sb3IuaXNWYWxpZCgpKQorICAgICAgICBy ZXR1cm4gbmlsOworCisgICAgcmV0dXJuIFtVSUNvbG9yIGNvbG9yV2l0aFJlZDooY29sb3IucmVk KCkgLyAyNTUuMCkgZ3JlZW46KGNvbG9yLmdyZWVuKCkgLyAyNTUuMCkgYmx1ZTooY29sb3IuYmx1 ZSgpIC8gMjU1LjApIGFscGhhOihjb2xvci5hbHBoYSgpIC8gMjU1LjApXTsKK30KKwogLSAodm9p ZClfZGlkQ29tbWl0TGF5ZXJUcmVlOihjb25zdCBXZWJLaXQ6OlJlbW90ZUxheWVyVHJlZVRyYW5z YWN0aW9uJilsYXllclRyZWVUcmFuc2FjdGlvbgogewogICAgIEFTU0VSVCghX2N1c3RvbUNvbnRl bnRWaWV3KTsKQEAgLTM4Niw3ICszOTYsNyBAQCAtICh2b2lkKV9kaWRDb21taXRMYXllclRyZWU6 KGNvbnN0IFdlYktpCiAgICAgaWYgKCFsYXllclRyZWVUcmFuc2FjdGlvbi5zY2FsZVdhc1NldEJ5 VUlQcm9jZXNzKCkgJiYgIVtfc2Nyb2xsVmlldyBpc1pvb21pbmddICYmICFbX3Njcm9sbFZpZXcg aXNab29tQm91bmNpbmddICYmICFbX3Njcm9sbFZpZXcgX2lzQW5pbWF0aW5nWm9vbV0pCiAgICAg ICAgIFtfc2Nyb2xsVmlldyBzZXRab29tU2NhbGU6bGF5ZXJUcmVlVHJhbnNhY3Rpb24ucGFnZVNj YWxlRmFjdG9yKCldOwogCi0gICAgaWYgKFVJQ29sb3IgKnBhZ2VFeHRlbmRlZEJhY2tncm91bmRD b2xvciA9IFtzZWxmIF9wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3JdKSB7CisgICAgaWYgKFVJ Q29sb3IgKnBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvciA9IFtzZWxmIHBhZ2VFeHRlbmRlZEJh Y2tncm91bmRDb2xvcl0pIHsKICAgICAgICAgaWYgKFtzZWxmIF9iYWNrZ3JvdW5kRXh0ZW5kc0Jl eW9uZFBhZ2VdKQogICAgICAgICAgICAgW19zY3JvbGxWaWV3IHNldEJhY2tncm91bmRDb2xvcjpw YWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3JdOwogICAgIH0KQEAgLTg5OCwxMSArOTA4LDggQEAg LSAodm9pZClfc2V0T2JzY3VyZWRJbnNldHM6KFVJRWRnZUluc2V0cwogCiAtIChVSUNvbG9yICop X3BhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvcgogewotICAgIFdlYkNvcmU6OkNvbG9yIGNvbG9y ID0gX3BhZ2UtPnBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvcigpOwotICAgIGlmICghY29sb3Iu aXNWYWxpZCgpKQotICAgICAgICByZXR1cm4gbmlsOwotCi0gICAgcmV0dXJuIFtVSUNvbG9yIGNv bG9yV2l0aFJlZDooY29sb3IucmVkKCkgLyAyNTUuMCkgZ3JlZW46KGNvbG9yLmdyZWVuKCkgLyAy NTUuMCkgYmx1ZTooY29sb3IuYmx1ZSgpIC8gMjU1LjApIGFscGhhOihjb2xvci5hbHBoYSgpIC8g MjU1LjApXTsKKyAgICAvLyBUaGlzIGlzIGRlcHJlY2F0ZWQuCisgICAgcmV0dXJuIG5pbDsKIH0K IAogLSAodm9pZClfc2V0QmFja2dyb3VuZEV4dGVuZHNCZXlvbmRQYWdlOihCT09MKWJhY2tncm91 bmRFeHRlbmRzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAkocmV2aXNpb24gMTY1NDA0KQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTcwLDYgKzcwLDggQEAgdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS1Jl bmRlcgogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0T2JzY3VyZWRJbnNldHM6KSBV SUVkZ2VJbnNldHMgX29ic2N1cmVkSW5zZXRzOwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0 dGVyPV9zZXRCYWNrZ3JvdW5kRXh0ZW5kc0JleW9uZFBhZ2U6KSBCT09MIF9iYWNrZ3JvdW5kRXh0 ZW5kc0JleW9uZFBhZ2U7CisKKy8vIFRoaXMgaXMgZGVwcmVjYXRlZC4KIEBwcm9wZXJ0eSAocmVh ZG9ubHkpIFVJQ29sb3IgKl9wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3I7CiAKIC0gKHZvaWQp X2JlZ2luSW50ZXJhY3RpdmVPYnNjdXJlZEluc2V0c0NoYW5nZTsKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS1ZpZXdJT1MubW0JKHJldmlzaW9uIDE2NTQwNCkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMzY4LDExICszNjgsOCBAQCAtICh2b2lkKV9lbmRJbnRlcmFjdGl2ZU9ic2N1 cmVkSW5zZXRzQ2hhCiAKIC0gKFVJQ29sb3IgKilfcGFnZUV4dGVuZGVkQmFja2dyb3VuZENvbG9y CiB7Ci0gICAgV2ViQ29yZTo6Q29sb3IgY29sb3IgPSBbX2NvbnRlbnRWaWV3IHBhZ2VdLT5wYWdl RXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IoKTsKLSAgICBpZiAoIWNvbG9yLmlzVmFsaWQoKSkKLSAg ICAgICAgcmV0dXJuIG5pbDsKLQotICAgIHJldHVybiBbVUlDb2xvciBjb2xvcldpdGhSZWQ6KGNv bG9yLnJlZCgpIC8gMjU1LjApIGdyZWVuOihjb2xvci5ncmVlbigpIC8gMjU1LjApIGJsdWU6KGNv bG9yLmJsdWUoKSAvIDI1NS4wKSBhbHBoYTooY29sb3IuYWxwaGEoKSAvIDI1NS4wKV07CisgICAg Ly8gVGhpcyBpcyBkZXByZWNhdGVkLiAKKyAgICByZXR1cm4gbmlsOwogfQogCiAtICh2b2lkKV9z ZXRCYWNrZ3JvdW5kRXh0ZW5kc0JleW9uZFBhZ2U6KEJPT0wpYmFja2dyb3VuZEV4dGVuZHMK