130083 2014-03-11 03:44:52 -0700 [CSS Grid Layout] Add layout test for anonymous grid items 2014-03-11 06:23:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue jfernandez svillar oldest_to_newest 989341 0 rego 2014-03-11 03:44:52 -0700 It would be nice to have a layout test to prevent regressions in the support of anonymous grid items. This has been already fixed in Blink and will be ported to WebKit: https://codereview.chromium.org/181183005 989343 1 226414 rego 2014-03-11 03:54:46 -0700 Created attachment 226414 Patch 989360 2 226414 svillar 2014-03-11 04:44:32 -0700 Comment on attachment 226414 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226414&action=review OK I guess it won't harm. > LayoutTests/ChangeLog:8 > + Add a layout test to prevent regressions supporting anonymous grid items. Cou you improve a bit the description? Like mentioning that they don't have document() or node() blablabla 989366 3 226419 rego 2014-03-11 05:44:16 -0700 Created attachment 226419 Patch Patch for landing. 989371 4 226419 commit-queue 2014-03-11 06:23:11 -0700 Comment on attachment 226419 Patch Clearing flags on attachment: 226419 Committed r165449: <http://trac.webkit.org/changeset/165449> 989372 5 commit-queue 2014-03-11 06:23:13 -0700 All reviewed patches have been landed. Closing bug. 226414 2014-03-11 03:54:46 -0700 2014-03-11 05:44:10 -0700 Patch bug-130083-20140311115445.patch text/plain 2208 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MzcwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGEzMGQyNDE3OWM2ZjlkMTRjODU0 YzI0YTZhZjNmYjJmOTM1ODI1Zi4uY2EwODkxMGJkM2MwMjBhMjEyM2I3NzVkZDAyMDIxYzA3Yzk0 ZDhjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTExICBNYW51ZWwgUmVnbyBDYXNh c25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIEFk ZCBsYXlvdXQgdGVzdCBmb3IgYW5vbnltb3VzIGdyaWQgaXRlbXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA4MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGxheW91dCB0ZXN0IHRvIHByZXZl bnQgcmVncmVzc2lvbnMgc3VwcG9ydGluZyBhbm9ueW1vdXMgZ3JpZCBpdGVtcy4KKworICAgICAg ICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2Fub255bW91cy1ncmlkLWl0ZW1zLWV4cGVjdGVkLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2Fub255bW91cy1ncmlk LWl0ZW1zLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAzLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IGpzL2RvbS9jcmVhdGUtbG90cy1v Zi13b3JrZXJzLmh0bWwgZnJlcXVlbnRseSBjcmFzaGVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hbm9ueW1vdXMtZ3JpZC1pdGVtcy1leHBlY3RlZC5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvYW5vbnltb3VzLWdyaWQtaXRlbXMt ZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jM2QwYTE4MmM4MmU3NDFmNGNmNDAzMGNjYWY5MGUy Y2FlZGJmYzNlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1s YXlvdXQvYW5vbnltb3VzLWdyaWQtaXRlbXMtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDEzIEBA Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICB0ZXN0UnVubmVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0Q1NTR3JpZExheW91 dEVuYWJsZWQiLCAxKTsKKzwvc2NyaXB0PgorPGJvZHk+CisgICAgPGRpdj5DaGVja3MgdGhhdCBh bm9ueW1vdXMgZ3JpZCBpdGVtcyBhcmUgc3VwcG9ydGVkLiBUaGlzIHNob3VsZCBub3QgY3Jhc2gu PC9kaXY+CisgICAgPGRpdiBzdHlsZT0iZGlzcGxheTogLXdlYmtpdC1ncmlkOyI+CisgICAgICAg IDxkaXY+YW5vbnltb3VzIGl0ZW08L2Rpdj4KKyAgICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2Fub255bW91cy1n cmlkLWl0ZW1zLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hbm9ueW1v dXMtZ3JpZC1pdGVtcy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU0NDI1ZWZmODdlZjY4ZDdiYWQ1ZWY1M2U0 YmUyYzQ0MGJhMWIzZGMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1n cmlkLWxheW91dC9hbm9ueW1vdXMtZ3JpZC1pdGVtcy5odG1sCkBAIC0wLDAgKzEsMTMgQEAKKzwh RE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQor ICAgIHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRDU1NHcmlkTGF5b3V0RW5h YmxlZCIsIDEpOworPC9zY3JpcHQ+Cis8Ym9keT4KKyAgICA8ZGl2PkNoZWNrcyB0aGF0IGFub255 bW91cyBncmlkIGl0ZW1zIGFyZSBzdXBwb3J0ZWQuIFRoaXMgc2hvdWxkIG5vdCBjcmFzaC48L2Rp dj4KKyAgICA8ZGl2IHN0eWxlPSJkaXNwbGF5OiAtd2Via2l0LWdyaWQ7Ij4KKyAgICAgICAgYW5v bnltb3VzIGl0ZW0KKyAgICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K 226419 2014-03-11 05:44:16 -0700 2014-03-11 06:23:11 -0700 Patch bug-130083-20140311134415.patch text/plain 2349 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MzcwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGEzMGQyNDE3OWM2ZjlkMTRjODU0 YzI0YTZhZjNmYjJmOTM1ODI1Zi4uM2FiN2I0YWFiNTI1MDhkNmRhMTQ0ODZhN2VmZTU3ZjM0MzMy Y2U2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTExICBNYW51ZWwgUmVnbyBDYXNh c25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIEFk ZCBsYXlvdXQgdGVzdCBmb3IgYW5vbnltb3VzIGdyaWQgaXRlbXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDA4MworCisgICAgICAgIFJldmlld2Vk IGJ5IFNlcmdpbyBWaWxsYXIgU2VuaW4uCisKKyAgICAgICAgQWRkIGEgbGF5b3V0IHRlc3QgdG8g cHJldmVudCByZWdyZXNzaW9ucyBzdXBwb3J0aW5nIGFub255bW91cyBncmlkIGl0ZW1zLgorCisg ICAgICAgIEZvciBleGFtcGxlLCBhbm9ueW1vdXMgZ3JpZCBpdGVtcyBkbyBub3QgaGF2ZSBhbiBh c3NvY2lhdGVkIE5vZGUsIHNvIHRyeWluZyB0byBhY2Nlc3MgaXQgd2lsbCBtYWtlIHRoaXMgdGVz dAorICAgICAgICBjcmFzaC4KKworICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2Fub255 bW91cy1ncmlkLWl0ZW1zLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3Nz LWdyaWQtbGF5b3V0L2Fub255bW91cy1ncmlkLWl0ZW1zLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAz LTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT046IGpzL2RvbS9jcmVhdGUtbG90cy1vZi13b3JrZXJzLmh0bWwgZnJlcXVlbnRseSBjcmFz aGVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hbm9ueW1v dXMtZ3JpZC1pdGVtcy1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1s YXlvdXQvYW5vbnltb3VzLWdyaWQtaXRlbXMtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jM2Qw YTE4MmM4MmU3NDFmNGNmNDAzMGNjYWY5MGUyY2FlZGJmYzNlCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvYW5vbnltb3VzLWdyaWQtaXRlbXMtZXhw ZWN0ZWQuaHRtbApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNj cmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLm92ZXJyaWRlUHJl ZmVyZW5jZSgiV2ViS2l0Q1NTR3JpZExheW91dEVuYWJsZWQiLCAxKTsKKzwvc2NyaXB0PgorPGJv ZHk+CisgICAgPGRpdj5DaGVja3MgdGhhdCBhbm9ueW1vdXMgZ3JpZCBpdGVtcyBhcmUgc3VwcG9y dGVkLiBUaGlzIHNob3VsZCBub3QgY3Jhc2guPC9kaXY+CisgICAgPGRpdiBzdHlsZT0iZGlzcGxh eTogLXdlYmtpdC1ncmlkOyI+CisgICAgICAgIDxkaXY+YW5vbnltb3VzIGl0ZW08L2Rpdj4KKyAg ICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y3NzLWdyaWQtbGF5b3V0L2Fub255bW91cy1ncmlkLWl0ZW1zLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2Nzcy1ncmlkLWxheW91dC9hbm9ueW1vdXMtZ3JpZC1pdGVtcy5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjU0NDI1ZWZmODdlZjY4ZDdiYWQ1ZWY1M2U0YmUyYzQ0MGJhMWIzZGMKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9hbm9ueW1vdXMtZ3JpZC1pdGVt cy5odG1sCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c2NyaXB0 PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJl bmNlKCJXZWJLaXRDU1NHcmlkTGF5b3V0RW5hYmxlZCIsIDEpOworPC9zY3JpcHQ+Cis8Ym9keT4K KyAgICA8ZGl2PkNoZWNrcyB0aGF0IGFub255bW91cyBncmlkIGl0ZW1zIGFyZSBzdXBwb3J0ZWQu IFRoaXMgc2hvdWxkIG5vdCBjcmFzaC48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSJkaXNwbGF5OiAt d2Via2l0LWdyaWQ7Ij4KKyAgICAgICAgYW5vbnltb3VzIGl0ZW0KKyAgICA8L2Rpdj4KKzwvYm9k eT4KKzwvaHRtbD4K